Re: [PATCH, v2] Fortran: fix CLASS attribute handling [PR106856]

2023-03-04 Thread Mikael Morin
Le 04/03/2023 à 22:20, Harald Anlauf a écrit : Hi Mikael, Am 04.03.23 um 18:09 schrieb Mikael Morin: There was a comment about the old_symbol thing at the end of my previous message: https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613354.html I think Tobias might be the better person to

Re: [PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-04 Thread Segher Boessenkool
On Sat, Mar 04, 2023 at 06:32:15PM -, Roger Sayle wrote: > This patch addresses PR rtl-optimization/106594, a P1 performance > regression affecting aarch64. > > This patch has been tested on x86_64-pc-linux-gnu with make bootstrap > and make -k check, both with and without --target_board=unix{

Re: [PATCH, v2] Fortran: fix CLASS attribute handling [PR106856]

2023-03-04 Thread Harald Anlauf via Gcc-patches
Hi Mikael, Am 04.03.23 um 18:09 schrieb Mikael Morin: There was a comment about the old_symbol thing at the end of my previous message: https://gcc.gnu.org/pipermail/gcc-patches/2023-March/613354.html I think Tobias might be the better person to answer this. But when playing with variations o

[PATCH] PR rtl-optimization/106594: Preserve zero_extend in combine when cheap.

2023-03-04 Thread Roger Sayle
This patch addresses PR rtl-optimization/106594, a P1 performance regression affecting aarch64. This patch has been tested on x86_64-pc-linux-gnu with make bootstrap and make -k check, both with and without --target_board=unix{-m32}, with no new failures. If someone (who can regression test this

Re: [PATCH, v2] Fortran: fix CLASS attribute handling [PR106856]

2023-03-04 Thread Mikael Morin
Le 04/03/2023 à 17:06, Harald Anlauf a écrit : Sorry, attached the wrong patch. Here's the correct one. Harald Am 04.03.23 um 17:02 schrieb Harald Anlauf via Gcc-patches: The attached revised version uses the above proven changes, and extends the new testcase class_74.f90 by variations of th

Re: [PATCH, v2] Fortran: fix CLASS attribute handling [PR106856]

2023-03-04 Thread Harald Anlauf via Gcc-patches
Sorry, attached the wrong patch. Here's the correct one. Harald Am 04.03.23 um 17:02 schrieb Harald Anlauf via Gcc-patches: The attached revised version uses the above proven changes, and extends the new testcase class_74.f90 by variations of the failures remaining with version 1 so that diff

Re: [PATCH, v2] Fortran: fix CLASS attribute handling [PR106856]

2023-03-04 Thread Harald Anlauf via Gcc-patches
Hi Mikael! Am 04.03.23 um 14:56 schrieb Mikael Morin: I have found the time finally.  It's not as bad as it seemed.  See below. diff --git a/gcc/fortran/decl.cc b/gcc/fortran/decl.cc index eec0314cf4c..72d8c6f1c14 100644 --- a/gcc/fortran/decl.cc +++ b/gcc/fortran/decl.cc +  sym->attr.p

Re: [PATCH, v2] Fortran: fix CLASS attribute handling [PR106856]

2023-03-04 Thread Harald Anlauf via Gcc-patches
Hi Mikael! Am 04.03.23 um 14:56 schrieb Mikael Morin: I have found the time finally.  It's not as bad as it seemed.  See below. diff --git a/gcc/fortran/decl.cc b/gcc/fortran/decl.cc index eec0314cf4c..72d8c6f1c14 100644 --- a/gcc/fortran/decl.cc +++ b/gcc/fortran/decl.cc +  sym->attr.p

Re: [PATCH] Fortran: fix CLASS attribute handling [PR106856]

2023-03-04 Thread Mikael Morin
Le 03/03/2023 à 22:24, Mikael Morin a écrit : I have two comments, one about the handling of as and sym->as, which I quite don't understand, but I haven't had time to write something about it. I have found the time finally. It's not as bad as it seemed. See below. diff --git a/gcc/fortran/

Re: [PATCH] update copyright year in libstdcc++ manual

2023-03-04 Thread Xi Ruoyao via Gcc-patches
Wrong subject: the library is libstdc++, not "cc++". On Fri, 2022-12-30 at 10:30 +, Jonny Grant wrote: > 2022-12-30  Jonathan Grant > * libstdc++-v3/doc/xml/faq.xml: update copyright year in > libstdcc++ manual Wrong ChangeLog format, see https://gcc.gnu.org/codingconventions.html#Ch

New French PO file for 'gcc' (version 13.1-b20230212)

2023-03-04 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the French team of translators. The file is available at: https://translationproject.org/latest/gcc/fr.po (This file, 'gcc-13.1-b20230212.fr.po',

Re: [PATCH] Remove remaining traces of m_vecdata from comments [PR109006]

2023-03-04 Thread Richard Biener via Gcc-patches
> Am 04.03.2023 um 10:02 schrieb Jakub Jelinek via Gcc-patches > : > > Hi! > > The following patch adjusts remaining references to the removed m_vecdata > array from vec.h in various comments. > > Tested on x86_64-linux, ok for trunk? Ok Richard > 2023-03-04 Jakub Jelinek > >PR

Re: [PATCH][stage1] Remove conditionals around free()

2023-03-04 Thread Janne Blomqvist via Gcc-patches
On Wed, Mar 1, 2023 at 11:31 PM Bernhard Reutner-Fischer via Fortran wrote: > > Hi! > > Mere cosmetics. > > - if (foo != NULL) > free (foo); > > With the caveat that coccinelle ruins replacement whitespace or i'm > uneducated enough to be unable to _not_ run the diff through > sed -e 's/^+\([

[committed] testsuite: Fix up syntax errors in scan-tree-dump-times target selectors

2023-03-04 Thread Jakub Jelinek via Gcc-patches
Hi! On Thu, Mar 02, 2023 at 07:23:32PM +0100, Robin Dapp via Gcc-patches wrote: > this patch changes SLP test expectations. As we only vectorize when no > more than one rgroup is present, no vectorization is performed. This broke the tests, I'm seeing syntax errors: ERROR: gcc.dg/vect/slp-3.c -f

[PATCH] Remove remaining traces of m_vecdata from comments [PR109006]

2023-03-04 Thread Jakub Jelinek via Gcc-patches
Hi! The following patch adjusts remaining references to the removed m_vecdata array from vec.h in various comments. Tested on x86_64-linux, ok for trunk? 2023-03-04 Jakub Jelinek PR middle-end/109006 * vec.cc (test_auto_alias): Adjust comment for removal of m_vecdata.

[committed] diagnostics, v2: Fix up selftests with $COLUMNS < 42 [PR108973]

2023-03-04 Thread Jakub Jelinek via Gcc-patches
On Fri, Mar 03, 2023 at 08:54:32AM -0500, David Malcolm wrote: > Thanks for working on this. > > Patch is OK, but I wonder if it would even better to just hardcode > caret_max_width as 80 here, to better eliminate that influence from > from the environment in the unit tests? I think all of the te