Re: Aligning stack offsets for spills

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 9:00 PM Jeff Law wrote: > > > So, as many of you know I left Red Hat a while ago and joined Tachyum. > We're building a new processor and we've come across an issue where I > think we need upstream discussion. > > I can't divulge many of the details right now, but one of the

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-07 Thread Aldy Hernandez via Gcc-patches
On 6/7/21 9:20 PM, Andrew MacLeod wrote: On 6/7/21 9:30 AM, Richard Biener via Gcc-patches wrote: On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez via Gcc-patches wrote: The substitute_and_fold_engine which evrp uses is expecting symbolics from value_of_expr / value_on_edge / etc, which range

[pushed] c++: preserve BASELINK from lookup [PR91706]

2021-06-07 Thread Jason Merrill via Gcc-patches
In the earlier patch for PR91706 I fixed the BASELINK built by baselink_for_fns, but since we already had one from lookup, we should keep that one around instead of stripping it. The removed hunk in get_class_binding was a wierdly large amount of code to decide whether to pull out BASELINK_FUNCTIO

[pushed] c++: alias with same name as base fn [PR91706]

2021-06-07 Thread Jason Merrill via Gcc-patches
This is a bit complex. Looking up c in the definition of D::c finds C::c, OK. Looking up c in the definition of E finds D::c, OK. Since the alias is not dependent, we strip it from the template argument, leaving using E = A())>; where 'c' still refers to C::c. But instantiating E looks up 'c'

[pushed] c++: fix modules binfo merging

2021-06-07 Thread Jason Merrill via Gcc-patches
My coming fix for PR91706 caused some regressions in the modules testsuite. This turned out to be because the change to properly use the base subobject BINFO as BASELINK_BINFO hit problems with the code for merging binfos. The tree reader needed a typo fix. The duplicate_hash function was crashin

[pushed] c++: alias member template [PR100102]

2021-06-07 Thread Jason Merrill via Gcc-patches
Patrick already fixed the primary cause of this bug. But while I was looking at this testcase I noticed that with the qualified name k::o we ended up with a plain FUNCTION_DECL, whereas without the k:: we got a BASELINK. There seems to be no good reason not to return the BASELINK in this case as

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Trevor Saunders
On Mon, Jun 07, 2021 at 02:34:26PM -0600, Martin Sebor wrote: > On 6/7/21 2:51 AM, Richard Biener wrote: > > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders > > wrote: > > > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > > wrote: > > > > On 6/2/21 12:55 AM, Ric

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Trevor Saunders
On Mon, Jun 07, 2021 at 04:17:09PM -0600, Martin Sebor wrote: > On 6/3/21 2:29 AM, Trevor Saunders wrote: > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > wrote: > > > On 6/2/21 12:55 AM, Richard Biener wrote: > > > > On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote

[PATCH] doc/typo: mthread -> mthreads

2021-06-07 Thread imba-tjd via Gcc-patches
> unrecognized command line option '-mthread'; did you mean '-mthreads'? --- gcc/doc/invoke.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 04048cd8332b..92bb1308b805 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.

Re: [RFC/PATCH 00/11] Fix up some unexpected empty split conditions

2021-06-07 Thread Kewen.Lin via Gcc-patches
Hi Segher, on 2021/6/8 上午7:50, Segher Boessenkool wrote: > Hi! > > On Fri, Jun 04, 2021 at 10:57:51AM +0800, Kewen.Lin via Gcc-patches wrote: >> To find out those need fixing seems to be the critical part. It's >> not hard to add one explicit "&&" to those that don't have it now, but >> even wit

Re: [RFC/PATCH 00/11] Fix up some unexpected empty split conditions

2021-06-07 Thread Kewen.Lin via Gcc-patches
on 2021/6/7 下午3:12, Richard Biener wrote: > On Fri, Jun 4, 2021 at 4:58 AM Kewen.Lin via Gcc-patches > wrote: >> >> Hi Segher, >> >> on 2021/6/3 下午5:18, Segher Boessenkool wrote: >>> On Thu, Jun 03, 2021 at 03:00:44AM -0500, Segher Boessenkool wrote: On Thu, Jun 03, 2021 at 01:22:38PM +0800,

[PATCH v2] rs6000: Support doubleword swaps removal in rot64 load store [PR100085]

2021-06-07 Thread Xionghu Luo via Gcc-patches
Update the patch according to the comments. Thanks. On P8LE, extra rot64+rot64 load or store instructions are generated in float128 to vector __int128 conversion. This patch teaches pass swaps to also handle such pattens to remove extra swap instructions. (insn 7 6 8 2 (set (subreg:V1TI (reg:K

[PATCH] libstdc++: Fix Wrong param type in :atomic_ref<_Tp*>::wait [PR100889]

2021-06-07 Thread Thomas Rodgers
This time without the repeatred [PR] in the subject line. Fixes libstdc++/100889 libstdc++-v3/ChangeLog: * include/bits/atomic_base.h (atomic_ref<_Tp*>::wait): Change parameter type from _Tp to _Tp*. * testsuite/29_atomics/atomic_ref/wait_notify.cc: Extend cov

[PATCH] c++: explicit() ignored on deduction guide [PR100065]

2021-06-07 Thread Marek Polacek via Gcc-patches
When we have explicit() with a value-dependent argument, we can't evaluate it at parsing time, so cp_parser_function_specifier_opt stashes the argument into the decl-specifiers and grokdeclarator then stores it into explicit_specifier_map, which is then used when substituting the function decl. gr

Re: [RFC/PATCH 00/11] Fix up some unexpected empty split conditions

2021-06-07 Thread Segher Boessenkool
Hi! On Fri, Jun 04, 2021 at 10:57:51AM +0800, Kewen.Lin via Gcc-patches wrote: > To find out those need fixing seems to be the critical part. It's > not hard to add one explicit "&&" to those that don't have it now, but > even with further bootstrapped and regression tested I'm still not > confid

Re: [PATCH][version 3]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-06-07 Thread Kees Cook via Gcc-patches
On Mon, Jun 07, 2021 at 04:18:46PM +, Qing Zhao wrote: > Hi, > > > On Jun 7, 2021, at 2:53 AM, Richard Biener wrote: > > > >> > >> To address the above suggestion: > >> > >> My study shows: the call to __builtin_clear_padding is expanded during > >> gimplification phase. > >> And there i

Re: [PATCH][version 3]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-06-07 Thread Kees Cook via Gcc-patches
On Mon, Jun 07, 2021 at 09:48:41AM +0200, Richard Biener wrote: > On Thu, 27 May 2021, Qing Zhao wrote: > > @@ -5001,6 +5185,17 @@ gimplify_init_constructor (tree *expr_p, gimple_seq > > *pre_p, gimple_seq *post_p, > > /* If a single access to the target must be ensured and all > > element

Re: [PATCH, rs6000] Update Power10 scheduling description for fused instruction types

2021-06-07 Thread Segher Boessenkool
On Mon, Jun 07, 2021 at 03:41:29PM -0500, Pat Haugen wrote: > Update Power10 scheduling description for new fused instruction types. Okay for trunk. Thanks! Segher

Re: [PATCH 2/2] Add IEEE 128-bit fp conditional move on PowerPC.

2021-06-07 Thread Segher Boessenkool
On Tue, May 18, 2021 at 04:28:27PM -0400, Michael Meissner wrote: > In this patch, I simplified things compared to previous patches. Instead of > allowing any four of the modes to be used for the conditional move comparison > and the move itself could use different modes, I restricted the conditio

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Martin Sebor via Gcc-patches
On 6/3/21 2:29 AM, Trevor Saunders wrote: On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches wrote: On 6/2/21 12:55 AM, Richard Biener wrote: On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: On 5/27/21 2:53 PM, Jason Merrill wrote: On 4/27/21 11:52 AM, Martin Sebor via

[PATCH] rtl: Join the insn and split conditions in define_insn_and_split

2021-06-07 Thread Segher Boessenkool
In theory we could have a split condition not inclusive of the insn condition in the past. That never was a good idea, the code does not do what a non-suspicious reader would think it does. But it leads to more serious problems together with iterators: if the split condition (as written) does not

[PATCH] libstdc++: Fix Wrong param type in :atomic_ref<_Tp*>::wait [PR100889] [PR100889]

2021-06-07 Thread Thomas Rodgers
Fixes libstdc++/100889 libstdc++-v3/ChangeLog: * include/bits/atomic_base.h (atomic_ref<_Tp*>::wait): Change parameter type from _Tp to _Tp*. * testsuite/29_atomics/atomic_ref/wait_notify.cc: Extend coverage of types tested. --- libstdc++-v3/include/bits/atomic_ba

Re: [PATCH 1/3]: C N2653 char8_t: Language support

2021-06-07 Thread Joseph Myers
Also, it seems odd to add a new field to cpp_options without any code in libcpp that uses the value of that field. -- Joseph S. Myers jos...@codesourcery.com

[PATCH] PR tree-optimization/100299 - Implement a sparse bitmap representation for Rangers on-entry cache.

2021-06-07 Thread Andrew MacLeod via Gcc-patches
This pair of patches provides a sparse representation of the on-entry cache for ranger.  When the number of basic blocks exceed -param=evrp-sparse-threshold=  (default to 800), ranger moves to a sparse representation rather allocating a full vector for each ssa-name. This is based on an extens

Re: [PATCH 2/2] Add IEEE 128-bit fp conditional move on PowerPC.

2021-06-07 Thread Segher Boessenkool
On Thu, May 20, 2021 at 02:27:06PM -0500, will schmidt wrote: > On Tue, 2021-05-18 at 16:28 -0400, Michael Meissner wrote: > > + if (compare_mode == result_mode > > + || (compare_mode == SFmode && result_mode == DFmode) > > + || (compare_mode == DFmode && result_mode == SFmode)) > > +

Re: RFC: Sphinx for GCC documentation

2021-06-07 Thread Bernhard Reutner-Fischer via Gcc-patches
On Mon, 7 Jun 2021 15:30:22 +0200 Martin Liška wrote: > Anyway, this is resolved as I use more appropriate directive: > https://splichal.eu/scripts/sphinx/gfortran/_build/html/intrinsic-procedures/access-checks-file-access-modes.html ISTM there's a typo s/Tailing/Trailing/ in gcc/fortran/intrins

Re: [PATCH 1/3]: C N2653 char8_t: Language support

2021-06-07 Thread Joseph Myers
On Sun, 6 Jun 2021, Tom Honermann via Gcc-patches wrote: > When -fchar8_t support is enabled for non-C++ modes, the _CHAR8_T_SOURCE macro > is predefined. This is the mechanism proposed to glibc to opt-in to > declarations of the char8_t typedef and c8rtomb and mbrtoc8 functions proposed > in N26

Re: [PATCH 0/3]: C N2653 char8_t implementation

2021-06-07 Thread Joseph Myers
On Sun, 6 Jun 2021, Tom Honermann via Gcc-patches wrote: > These changes do not impact default gcc behavior. The existing -fchar8_t > option is extended to C compilation to enable the N2653 changes, and > -fno-char8_t is extended to explicitly disable them. N2653 has not yet been > accepted by W

[PATCH] i386: Add init pattern for V4QI vectors [PR100637]

2021-06-07 Thread Uros Bizjak via Gcc-patches
2021-06-07 Uroš Bizjak gcc/ PR target/100637 * config/i386/i386-expand.c (ix86_expand_vector_init_duplicate): Handle V4QI mode. (ix86_expand_vector_init_one_nonzero): Ditto. (ix86_expand_vector_init_one_var): Ditto. (ix86_expand_vector_init_general): Ditto. * config/

[PATCH, rs6000] Update Power10 scheduling description for fused instruction types

2021-06-07 Thread Pat Haugen via Gcc-patches
Update Power10 scheduling description for new fused instruction types. Bootstrap/regtest on powerpc64le(Power10) with no new regressions. Ok for trunk? -Pat 2021-06-07 Pat Haugen gcc/ChangeLog: * config/rs6000/power10.md (power10-fused-load, power10-fused-store, power10-fus

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Martin Sebor via Gcc-patches
On 6/7/21 2:51 AM, Richard Biener wrote: On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders wrote: On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches wrote: On 6/2/21 12:55 AM, Richard Biener wrote: On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: On 5/27/21 2:53 PM, Ja

[PATCH] middle-end/100951 - make sure to generate VECTOR_CST in lowering

2021-06-07 Thread H.J. Lu via Gcc-patches
On Mon, Jun 7, 2021 at 11:10 AM Richard Biener wrote: > > On Mon, Jun 7, 2021 at 7:59 PM Richard Biener > wrote: > > > > On Mon, Jun 7, 2021 at 4:19 PM H.J. Lu wrote: > > > > > > On Mon, Jun 7, 2021 at 12:12 AM Richard Sandiford > > > wrote: > > > > > > > > "H.J. Lu" writes: > > > > > Update v

Re: [PATCH 1/2] Add IEEE 128-bit min/max support on PowerPC.

2021-06-07 Thread Segher Boessenkool
On Tue, May 18, 2021 at 04:26:06PM -0400, Michael Meissner wrote: > This patch adds the support for the IEEE 128-bit floating point C minimum and > maximum instructions. > gcc/ > 2021-05-18 Michael Meissner > > * config/rs6000/rs6000.c (rs6000_emit_minmax): Add support for ISA > 3.

Re: [PATCH 1/2] Add IEEE 128-bit min/max support on PowerPC.

2021-06-07 Thread Segher Boessenkool
Hi! On Thu, May 20, 2021 at 09:38:49PM -0400, Michael Meissner wrote: > Basically for code generation tests, I see the following cases: > > 1) Test code targetting precisley power8 (or power9, power10), etc. Hopefully > these are rare. -mdejagnu-cpu= works perfectly for this. You may need a *_

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-07 Thread Andrew MacLeod via Gcc-patches
On 6/7/21 9:30 AM, Richard Biener via Gcc-patches wrote: On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez via Gcc-patches wrote: The substitute_and_fold_engine which evrp uses is expecting symbolics from value_of_expr / value_on_edge / etc, which ranger does not provide. In some cases, these prov

[PATCH] x86: Don't compile pr82735-[345].c for x32

2021-06-07 Thread H.J. Lu via Gcc-patches
On Thu, Jun 3, 2021 at 11:31 PM Hongtao Liu via Gcc-patches wrote: > > On Fri, Jun 4, 2021 at 2:27 PM Uros Bizjak via Gcc-patches > wrote: > > > > On Thu, Jun 3, 2021 at 8:54 AM liuhongt wrote: > > > > > > When __builtin_ia32_vzeroupper is called explicitly, the corresponding > > > vzeroupper pa

Re: [PATCH ] RS6000 Add 128-bit Binary Integer sign extend operations

2021-06-07 Thread Segher Boessenkool
Hi Carl, On Wed, Apr 28, 2021 at 10:39:14AM -0700, Carl Love wrote: > The agreement for the sign extension builtin was to just make it Endian > aware rather then go with a more complex definition. The prior patch > has been updated with this new functionality. > > This patch adds support for the

Re: [PATCH] Add --enable-default-semantic-interposition to GCC configure

2021-06-07 Thread Fangrui Song
On 2021-06-07, Jakub Jelinek wrote: On Mon, Jun 07, 2021 at 12:01:55PM -0600, Jeff Law via Gcc-patches wrote: > This breaks assumptions across the board. If software packages want > to use -fno-semantic-interposition that is one thing. But distros > should not be changing the default. This

Aligning stack offsets for spills

2021-06-07 Thread Jeff Law
So, as many of you know I left Red Hat a while ago and joined Tachyum.  We're building a new processor and we've come across an issue where I think we need upstream discussion. I can't divulge many of the details right now, but one of the quirks of our architecture is that reg+d addressing

Re: [PATCH 5/5 ver4] RS6000: Conversions between 128-bit integer and floating point values.

2021-06-07 Thread Segher Boessenkool
On Mon, Apr 26, 2021 at 09:36:33AM -0700, Carl Love wrote: > This patch adds support for converting to/from 128-bit integers and > 128-bit decimal floating point formats using the new P10 instructions > dcffixqq and dctfixqq. The new instructions are only used on P10 HW, > otherwise the conversion

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-07 Thread Aldy Hernandez via Gcc-patches
On 6/7/21 3:30 PM, Richard Biener wrote: On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez via Gcc-patches wrote: The substitute_and_fold_engine which evrp uses is expecting symbolics from value_of_expr / value_on_edge / etc, which ranger does not provide. In some cases, these provide important

Re: [PATCH] Add --enable-default-semantic-interposition to GCC configure

2021-06-07 Thread Jakub Jelinek via Gcc-patches
On Mon, Jun 07, 2021 at 12:01:55PM -0600, Jeff Law via Gcc-patches wrote: > > This breaks assumptions across the board. If software packages want > > to use -fno-semantic-interposition that is one thing. But distros > > should not be changing the default. This is just like using > > -ffast-math

Re: [PATCH v2 1/2] Allow vec_duplicate_optab to fail

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 7:59 PM Richard Biener wrote: > > On Mon, Jun 7, 2021 at 4:19 PM H.J. Lu wrote: > > > > On Mon, Jun 7, 2021 at 12:12 AM Richard Sandiford > > wrote: > > > > > > "H.J. Lu" writes: > > > > Update vec_duplicate to allow to fail so that backend can only allow > > > > broadcas

Re: [PATCH] Add --enable-default-semantic-interposition to GCC configure

2021-06-07 Thread Jeff Law via Gcc-patches
On 6/6/2021 5:18 PM, Andrew Pinski via Gcc-patches wrote: On Sun, Jun 6, 2021 at 4:13 PM Fangrui Song via Gcc-patches wrote: From: Fangrui Song --enable-default-semantic-interposition=no makes -fPIC default to -fno-semantic-interposition which enables interprocedural optimizations for defa

Re: [PATCH v2 1/2] Allow vec_duplicate_optab to fail

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 4:19 PM H.J. Lu wrote: > > On Mon, Jun 7, 2021 at 12:12 AM Richard Sandiford > wrote: > > > > "H.J. Lu" writes: > > > Update vec_duplicate to allow to fail so that backend can only allow > > > broadcasting an integer constant to a vector when broadcast instruction > > > is

Re: [PATCH][RFC] Sparse on entry cache for Ranger.

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 7:26 PM Andrew MacLeod wrote: > > On 6/7/21 4:40 AM, Richard Biener wrote: > > On Wed, Jun 2, 2021 at 11:15 PM Andrew MacLeod wrote: > >> > >> My thoughts are I would put this into trunk, and assuming nothing comes > >> up over the next couple of days, port it back to GCC1

Re: [PATCH 02/57] Support scanning of build-time GC roots in gengtype

2021-06-07 Thread Bill Schmidt via Gcc-patches
On 6/7/21 12:45 PM, Richard Biener wrote: On Mon, Jun 7, 2021 at 5:38 PM Bill Schmidt wrote: On 6/7/21 8:36 AM, Richard Biener wrote: Some maybe obvious issue - what about DOS-style path hosts? You seem to build ../ strings to point to parent dirs... I'm not sure what we do elsewhere - I supp

Re: [PATCH 02/57] Support scanning of build-time GC roots in gengtype

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 5:38 PM Bill Schmidt wrote: > > On 6/7/21 8:36 AM, Richard Biener wrote: > > > > Some maybe obvious issue - what about DOS-style path hosts? > > You seem to build ../ strings to point to parent dirs... I'm not sure > > what we do elsewhere - I suppose we arrange for appropr

Re: [PATCH][RFC] Sparse on entry cache for Ranger.

2021-06-07 Thread Andrew MacLeod via Gcc-patches
On 6/7/21 4:40 AM, Richard Biener wrote: On Wed, Jun 2, 2021 at 11:15 PM Andrew MacLeod wrote: My thoughts are I would put this into trunk, and assuming nothing comes up over the next couple of days, port it back to GCC11 to resolve 100299 and other excessive memory consumption PRs there as w

Re: [PATCH][version 3]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-06-07 Thread Qing Zhao via Gcc-patches
Hi, > On Jun 7, 2021, at 2:53 AM, Richard Biener wrote: > >> >> To address the above suggestion: >> >> My study shows: the call to __builtin_clear_padding is expanded during >> gimplification phase. >> And there is no __bultin_clear_padding expanding during rtx expanding phase. >> However, f

Re: [PATCH][version 3]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-06-07 Thread Qing Zhao via Gcc-patches
(Kees, can you answer one of Richard’s question below? On the reason to initialize padding of structures) Richard, On Jun 7, 2021, at 2:48 AM, Richard Biener mailto:rguent...@suse.de>> wrote: Meh - can you try using a mailer that does proper quoting? It's difficult to spot your added comment

Re: [PATCH 02/57] Support scanning of build-time GC roots in gengtype

2021-06-07 Thread Bill Schmidt via Gcc-patches
On 6/7/21 8:36 AM, Richard Biener wrote: Some maybe obvious issue - what about DOS-style path hosts? You seem to build ../ strings to point to parent dirs... I'm not sure what we do elsewhere - I suppose we arrange for appropriate -I command line arguments? Well, actually it's just using "./"

Re: [PATCH] PR libstdc++/98842: Fixed Constraints on operator<=>(optional, U)

2021-06-07 Thread Jonathan Wakely via Gcc-patches
On Fri, 4 Jun 2021 at 21:41, Jonathan Wakely wrote: > > On Thu, 3 Jun 2021 at 17:27, Seija K. via Libstdc++ > wrote: > > > The original operator was underconstrained. _Up needs to fulfill > > compare_three_way_result, > > as mentioned in this bug report > > https://gcc.gnu.org/bugzilla/show_bug.cg

Re: [PATCH] predcom: Adjust some unnecessary update_ssa calls

2021-06-07 Thread Martin Sebor via Gcc-patches
On 6/7/21 8:46 AM, Richard Biener via Gcc-patches wrote: On Wed, Jun 2, 2021 at 11:29 AM Kewen.Lin wrote: Hi, As Richi suggested in PR100794, this patch is to remove some unnecessary update_ssa calls with flag TODO_update_ssa_only_virtuals, also do some refactoring. Bootstrapped/regtested on

Re: [PATCH] Improve match_simplify_replacement in phi-opt

2021-06-07 Thread Richard Biener via Gcc-patches
On Thu, Jun 3, 2021 at 7:32 AM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > This improves match_simplify_replace in phi-opt to handle the > case where there is one cheap (non-call) preparation statement in the > middle basic block similar to xor_replacement and others. > This all

Re: [PATCH] libstdc++: add missing typename for dependent type in std::ranges::elements_view [PR100900]

2021-06-07 Thread Jonathan Wakely via Gcc-patches
The patch is approved, if Patrick doesn't do it I'll push it later today. Thanks!

Re: [PATCH v2] predcom: Enabled by loop vect at O2 [PR100794]

2021-06-07 Thread Richard Biener via Gcc-patches
On Thu, Jun 3, 2021 at 5:33 AM Kewen.Lin wrote: > > Hi Richard, > > on 2021/6/3 上午1:19, Richard Sandiford wrote: > > "Kewen.Lin via Gcc-patches" writes: > >> Hi, > >> > >> As PR100794 shows, in the current implementation PRE bypasses > >> some optimization to avoid introducing loop carried depend

Re: [PATCH] predcom: Adjust some unnecessary update_ssa calls

2021-06-07 Thread Richard Biener via Gcc-patches
On Wed, Jun 2, 2021 at 11:29 AM Kewen.Lin wrote: > > Hi, > > As Richi suggested in PR100794, this patch is to remove > some unnecessary update_ssa calls with flag > TODO_update_ssa_only_virtuals, also do some refactoring. > > Bootstrapped/regtested on powerpc64le-linux-gnu P9, > x86_64-redhat-linu

[committed] H8 -- use simple moves to eliminate redundant test/compares

2021-06-07 Thread Jeff Law
On the H8 most simple data movement instructions set the N and Z bits in the status register in useful ways.  This patch exposes that and as a result we eliminate more unnecessary test/compare instructions.  Eliminating an SImode test is particularly profitable from a codesize standpoint (6 b

[PATCH] x86: Update g++.target/i386/pr100885.C

2021-06-07 Thread H.J. Lu via Gcc-patches
On Fri, Jun 4, 2021 at 12:47 AM Jakub Jelinek via Gcc-patches wrote: > > On Fri, Jun 04, 2021 at 01:03:58AM +, Liu, Hongtao wrote: > > Thanks for the review. > > Yes, you're right, AVX512VL parts are already guaranteed by > > ix86_hard_regno_mode_ok. > > > > Here is updated patch. > > One rem

Re: [PATCH PR100740]Fix overflow check in simplifying exit cond comparing two IVs.

2021-06-07 Thread Richard Biener via Gcc-patches
On Sun, Jun 6, 2021 at 12:01 PM Bin.Cheng wrote: > > On Wed, Jun 2, 2021 at 3:28 PM Richard Biener via Gcc-patches > wrote: > > > > On Tue, Jun 1, 2021 at 4:00 PM bin.cheng via Gcc-patches > > wrote: > > > > > > Hi, > > > As described in patch summary, this fixes the wrong code issue by adding

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-07 Thread Andrew MacLeod via Gcc-patches
On 6/7/21 9:45 AM, Richard Biener wrote: On Mon, Jun 7, 2021 at 3:37 PM Andrew MacLeod wrote: On 6/7/21 3:25 AM, Richard Biener wrote: On Wed, Jun 2, 2021 at 2:53 PM Andrew MacLeod wrote: On 6/2/21 7:52 AM, Richard Biener wrote: On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches

Re: [PATCH v2 1/2] Allow vec_duplicate_optab to fail

2021-06-07 Thread H.J. Lu via Gcc-patches
On Mon, Jun 7, 2021 at 12:12 AM Richard Sandiford wrote: > > "H.J. Lu" writes: > > Update vec_duplicate to allow to fail so that backend can only allow > > broadcasting an integer constant to a vector when broadcast instruction > > is available. > > I'm not sure why we need this to fail though.

Re: RFC: Sphinx for GCC documentation

2021-06-07 Thread Tobias Burnus
On 07.06.21 15:28, Martin Liška wrote: * I note that we write before the argument index, that those are without -/-- prefix but that's not true. Something to fix after the conversation. Can you please show me a few examples of it? * https://splichal.eu/scripts/sphinx/gfortran/_build/html

Re: [Patch] Fortran/OpenMP: Fix clause splitting for target/parallel/teams [PR99928]

2021-06-07 Thread Jakub Jelinek via Gcc-patches
On Mon, Jun 07, 2021 at 03:21:10PM +0200, Tobias Burnus wrote: > +static void > +gfc_add_clause_implicitly (gfc_omp_clauses *clauses_out, > +gfc_omp_clauses *clauses_in, > +bool is_target, bool is_parallel_do) > +{ > + int clauselist_to_add = is_targ

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 3:37 PM Andrew MacLeod wrote: > > On 6/7/21 3:25 AM, Richard Biener wrote: > > On Wed, Jun 2, 2021 at 2:53 PM Andrew MacLeod wrote: > >> On 6/2/21 7:52 AM, Richard Biener wrote: > >>> On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches > >>> wrote: > We've

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-07 Thread Andrew MacLeod via Gcc-patches
On 6/7/21 3:25 AM, Richard Biener wrote: On Wed, Jun 2, 2021 at 2:53 PM Andrew MacLeod wrote: On 6/2/21 7:52 AM, Richard Biener wrote: On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches wrote: We've been having "issues" in our branch when exporting to the global space ranges that

Re: [PATCH 02/57] Support scanning of build-time GC roots in gengtype

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 2:35 PM Bill Schmidt wrote: > > On 6/7/21 5:39 AM, Richard Sandiford wrote: > > Bill Schmidt via Gcc-patches writes: > >> On 5/20/21 5:24 PM, Segher Boessenkool wrote: > >>> On Tue, May 11, 2021 at 11:01:22AM -0500, Bill Schmidt wrote: > Hi! I'd like to ping this spec

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 12:33 PM Trevor Saunders wrote: > > On Mon, Jun 07, 2021 at 10:51:18AM +0200, Richard Biener via Gcc-patches > wrote: > > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders > > wrote: > > > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > > w

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez via Gcc-patches wrote: > > The substitute_and_fold_engine which evrp uses is expecting symbolics > from value_of_expr / value_on_edge / etc, which ranger does not provide. > In some cases, these provide important folding cues, as in the case of > alia

Re: RFC: Sphinx for GCC documentation

2021-06-07 Thread Martin Liška
On 6/4/21 4:24 PM, Koning, Paul wrote: On Jun 4, 2021, at 3:55 AM, Tobias Burnus wrote: Hello, On 13.05.21 13:45, Martin Liška wrote: On 4/1/21 3:30 PM, Martin Liška wrote: That said, I'm asking the GCC community for a green light before I invest more time on it? So far, I've received ju

[vect-patterns][RFC] Refactor widening patterns to allow internal_fn's

2021-06-07 Thread Joel Hutton via Gcc-patches
Hi all, This refactor allows widening patterns (such as widen_plus/widen_minus) to be represented as either internal_fns or tree_codes. The widening patterns were originally added as tree codes with the expectation that they would be refactored later. [vect-patterns] Refactor as internal_fn's

Re: RFC: Sphinx for GCC documentation

2021-06-07 Thread Martin Liška
On 6/4/21 9:55 AM, Tobias Burnus wrote: Hello, On 13.05.21 13:45, Martin Liška wrote: On 4/1/21 3:30 PM, Martin Liška wrote: That said, I'm asking the GCC community for a green light before I invest more time on it? So far, I've received just a small feedback about the transition. In most cas

Re: [PATCH] Reformat target.def for better parsing.

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 10:35 AM Martin Liška wrote: > > On 6/7/21 8:14 AM, Richard Biener wrote: > > Hmm, what's the problem with parsing the strings? The newlines are > > only because of our line length limits and hard-coding them looks both > > error-prone and ugly. > > For the future Sphinx co

[Patch] Fortran/OpenMP: Fix clause splitting for target/parallel/teams [PR99928]

2021-06-07 Thread Tobias Burnus
This removes the remaining xfails in gfortran.dg/gomp/pr99928-*.f90 and should in theory fix all splitting issues. I see some differences for 'parallel do simd' with regards to attaching lastprivate to 'for' vs. 'parallel' There are probably more. (I hope none of them is relevant.) There are also

Re: [PATCH] Simplify (view_convert ~a) < 0 to (view_convert a) >= 0 [PR middle-end/100738]

2021-06-07 Thread Richard Biener via Gcc-patches
On Mon, Jun 7, 2021 at 9:02 AM Hongtao Liu via Gcc-patches wrote: > > On Mon, Jun 7, 2021 at 2:22 PM Hongtao Liu wrote: > > > > On Fri, Jun 4, 2021 at 4:18 PM Marc Glisse wrote: > > > > > > On Fri, 4 Jun 2021, Hongtao Liu via Gcc-patches wrote: > > > > > > > On Tue, Jun 1, 2021 at 6:17 PM Marc G

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-07 Thread Aldy Hernandez via Gcc-patches
On Mon, Jun 7, 2021 at 9:30 AM Richard Biener wrote: > > On Wed, Jun 2, 2021 at 4:53 PM Aldy Hernandez wrote: > > > > > > > > On 6/2/21 1:52 PM, Richard Biener wrote: > > > On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches > > > wrote: > > > > > the case where this only happens aft

Re: [PATCH 02/57] Support scanning of build-time GC roots in gengtype

2021-06-07 Thread Bill Schmidt via Gcc-patches
On 6/7/21 5:39 AM, Richard Sandiford wrote: Bill Schmidt via Gcc-patches writes: On 5/20/21 5:24 PM, Segher Boessenkool wrote: On Tue, May 11, 2021 at 11:01:22AM -0500, Bill Schmidt wrote: Hi!  I'd like to ping this specific patch from the series, which is the only one remaining that affects

Re: [wwwdocs] Add HTML anchors to GCC 5 "porting to" notes

2021-06-07 Thread Gerald Pfeifer
On Mon, 7 Jun 2021, Jonathan Wakely wrote: > This adds id attributes to the heading elements of > https://gcc.gnu.org/gcc-5/porting_to.html (so that I can link directly > to the section on inline functions). > > All later porting_to.html notes have anchors like this. > > OK for wwwdocs? (a) This

Re: [RFC] Implementing detection of saturation and rounding arithmetic

2021-06-07 Thread Bin.Cheng via Gcc-patches
On Fri, Jun 4, 2021 at 12:35 AM Andre Vieira (lists) via Gcc-patches wrote: > > Hi, > > This RFC is motivated by the IV sharing RFC in > https://gcc.gnu.org/pipermail/gcc-patches/2021-May/569502.html and the > need to have the IVOPTS pass be able to clean up IV's shared between > multiple loops. W

Re: [PATCH, OpenMP 5.0] Implement relaxation of implicit map vs. existing device mappings (for mainline trunk)

2021-06-07 Thread Thomas Schwinge
Hi Chung-Lin! On 2021-05-14T21:20:25+0800, Chung-Lin Tang wrote: > This is a version of patch > https://gcc.gnu.org/pipermail/gcc-patches/2021-May/569665.html > for mainline trunk. Related to the discussion in that thread, <87tuneu3f4.fsf@euler.schwinge.homeip.net">http://mid.mail-archive.com/8

Re: [PING] [PATCH] For obj-c stage-final re-use the checksum from the previous stage

2021-06-07 Thread Richard Biener
On Fri, 4 Jun 2021, Bernd Edlinger wrote: > Ping... OK. Richard. > On 5/28/21 9:47 AM, Bernd Edlinger wrote: > > Hi Richard, > > > > I've replicated your PR to make the objective-c checksum compare equal > > > > commit fb2647aaf55b453b37badfd40c14c59486a74584 > > Author: Richard Biener > > D

[PATCH 2/2] arm: Auto-vectorization for MVE: add pack/unpack patterns

2021-06-07 Thread Christophe Lyon via Gcc-patches
This patch adds vec_unpack_hi_, vec_unpack_lo_, vec_pack_trunc_ patterns for MVE. It does so by moving the unpack patterns from neon.md to vec-common.md, while adding them support for MVE. The pack expander is derived from the Neon one (which in turn is renamed into neon_quad_vec_pack_trunc_). Th

[PATCH 1/2] arm: Auto-vectorization for MVE: vclz

2021-06-07 Thread Christophe Lyon via Gcc-patches
This patch adds support for auto-vectorization of clz for MVE. It does so by removing the unspec from mve_vclzq_ and uses 'clz' instead. It moves to neon_vclz expander from neon.md to vec-common.md and renames it into the standard name clz2. 2021-06-03 Christophe Lyon gcc/ * c

Re: [PATCH 02/57] Support scanning of build-time GC roots in gengtype

2021-06-07 Thread Richard Sandiford via Gcc-patches
Bill Schmidt via Gcc-patches writes: > On 5/20/21 5:24 PM, Segher Boessenkool wrote: >> On Tue, May 11, 2021 at 11:01:22AM -0500, Bill Schmidt wrote: >>> Hi!  I'd like to ping this specific patch from the series, which is the >>> only one remaining that affects common code.  I confess that I don't

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Trevor Saunders
On Mon, Jun 07, 2021 at 10:51:18AM +0200, Richard Biener via Gcc-patches wrote: > On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders wrote: > > > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches > > wrote: > > > On 6/2/21 12:55 AM, Richard Biener wrote: > > > > On Tue, Jun 1,

Re: [PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-07 Thread Aldy Hernandez via Gcc-patches
Sorry, meant to append... "OK for trunk?" :) On Mon, Jun 7, 2021 at 12:10 PM Aldy Hernandez wrote: > > The substitute_and_fold_engine which evrp uses is expecting symbolics > from value_of_expr / value_on_edge / etc, which ranger does not provide. > In some cases, these provide important folding

Re: [PATCH 1/4]middle-end Vect: Add support for dot-product where the sign for the multiplicant changes.

2021-06-07 Thread Richard Sandiford via Gcc-patches
Sorry for the slow response. Tamar Christina writes: > […] > diff --git a/gcc/tree-vect-patterns.c b/gcc/tree-vect-patterns.c > index > 441d6cd28c4eaded7abd756164890dbcffd2f3b8..82123b96313e6783ea214b9259805d65c07d8858 > 100644 > --- a/gcc/tree-vect-patterns.c > +++ b/gcc/tree-vect-patterns.c >

[PATCH] Implement a context aware points-to analyzer for use in evrp.

2021-06-07 Thread Aldy Hernandez via Gcc-patches
The substitute_and_fold_engine which evrp uses is expecting symbolics from value_of_expr / value_on_edge / etc, which ranger does not provide. In some cases, these provide important folding cues, as in the case of aliases for pointers. For example, legacy evrp may return [&foo, &foo] for the value

[wwwdocs] Add HTML anchors to GCC 5 "porting to" notes

2021-06-07 Thread Jonathan Wakely via Gcc-patches
This adds id attributes to the heading elements of https://gcc.gnu.org/gcc-5/porting_to.html (so that I can link directly to the section on inline functions). All later porting_to.html notes have anchors like this. OK for wwwdocs? commit 9f1723bc1d6b52fcfcfc4a8aee93eada98412e78 Author: Jonathan

[wwwdocs] Document libstdc++ support for generic unordered lookup

2021-06-07 Thread Jonathan Wakely via Gcc-patches
This should have been in the GCC 11 release notes, pushed now. commit bbbf05e7f3d3e7a74d23e8cc252ebae895158abe Author: Jonathan Wakely Date: Mon Jun 7 10:27:00 2021 +0100 Document libstdc++ support for generic unordered lookup diff --git a/htdocs/gcc-11/changes.html b/htdocs/gcc-11/change

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

2021-06-07 Thread Richard Biener via Gcc-patches
On Thu, Jun 3, 2021 at 10:29 AM Trevor Saunders wrote: > > On Wed, Jun 02, 2021 at 10:04:03AM -0600, Martin Sebor via Gcc-patches wrote: > > On 6/2/21 12:55 AM, Richard Biener wrote: > > > On Tue, Jun 1, 2021 at 9:56 PM Martin Sebor wrote: > > > > > > > > On 5/27/21 2:53 PM, Jason Merrill wrote:

Re: [PATCH][RFC] Sparse on entry cache for Ranger.

2021-06-07 Thread Richard Biener via Gcc-patches
On Wed, Jun 2, 2021 at 11:15 PM Andrew MacLeod wrote: > > As mentioned earlier, I abstracted the on-entry cache at the beginning > of stage1. This was to make it easier to port future changes back to > GCC11 so we could provide alternate representations to deal with memory > issues, or what have y

Re: [PATCH] Reformat target.def for better parsing.

2021-06-07 Thread Martin Liška
On 6/7/21 8:14 AM, Richard Biener wrote: Hmm, what's the problem with parsing the strings? The newlines are only because of our line length limits and hard-coding them looks both error-prone and ugly. For the future Sphinx conversion, I need to replace content of the hook definitions in .def

Re: [EXTERNAL] Re: [PATCH] tree-optimization: Optimize division followed by multiply [PR95176]

2021-06-07 Thread Richard Biener via Gcc-patches
On Wed, Jun 2, 2021 at 10:55 PM Victor Tong wrote: > > Hi Richard, > > Thanks for reviewing my patch. I did a search online and you're right -- > there isn't a vector modulo instruction. I'll remove the X * (Y / X) --> Y - > (Y % X) pattern and the existing X - (X / Y) * Y --> X % Y from trigger

Re: [PATCH][version 3]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-06-07 Thread Richard Biener
On Thu, 3 Jun 2021, Qing Zhao wrote: > Hi, Richard, > > > On May 26, 2021, at 6:18 AM, Richard Biener > mailto:rguent...@suse.de>> wrote: > > On Wed, 12 May 2021, Qing Zhao wrote: > > Hi, > > This is the 3rd version of the patch for the new security feature for GCC. > > Please take look and

Re: [PATCH][version 3]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-06-07 Thread Richard Biener
On Thu, 3 Jun 2021, Qing Zhao wrote: > Hi, Richard, > > For the following, I need more clarification: > > > > +/* Expand the IFN_DEFERRED_INIT function according to its second > argument. */ > +static void > +expand_DEFERRED_INIT (internal_fn, gcall *stmt) > +{ > + tree var = gimple_call_lhs

Re: [PATCH][version 3]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-06-07 Thread Richard Biener
On Thu, 27 May 2021, Qing Zhao wrote: > Hi, Richard, > > Thanks a lot for your comments. > > > On May 26, 2021, at 6:18 AM, Richard Biener > mailto:rguent...@suse.de>> wrote: > > On Wed, 12 May 2021, Qing Zhao wrote: > > Hi, > > This is the 3rd version of the patch for the new security feat

[PATCH] build: Implement --with-multilib-list for avr target

2021-06-07 Thread Matt Jacobson via Gcc-patches
The AVR target builds a lot of multilib variants of target libraries by default, and I found myself wanting to use the --with-multilib-list argument to limit what I was building, to shorten build times. This patch implements that option for the AVR target. Tested by configuring and building an AV

Re: [RFC/PATCH] updating global ranges and their effect on __builtin_unreachable code

2021-06-07 Thread Richard Biener via Gcc-patches
On Wed, Jun 2, 2021 at 4:53 PM Aldy Hernandez wrote: > > > > On 6/2/21 1:52 PM, Richard Biener wrote: > > On Wed, Jun 2, 2021 at 12:34 PM Aldy Hernandez via Gcc-patches > > wrote: > > > But the whole point of all this singing and dancing is not to make > > warnings but to be able to implement ass

  1   2   >