Re: Fix testsuite/g++.dg/cpp1y/constexpr-66093.C execution failure...

2021-01-01 Thread Alexandre Oliva
On Jan 1, 2021, Mike Stump wrote: > On Jan 1, 2021, at 3:37 PM, Alexandre Oliva wrote: >> >> On Dec 29, 2020, Mike Stump wrote: >> >>> a[i-1] = i; >> >> 'fraid that won't pass: >> >> for (int i = 0; i < n; i++) { >> assert (a[i] == i); >> } > Ok, how about your version with the comment up

Re: Fix testsuite/g++.dg/cpp1y/constexpr-66093.C execution failure...

2021-01-01 Thread Mike Stump via Gcc-patches
On Jan 1, 2021, at 3:37 PM, Alexandre Oliva wrote: > > On Dec 29, 2020, Mike Stump wrote: > >> a[i-1] = i; > > 'fraid that won't pass: > >for (int i = 0; i < n; i++) { >assert (a[i] == i); >} Ok, how about your version with the comment updated?

Re: libgo patch committed: Update to Go1.16beta1 release

2021-01-01 Thread H.J. Lu via Gcc-patches
On Fri, Jan 1, 2021 at 3:15 PM Ian Lance Taylor via Gcc-patches wrote: > > As far as I know all the build problems introduced by the update to > Go1.16beta1 are now fixed. > > Please let me know if I missed anything. > You missed this one for x32: diff --git a/libgo/go/internal/cpu/cpu_no_name.g

Re: Fix testsuite/g++.dg/cpp1y/constexpr-66093.C execution failure...

2021-01-01 Thread Alexandre Oliva
On Dec 29, 2020, Mike Stump wrote: > a[i-1] = i; 'fraid that won't pass: for (int i = 0; i < n; i++) { assert (a[i] == i); } we could make it: a[i-1] = i-1; but... yuck. IMHO it's a lot less surprising to have an init loop that matches the check. >> +++ b/gcc/tests

Re: libgo patch committed: Update to Go1.16beta1 release

2021-01-01 Thread Ian Lance Taylor via Gcc-patches
As far as I know all the build problems introduced by the update to Go1.16beta1 are now fixed. Please let me know if I missed anything. Sorry for the difficulties, it's hard to test on so many systems. Ian On Fri, Jan 1, 2021 at 3:14 PM Ian Lance Taylor wrote: > > On Fri, Jan 1, 2021 at 1:32 A

Re: libgo patch committed: Update to Go1.16beta1 release

2021-01-01 Thread Ian Lance Taylor via Gcc-patches
On Fri, Jan 1, 2021 at 1:32 AM Andreas Schwab wrote: > > --- a/libgo/go/internal/cpu/cpu_gccgo.c > +++ b/libgo/go/internal/cpu/cpu_gccgo.c > @@ -200,3 +200,29 @@ struct queryResult kdsaQuery() { > } > > #endif /* defined(__s390x__) */ > + > +#ifdef __aarch64__ > + > +uint64_t getisar0(void) > +

Re: libgo patch committed: Update to Go1.16beta1 release

2021-01-01 Thread Ian Lance Taylor via Gcc-patches
On Thu, Dec 31, 2020 at 11:48 AM Rainer Orth wrote: > > > I've committed a patch to update libgo to the Go 1.16beta1 release. > > > > This patch does not include support for the new //go:embed directive > > that will be available in Go 1.16.1 (https://golang.org/issue/41191) > > Support for that r

Re: libgo patch committed: Update to Go1.16beta1 release

2021-01-01 Thread Ian Lance Taylor via Gcc-patches
On Thu, Dec 31, 2020 at 7:40 AM Matthias Klose wrote: > > On 12/31/20 12:14 AM, Ian Lance Taylor via Gcc-patches wrote: > > I've committed a patch to update libgo to the Go 1.16beta1 release. > > > > This patch does not include support for the new //go:embed directive > > that will be available in

Re: libgo patch committed: Update to Go1.16beta1 release

2021-01-01 Thread Andreas Schwab
../../../../libgo/go/golang.org/x/sys/cpu/cpu.go:200:9: error: reference to undefined name ‘initOptions’ 200 | initOptions() | ^ make[2]: *** [golang.org/x/sys/cpu.lo] Error 1 Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 251

[PATCH] libstdc++/98466 Fix _GLIBCXX_DEBUG N3644 integration

2021-01-01 Thread François Dumont via Gcc-patches
I think the PR is not limited to unordered containers iterator, it impacts all _GLIBCXX_DEBUG iterators. However unordered containers local_iterator was more complicated to handle. Because of c++/65816 I prefer to review _Node_iterator_default constructor to set _M_cur to nullptr even if in pr

Re: libgo patch committed: Update to Go1.16beta1 release

2021-01-01 Thread Andreas Schwab
../../../libgo/go/internal/cpu/cpu_ppcx.go:13:5: error: redefinition of 'HWCap' 13 | var HWCap uint | ^ ../../../libgo/go/internal/cpu/cpu_ppc64x_linux.go:12:5: note: previous definition of 'HWCap' was here 12 | var HWCap uint | ^ ../../../libgo/go/internal/cpu/cpu_ppcx.g

Re: [PATCH] PR fortran/96381 - invalid read in gfc_find_derived_vtab

2021-01-01 Thread Paul Richard Thomas via Gcc-patches
Hi Harald, It looks good to me - OK for master and backporting. Thanks Paul On Fri, 1 Jan 2021 at 16:14, Harald Anlauf via Fortran wrote: > Dear all, > > happy New Year! > > The testcase committed with the fix for PR93337 uncovered a latent issue > with an invalid read that was discovered wi

[PATCH] PR fortran/96381 - invalid read in gfc_find_derived_vtab

2021-01-01 Thread Harald Anlauf via Gcc-patches
Dear all, happy New Year! The testcase committed with the fix for PR93337 uncovered a latent issue with an invalid read that was discovered with an ASAN instrumented compiler but which could also be verified by running f951 under valgrind. According to my gdb sessions the invalid read happens wh

Re: libgo patch committed: Update to Go1.16beta1 release

2021-01-01 Thread Matthias Klose
On 12/31/20 12:14 AM, Ian Lance Taylor via Gcc-patches wrote: > I've committed a patch to update libgo to the Go 1.16beta1 release. > > This patch does not include support for the new //go:embed directive > that will be available in Go 1.16.1 (https://golang.org/issue/41191) > Support for that req

[PATCH] x86: Cast to unsigned short first for _mm_extract_pi16

2021-01-01 Thread H.J. Lu via Gcc-patches
_mm_extract_pi16 is intrinsic for pextrw, which should be zero-extended, not sign-extended. gcc/ PR target/98495 * config/i386/xmmintrin.h (_mm_extract_pi16): Cast to unsigned short first. gcc/testsuite/ PR target/98495 * gcc.target/i386/pr98495-1.c: New

[patch, shared memory coarray, committed] Fix SYNC IMAGES(*)

2021-01-01 Thread Thomas Koenig via Gcc-patches
Hi, a rather obvious patch for SYNC IMAGES(*) failing because it did not deal with a -1 argument. Make SYNC IMAGES(*) work by handling size of -1 in library. libgfortran/ChangeLog: * caf_shared/sync.c (sync_table): Change size argument and index to int. * caf_shared/syn

Re: libgo patch committed: Update to Go1.16beta1 release

2021-01-01 Thread Andreas Schwab
--- a/libgo/go/internal/cpu/cpu_gccgo.c +++ b/libgo/go/internal/cpu/cpu_gccgo.c @@ -200,3 +200,29 @@ struct queryResult kdsaQuery() { } #endif /* defined(__s390x__) */ + +#ifdef __aarch64__ + +uint64_t getisar0(void) + __asm__(GOSYM_PREFIX "internal_1cpu.getisar0") + __attribute__((no_split_

Re: libgo patch committed: Update to Go1.16beta1 release

2021-01-01 Thread Andreas Schwab
On aarch64: /usr/aarch64-suse-linux/bin/ld: ../aarch64-suse-linux/libgo/.libs/libgo.so: undefined reference to `internal_1cpu.getMIDR' collect2: error: ld returned 1 exit status make[2]: *** [Makefile:831: test2json] Error 1 Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint

Re: [08/23] Add an alternative splay tree implementation

2021-01-01 Thread Andreas Schwab
That doesn't build with gcc 4.8: In file included from ../../gcc/splay-tree-utils.h:491:0, from ../../gcc/rtl-ssa.h:45, from ../../gcc/fwprop.c:29: ../../gcc/splay-tree-utils.tcc:24:1: error: prototype for 'typename base_splay_tree::node_type base_splay_tree::ge