[PATCH] Fix missed IPA-CP on by-ref argument directly passed through (PR ipa/93429)

2020-01-26 Thread Feng Xue OS
Current IPA does not propagate aggregate constant for by-ref argument if it is simple pass-through of caller parameter. Here is an example, f1 (int *p) { ... = *p; ... } f2 (int *p) { *p = 2; f1 (p); } It is easy to know that in f1(), *p should be 2 after

[COMMITTED] c++: Fix -Wnoexcept handling of system headers (PR90992).

2020-01-26 Thread Jason Merrill
The immediate issue here was that the second warning didn't depend on the first one, so if the first location was in a system header, we'd mysteriously give the second by itself. It's also the case that the thing we care about being in a system header is the function that we want to suggest adding

Re: [PATCH] sanopt: Avoid crash on anonymous parameter [PR93436]

2020-01-26 Thread Jakub Jelinek
On Sun, Jan 26, 2020 at 04:18:33PM -0500, Marek Polacek wrote: > 2020-01-26 Marek Polacek > > PR tree-optimization/93436 > * sanopt.c (sanitize_rewrite_addressable_params): Avoid crash on > null DECL_NAME. LGTM, thanks. > --- > gcc/sanopt.c | 9 ++--- > 1 file changed,

Re: [PATCH] sanopt: Avoid crash on anonymous parameter [PR93436]

2020-01-26 Thread Marek Polacek
On Sun, Jan 26, 2020 at 12:09:09PM +0100, Jakub Jelinek wrote: > On Sat, Jan 25, 2020 at 07:13:20PM -0500, Marek Polacek wrote: > > Here we crash when using -fsanitize=address -fdump-tree-sanopt because > > the dumping code uses IDENTIFIER_POINTER on a null DECL_NAME. Instead, > > we can print ""

[committed] coroutines: Fix whitespace and comment markers.

2020-01-26 Thread Iain Sandoe
This fixes up the uses of non-canonical forms Nathan obseved, for comments inlined in function calls and some uses of C++ style comment markers that had slipped through. Whitespace and comment changes only, NFC intended. tested in x86_64-darwin16, pushed to master, thanks Iain commit 8022264265d

Re: [PATCH] i386: Fix up -fdollars-in-identifiers with identifiers starting with $ in -masm=att (PR target/91298)

2020-01-26 Thread Rainer Orth
Hi Jakub, > On Thu, Jan 23, 2020 at 09:19:52PM +0100, Rainer Orth wrote: >> Unlikely: there's barely any development on the Solaris assemblers these >> days, though I prefer to xfail tests if possible to get notified if they >> suddenly start to work for some reason. > > Ok. here's what I've inst

Re: [PATCH] Make target_clones resolver fn static.

2020-01-26 Thread Jeff Law
On Tue, 2020-01-21 at 13:48 +0100, Martin Liška wrote: > From a3faaced989869867671ceadd89b56fabde225ff Mon Sep 17 00:00:00 2001 > From: Martin Liska > Date: Thu, 16 Jan 2020 10:38:41 +0100 > Subject: [PATCH] Make target_clones resolver fn static. > > gcc/ChangeLog: > > 2020-01-17 Martin Liska

Re: [PING^7][PATCH 0/4] Fix library testsuite compilation for build sysroot

2020-01-26 Thread Jeff Law
On Tue, 2020-01-21 at 02:19 +, Maciej W. Rozycki wrote: > On Fri, 20 Dec 2019, Mike Stump wrote: > > > > > This patch series addresses a problem with the testsuite compiler being > > > > set up across libatomic, libffi, libgo, libgomp with no correlation > > > > whatsoever to the target comp

Re: [PATCH] RX update functions with string constraint

2020-01-26 Thread Jeff Law
On Tue, 2020-01-21 at 14:18 +0200, Darius Galis wrote: > Hello, > > The following patch updates the setmemsi and rx_setmem functions. > The patch adds the rx_allow_string_insns constraint to these functions > in order to be used only when the string support is enabled. > > Regression test is OK,

Re: [PATCH] checking: avoid verify_type_variant crash on incomplete type.

2020-01-26 Thread Jeff Law
On Sat, 2020-01-25 at 23:21 -0500, Jason Merrill wrote: > Here, we end up calling gen_type_die_with_usage for a type that's in the > middle of finish_struct_1, after we set TYPE_NEEDS_CONSTRUCTING on it but > before we copy all the flags to the variants--and, significantly, before we > set its TYPE

Re: [PATCH] lra: Stop registers being incorrectly marked live [PR92989]

2020-01-26 Thread Jeff Law
On Mon, 2020-01-20 at 13:03 +, Richard Sandiford wrote: > lra_assign has an assert to make sure that no pseudo is allocated > to a conflicting hard register. It used to be restricted to > !flag_ipa_ra, but in g:a1e6ee38e708ef2bdef4 I'd enabled it for > flag_ipa_ra too. It then tripped while b

Re: [PATCH] cselib: Fix handling of multireg values for call insns [PR93170]

2020-01-26 Thread Jeff Law
On Mon, 2020-01-20 at 12:54 +, Richard Sandiford wrote: > g:3bd2918594dae34ae84f mishandled the case in which only the > tail end of a multireg hard register is invalidated by the call. > Walking all the entries should be both safer and more precise. > > Avoiding cselib_invalidate_regno also m

Re: [PATCH] Fix gcc.dg/torture/pr91323.c for aarch64 targets

2020-01-26 Thread Jeff Law
On Fri, 2020-01-17 at 12:07 +, Richard Sandiford wrote: > PR91323 was fixed for x86 and sparc in target code, but aarch64 > instead relies on the target-independent comparison splitters. > Since LTGT is an unordered-signalling operation, we should split > it into unordered-signalling operations

Re: [PATCH] Relax invalidation of TOP N counters in PGO.

2020-01-26 Thread Martin Liška
Hello Honza. Thank you for the fix! Martin

Re: [PATCH] sanopt: Avoid crash on anonymous parameter [PR93436]

2020-01-26 Thread Jakub Jelinek
On Sat, Jan 25, 2020 at 07:13:20PM -0500, Marek Polacek wrote: > Here we crash when using -fsanitize=address -fdump-tree-sanopt because > the dumping code uses IDENTIFIER_POINTER on a null DECL_NAME. Instead, > we can print "" in such a case. Or we could avoid printing > that diagnostic altogethe

Re: [PATCH] i386: Fix up *{add,sub}v4_doubleword patterns (PR target/93412)

2020-01-26 Thread Uros Bizjak
On Sun, Jan 26, 2020 at 12:59 AM Jakub Jelinek wrote: > > Hi! > > In the *{add,sub}v4_doubleword patterns, we don't really want to see a > VOIDmode last operand, because it then means invalid RTL > (sign_extend:{TI,POI} (const_int ...)) or so, and therefore something we > don't really handle in th

Re: [PATCH] i386: Fix up *avx_vperm_broadcast_v4df [PR93430]

2020-01-26 Thread Uros Bizjak
On Sun, Jan 26, 2020 at 12:55 AM Jakub Jelinek wrote: > > Hi! > > Apparently my recent patch which moved the *avx_vperm_broadcast* and > *vpermil* patterns before vpermpd broke the following testcase, the > define_insn_and_split matched always but the splitter condition only split > it if not -mav