Re: [C++ PATCH] Avoid bogus errors due to -Wredundant-tags (PR c++/93138)

2020-01-04 Thread Jason Merrill
On 1/3/20 6:34 PM, Jakub Jelinek wrote: Hi! For -Wredundant-tags or -Wmismatched-tags, cp_parser_maybe_warn_enum_key and cp_parser_check_class_key perform an extra name lookup to check if the enum/struct/class/union keyword is redundant, but as the testcase shows, if it is not redundant, but the

Re: [C++ PATCH] Fix up cp-gimplify.c ICE (PR c++/93046)

2020-01-04 Thread Jason Merrill
On 1/3/20 6:37 PM, Jakub Jelinek wrote: On the following testcase since the split_nonconstant_init move on the COND_EXPR with omitted middle-end operand we end up with the operator bool called on a TARGET_EXPR in the first operand and the same TARGET_EXPR appearing in INIT_EXPR in the second oper

[PATCH] Make cgraph_edge::resolve_speculation static

2020-01-04 Thread Martin Jambor
Hi, throughout this year a few of us got burnt by the fact that cgraph_edge::resolve_speculation method sometimes removed and deallocated its this pointer, sometimes making the this pointer of a few other methods of the class also suddenly invalid. We postponed dealing with the issue because simp

Re: [PATCH] gdbinit.in: make shorthands accept an explicit argument

2020-01-04 Thread Konstantin Kharlamov
Thank you for reviving the patch. I didn't post any updates because I got stuck for some reasons while trying to get GNU assignment, so my contribution would be accepted. Anyway, looks good to me, thanks. On 04.01.2020 16:35, Alexander Monakov wrote: Hi, I'm posting an updated patch for GCC

[PATCH] gdbinit.in: make shorthands accept an explicit argument

2020-01-04 Thread Alexander Monakov
Hi, I'm posting an updated patch for GCC gdbinit originally proposed by Konstantin. The patch amends debugging shorthands such as 'pr' to accept an explicit argument, in addition to taking an implicit argument from $ as today. In other words, pr x will be accepted to call 'debug_rtx (x)' just

Re: [PATCH] Improve __builtin_add_overflow on x86 for double-word types (PR target/93141)

2020-01-04 Thread Jakub Jelinek
On Sat, Jan 04, 2020 at 12:13:50PM +0100, Uros Bizjak wrote: > LGTM, but I wonder if *addcarry_1 gets overmacroized, the insn > condition is really hard to comprehend. Perhaps it should be written > as a separate pattern for SImode and DImode instead? > > +(define_insn "*addcarry_1" > > + [(set (

Re: [PATCH] Improve __builtin_add_overflow on x86 for double-word types (PR target/93141)

2020-01-04 Thread Uros Bizjak
On Sat, Jan 4, 2020 at 12:50 AM Jakub Jelinek wrote: > > Hi! > > As the following testcase shows, we generate quite bad code for > double-word __builtin_add_overflow on x86, we have add[dt]i3_doubleword > pattern and emit add[ql]; adc[ql];, but then we could just use setc/seto > or adc etc., but w