Re: Re: [PATCH] [MIPS] Fix PR target/91769

2019-10-05 Thread Paul Hua
Hi: The testsuite has a typo in "dg-final scan-assembler", s/mthc1/mtc1/. On Fri, Oct 4, 2019 at 7:21 PM Dragan Mladjenovic wrote: > > On 01.10.2019. 21:37, Jeff Law wrote: > > On 9/25/19 1:16 AM, Dragan Mladjenovic wrote: > >> From: "Dragan Mladjenovic" > >> > >> This fixes the issue by check

HEADSUP -- gcc/testsuite/ChangeLog bloat

2019-10-05 Thread Steve Kargl
All, It seems I fat-fingered a commit earlier today, where I accidently included a duplicate of gcc/testsuite/ChangeLog in itselfi on trunk. This added over 11000 lines of bloat to gcc/testsuite/ChangeLog. I have committed a patch to remove the bloat at revision 276630. Sorry about the unfor

Fix typo in inliner badness calculation

2019-10-05 Thread Jan Hubicka
Hi, this patch fixes a typo in the way edge badness is calculated I noticed while verifing the code. Bootstrapped/regtested x86_64-linux, comitted. * ipa-inline.c: Fix type; compute size rather than self_size for size of caller function. Index: ipa-inline.c ==

[Patch, fortran] PR91926 - assumed rank optional

2019-10-05 Thread Paul Richard Thomas
I must apologise not posting this before committing. I left for a vacation this morning and I thought that this problem and the one posted by Gilles were best fixed before departing. The patch only touches the new ISO_Fortran binding feature and so I thought that I would be safe to do this. It was

Re: [PATCH, OBVIOUS] Fix -Wshadow=local warnings in gcc/[a-c]*.c

2019-10-05 Thread Segher Boessenkool
Hi Bernd, On Sat, Oct 05, 2019 at 09:12:19AM +, Bernd Edlinger wrote: > On 10/5/19 10:08 AM, Segher Boessenkool wrote: > > I'll just review the combine part. > > > > On Sat, Oct 05, 2019 at 06:36:34AM +, Bernd Edlinger wrote: > >> --- gcc/combine.c (revision 276598) > >> +++ gcc/combine.

Re: [PATCHv2] Change the library search path when using --with-advance-toolchain

2019-10-05 Thread Segher Boessenkool
On Fri, Oct 04, 2019 at 06:31:34PM -0300, Tulio Magno Quites Machado Filho wrote: > Remove all -L directories from LINK_OS_EXTRA_SPEC32 and > LINK_OS_EXTRA_SPEC64 so that user directories specified at > build time have higher preference over the advance toolchain libraries. > > Set MD_STARTFILE_P

[PATCH] PR fortran/91801 -- convert assert to an error

2019-10-05 Thread Steve Kargl
Tested on x86_64-*-freebsd. OK to commit? The error message says it all. 2019-10-05 Steven G. Kargl PR fortran/91801 * simplify.c (gfc_simplify_reshape): Convert a gcc_assert into a gfc_error as a user can easily hit the condition. 2019-10-05 Steven G. Kargl

[wwwdocs] Update C++ DR table

2019-10-05 Thread Marek Polacek
Updates from the February, 2019 (Kona) meeting. Applied to CVS. Index: cxx-dr-status.html === RCS file: /cvs/gcc/wwwdocs/htdocs/projects/cxx-dr-status.html,v retrieving revision 1.35 diff -u -r1.35 cxx-dr-status.html --- cxx-dr-statu

Re: [PATCH] PR fortran/91497 -- Silence conversion warnings

2019-10-05 Thread Steve Kargl
On Sat, Oct 05, 2019 at 06:27:08AM -0700, Steve Kargl wrote: > On Sat, Oct 05, 2019 at 03:18:45PM +0200, Rainer Orth wrote: > > Hi Steve, > > > > >> the new testcases FAILs on sparc and a couple of other targets: > > >> > > >> +FAIL: gfortran.dg/pr91497.f90 -O (test for excess errors) > > >>

Re: [21/32] Remove global call sets: LRA

2019-10-05 Thread Richard Sandiford
"H.J. Lu" writes: > On Fri, Oct 4, 2019 at 11:03 AM H.J. Lu wrote: >> >> On Wed, Sep 11, 2019 at 12:14 PM Richard Sandiford >> wrote: >> > >> > lra_reg has an actual_call_used_reg_set field that is only used during >> > inheritance. This in turn required a special lra_create_live_ranges >> > pa

Re: [PATCH] PR fortran/91497 -- Silence conversion warnings

2019-10-05 Thread Steve Kargl
On Sat, Oct 05, 2019 at 03:18:45PM +0200, Rainer Orth wrote: > Hi Steve, > > >> the new testcases FAILs on sparc and a couple of other targets: > >> > >> +FAIL: gfortran.dg/pr91497.f90 -O (test for excess errors) > >> > >> Excess errors: > >> /vol/gcc/src/hg/trunk/local/gcc/testsuite/gfortran

Re: [PATCH] PR fortran/91497 -- Silence conversion warnings

2019-10-05 Thread Rainer Orth
Hi Steve, >> the new testcases FAILs on sparc and a couple of other targets: >> >> +FAIL: gfortran.dg/pr91497.f90 -O (test for excess errors) >> >> Excess errors: >> /vol/gcc/src/hg/trunk/local/gcc/testsuite/gfortran.dg/pr91497.f90:13:13: >> Error: Old-style type declaration REAL*10 not suppo

Re: Add a simulate_builin_function_decl langhook

2019-10-05 Thread Richard Sandiford
Jeff Law writes: > On 9/26/19 6:04 AM, Richard Sandiford wrote: >> Although it's possible to define the SVE intrinsics in a normal header >> file, it's much more convenient to define them directly in the compiler. >> This also speeds up compilation and gives better error messages. >> >> The idea

Re: [PATCH, OBVIOUS] Fix -Wshadow=local warnings in gcc/[a-c]*.c

2019-10-05 Thread Bernd Edlinger
Hi Segher, On 10/5/19 10:08 AM, Segher Boessenkool wrote: > Hi Bernd, > > I'll just review the combine part. > > On Sat, Oct 05, 2019 at 06:36:34AM +, Bernd Edlinger wrote: >> --- gcc/combine.c(revision 276598) >> +++ gcc/combine.c(working copy) >> @@ -1219,7 +1219,7 @@ combine_instr

Re: [PATCH] IPA-CP release transformation summary (PR jit/91928)

2019-10-05 Thread Andrea Corallo
Jeff Law writes: > On 10/3/19 6:47 AM, Andrea Corallo wrote: >> >> Jeff Law writes: >> >>> On 10/1/19 4:11 AM, Andrea Corallo wrote: Martin Jambor writes: > Hi, > > On Mon, Sep 30 2019, Andrea Corallo wrote: >> Hi all, >> I'd like to submit this patch. >> It rel

Re: [PATCH] Fix -Wshadow=local warnings in elfos.h

2019-10-05 Thread Segher Boessenkool
On Sat, Oct 05, 2019 at 08:28:26AM +, Bernd Edlinger wrote: > On 10/5/19 9:26 AM, Segher Boessenkool wrote: > > On Fri, Oct 04, 2019 at 02:26:26PM -0600, Jeff Law wrote: > > To get 95% of the benefit for only 2% of the pain, you can make an inline > > function where there was a macro before, an

Re: [PATCH] Fix -Wshadow=local warnings in elfos.h

2019-10-05 Thread Bernd Edlinger
On 10/5/19 9:26 AM, Segher Boessenkool wrote: > On Fri, Oct 04, 2019 at 02:26:26PM -0600, Jeff Law wrote: >> Same objections as before. As long as we're using macros like this, >> we're going to have increased potential for shadowing problems and >> macros which touch implementation details that j

[Darwin, committed] Amend section for constants with relocations.

2019-10-05 Thread Iain Sandoe
Darwin's linker doesn't like text section relocations (they require special enabling). At least, the Fortran FE seems to generate cases where the initialiser for a pointer constant can need a relocation. We can handle this by special-casing SECCAT_RODATA when the relocation is present by placin

Re: [PATCH, OBVIOUS] Fix -Wshadow=local warnings in gcc/[a-c]*.c

2019-10-05 Thread Segher Boessenkool
Hi Bernd, I'll just review the combine part. On Sat, Oct 05, 2019 at 06:36:34AM +, Bernd Edlinger wrote: > --- gcc/combine.c (revision 276598) > +++ gcc/combine.c (working copy) > @@ -1219,7 +1219,7 @@ combine_instructions (rtx_insn *f, unsigned int nr >FOR_BB_INSNS (this_basi

[PATCH, OBVIOUS] Fix -Wshadow=local warnings in gcc/[d-f]*.c

2019-10-05 Thread Bernd Edlinger
Hi, this fixes -Wshadow=local warnings in the following files: M gcc/df-problems.c M gcc/df-scan.c M gcc/diagnostic-show-locus.c M gcc/dse.c M gcc/dwarf2cfi.c M gcc/dwarf2out.c M gcc/emit-rtl.c M gcc/expmed.c M gcc/final.c M gcc/fold-con

Re: [C++ PATCH] PR c++/91369 - Implement P0784R7: constexpr new

2019-10-05 Thread Jakub Jelinek
On Fri, Oct 04, 2019 at 03:34:39PM -0400, Jason Merrill wrote: > > @@ -1656,6 +1671,64 @@ cxx_eval_call_expression (const constexp > >lval, non_constant_p, overflow_p); > > if (!DECL_DECLARED_CONSTEXPR_P (fun)) > > { > > + if (cxx_dialect >= cx

Re: [PATCH] Fix -Wshadow=local warnings in elfos.h

2019-10-05 Thread Segher Boessenkool
On Fri, Oct 04, 2019 at 02:26:26PM -0600, Jeff Law wrote: > Same objections as before. As long as we're using macros like this, > we're going to have increased potential for shadowing problems and > macros which touch implementation details that just happen to be > available in the context where t

Re: [PATCH] Fix -Wshadow=local warnings in rtl.h

2019-10-05 Thread Jakub Jelinek
On Sat, Oct 05, 2019 at 06:12:37AM +, Bernd Edlinger wrote: > On 10/3/19 5:25 PM, Jakub Jelinek wrote: > > What effect does this have on the cc1/cc1plus .text sizes? > > r276457: > > with patch, --enable-languages=all --enable-checking=yes,rtl > $ size gcc/cc1 >textdata bss de