Re: [C++ PATCH] vfunc overrider simplification

2019-08-24 Thread Nathan Sidwell
On 8/23/19 3:24 PM, Nathan Sidwell wrote: In fixing a vfunc override bug on the modules branch, I noticed that check_for_override can simply check IDENTIFIER_VIRTUAL_P -- the dtor identifier and those for conversion operators will have it set correctly.  (there a multiple conversion operator id

Re: [patch, fortran] Fix PR 91390 - treatment of extra parameter in a subroutine call

2019-08-24 Thread Thomas König
Hi Steve, OK. Thanks for taking on this task. Committed (r274902). Thanks for the review! As to the open question about how to handle this check, I would create -fallow-argument-mismatch (or whatever option name you like). gfortran issues an error if a mismatch is detected. -fallow-... wo

Re: types for VR_VARYING

2019-08-24 Thread Martin Sebor
On 8/24/19 4:55 AM, Aldy Hernandez wrote: On 8/23/19 4:27 PM, Martin Sebor wrote: On 8/15/19 10:06 AM, Aldy Hernandez wrote: Hey Aldy, After enabling EVRP for the strlen pass (as part of the sprintf integration) I get a SEGV in the return statement in the function below.  Backing out this

Re: [patch, fortran] Fix PR 91390 - treatment of extra parameter in a subroutine call

2019-08-24 Thread Steve Kargl
On Tue, Aug 20, 2019 at 10:32:37PM +0200, Thomas König wrote: > > 2019-08-20 Thomas Koenig > > PR fortran/91390 > * frontend-passes.c (check_externals_procedure): New > function. If a procedure is not in the translation unit, create > an "interface" for it, including it

Re: [PATCH v6 3/3] PR80791 Consider doloop cmp use in ivopts

2019-08-24 Thread Kewen.Lin
Hi Bin, on 2019/8/23 下午5:43, Bin.Cheng wrote: > On Fri, Aug 23, 2019 at 4:27 PM Kewen.Lin wrote: >> >> Hi Bin >> >> on 2019/8/23 上午10:19, Bin.Cheng wrote: >>> On Thu, Aug 22, 2019 at 3:09 PM Kewen.Lin wrote: Hi Bin, on 2019/8/22 下午1:46, Bin.Cheng wrote: > On Thu, Aug 22,

Re: types for VR_VARYING

2019-08-24 Thread Aldy Hernandez
On 8/23/19 4:27 PM, Martin Sebor wrote: On 8/15/19 10:06 AM, Aldy Hernandez wrote: Hey Aldy, After enabling EVRP for the strlen pass (as part of the sprintf integration) I get a SEGV in the return statement in the function below.  Backing out this change gets rid of the ICE and lets my tes

Re: [x86 testsuite] preserve full register across main

2019-08-24 Thread Uros Bizjak
On Friday, August 23, 2019, Alexandre Oliva wrote: > This test uses a call-saved register as a global variable. It > attempts to preserve its value across main, but only the lower int > part is preserved, which is not good enough for x86_64, when the > runtime that calls main() happens to hold so