Re: [PATCH] [RFC, PGO+LTO] Missed function specialization + partial devirtualization

2019-06-19 Thread luoxhu
Hi Martin, On 2019/6/20 09:59, luoxhu wrote: On 2019/6/19 20:18, Martin Liška wrote: On 6/19/19 10:56 AM, Martin Liška wrote: Thank you very much for the numbers. Today, I'm going to prepare the generalization of single-value counter to track N values. Ok, here's a patch candidate that doe

Re: PR libstdc++/90945 Patch to have pretty printer for std::vector return bool intead of int for elements

2019-06-19 Thread Stephan Bergmann
On 19/06/2019 21:54, Jonathan Wakely wrote: On 19/06/19 21:49 +0200, Michael Weghorn wrote: On 19/06/2019 21.37, Jonathan Wakely wrote: +  std::vector vb; +  vb.reserve(100); +  vb.push_back(true); +  vb.push_back(true); +  vb.push_back(false); +  vb.push_back(false); +  vb.push_back(true); + 

Re: [PATCH] Enable GCC support for AVX512_VP2INTERSECT.

2019-06-19 Thread Uros Bizjak
On Thu, Jun 20, 2019 at 7:36 AM Hongtao Liu wrote: > > On Sat, Jun 8, 2019 at 4:12 AM Uros Bizjak wrote: > > > > On 6/7/19, H.J. Lu wrote: > > > > >> > > +/* Register pair. */ > > >> > > +VECTOR_MODES_WITH_PREFIX (P, INT, 2); /* P2QI */ > > >> > > +VECTOR_MODES_WITH_PREFIX (P, INT, 4); /* P2HI

Re: [RFC] ARM -mfpu=auto woes

2019-06-19 Thread Alexandre Oliva
Richard, Thanks for your feedback. I conclude from it that it's not worth it to introduce code to support configuring --with-fpu=auto, so I'm going ahead and installing just the obvious configury bits I'd posted before. On Jun 12, 2019, Alexandre Oliva wrote: > So, any objections to my install

Re: [PATCH] Enable GCC support for AVX512_VP2INTERSECT.

2019-06-19 Thread Hongtao Liu
On Sat, Jun 8, 2019 at 4:12 AM Uros Bizjak wrote: > > On 6/7/19, H.J. Lu wrote: > > >> > > +/* Register pair. */ > >> > > +VECTOR_MODES_WITH_PREFIX (P, INT, 2); /* P2QI */ > >> > > +VECTOR_MODES_WITH_PREFIX (P, INT, 4); /* P2HI P4QI */ > >> > > > >> > > I think > >> > > > >> > > INT_MODE (P2QI,

Re: [PATCH 0/2][RFC][PR88836][AARCH64] Fix redundant ptest instruction

2019-06-19 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for your comments. On Thu, 16 May 2019 at 18:13, Richard Sandiford wrote: > > kugan.vivekanandara...@linaro.org writes: > > From: Kugan Vivekanandarajah > > > > Inorder to fix this PR. > > * We need to change the whilelo pattern in backend > > * Change RTL CSE such that: >

Re: Use ODR for canonical types construction in LTO

2019-06-19 Thread Jason Merrill
On Wed, Jun 19, 2019 at 2:47 PM Nathan Sidwell wrote: > > On 6/19/19 1:53 PM, Jan Hubicka wrote: > -ctype = CLASSTYPE_AS_BASE (ctype); > +{ > + if (!tree_int_cst_equal (TYPE_SIZE (ctype), > + TYPE_SIZE (CLASSTYPE_AS_BASE (ctype > +

[C++ Patch] PR 90909 ("[10 Regression] call devirtualized to pure virtual")

2019-06-19 Thread Paolo Carlini
Hi, this bug notices that the more aggressive de-virtualization check that we have now in place (fixed c++/67184) doesn't work correctly for the below reproducer, which involves a pure virtual: we de-virtualize and the build fails at link-time. To cure this I believe we simply want an additio

[PATCH] Adding RBIT gcc builtin for ARM

2019-06-19 Thread Ayan Shafqat
The attached patch contains __builtin_arm_rbit which generates RBIT instruction for ARM targets. Please let me know if you any questions or comments, or commit this patch for me as I do not have write access to SVN. Thanks Ayan commit a692b5b4965840babbdaf5e2b9b1feb1995d351d Author: Ayan Sha

Re: [PATCH] [RFC, PGO+LTO] Missed function specialization + partial devirtualization

2019-06-19 Thread luoxhu
On 2019/6/19 20:18, Martin Liška wrote: On 6/19/19 10:56 AM, Martin Liška wrote: Thank you very much for the numbers. Today, I'm going to prepare the generalization of single-value counter to track N values. Ok, here's a patch candidate that does tracking of most common N values. For your

C++ PATCH for c++/64235 - missing syntax error with invalid alignas

2019-06-19 Thread Marek Polacek
We are wrongly accepting invalid code like: struct alignas(16 S2 { }; // missing ) The reason is that cp_parser_type_specifier uses tentative parsing to see if we're dealing with a class-specifier, and if that doesn't work, it looks for an elaborated-type-specifier. When trying to parse it as

Re: [PATCH,RFC,V2 2/3] Add CTF command line options : -gtLEVEL

2019-06-19 Thread Indu Bhagat
On 06/18/2019 12:24 PM, Bernhard Reutner-Fischer wrote: On 12 June 2019 20:00:09 CEST, Indu Bhagat wrote: -gtLEVEL is used to request CTF debug information and also to specify how much CTF debug information. The option name is way too generic IMO. -gctfLEVEL or some such would at least indi

[PATCH] Fix non-standard behaviour of std::istream_iterator

2019-06-19 Thread Jonathan Wakely
The current implementation of istream_iterator allows the iterator to be reused after reaching end-of-stream, so that subsequent reads from the stream can succeed (e.g. if the stream state has been cleared and stream position changed from EOF). The P0738R2 paper clarified that the expected behavio

[PATCH] PR libstdc++/90920 restore previous checks for empty ranges

2019-06-19 Thread Jonathan Wakely
The change in r263433 broke the contract of the __rotate functions, by no longer accepting empty ranges. That means that callers which inlined the old version of std::rotate (without checks) that end up linking to a new definition of std::__rotate (also without checks) could perform a divide by ze

Re: PR libstdc++/90945 Patch to have pretty printer for std::vector return bool intead of int for elements

2019-06-19 Thread Jonathan Wakely
On 19/06/19 21:58 +0200, Michael Weghorn wrote: On 19/06/2019 21.54, Jonathan Wakely wrote: +  std::vector vb; +  vb.reserve(100); +  vb.push_back(true); +  vb.push_back(true); +  vb.push_back(false); +  vb.push_back(false); +  vb.push_back(true); +  vb.erase(vb.begin()); +// { dg-final { regexp

Re: [PATCH] improve strcmp folding of unequal strings (PR 90626)

2019-06-19 Thread Martin Sebor
On 6/14/19 2:03 PM, Jeff Law wrote: On 6/13/19 5:50 PM, Martin Sebor wrote: While integrating the strlen and sprintf passes and investigating optimization opportunities that it opens up I noticed a few related to a strcmp optimization implemented in GCC 9.  One is to take advantage of the fact t

[PATCH] PR fortran/86587 -- PRIVATE and BIND(C) are allowed for derived type

2019-06-19 Thread Steve Kargl
Revision 126185 introduced ISO C Binding to gfortran. In that revision, a check for a conflict between a derived type with the PRIVATE attribute and BIND(C) was introduced. After checking the F2003, F2008, and F2018 standards, I cannot find this restriction. Thus, the check is removed by the atta

Re: [wwwdocs] Announce PRU backend

2019-06-19 Thread Dimitar Dimitrov
On сряда, 19 юни 2019 г. 13:23:01 EEST Jeff Law wrote: > On 6/19/19 11:06 AM, Dimitar Dimitrov wrote: > > Hi, > > > > This WWW update announces the new PRU port in WWW docs, and fills in the > > backend characteristics. > OK > jeff Thank you. Pushed to CVS. Dimitar

Re: [PATCH] Wrap 'expand_all_functions' and 'ipa_passes' around timevars

2019-06-19 Thread Giuliano Belinassi
Hi, Oh, I have completely forgotten about this patch On 06/19, Jeff Law wrote: > On 1/24/19 12:51 PM, Giuliano Belinassi wrote: > > This patch adds two variables named 'TV_CGRAPH_FUNC_EXPANSION' and > > 'TV_CGRAPH_IPA_PASSES' that count the elapsed time of the functions > > 'expand_all_functions'

Re: PR libstdc++/90945 Patch to have pretty printer for std::vector return bool intead of int for elements

2019-06-19 Thread Michael Weghorn
On 19/06/2019 21.54, Jonathan Wakely wrote: >>> +  std::vector vb; >>> +  vb.reserve(100); >>> +  vb.push_back(true); >>> +  vb.push_back(true); >>> +  vb.push_back(false); >>> +  vb.push_back(false); >>> +  vb.push_back(true); >>> +  vb.erase(vb.begin()); >>> +// { dg-final { regexp-test vb {std::

Re: PR libstdc++/90945 Patch to have pretty printer for std::vector return bool intead of int for elements

2019-06-19 Thread Jonathan Wakely
On 19/06/19 21:49 +0200, Michael Weghorn wrote: Thank you for the quick reply! On 19/06/2019 21.37, Jonathan Wakely wrote: Thanks, the patch looks fine and is small enough that we can accept it without a copyright assignment, but if you plan to contribute again you should look into https://gcc.

Re: PR libstdc++/90945 Patch to have pretty printer for std::vector return bool intead of int for elements

2019-06-19 Thread Michael Weghorn
Thank you for the quick reply! On 19/06/2019 21.37, Jonathan Wakely wrote: > Thanks, the patch looks fine and is small enough that we can accept it > without a copyright assignment, but if you plan to contribute again > you should look into https://gcc.gnu.org/contribute.html#legal I'll do as soo

Re: [PATCH] implement -Wformat-diag, v2

2019-06-19 Thread Martin Sebor
On 6/19/19 10:46 AM, Jeff Law wrote: On 6/18/19 1:21 PM, Martin Sebor wrote: On 6/18/19 12:59 PM, Jeff Law wrote: On 5/22/19 10:42 AM, Martin Sebor wrote: Attached is a revised implementation of the -Wformat-diag checker incorporating the feedback I got on the first revision. Martin gcc-wfor

Re: PR libstdc++/90945 Patch to have pretty printer for std::vector return bool intead of int for elements

2019-06-19 Thread Jonathan Wakely
On 19/06/19 19:04 +0200, Michael Weghorn wrote: Hi everyone, the Python pretty printer for a 'std::vector' currently returns integers as values for the elements, which e.g. leads to the situation that a 'gdb.Value' constructed from that doesn't have 'bool' type, but an integer type ('long long'

Re: C++ PATCH for c++/60364 - noreturn after first decl not diagnosed (v2)

2019-06-19 Thread Jeff Law
On 6/17/19 12:10 PM, Marek Polacek wrote: > On Mon, Jun 17, 2019 at 09:02:17AM -0600, Martin Sebor wrote: >>> diff --git gcc/cp/tree.c gcc/cp/tree.c >>> index cd021b7f594..bb695e14e73 100644 >>> --- gcc/cp/tree.c >>> +++ gcc/cp/tree.c >>> @@ -4453,6 +4453,8 @@ const struct attribute_spec std_attrib

[Darwin, specs, committed] Tidy some more linker options.

2019-06-19 Thread Iain Sandoe
pie, no-pie and rdynamic are driver options, we can process them in the relevant place and drop them once dealt with. Support for the -pie, -no_pie and -no_compact_unwind options should ideally be checked at configure time, however the status quo is to assert that linkers capable of targeting

Re: [wwwdocs] Announce PRU backend

2019-06-19 Thread Jeff Law
On 6/19/19 11:06 AM, Dimitar Dimitrov wrote: > Hi, > > This WWW update announces the new PRU port in WWW docs, and fills in the > backend characteristics. OK jeff

Re: PING^1: [PATCH] i386: Generate standard floating point scalar operation patterns

2019-06-19 Thread Jeff Law
On 6/3/19 4:50 PM, H.J. Lu wrote: > On Tue, May 21, 2019 at 8:54 AM H.J. Lu wrote: >> >> On Wed, May 15, 2019 at 2:29 PM Richard Sandiford >> wrote: >>> >>> "H.J. Lu" writes: On Thu, Feb 7, 2019 at 9:49 AM H.J. Lu wrote: > > Standard scalar operation patterns which preserve the res

[Committed] PR fortran/69499 -- SELECT TYPE is executable statement

2019-06-19 Thread Steve Kargl
I have committed the attach patch. It checks that a SELECT TYPE construct does not appear in MODULE or SUBMODULE scope as it is an executable statement. 2019-06-19 Steven G. Kargl PR fortran/69499 * match.c (gfc_match_select_type): SELECT TYPE is an executable state

Re: Use ODR for canonical types construction in LTO

2019-06-19 Thread Nathan Sidwell
On 6/19/19 1:53 PM, Jan Hubicka wrote: -ctype = CLASSTYPE_AS_BASE (ctype); +{ + if (!tree_int_cst_equal (TYPE_SIZE (ctype), + TYPE_SIZE (CLASSTYPE_AS_BASE (ctype +ctype = CLASSTYPE_AS_BASE (ctype); +} tree clobber = build_clobber (cty

Re: [PATCH] Reintroduce vec_shl_optab and use it for #pragma omp scan inclusive

2019-06-19 Thread Richard Biener
On June 19, 2019 2:46:15 PM GMT+02:00, Richard Sandiford wrote: >Richard Biener writes: >> On June 19, 2019 11:05:42 AM GMT+02:00, Richard Sandiford > wrote: >>>Richard Biener writes: On June 19, 2019 10:55:16 AM GMT+02:00, Jakub Jelinek >>> wrote: >Hi! > >When VEC_[LR]SHIFT_EX

Re: [PATCH] Wrap 'expand_all_functions' and 'ipa_passes' around timevars

2019-06-19 Thread Jeff Law
On 1/24/19 12:51 PM, Giuliano Belinassi wrote: > This patch adds two variables named 'TV_CGRAPH_FUNC_EXPANSION' and > 'TV_CGRAPH_IPA_PASSES' that count the elapsed time of the functions > 'expand_all_functions' and 'ipa_passes', respectivelly. > > The main point of this is that these functions tak

Re: [PATCH 2/2] PR c/65403 - Add tests for -Wno-error=

2019-06-19 Thread Jeff Law
On 3/18/19 8:46 PM, Alex Henrie wrote: > --- > gcc/testsuite/c-c++-common/pr65403-1.c | 10 ++ > gcc/testsuite/c-c++-common/pr65403-2.c | 15 +++ > 2 files changed, 25 insertions(+) > create mode 100644 gcc/testsuite/c-c++-common/pr65403-1.c > create mode 100644 gcc/testsuite

Re: Use ODR for canonical types construction in LTO

2019-06-19 Thread Jan Hubicka
> > > -ctype = CLASSTYPE_AS_BASE (ctype); > > > +{ > > > + if (!tree_int_cst_equal (TYPE_SIZE (ctype), > > > +TYPE_SIZE (CLASSTYPE_AS_BASE (ctype > > > +ctype = CLASSTYPE_AS_BASE (ctype); > > > +} > > > tree clobber = build_clobber (ctype); >

Re: [PATCH 1/2] PR c/65403 - Ignore -Wno-error=

2019-06-19 Thread Jeff Law
On 3/18/19 8:46 PM, Alex Henrie wrote: > From: Manuel López-Ibáñez > > * opts.c: Ignore -Wno-error= except if there are > other diagnostics. That's not a complete ChangeLog entry. Each file/function changed should be mentioned. Something like this: * opts-common.c (ignored_wnoerror_opt

unordered_multimap/unordered_multiset optimizations

2019-06-19 Thread François Dumont
Hi     Still influenced by PR 68303 this patch: - Extend usage of find within other methods. It simplify code and will allow to implement the PR in less places if we decide to do so. - Get rid of several bucket index comparison for non-unique key containers this way we have less hash code co

[wwwdocs] Announce PRU backend

2019-06-19 Thread Dimitar Dimitrov
Hi, This WWW update announces the new PRU port in WWW docs, and fills in the backend characteristics. Thanks, Dimitar Index: htdocs/backends.html === RCS file: /cvs/gcc/wwwdocs/htdocs/backends.html,v retrieving revision 1.85 diff -

PR libstdc++/90945 Patch to have pretty printer for std::vector return bool intead of int for elements

2019-06-19 Thread Michael Weghorn
Hi everyone, the Python pretty printer for a 'std::vector' currently returns integers as values for the elements, which e.g. leads to the situation that a 'gdb.Value' constructed from that doesn't have 'bool' type, but an integer type ('long long' for my test with gdb 8.2.1 on Debian testing, amd6

Re: [PATCH 1/3] Create GCN-specific gthreads

2019-06-19 Thread Jeff Law
On 6/19/19 10:56 AM, Andrew Stubbs wrote: > On 19/06/2019 17:04, Jeff Law wrote: >> On 6/19/19 2:57 AM, Andrew Stubbs wrote: >>> Ping. >>> >>> I can probably approve this myself, as it only affects GCN, but I'd >>> appreciate a second opinion. >> Yes, this would fall under things you could approve

Re: [PATCH 2/3] Stub implementation of unwinding for AMD GCN.

2019-06-19 Thread Andrew Stubbs
On 19/06/2019 17:04, Jeff Law wrote: On 6/19/19 2:58 AM, Andrew Stubbs wrote: Ping. I can probably approve this myself, as it only affects GCN, but I'd appreciate a second opinion. Similarly this is fine to self-approve. Thanks. Sorry, same again, I meant I'd like another opinion on the pat

Re: [PATCH 1/3] Create GCN-specific gthreads

2019-06-19 Thread Andrew Stubbs
On 19/06/2019 17:04, Jeff Law wrote: On 6/19/19 2:57 AM, Andrew Stubbs wrote: Ping. I can probably approve this myself, as it only affects GCN, but I'd appreciate a second opinion. Yes, this would fall under things you could approve yourself. Thanks for double-checking. Sorry, I meant I'd l

Re: [PATCH] implement -Wformat-diag, v2

2019-06-19 Thread Jeff Law
On 6/18/19 1:21 PM, Martin Sebor wrote: > On 6/18/19 12:59 PM, Jeff Law wrote: >> On 5/22/19 10:42 AM, Martin Sebor wrote: >>> Attached is a revised implementation of the -Wformat-diag checker >>> incorporating the feedback I got on the first revision. >>> >>> Martin >>> >>> gcc-wformat-diag-checke

Re: [PATCH] PR fortran/69398 -- Duplicate dimensions and CLASS

2019-06-19 Thread Dominique d'Humières
Hi Steve, Patch missing? TIA Dominique

Re: [PATCH] PR fortran/87907 -- Don't dereference a NULL pointer

2019-06-19 Thread Paul Richard Thomas
Hi Steve, I'm surprised that you didn't commit as obvious :-) OK for trunk. Thanks Paul On Tue, 18 Jun 2019 at 20:30, Steve Kargl wrote: > > The attach patch has been regression tested on x86_64-*-freebsd. > If the pointer is NULL, the function simply returns. It seems > that gfortran then do

Re: [RFC, PATCH] Display inlining context for uninitialized warnings

2019-06-19 Thread Jeff Law
On 6/19/19 8:57 AM, Martin Sebor wrote: > On 6/19/19 5:11 AM, Vladislav Ivanishin wrote: >> Hi, >> >> This patch (partially) adds displaying inlining context for >> -W{maybe,}uninitialized warnings.  This is not as trivial to enable as >> simply supplying the "%G" format specifier, so I have some q

[Darwin, committed] Fix two off-by-one errors in the driver.

2019-06-19 Thread Iain Sandoe
Spotted by Dominique with a sanitised build. fixed thus on trunk - will backport as needed. thanks Iain 2019-06-19 Iain Sandoe * config/darwin-driver.c (darwin_driver_init): Fix off-by-one errors in computing the number of options to be moved. diff --git a/gcc/config/darwin

Re: [PATCH 3/3] Enable full libgfortran library for AMD GCN

2019-06-19 Thread Jeff Law
On 6/7/19 8:40 AM, Andrew Stubbs wrote: > This patch basically reverts the previous patch to put AMD GCN in > "minimal" mode. > > OK to commit? OK jeff

Re: [PATCH 2/3] Stub implementation of unwinding for AMD GCN.

2019-06-19 Thread Jeff Law
On 6/19/19 2:58 AM, Andrew Stubbs wrote: > Ping. > > I can probably approve this myself, as it only affects GCN, but I'd > appreciate a second opinion. Similarly this is fine to self-approve. Thanks. Jeff

Re: [PATCH 1/3] Create GCN-specific gthreads

2019-06-19 Thread Jeff Law
On 6/19/19 2:57 AM, Andrew Stubbs wrote: > Ping. > > I can probably approve this myself, as it only affects GCN, but I'd > appreciate a second opinion. Yes, this would fall under things you could approve yourself. Thanks for double-checking. jeff

Re: [PATCH, netbsd] Give a name to the number 0 in sysarch(0, ...)

2019-06-19 Thread Jeff Law
On 6/19/19 7:13 AM, co...@sdf.org wrote: > The definition originates in > https://nxr.netbsd.org/xref/src/sys/arch/arm/include/sysarch.h#58 > > I've added the prefix SYSARCH to avoid any naming conflict concerns. > > It looked a bit like an error on a first impression :-) > > > 0001-Give-a-name

Re: [PATCH] Decrease hash-table-verification-limit from 100 to 10.

2019-06-19 Thread Jeff Law
On 6/19/19 7:15 AM, Martin Liška wrote: > Hi. > > The patch is about decrease of verification limit. I collected following > statistics: > > godot WPA: > > hash-table-verification-limit=0: 66s > hash-table-verification-limit=10: 69s > hash-table-verification-limit=100: 94s > > make all runtime

Re: [PATCH] [ARC] Fix PR89838

2019-06-19 Thread Jeff Law
On 6/19/19 3:29 AM, Claudiu Zissulescu wrote: > Hi Jeff, > >> OK. >> > Thank you for your review. > >> THe BZ mentions that this was found building a glibc test for ARC. >> Is there a glibc port for the ARC? I don't see one in the glibc >> git repo. Are you aware of any plans to produce an offi

Re: std::inclusive_scan

2019-06-19 Thread Jonathan Wakely
On 19/06/19 00:04 +0100, Jonathan Wakely wrote: On 18/06/19 19:08 +0100, Dietmar Kuehl via libstdc++ wrote: The first release shipping the parallel algorithms is gcc-9.1.0. Specifically std::inclusive_scan() *without* execution policy seems to be missing, though. I guess, that’s because it was

Go patch committed: Optimize string concatenations

2019-06-19 Thread Ian Lance Taylor
This patch to the Go frontend and libgo by Cherry Zhang optimizes string concatenations. runtime.concatstring{2,3,4,5} are just wrappers of concatstrings. These wrappers don't provide any benefit, at least in the C calling convention we use, where passing arrays by value isn't an efficient thing.

Re: [RFC, PATCH] Display inlining context for uninitialized warnings

2019-06-19 Thread Martin Sebor
On 6/19/19 5:11 AM, Vladislav Ivanishin wrote: Hi, This patch (partially) adds displaying inlining context for -W{maybe,}uninitialized warnings. This is not as trivial to enable as simply supplying the "%G" format specifier, so I have some questions below. I need this hunk void percent_K_

[PATCH, v2] PowerPC: Add 'prefix' to the 'isa' attribute

2019-06-19 Thread Michael Meissner
On Tue, Jun 18, 2019 at 07:13:22AM -0500, Segher Boessenkool wrote: > On Mon, Jun 17, 2019 at 08:04:42PM -0400, Michael Meissner wrote: > > --- gcc/config/rs6000/rs6000.md (revision 272270) > > +++ gcc/config/rs6000/rs6000.md (working copy) > > @@ -267,7 +267,9 @@ (define_attr "cpu" > >

[PATCH, i386]: Remove dead code from cmpstrnsi expander

2019-06-19 Thread Uros Bizjak
Operand 0 is always a register due to register_operand predicate. 2019-06-19 Uroš Bizjak * config/i386/i386.md (cmpstrnsi): Remove dead code. Bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Committed to mainline SVN. Uros. Index: config/i386/i386.md =

Re: Use ODR for canonical types construction in LTO

2019-06-19 Thread Nathan Sidwell
On 6/19/19 9:28 AM, Jan Hubicka wrote: Jason, I also wonder if something like this would make sense: * decl.c (build_clobber_this): Use original basetype if they match. Index: decl.c === --- decl.c (revision 27

Re: Use ODR for canonical types construction in LTO

2019-06-19 Thread Jan Hubicka
> Jason, > I also wonder if something like this would make sense: > > * decl.c (build_clobber_this): Use original basetype if they > match. > > Index: decl.c > === > --- decl.c(revision 272381) > +++ decl.c(workin

[PATCH] Decrease hash-table-verification-limit from 100 to 10.

2019-06-19 Thread Martin Liška
Hi. The patch is about decrease of verification limit. I collected following statistics: godot WPA: hash-table-verification-limit=0: 66s hash-table-verification-limit=10: 69s hash-table-verification-limit=100: 94s make all runtime libraries in GCC for --disable-bootstrap --disable-libsanitize

[PATCH, netbsd] Give a name to the number 0 in sysarch(0, ...)

2019-06-19 Thread coypu
The definition originates in https://nxr.netbsd.org/xref/src/sys/arch/arm/include/sysarch.h#58 I've added the prefix SYSARCH to avoid any naming conflict concerns. It looked a bit like an error on a first impression :-) * config/arm/netbsd-elf.h (SYSARCH_ARM_SYNC_ICACHE): New definition. (CLEAR_I

Re: [PATCH] Fix PR84521

2019-06-19 Thread Wilco Dijkstra
Hi Max, > On Tue, Jun 18, 2019 at 4:53 PM Wilco Dijkstra wrote: > > > It would work if a frame pointer was initialized in the function test, but > > > it wasn't: > > > > Right, because it unwinds, it needs a valid frame pointer since we no > > longer store the stack pointer. So xtensa_frame_point

Re: [PATCH] Reintroduce vec_shl_optab and use it for #pragma omp scan inclusive

2019-06-19 Thread Jakub Jelinek
On Wed, Jun 19, 2019 at 01:46:15PM +0100, Richard Sandiford wrote: > For can_vec_perm_const_p we could either add zeroness information > to vec_perm_indices or provide it separately (e.g. with tree inputs). > In the latter case the zeroness could be relayed to > targetm.vec_perm_const by passing ze

Re: [PING][PATCH 0/3] GNAT test suite fixes for build sysroot

2019-06-19 Thread Arnaud Charlet
> > In the course of setting up GCC regression testing for the RISC-V target > > I have discovered that the GNAT test suite does not correctly respond to > > the test environment settings passed from the test harness in my setup and > > consequently no test case works correctly. > > Ping for:

Re: [PATCH] Reintroduce vec_shl_optab and use it for #pragma omp scan inclusive

2019-06-19 Thread Richard Sandiford
Richard Biener writes: > On June 19, 2019 11:05:42 AM GMT+02:00, Richard Sandiford > wrote: >>Richard Biener writes: >>> On June 19, 2019 10:55:16 AM GMT+02:00, Jakub Jelinek >> wrote: Hi! When VEC_[LR]SHIFT_EXPR has been replaced with VEC_PERM_EXPR, vec_shl_optab has been

Re: [PATCH] [RFC, PGO+LTO] Missed function specialization + partial devirtualization

2019-06-19 Thread Martin Liška
On 6/19/19 10:56 AM, Martin Liška wrote: > Thank you very much for the numbers. Today, I'm going to prepare the > generalization of single-value counter to track N values. Ok, here's a patch candidate that does tracking of most common N values. For your test-case I can see: pr69678.gcda:01a

[PING][PATCH 0/3] GNAT test suite fixes for build sysroot

2019-06-19 Thread Maciej Rozycki
On Tue, 14 May 2019, Maciej W. Rozycki wrote: > In the course of setting up GCC regression testing for the RISC-V target > I have discovered that the GNAT test suite does not correctly respond to > the test environment settings passed from the test harness in my setup and > consequently no tes

[PATCH v3 3/3] PR80791 Consider doloop cmp use in ivopts

2019-06-19 Thread Kewen.Lin
Hi all, This is the following patch after https://gcc.gnu.org/ml/gcc-patches/2019-06/msg00910.html Main steps: 1) Identify the doloop cmp type iv use and record its bind_cand (explain it later). 2) Set zero cost for pairs between this use and any iv cand. 3) IV cand set selecting algorith

Re: [PATCH] Reintroduce vec_shl_optab and use it for #pragma omp scan inclusive

2019-06-19 Thread Richard Biener
On June 19, 2019 11:05:42 AM GMT+02:00, Richard Sandiford wrote: >Richard Biener writes: >> On June 19, 2019 10:55:16 AM GMT+02:00, Jakub Jelinek > wrote: >>>Hi! >>> >>>When VEC_[LR]SHIFT_EXPR has been replaced with VEC_PERM_EXPR, >>>vec_shl_optab >>>has been removed as unused, because we only u

[RFC, PATCH] Display inlining context for uninitialized warnings

2019-06-19 Thread Vladislav Ivanishin
Hi, This patch (partially) adds displaying inlining context for -W{maybe,}uninitialized warnings. This is not as trivial to enable as simply supplying the "%G" format specifier, so I have some questions below. I need this hunk void percent_K_format (text_info *text, location_t loc, tree blo

Re: Use ODR for canonical types construction in LTO

2019-06-19 Thread Jan Hubicka
Jason, I also wonder if something like this would make sense: * decl.c (build_clobber_this): Use original basetype if they match. Index: decl.c === --- decl.c (revision 272381) +++ decl.c (working copy) @@ -

RE: [PATCH] [ARC] Fix PR89838

2019-06-19 Thread Claudiu Zissulescu
Hi Jeff, > OK. > Thank you for your review. > THe BZ mentions that this was found building a glibc test for ARC. Is > there a glibc port for the ARC? I don't see one in the glibc git repo. > Are you aware of any plans to produce an official glibc port. Indeed, we are in the process of upstr

Re: [PATCH] Reintroduce vec_shl_optab and use it for #pragma omp scan inclusive

2019-06-19 Thread Richard Sandiford
Richard Biener writes: > On June 19, 2019 10:55:16 AM GMT+02:00, Jakub Jelinek > wrote: >>Hi! >> >>When VEC_[LR]SHIFT_EXPR has been replaced with VEC_PERM_EXPR, >>vec_shl_optab >>has been removed as unused, because we only used vec_shr_optab for the >>reductions. >>Without this patch the vect-si

Re: [PATCH] Reintroduce vec_shl_optab and use it for #pragma omp scan inclusive

2019-06-19 Thread Richard Biener
On June 19, 2019 10:55:16 AM GMT+02:00, Jakub Jelinek wrote: >Hi! > >When VEC_[LR]SHIFT_EXPR has been replaced with VEC_PERM_EXPR, >vec_shl_optab >has been removed as unused, because we only used vec_shr_optab for the >reductions. >Without this patch the vect-simd-*.c tests can be vectorized just

Re: Use ODR for canonical types construction in LTO

2019-06-19 Thread Jan Hubicka
Hi, Jason, this is about C++ frontend producing two copies of same type with different TYPE_CANONICAL but same get_alias_set. Since the types are structurally different, this does not go well with LTO which no longer sees they are same. They are created in if (CLASSTYPE_NON_LAYOUT_POD_P (t) ||

Re: [PATCH 2/3] Stub implementation of unwinding for AMD GCN.

2019-06-19 Thread Andrew Stubbs
Ping. I can probably approve this myself, as it only affects GCN, but I'd appreciate a second opinion. Thanks Andrew On 07/06/2019 15:40, Andrew Stubbs wrote: This patch provides the "_Unwind_Backtrace" and "_Unwind_GetIPInfo" symbols required to link programs using libgfortran. I do not

Re: [PATCH 1/3] Create GCN-specific gthreads

2019-06-19 Thread Andrew Stubbs
Ping. I can probably approve this myself, as it only affects GCN, but I'd appreciate a second opinion. Thanks Andrew On 07/06/2019 15:39, Andrew Stubbs wrote: This patch creates a new gthread model for AMD GCN devices. For now, there's just enough support for libgfortran to use mutexes in

Re: [PATCH] [RFC, PGO+LTO] Missed function specialization + partial devirtualization

2019-06-19 Thread Martin Liška
On 6/19/19 10:50 AM, luoxhu wrote: > Hi Martin, > > On 2019/6/18 18:21, Martin Liška wrote: >> On 6/18/19 3:45 AM, Xiong Hu Luo wrote: >>> 6.2.  SPEC2017 peakrate: >>> 523.xalancbmk_r (+4.87%); 538.imagick_r (+4.59%); 511.povray_r >>> (+13.33%); >>> 525.x264_r (-5.29%). >>

[PATCH] Reintroduce vec_shl_optab and use it for #pragma omp scan inclusive

2019-06-19 Thread Jakub Jelinek
Hi! When VEC_[LR]SHIFT_EXPR has been replaced with VEC_PERM_EXPR, vec_shl_optab has been removed as unused, because we only used vec_shr_optab for the reductions. Without this patch the vect-simd-*.c tests can be vectorized just fine for SSE4 and above, but can't be with SSE2. As the comment in t

Re: [PATCH] [RFC, PGO+LTO] Missed function specialization + partial devirtualization

2019-06-19 Thread luoxhu
Hi Martin, On 2019/6/18 18:21, Martin Liška wrote: On 6/18/19 3:45 AM, Xiong Hu Luo wrote: 6.2. SPEC2017 peakrate: 523.xalancbmk_r (+4.87%); 538.imagick_r (+4.59%); 511.povray_r (+13.33%); 525.x264_r (-5.29%). Can you please elaborate what are the key indirect call pr

[committed] Fix handling of references in reduction(inscan, ...) and inclusive clauses

2019-06-19 Thread Jakub Jelinek
Hi! References are a nightmare to support :(. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2019-06-19 Jakub Jelinek * omp-low.c (lower_rec_input_clauses): Handle references properly in inscan clauses. (lower_omp_scan): Likewise. cp/

Re: [C++ PATCH] Avoid constexpr garbage for implicit conversion to void.

2019-06-19 Thread Jakub Jelinek
On Tue, Jun 18, 2019 at 12:07:38PM -0400, Jason Merrill wrote: > commit 8f67898b9bd5924f3dd5218164df62ada10ea428 > Author: Jason Merrill > Date: Sat Jun 15 23:59:55 2019 -0400 > > Consolidate constexpr array handling. > > * constexpr.c (eval_and_check_array_index): Split ou

Re: [PATCH] Add new micro-benchmark for string operations.

2019-06-19 Thread Martin Liška
On 6/17/19 11:21 AM, Martin Liška wrote: > I'm adding a micro-benchmark that Honza has been using for quite some time. I'm going to install that as it's a script in contrib. Martin