Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-25 Thread Jeff Law
On 08/23/2018 08:48 AM, Bernd Edlinger wrote: > On 08/23/18 16:24, Jeff Law wrote: >>> >>> Yes, and which one was the earlier, more controversial patch from me? >> >> https://gcc.gnu.org/ml/gcc-patches/2018-07/msg01800.html >> >> >> Which is the issue I'm working through right now :-) >> > > Okay,

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-25 Thread Jeff Law
On 08/21/2018 11:49 AM, Martin Sebor wrote: > On 08/21/2018 09:44 AM, Joseph Myers wrote: >> On Tue, 21 Aug 2018, Martin Sebor wrote: >> >>> Sure, but the only valid argument to %ls is wchar_t*.  Passing >>> it something else is undefined. >> >> Well, (wchar_t *)"something\0\0\0\0" would be OK give

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-25 Thread Jeff Law
On 08/21/2018 10:35 AM, Martin Sebor wrote: > On 08/21/2018 09:59 AM, Jeff Law wrote: >> On 08/21/2018 09:57 AM, Martin Sebor wrote: >>> On 08/21/2018 02:59 AM, Richard Biener wrote: On Tue, 21 Aug 2018, Bernd Edlinger wrote: > gcc -S -O2 -Wall -Wformat-overflow -ftrack-macro-expansio

Re: [PATCH] Use complete_array_type on flexible array member initializers

2018-08-25 Thread Jeff Law
On 08/24/2018 07:13 AM, Bernd Edlinger wrote: > Hi! > > > This patch prevents init values of STRING_CST and braced > array initializers to reach the middle-end with incomplete > type. > > This will allow further simplifications in the middle-end, > and address existing issues with STRING_CST in

Re: [PATCH] avoid warning on constant strncpy until next statement is reachable (PR 87028)

2018-08-25 Thread Jeff Law
On 08/24/2018 09:58 AM, Martin Sebor wrote: > The warning suppression for -Wstringop-truncation looks for > the next statement after a truncating strncpy to see if it > adds a terminating nul.  This only works when the next > statement can be reached using the Gimple statement iterator > which isn'

Re: [PATCHv2] Call braced_list_to_string after array size is fixed

2018-08-25 Thread Jeff Law
On 08/24/2018 01:52 PM, Bernd Edlinger wrote: > Hi, > > this updated patch fixes one regression with current trunk due > to a new test case. Sorry for the confusion. > > The change to the previous version is: > 1) the check to avoid folding on empty char arrays is restored. > 2) A null-terminati

Re: C++ PATCH for c++/87029, Implement -Wredundant-move

2018-08-25 Thread Jason Merrill
On Sat, Aug 25, 2018 at 5:34 AM, Marek Polacek wrote: > On Fri, Aug 24, 2018 at 11:32:18PM +1000, Jason Merrill wrote: >> On Fri, Aug 24, 2018 at 12:53 AM, Marek Polacek wrote: >> > On Thu, Aug 23, 2018 at 10:44:30AM -0400, Marek Polacek wrote: >> >> +T >> >> +fn3 (const T t) >> >> +{ >> >> + //

Re: C++ PATCH for c++/87080, ICE with -Wpessimizing-move

2018-08-25 Thread Jason Merrill
OK. On Sat, Aug 25, 2018 at 7:02 AM, Marek Polacek wrote: > The problem in this testcase was that we were calling is_std_move_p from > template context, which breaks in cp_get_fndecl_from_callee. This warning > is not meant to warn while parsing a template, so I think we should apply > this. >

Re: PING [PATCH] warn for strlen of arrays with missing nul (PR 86552, 86711, 86714) )

2018-08-25 Thread Jeff Law
On 08/25/2018 01:32 PM, Bernd Edlinger wrote: > On 08/25/18 21:02, Jeff Law wrote: >> On 08/25/2018 12:36 PM, Bernd Edlinger wrote: >> >> > > Well, ya call it "layer one patch over the other" > I call it "incremental improvements". It is (of course) a case by case basis. The w

Re: [patch, libfortran] correct buffer size in library matmul

2018-08-25 Thread Jerry DeLisle
On 08/25/2018 12:38 PM, Thomas Koenig wrote: Hello world, the attached patch fixes a regression where the calculation of the size of the buffer for matmul was too small for ine special case. Regression-tested. OK for trunk? Regards Thomas OK Thomas and thanks for the fix. Jerry

Keep std::deque algos specializations in Debug mode

2018-08-25 Thread François Dumont
The last optimizations that get disabled when Debug mode is enable are the algo specializations for std::deque iterators. This patch move those algos in std namespace as they should even when Debug mode is enable so that they get considered even when calls are made with the namespace qualifica

Re: PING [PATCH] warn for strlen of arrays with missing nul (PR 86552, 86711, 86714) )

2018-08-25 Thread Martin Sebor
On 08/25/2018 01:32 PM, Bernd Edlinger wrote: On 08/25/18 21:02, Jeff Law wrote: On 08/25/2018 12:36 PM, Bernd Edlinger wrote: Well, ya call it "layer one patch over the other" I call it "incremental improvements". It is (of course) a case by case basis. The way I try to look at these thi

Re: [PR 87059] kludge over MIN_EXPR problem causing VRP failure in value ranges

2018-08-25 Thread Aldy Hernandez
Agreed. Thank you Martin! On Sat, Aug 25, 2018, 21:19 Jeff Law wrote: > On 08/24/2018 10:50 AM, Aldy Hernandez wrote: > > As discussed in the PR, the MIN_EXPR being passed to VRP has > > incompatible signs. I expect MIN_EXPR to have the same type for all > > arguments plus the MIN_EXPR node its

[patch, libfortran] correct buffer size in library matmul

2018-08-25 Thread Thomas Koenig
Hello world, the attached patch fixes a regression where the calculation of the size of the buffer for matmul was too small for ine special case. Regression-tested. OK for trunk? Regards Thomas 2018-08-25 Thomas Koenig PR libfortran/86704 * m4/matmul_internal.m4: C

Re: PING [PATCH] warn for strlen of arrays with missing nul (PR 86552, 86711, 86714) )

2018-08-25 Thread Bernd Edlinger
On 08/25/18 21:02, Jeff Law wrote: > On 08/25/2018 12:36 PM, Bernd Edlinger wrote: > > Well, ya call it "layer one patch over the other" I call it "incremental improvements". >>> It is (of course) a case by case basis. The way I try to look at these >>> things is to ask whether

Re: [PR 87059] kludge over MIN_EXPR problem causing VRP failure in value ranges

2018-08-25 Thread Jeff Law
On 08/24/2018 10:50 AM, Aldy Hernandez wrote: > As discussed in the PR, the MIN_EXPR being passed to VRP has > incompatible signs.  I expect MIN_EXPR to have the same type for all > arguments plus the MIN_EXPR node itself, but this is not the case. > > The culprit on PPC is expand_builtin_strncmp,

Re: [PATCH] convert MIN_EXPR operands to the same type (PR 87059)

2018-08-25 Thread Jeff Law
On 08/24/2018 01:06 PM, Martin Sebor wrote: > PR 87059 points out an ICE in the recently enhanced VRP code > that was traced back to a MIN_EXPR built out of operands of > types with different sign by expand_builtin_strncmp(). > > The attached patch adjusts the function to make sure both > operands

Re: PING [PATCH] warn for strlen of arrays with missing nul (PR 86552, 86711, 86714) )

2018-08-25 Thread Jeff Law
On 08/25/2018 12:36 PM, Bernd Edlinger wrote: >>> >>> Well, ya call it "layer one patch over the other" >>> I call it "incremental improvements". >> It is (of course) a case by case basis. The way I try to look at these >> things is to ask whether or not the first patch under consideration >

Re: [PATCH, RFC, rs6000, v3] enable early gimple-folding of vec_splat

2018-08-25 Thread Bill Schmidt
On 8/25/18 1:09 PM, Segher Boessenkool wrote: > Hey, > > On Sat, Aug 25, 2018 at 12:15:16PM -0500, Bill Schmidt wrote: >> On 8/20/18 4:44 PM, Will Schmidt wrote: >>> Enable GIMPLE folding of the vec_splat() intrinsic. (v3). >>> >>> This uses the tree_vec_extract() function out of tree-vect-gen

Re: PING [PATCH] warn for strlen of arrays with missing nul (PR 86552, 86711, 86714) )

2018-08-25 Thread Bernd Edlinger
On 08/25/18 19:32, Jeff Law wrote: > On 08/25/2018 12:32 AM, Bernd Edlinger wrote: >> On 08/25/18 01:54, Jeff Law wrote: >>> On 08/24/2018 11:26 AM, Bernd Edlinger wrote: On 08/24/18 18:51, Jeff Law wrote: >> Well, this is broken for wide character strings. >> but I hope we can get rid

Re: [PATCH, RFC, rs6000, v3] enable early gimple-folding of vec_splat

2018-08-25 Thread Segher Boessenkool
Hey, On Sat, Aug 25, 2018 at 12:15:16PM -0500, Bill Schmidt wrote: > On 8/20/18 4:44 PM, Will Schmidt wrote: > > Enable GIMPLE folding of the vec_splat() intrinsic. (v3). > > > > This uses the tree_vec_extract() function out of tree-vect-generic.c > > to retrieve the splat value, which is a B

Re: [PATCH, rs6000] Fix PR86731 vec_sl()

2018-08-25 Thread Segher Boessenkool
Hi! On Tue, Aug 14, 2018 at 06:18:28PM -0500, Will Schmidt wrote: > PR target/86731 > * config/rs6000/rs6000.c (rs6000_gimple_fold_builtin): Update logic > around folding of vec_sl() to handle out of range shift values. Shouldn't indent continuation lines in changelog. > +

Re: PING [PATCH] warn for strlen of arrays with missing nul (PR 86552, 86711, 86714) )

2018-08-25 Thread Jeff Law
On 08/25/2018 12:32 AM, Bernd Edlinger wrote: > On 08/25/18 01:54, Jeff Law wrote: >> On 08/24/2018 11:26 AM, Bernd Edlinger wrote: >>> On 08/24/18 18:51, Jeff Law wrote: > Well, this is broken for wide character strings. > but I hope we can get rid of STRING_CST which are > not explici

Re: [PATCH, RFC, rs6000, v3] enable early gimple-folding of vec_splat

2018-08-25 Thread Bill Schmidt
On 8/20/18 4:44 PM, Will Schmidt wrote: > Hi > Enable GIMPLE folding of the vec_splat() intrinsic. (v3). > > This uses the tree_vec_extract() function out of tree-vect-generic.c > to retrieve the splat value, which is a BIT_FIELD_REF. That function is > made non-static as part of this change

Re: [PATCH, rs6000] Fix PR86731 vec_sl()

2018-08-25 Thread Bill Schmidt
On 8/14/18 6:18 PM, Will Schmidt wrote: > Hi, > > Here is a first pass at fixing PR86731, which is an issue introduced > when gimple folding the vec_sl() intrinsic. > > This has been sniff tested (successfully) on a power7. Full regtests for > linux/Powerpc systems is pending. I expect I'

[Patch, Fortran, committed] PR 86545: ICE in transfer_expr on invalid WRITE statement

2018-08-25 Thread Janus Weil
Hi all, I have just committed a small patch for an ICE-on-invalid problem: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=263854 The patch was approved by Jerry on bugzilla and I checked that it shows no failures in the testsuite. Cheers, Janus

[wwwdocs] Replace valign="top" on our main page by CSS

2018-08-25 Thread Gerald Pfeifer
A minor step towards HTML 5. Committed. Gerald Index: gcc.css === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc.css,v retrieving revision 1.51 diff -u -r1.51 gcc.css --- gcc.css 4 Apr 2018 17:43:03 - 1.51 +++ gcc.css 25 Au

Re: [wwwdocs] Replace use of in all of bugs/

2018-08-25 Thread Gerald Pfeifer
On Sat, 25 Aug 2018, Gerald Pfeifer wrote: > Applied. And here are two more that escaped my original search since the spanned two lines. Applied as well. Gerald Index: bugs/index.html === RCS file: /cvs/gcc/wwwdocs/htdocs/bugs/ind

[wwwdocs] Replace use of in all of bugs/

2018-08-25 Thread Gerald Pfeifer
This is a necessary step on our move towards HTML 5. Applied. Gerald Replace by the use of it attributes in all of bugs/. Index: index.html === RCS file: /cvs/gcc/wwwdocs/htdocs/bugs/index.html,v retrieving revision 1.123 diff -u

[wwwdocs] Remove cvsup.html

2018-08-25 Thread Gerald Pfeifer
Funny enough, this page survived quite a while even after the migration from CVS to SVN in 2005 (though it had not been linked from any of our other pages). Committed. Gerald Index: cvsup.html === RCS file: cvsup.html diff -N cvsup.

[PATCH, Darwin] Minor code clean-up, NFC, committed.

2018-08-25 Thread Iain Sandoe
Hi I committed the following patch which cleans up fallout from an ancient merge of the machopic stuff. No functional change intended. 2018-08-25 Iain Sandoe gcc/ * config/darwin.c (machopic_legitimize_pic_address): Clean up extraneous parentheses, dead code section and form