Re: [PATCH GCC8][01/33]Handle TRUNCATE between tieable modes in rtx_cost

2017-05-02 Thread Eric Botcazou
> 2017-04-11 Bin Cheng > > * rtlanal.c (rtx_cost): Handle TRUNCATE between tieable modes. This breaks bootstrap with RTL checking: /home/eric/build/gcc/native/./gcc/xgcc -B/home/eric/build/gcc/native/./gcc/ - nostdinc -x c /dev/null -S -o /dev/null -fself- test=/home/eric/svn/gcc/gcc/te

Re: [PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-05-02 Thread Uros Bizjak
On Wed, May 3, 2017 at 12:16 AM, Daniel Santos wrote: >> I'd recommend that in the predicate, you check match_parallel from the >> bottom up, since subexpressions on the top are already matched, and >> you can have different number of subexpressions at the top. >> >> Uros. > > > OK, this all make

Re: [1/2] PR 78736: New warning -Wenum-conversion

2017-05-02 Thread Prathamesh Kulkarni
On 3 May 2017 at 03:28, Martin Sebor wrote: > On 05/02/2017 11:11 AM, Prathamesh Kulkarni wrote: >> >> Hi, >> The attached patch attempts to add option -Wenum-conversion for C and >> objective-C similar to clang, which warns when an enum value of a type >> is implicitly converted to enum value of

Re: [PATCH v4 0/12] [i386] Improve 64-bit Microsoft to System V ABI pro/epilogues

2017-05-02 Thread Daniel Santos
On 05/02/2017 05:40 AM, Kai Tietz wrote: Right, and Wine people will tell, if something doesn't work for them. So ok for me too. Kai Yes, and I although I haven't repeated the Wine tests in a few months, little has changed since my last run. I'll be running them again soon anyway. Daniel

Re: [PATCH v4 0/12] [i386] Improve 64-bit Microsoft to System V ABI pro/epilogues

2017-05-02 Thread Daniel Santos
On 05/02/2017 05:21 AM, JonY wrote: On 05/01/2017 11:31 AM, Uros Bizjak wrote: I also assume that Cygwin and MinGW people agree with the patch and the functionality itself. Uros. Cygwin and MinGW does not use SysV/MS transitions directly in their own code, changes should be OK. And to be c

Re: [PATCH] c++ parser: fix-it hints for wrong usage of 'friend' and 'auto'

2017-05-02 Thread Martin Sebor
On 04/29/2017 04:23 PM, Volker Reichelt wrote: Hi, the following patch adds fix-it hints to the C++ parser for two wrongly used keywords detected in cp_parser_decl_specifier_seq. Bootstrapped and regtested on x86_64-pc-linux-gnu. OK for trunk? Regards, Volker 2017-04-29 Volker Reichelt

Re: {PATCH] New C++ warning -Wcatch-value

2017-05-02 Thread Martin Sebor
On 05/01/2017 02:38 AM, Volker Reichelt wrote: Hi, catching exceptions by value is a bad thing, as it may cause slicing, i.e. a) a superfluous copy b) which is only partial. See also https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#e15-catch-exceptions-from-a-hierarc

[PATCH 7/7] adjust quoting in tests (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
The attached patch adjust tests to expect quoting where it was previously not expected. Martin gcc/testsuite/ChangeLog: * g++.dg/abi/Wabi-2-3.C: Adjust. * g++.dg/abi/Wabi-3-2.C: Ditto. * g++.dg/lookup/using17.C: Ditto. * gcc.dg/format/gcc_diag-1.c (foo): Ditto. diff --git a/gcc/testsuite/g+

[PATCH 6/7] clean up quoting problems - objc (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
The attached patch adds missing quoting to diagnostic directives in files in the objc/ directory. Martin gcc/objc/ChangeLog: * objc-gnu-runtime-abi-01.c (objc_eh_runtime_type): Add missing quoting to %T directives. * objc-next-runtime-abi-01.c (objc_eh_runtime_type): Ditto. * objc-next-runti

[PATCH 5/7] clean up quoting problems - c-family (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
The attached patch adds missing quoting to diagnostic directives in files in the cp/ directory. Martin gcc/cp/ChangeLog: * call.c (print_z_candidate): Add missing quoting to %D and other like directives. (build_op_call_1): Same. * constraint.cc (diagnose_check_constraint): Same. * mangle.c

[PATCH 2/7] clean up quoting problems - gcc (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
The attached patch adds missing quoting to diagnostic directives in files in the top-level gcc/ directory. Martin gcc/ChangeLog: * builtins.c (expand_builtin_object_size): Add missing quoting to %D and like directives. * hsa-gen.c (hsa_type_for_scalar_tree_type): Same. (hsa_type_for_tree_typ

[PATCH 3/7] clean up quoting problems - c-family (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
The attached patch adds missing quoting to diagnostic directives in files in the c-family/ directory. Martin gcc/c-family/ChangeLog: * c-attribs.c (handle_alias_ifunc_attribute): Quote a %D directive. (handle_weakref_attribute): Same. diff --git a/gcc/c-family/c-attribs.c b/gcc/c-family/c-att

[PATCH 4/7] clean up quoting problems - config/i386 (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
The attached patch adds missing quoting to diagnostic directives in files in the config/i386 directory. Martin gcc/ChangeLog: * config/i386/i386.c (ix86_function_versions): Quote a %D directive. diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index d985657..450f9b0 100644 --- a/gc

[PATCH 1/7] enhance -Wformat to detect quoting problems (PR 80280 et al.)

2017-05-02 Thread Martin Sebor
In bug 80280 - Missing closing quote (%>) c/semantics.c and c/c-typeck.c, a translator points out one of a number of kinds of cosmetic problems that tend to come up late in development, during translation of GCC messages. Other, arguably more minor, kinds of issues are caused by forgetting to use

Re: [PATCH] ggc-page loop

2017-05-02 Thread Andrew Pinski
On Tue, May 2, 2017 at 3:41 PM, Nathan Sidwell wrote: > This loop in ggc-page confused me, because the iterator is one greater than > the indexing value. Also the formatting of the array indexing is incorrect. > > Fixed thusly, and applied as obvious after booting on x86_64-linux-gnu - for (i =

Re: [PATCH] RFC: spellchecker for comments, plus -Wfixme and -Wtodo

2017-05-02 Thread Trevor Saunders
On Tue, May 02, 2017 at 03:08:01PM -0400, David Malcolm wrote: > Currently the C/C++ frontends discard comments when parsing. > It's possible to set up libcpp to capture comments as tokens, > by setting CPP_OPTION (pfile, discard_comments) to false), > and this can be enabled using the -C command l

[PATCH] ggc-page loop

2017-05-02 Thread Nathan Sidwell
This loop in ggc-page confused me, because the iterator is one greater than the indexing value. Also the formatting of the array indexing is incorrect. Fixed thusly, and applied as obvious after booting on x86_64-linux-gnu nathan -- Nathan Sidwell 2017-05-02 Nathan Sidwell * ggc-pa

Fix ICE caused by rounoff error in ipa-inline-analysis

2017-05-02 Thread Jan Hubicka
Hi, the following patch silence overactive sanity check which now fires due to roundoff errors of sreals. Because this affects some bootstraps I am commiting it tonight. I will add testcase tomorrow. My apologizes for the breakage. Bootstrapped/regtested x86_64-linux. Honza * ipa-inli

Re: [PATCH] Pretty-printing of some unsupported expressions (PR c/35441)

2017-05-02 Thread Joseph Myers
On Fri, 10 Mar 2017, Volker Reichelt wrote: > a) This part (with foo1 and foo2 from the testcase) is straightforward. That part is OK. > b) I chose the shift operators 'a << b' and 'a >> b' for the rotate >expressions, which is not 100% correct. Would it be better to use >something like

Re: [PATCH 09/12] [i386] Add patterns and predicates foutline-msabi-xlouges

2017-05-02 Thread Daniel Santos
Thank you for the review. On 05/01/2017 06:18 AM, Uros Bizjak wrote: On Thu, Apr 27, 2017 at 10:09 AM, Daniel Santos wrote: Adds the predicates save_multiple and restore_multiple to predicates.md, which are used by following patterns in sse.md: * save_multiple - insn that calls a save stub *

Re: [driver, doc] Support escaping special characters in specs

2017-05-02 Thread Joseph Myers
On Tue, 21 Feb 2017, Rainer Orth wrote: > 2017-01-10 Jeff Downs > Rainer Orth > > * gcc.c (handle_braces): Support escaping in switch matching > text. > * doc/invoke.texi (Spec Files): Document it. > Remove superfluous @code markup in items. OK. -- Joseph

Re: [1/2] PR 78736: New warning -Wenum-conversion

2017-05-02 Thread Martin Sebor
On 05/02/2017 11:11 AM, Prathamesh Kulkarni wrote: Hi, The attached patch attempts to add option -Wenum-conversion for C and objective-C similar to clang, which warns when an enum value of a type is implicitly converted to enum value of another type and is enabled by Wall. It seems quite useful

Re: [PATCH] RFC: spellchecker for comments, plus -Wfixme and -Wtodo

2017-05-02 Thread Mike Stump
On May 2, 2017, at 12:08 PM, David Malcolm wrote: > > As a proof of concept, the patch uses this to add a spellchecker > for comments. :-) > I didn't bother with the autotool detection for enchant, and > just hacked it in for now. Only other comment would be, rather then requiring it, would be

Re: [wwwdocs, ARM, AArch64] Document ABI changes and fixes

2017-05-02 Thread Jakub Jelinek
On Tue, May 02, 2017 at 05:32:21PM +0100, Richard Earnshaw (lists) wrote: > This patch adds some release notes for the gcc ABI changes affecting ARM > and AArch64. > > Does this sound reasonable? LGTM. Jakub

New Spanish PO file for 'gcc' (version 7.1.0)

2017-05-02 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Spanish team of translators. The file is available at: http://translationproject.org/latest/gcc/es.po (This file, 'gcc-7.1.0.es.po', has just

New Spanish PO file for 'gcc' (version 7.1.0)

2017-05-02 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Spanish team of translators. The file is available at: http://translationproject.org/latest/gcc/es.po (This file, 'gcc-7.1.0.es.po', has just

[committed] Support fix-it hints that add new lines

2017-05-02 Thread David Malcolm
Previously fix-it hints couldn't contain newlines. This is due to the need to print something user-readable for them within diagnostic-show-locus, and for handling them within edit-context for printing diffs and regenerating content. This patch enables limited support for fix-it hints with newlin

[PATCH] RFC: spellchecker for comments, plus -Wfixme and -Wtodo

2017-05-02 Thread David Malcolm
Currently the C/C++ frontends discard comments when parsing. It's possible to set up libcpp to capture comments as tokens, by setting CPP_OPTION (pfile, discard_comments) to false), and this can be enabled using the -C command line option (see also -CC), but c-family/c-lex.c then discards any CPP_C

[2/2] PR 78736: libgomp fallout

2017-05-02 Thread Prathamesh Kulkarni
Hi, During gcc bootstrap, there's a couple of places where the warning got triggered. I suppose this wasn't a false positive since enum gomp_schedule_type and enum omp_sched_t are different types (although they have same set of values) ? Bootstrap+tested on x86_64-unknown-linux-gnu. Is this patch

[1/2] PR 78736: New warning -Wenum-conversion

2017-05-02 Thread Prathamesh Kulkarni
Hi, The attached patch attempts to add option -Wenum-conversion for C and objective-C similar to clang, which warns when an enum value of a type is implicitly converted to enum value of another type and is enabled by Wall. Bootstrapped+tested on x86_64-unknown-linux-gnu. Is the patch OK for trunk

Re: [gcn][patch] Add -mgpu option and plumb in assembler/linker

2017-05-02 Thread Martin Jambor
Hi Andrew, sorry for replying only now but yesterday was public holiday here and I am still only in the process of recovering from a long weekend. While the only objection I have is the C++ style comment in config/gcn/gcn.c, another problem, for me at least... On Fri, Apr 28, 2017 at 06:06:39PM

Re: [PATCH GCC8][07/33]Offset validity check in address expression

2017-05-02 Thread Bin.Cheng
On Mon, Apr 24, 2017 at 11:34 AM, Richard Biener wrote: > On Tue, Apr 18, 2017 at 12:41 PM, Bin Cheng wrote: >> Hi, >> For now, we check validity of offset by computing the maximum offset then >> checking if >> offset is smaller than the max offset. This is inaccurate, for example, >> some tar

[New file, Ping] Add testcase to ensure that #pragma GCC diagnostic push/pop works with -Wtraditional.

2017-05-02 Thread Eric Gallager
On 3/24/17, Eric Gallager wrote: > On 3/24/17, David Malcolm wrote: >> On Fri, 2017-03-24 at 14:10 -0400, Eric Gallager wrote: >>> The attached test case failed with gcc 4.9 and older, but started >>> compiling successfully with only the 1 expected warning with gcc 5. >>> Adding it to the test su

Re: [PATCH, GCC/LTO, ping3] Fix PR69866: LTO with def for weak alias in regular object file

2017-05-02 Thread Thomas Preudhomme
Now that GCC 7 is released, ping? Original message below: Hi, This patch fixes an assert failure when linking one LTOed object file having a weak alias with a regular object file containing a strong definition for that same symbol. The patch is twofold: + do not add an alias to a partition if

Re: [wwwdocs] grammar & style fixes for /gcc-7/changes.html

2017-05-02 Thread Jonathan Wakely
On 02/05/17 08:44 -0600, Sandra Loosemore wrote: On 05/02/2017 07:52 AM, Jonathan Wakely wrote: This is the result of proofreading the release notes for GCC 7. Some are obvious fixes for simple typos, but I've also tried to improve the clarity of some text. Please take a look and let me know if

[wwwdocs, ARM, AArch64] Document ABI changes and fixes

2017-05-02 Thread Richard Earnshaw (lists)
This patch adds some release notes for the gcc ABI changes affecting ARM and AArch64. Does this sound reasonable? R. Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-7/changes.html,v retrieving revision 1.80 diff -u -r1.

New French PO file for 'gcc' (version 7.1.0)

2017-05-02 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the French team of translators. The file is available at: http://translationproject.org/latest/gcc/fr.po (This file, 'gcc-7.1.0.fr.po', has just

New template for 'gcc' made available

2017-05-02 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. (If you have any questions, send them to .) A new POT file for textual domain 'gcc' has been made available to the language teams for translation. It is archived as: http://translationproject.org/POT-files/gcc-

Re: [PATCH] PR libstdc++/80553 don't allow destroying non-destructible types

2017-05-02 Thread Jonathan Wakely
On 02/05/17 17:30 +0200, Marc Glisse wrote: On Tue, 2 May 2017, Jonathan Wakely wrote: On 02/05/17 10:16 +0100, Jonathan Wakely wrote: On 28/04/17 13:56 +0100, Jonathan Wakely wrote: We optimize _Destroy and _Destroy_n to do nothing when the type has a trivial destructor, which means we do no

Re: [PATCH] [x86] Avoid builtins for SSE/AVX2 immidiate logical shifts

2017-05-02 Thread Marc Glisse
On Tue, 2 May 2017, Jakub Jelinek wrote: Also, you've removed some builtin uses like __builtin_ia32_psllwi256 above, but haven't removed those builtins from the compiler (unlike the intrinsics, the builtins are not supported and can be removed). When we changed previous intrinsics, the same i

Re: [PATCH GCC8][22/33]Generate TMR in new reassociation order

2017-05-02 Thread Marc Glisse
On Tue, 2 May 2017, Bin.Cheng wrote: On Tue, May 2, 2017 at 3:09 PM, Richard Biener wrote: On Wed, Apr 26, 2017 at 12:20 PM, Bin.Cheng wrote: This is another one where context diff might help. No code change from previous version. This isn't a context diff. Thanks for reviewing. I used

Re: [PATCH v2] Destroy arguments for _Cilk_spawn calling in the child (PR 80038)

2017-05-02 Thread Jeff Law
On 05/02/2017 01:56 AM, Xi Ruoyao wrote: On 2017-05-02 09:16 +0200, Andreas Schwab wrote: This could be related to --enable-checking=release: In file included from ../../gcc/c-family/c-common.h:26:0, from ../../gcc/c-family/cilk.c:28: ../../gcc/c-family/cilk.c: In function 'b

[PATCH, testsuite]: Fix g++.dg/lto/pr79671 execute failure

2017-05-02 Thread Uros Bizjak
Hello! We have to match input and output operand (or use "+") of an empty asm to move the value to a register. 2017-05-02 Uros Bizjak * g++.dg/lto/pr79671_0.C (foo): Fix asm constraints. Tested on alphaev68-linux-gnu (where the unpatched testcase fails) and x86_64-linux-gnu. OK for mail

[PATCH][GCC][AArch64][ARM] Modify idiv costs for Cortex-A53

2017-05-02 Thread Tamar Christina
Hi All, This patch adjusts the cost model for Cortex-A53 to increase the costs of an integer division. The reason for this is that we want to always expand the division to a multiply when doing a division by constant. On the Cortex-A53 shifts are modeled to cost 1 instruction, when doing the exp

[PATCH] Fix documentation and a ctor in gcov.c

2017-05-02 Thread Martin Liška
On 04/28/2017 07:23 PM, Nathan Sidwell wrote: > Write proper member initializers please. Hi. Done that, patch can bootstrap on ppc64le-redhat-linux and survives regression tests. I consider the patch as pre-approved. Martin >From e694ed03b29882bbaaa02747acb188e16d459514 Mon Sep 17 00:00:00 2001

[PATCH][GCC][AARCH64]Adjust costs so udiv is preferred over sdiv when both are valid. [Patch (1/2)]

2017-05-02 Thread Tamar Christina
Hi All, This patch adjusts the cost model so that when both sdiv and udiv are possible it prefers udiv over sdiv. This was done by making sdiv slightly more expensive instead of making udiv cheaper to keep the baseline costs of a division the same as before. For aarch64 this patch along with my

[PATCH][GCC][ARM] Adjust costs so udiv is preferred over sdiv when both are valid. [Patch (2/2)]

2017-05-02 Thread Tamar Christina
Hi All, This patch adjusts the cost model so that when both sdiv and udiv are possible it prefers udiv over sdiv. This was done by making sdiv slightly more expensive instead of making udiv cheaper to keep the baseline costs of a division the same as before. Similar to aarch64 this patch along w

Re: [wwwdocs] grammar & style fixes for /gcc-7/changes.html

2017-05-02 Thread Jonathan Wakely
On 02/05/17 08:44 -0600, Sandra Loosemore wrote: On 05/02/2017 07:52 AM, Jonathan Wakely wrote: This is the result of proofreading the release notes for GCC 7. Some are obvious fixes for simple typos, but I've also tried to improve the clarity of some text. Please take a look and let me know if

Re: [PATCH] PR libstdc++/80553 don't allow destroying non-destructible types

2017-05-02 Thread Marc Glisse
On Tue, 2 May 2017, Jonathan Wakely wrote: On 02/05/17 10:16 +0100, Jonathan Wakely wrote: On 28/04/17 13:56 +0100, Jonathan Wakely wrote: We optimize _Destroy and _Destroy_n to do nothing when the type has a trivial destructor, which means we do nothing (instead of giving an error) when tryin

Re: [PATCH, GCC/ARM, Stage 1] Enable Purecode for ARMv8-M Baseline

2017-05-02 Thread Ramana Radhakrishnan
On Tue, May 02, 2017 at 11:45:48AM +0100, Prakhar Bahuguna wrote: > This patch adds support for purecode to ARMv8-M Baseline, in addition to the > existing support for ARMv7-M and ARMv8-M Mainline. > > gcc/ChangeLog: > > 2017-01-11 Prakhar Bahuguna > Andre Simoes Dias Vieira > >

Re: [PATH][GCC][mid-end] Check the alternate cost model just as costs_lt_p

2017-05-02 Thread Jeff Law
On 05/02/2017 08:34 AM, Tamar Christina wrote: Hi all, When comparing costs, the rtl function costs_lt_p compares the costs of A and B such that if they are the same and we were checking for speed, compare the size and use that as determining factor. This applies the same principle to the compa

Re: [PATCH][GCC][mid-end] Support combining of LSHIFTRT + LSHIFTRT operations

2017-05-02 Thread Jeff Law
On 05/02/2017 08:34 AM, Tamar Christina wrote: Hi all, r217118 added an optimization to combine ashiftrt and lshiftrt. This same optimization can at the very least also apply to lshiftrt + lshiftrt with the same constraints. i.e. that both operations are done for scalar modes, that second operat

Re: [PATCH GCC8][22/33]Generate TMR in new reassociation order

2017-05-02 Thread Bin.Cheng
On Tue, May 2, 2017 at 3:09 PM, Richard Biener wrote: > On Wed, Apr 26, 2017 at 12:20 PM, Bin.Cheng wrote: >> This is another one where context diff might help. No code change >> from previous version. > > This isn't a context diff. Thanks for reviewing. I used git diff -U20 to generate patch.

Re: [PATCH] Fix cross compiling to x86_64-w64-mingw32

2017-05-02 Thread JonY
On 05/02/2017 12:11 PM, Hugo Beauzée-Luyssen wrote: > This patch fixes cross compiling to x86_64-w64-mingw32 > See https://github.com/Alexpux/MINGW-packages/issues/1580 and > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69506 > > My apologies if I missed something in the contributing/sending a pat

Re: [ARM] Enable FP16 vector arithmetic operations.

2017-05-02 Thread Tamar Christina
Hi All, I'm taking this one over from Matthew, I think it slipped through the cracks before. Since it still applies cleanly on trunk I'm just pinging it. Ok for trunk? Tamar From: gcc-patches-ow...@gcc.gnu.org on behalf of Matthew Wahab Sent: Friday,

Re: [wwwdocs] grammar & style fixes for /gcc-7/changes.html

2017-05-02 Thread Sandra Loosemore
On 05/02/2017 07:52 AM, Jonathan Wakely wrote: This is the result of proofreading the release notes for GCC 7. Some are obvious fixes for simple typos, but I've also tried to improve the clarity of some text. Please take a look and let me know if you disagree with any changes. Overall this is a

Re: [PATCH] handle sprintf(d, "%s", ...) in gimple-ssa-sprintf.c

2017-05-02 Thread Martin Sebor
FWIW, my fix for bug 79062 is only partial (it gets the pass to run but the warnings are still not issued). I don't quite understand what prevents the warning flag(s) from getting set when -flto is used. This seems to be a bigger problem than just the sprintf pass not doing something just right.

[PATCH][GCC][mid-end] Support combining of LSHIFTRT + LSHIFTRT operations

2017-05-02 Thread Tamar Christina
Hi all, r217118 added an optimization to combine ashiftrt and lshiftrt. This same optimization can at the very least also apply to lshiftrt + lshiftrt with the same constraints. i.e. that both operations are done for scalar modes, that second operation operates on a subreg of the first one and tha

[PATH][GCC][mid-end] Check the alternate cost model just as costs_lt_p

2017-05-02 Thread Tamar Christina
Hi all, When comparing costs, the rtl function costs_lt_p compares the costs of A and B such that if they are the same and we were checking for speed, compare the size and use that as determining factor. This applies the same principle to the comparison done for the costing of expr expansions. Po

[PATCH] Remove LTO_STREAMER_DEBUG (PR lto/79489).

2017-05-02 Thread Martin Liška
Hi. After a discussion with Richi on IRC, I'm removing the debugging infrastructure as it's obsolete. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Installed as it's pre-approved. Martin >From 88768989be6c79c43bd3166c87eaa877b867957c Mon Sep 17 00:00:00 2001 From: m

Re: [PATCH 5/5][GIMPLE FE] PR testsuite/80580: Handle invalid SSA names

2017-05-02 Thread Richard Biener
On Mon, May 1, 2017 at 8:09 PM, Mikhail Maltsev wrote: > When parsing SSA names, we should check that parent names are scalars. > In fact, this patch just uses the condition of a 'gcc_assert' in > 'make_ssa_name_fn'. + if (!(VAR_P (parent) + || TREE_CODE (parent) == PARM_DE

Re: [PATCH 4/5][GIMPLE FE] PR testsuite/80580. Handle invalid __MEM

2017-05-02 Thread Richard Biener
On Mon, May 1, 2017 at 8:08 PM, Mikhail Maltsev wrote: > This patch deals with invalid __MEM construct. Before we start building an > expression for __MEM, we must check that parsing succeeded and that the __MEM > operand is a pointer. Ok. Thanks, Richard. > -- > Regards, >Mikhail Maltsev >

Re: [PATCH 1/5][GIMPLE FE] PR testsuite/80580. Handle missing labels in goto statements

2017-05-02 Thread Richard Biener
On Mon, May 1, 2017 at 8:04 PM, Mikhail Maltsev wrote: > The first problem happens because we don't check for missing labels when > parsing > 'goto' statements. I.e.: > > __GIMPLE() void fn1() { > if (1) > goto > } > > The fix is pretty obvious: just add a check. > My question is: which fun

Re: [PATCH GCC8][22/33]Generate TMR in new reassociation order

2017-05-02 Thread Richard Biener
On Wed, Apr 26, 2017 at 12:20 PM, Bin.Cheng wrote: > This is another one where context diff might help. No code change > from previous version. This isn't a context diff. Anyways, changes like using 'tmp' really interfere with creating a useful diff so it's hard to review no-op changes from the

[wwwdocs] grammar & style fixes for /gcc-7/changes.html

2017-05-02 Thread Jonathan Wakely
This is the result of proofreading the release notes for GCC 7. Some are obvious fixes for simple typos, but I've also tried to improve the clarity of some text. Please take a look and let me know if you disagree with any changes. Index: htdocs/gcc-7/changes.html

[PATCH] canonical type hashing

2017-05-02 Thread Nathan Sidwell
On the modules branch, I need rematerialize canonical types and the like from a read-in serialized tree. I discovered the canonical-type hash table is fed a bespoke hash value by each type creator. There was no generic type hasher :( The rationale appears to allow each type constuctor to just

Re: [PATCH GCC8][14/33]Handle more cheap operations in force_expr_to_var_cost

2017-05-02 Thread Richard Biener
On Thu, Apr 27, 2017 at 5:45 PM, Bin.Cheng wrote: > On Thu, Apr 27, 2017 at 4:30 PM, Jeff Law wrote: >> On 04/26/2017 06:58 AM, Richard Biener wrote: >>> >>> On Tue, Apr 18, 2017 at 12:44 PM, Bin Cheng >>> wrote: Hi, This patch handles more cheap cases in function force_expr_to_va

[PATCH] Fix PR31130, remove strict-overflow handling from VRP

2017-05-02 Thread Richard Biener
The following patch removes (well, the patch only disables) strict-overflow handling (and thus emitting -Wstrict-overflo diagnostics) from VRP. I XFAILed three testcases (well, all three are really the same testcase), removed on XFAIL and added a testcase for the missed VRP caused by those INF(

Re: [PATCH] Implement a warning for bogus sizeof(pointer) / sizeof(pointer[0])

2017-05-02 Thread Bernd Edlinger
On 05/01/17 17:54, Jason Merrill wrote: > On Fri, Apr 28, 2017 at 1:05 PM, Bernd Edlinger > wrote: >> On 04/28/17 17:29, Martin Sebor wrote: >>> On 04/28/2017 08:12 AM, Bernd Edlinger wrote: Do you want me to change the %qT format strings to %T ? >>> >>> Yes, with the surrounding %< and

Re: [PATCH][x86] Add missing intrinsics for ADD[SD,SS] and SUB[SD,SS]

2017-05-02 Thread Uros Bizjak
On Tue, May 2, 2017 at 11:39 AM, Peryt, Sebastian wrote: > Hi, > Can you please commit it for me? Done. Uros.

[PATCH][www] Document -fno-strict-overflow changes (GCC 8)

2017-05-02 Thread Richard Biener
Doing this early so I won't forget. Wording can be improved. Committed. Richard. 2017-05-02 Richard Biener * changes.html (-fno-strict-overflow): Document changes. Index: changes.html === RCS file: /cvs/gcc/wwwdocs/ht

Re: [PATCH][AARCH64]Simplify call, call_value, sibcall, sibcall_value patterns.

2017-05-02 Thread Richard Earnshaw (lists)
On 01/12/16 15:39, Renlin Li wrote: > Hi all, > > This patch refactors the code used in call, call_value, sibcall, > sibcall_value expanders. > > Before the change, the logic is following: > > call expander --> call_internal --> call_reg/call_symbol > call_vlaue expander-->

Re: [PATCH] Optimize in VRP loads from constant arrays (take 2)

2017-05-02 Thread Richard Biener
On Tue, 2 May 2017, Jakub Jelinek wrote: > On Tue, May 02, 2017 at 01:13:19PM +0200, Richard Biener wrote: > > On Sat, 29 Apr 2017, Jakub Jelinek wrote: > > > > > On Fri, Apr 21, 2017 at 04:42:03PM +0200, Richard Biener wrote: > > > > On April 21, 2017 4:06:59 PM GMT+02:00, Jakub Jelinek > > > >

Re: [PATCH] Improve switchconv optimization (PR tree-optimization/79472)

2017-05-02 Thread Richard Biener
On Tue, 2 May 2017, Jakub Jelinek wrote: > On Tue, May 02, 2017 at 01:16:05PM +0200, Richard Biener wrote: > > On Sat, 29 Apr 2017, Jakub Jelinek wrote: > > > > > On Wed, Feb 15, 2017 at 12:51:30PM +0100, Jakub Jelinek wrote: > > > > On Wed, Feb 15, 2017 at 12:46:44PM +0100, Richard Biener wrote:

Re: [PATCH] Improve switchconv optimization (PR tree-optimization/79472)

2017-05-02 Thread Jakub Jelinek
On Tue, May 02, 2017 at 01:16:05PM +0200, Richard Biener wrote: > On Sat, 29 Apr 2017, Jakub Jelinek wrote: > > > On Wed, Feb 15, 2017 at 12:51:30PM +0100, Jakub Jelinek wrote: > > > On Wed, Feb 15, 2017 at 12:46:44PM +0100, Richard Biener wrote: > > > > >> Possibly, but for GCC 8. > > > > > > >

Re: [PATCH] Optimize in VRP loads from constant arrays (take 2)

2017-05-02 Thread Jakub Jelinek
On Tue, May 02, 2017 at 01:13:19PM +0200, Richard Biener wrote: > On Sat, 29 Apr 2017, Jakub Jelinek wrote: > > > On Fri, Apr 21, 2017 at 04:42:03PM +0200, Richard Biener wrote: > > > On April 21, 2017 4:06:59 PM GMT+02:00, Jakub Jelinek > > > wrote: > > > >This patch attempts to implement the o

[PATCH] Fix cross compiling to x86_64-w64-mingw32

2017-05-02 Thread Hugo Beauzée-Luyssen
This patch fixes cross compiling to x86_64-w64-mingw32 See https://github.com/Alexpux/MINGW-packages/issues/1580 and https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69506 My apologies if I missed something in the contributing/sending a patch guidelines. Regards, Index: libstdc++-v3/config/os/mingw3

[PATCH, alpha]: Merge some *_ieee insn patterns with their base patterns

2017-05-02 Thread Uros Bizjak
2017-05-02 Uros Bizjak * config/alpha/alpha.md (*add3_ieee): Merge to add3 using enabled attribute. (*sub3_ieee): Merge to sub3 using enabled attribute. (*mul3_ieee): Merge to mul3 using enabled attribute. (*div3_ieee): Merge to div3 using enabled attribute. (*sqrt2_ieee

[PATCH] Fix PR80549

2017-05-02 Thread Richard Biener
I have tested the following patch to fix another case where threading plus CFG cleanup messes up loops, identifying a previous loop with a new one and thus messing up nb_iterations_upper_bound. I believe preserving existing loops as much as possible is desirable (and CFG cleanup goes a long way p

Re: [PATCH] [x86] Avoid builtins for SSE/AVX2 immidiate logical shifts

2017-05-02 Thread Allan Sandfeld Jensen
On Tuesday 02 May 2017, Jakub Jelinek wrote: > On Mon, Apr 24, 2017 at 03:15:11PM +0200, Allan Sandfeld Jensen wrote: > > Okay, I have tried that, and I also made it more obvious how the > > intrinsics can become non-immediate shift. > > > > > > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > > inde

Re: [PATCH] Improve switchconv optimization (PR tree-optimization/79472)

2017-05-02 Thread Richard Biener
On Sat, 29 Apr 2017, Jakub Jelinek wrote: > On Wed, Feb 15, 2017 at 12:51:30PM +0100, Jakub Jelinek wrote: > > On Wed, Feb 15, 2017 at 12:46:44PM +0100, Richard Biener wrote: > > > >> Possibly, but for GCC 8. > > > > > > > > To both this switchconv patch and the potential improvement for loading

Re: [PATCH] Optimize in VRP loads from constant arrays (take 2)

2017-05-02 Thread Richard Biener
On Sat, 29 Apr 2017, Jakub Jelinek wrote: > On Fri, Apr 21, 2017 at 04:42:03PM +0200, Richard Biener wrote: > > On April 21, 2017 4:06:59 PM GMT+02:00, Jakub Jelinek > > wrote: > > >This patch attempts to implement the optimization mentioned in > > >http://gcc.gnu.org/ml/gcc-patches/2017-02/msg0

[PATCH, GCC/ARM, Stage 1] Enable Purecode for ARMv8-M Baseline

2017-05-02 Thread Prakhar Bahuguna
This patch adds support for purecode to ARMv8-M Baseline, in addition to the existing support for ARMv7-M and ARMv8-M Mainline. gcc/ChangeLog: 2017-01-11 Prakhar Bahuguna Andre Simoes Dias Vieira * config/arm/arm.md (movsi): Change TARGET_32BIT to TARGET_HAVE_MOVT.

Re: [PATCH v4 0/12] [i386] Improve 64-bit Microsoft to System V ABI pro/epilogues

2017-05-02 Thread Kai Tietz
2017-05-02 12:21 GMT+02:00 JonY <10wa...@gmail.com>: > On 05/01/2017 11:31 AM, Uros Bizjak wrote: >> On Thu, Apr 27, 2017 at 10:04 AM, Daniel Santos >> wrote: >>> All of patches are concerned with 64-bit Microsoft ABI functions that call >>> System V ABI function which clobbers RSI, RDI and XMM6-

Re: Drop Z from X + Z < Y + Z

2017-05-02 Thread Richard Biener
On Fri, Apr 28, 2017 at 10:23 PM, Marc Glisse wrote: > On Fri, 28 Apr 2017, Richard Biener wrote: > >> On Fri, Apr 28, 2017 at 1:35 PM, Marc Glisse wrote: >>> >>> Hello, >>> >>> surprisingly, this did not cause any Wstrict-overflow failure. Some of it >>> sounds more like reassoc's job, but it is

Re: [PATCH] handle sprintf(d, "%s", ...) in gimple-ssa-sprintf.c

2017-05-02 Thread Richard Biener
On Fri, Apr 28, 2017 at 6:35 PM, Jeff Law wrote: > On 04/25/2017 09:55 PM, Martin Sebor wrote: >> >> On 04/25/2017 04:05 PM, Jeff Law wrote: >>> >>> On 04/21/2017 03:33 PM, Martin Sebor wrote: Bug 77671 - missing -Wformat-overflow warning on sprintf overflow with "%s", is caused by

Re: [PATCH v4 0/12] [i386] Improve 64-bit Microsoft to System V ABI pro/epilogues

2017-05-02 Thread JonY
On 05/01/2017 11:31 AM, Uros Bizjak wrote: > On Thu, Apr 27, 2017 at 10:04 AM, Daniel Santos > wrote: >> All of patches are concerned with 64-bit Microsoft ABI functions that call >> System V ABI function which clobbers RSI, RDI and XMM6-15 and are aimed at >> improving performance and .text size

Re: [PATCH] adding missing LTO to some warning options (PR 78606)

2017-05-02 Thread Tom de Vries
On 05/01/2017 08:05 PM, Martin Sebor wrote: On 04/30/2017 02:02 PM, Tom de Vries wrote: On 01/10/2017 11:16 PM, Martin Sebor wrote: + __builtin_sprintf (d, "%32s", "x"); /* { dg-warning "directive writing 32 bytes into a region of size 12" "-Wformat-length" { xfail *-*-* } } */ This xpasse

Re: [PATCH] [x86] Avoid builtins for SSE/AVX2 immidiate logical shifts

2017-05-02 Thread Jakub Jelinek
On Mon, Apr 24, 2017 at 03:15:11PM +0200, Allan Sandfeld Jensen wrote: > Okay, I have tried that, and I also made it more obvious how the intrinsics > can become non-immediate shift. > > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index b58f5050db0..b9406550fc5 100644 > --- a/gcc/ChangeLog > ++

Re: Update ipa-cp to new time metrics

2017-05-02 Thread Richard Biener
On Tue, May 2, 2017 at 11:33 AM, Jan Hubicka wrote: > Hi, > this patch makes ipa-cp to use nonspecialized time as a base for decision > about > cloning. I wonder about the capping - we perhaps want to use sreals further > in > the code because time differences can be large (with profile feedbac

[Patch AArch64] Do not increase data alignment at -Os and with -fconserve-stack.

2017-05-02 Thread Ramana Radhakrishnan
We unnecessarily align data to 8 byte alignments even when -Os is specified. This brings the logic in the AArch64 backend more in line with the ARM backend and helps gain some image size in a few places. Caught by an internal report on the size of rodata sections being high with aarch64 gcc.

Re: [PATCH] PR libstdc++/80553 don't allow destroying non-destructible types

2017-05-02 Thread Jonathan Wakely
On 02/05/17 10:16 +0100, Jonathan Wakely wrote: On 28/04/17 13:56 +0100, Jonathan Wakely wrote: We optimize _Destroy and _Destroy_n to do nothing when the type has a trivial destructor, which means we do nothing (instead of giving an error) when trying to destroy types with deleted destructors.

RE: [PATCH][x86] Add missing intrinsics for ADD[SD,SS] and SUB[SD,SS]

2017-05-02 Thread Peryt, Sebastian
Hi, Can you please commit it for me? Thanks, Sebastian -Original Message- From: Uros Bizjak [mailto:ubiz...@gmail.com] Sent: Monday, May 1, 2017 11:28 AM To: Peryt, Sebastian Cc: gcc-patches@gcc.gnu.org; kirill.yuk...@gmail.com Subject: Re: [PATCH][x86] Add missing intrinsics for ADD[SD

Update ipa-cp to new time metrics

2017-05-02 Thread Jan Hubicka
Hi, this patch makes ipa-cp to use nonspecialized time as a base for decision about cloning. I wonder about the capping - we perhaps want to use sreals further in the code because time differences can be large (with profile feedback). But I guess this can be done incrementally - main point of the

[Patch, testsuite] Fix bogus pr78138.c failure for avr

2017-05-02 Thread Senthil Kumar Selvaraj
Hi, The trivial patch below fixes a bogus testsuite failure (gcc.dg/pr78138.c) for the avr target. The declaration for memcpy had the size parameter declared as unsigned long. For avr, __SIZE_TYPE__ is unsigned int, and this caused a builtin-declaration-mismatch warning, resulting i

[PATCH] Fix PR80591

2017-05-02 Thread Richard Biener
I am testing reversal of r246809 which was bogus. Bootstrap / regtest running on x86_64-unknown-linux-gnu. Richard. 2017-05-02 Richard Biener PR tree-optimization/80591 Revert 2017-04-10 Richard Biener * tree-ssa-structalias.c (find_func_aliases): Properl

[Ada] Reimplement layout of partially constrained derived untagged types

2017-05-02 Thread Arnaud Charlet
The layout done in gigi for partially constrained derived untagged types, that is to say discriminated record types derived from an untagged parent type with constraints, is done independently of that of their parent type, which is a bit annoying since the layouts must be compatible if there is no

Re: [PATCH] PR libstdc++/80553 don't allow destroying non-destructible types

2017-05-02 Thread Jonathan Wakely
On 28/04/17 13:56 +0100, Jonathan Wakely wrote: We optimize _Destroy and _Destroy_n to do nothing when the type has a trivial destructor, which means we do nothing (instead of giving an error) when trying to destroy types with deleted destructors. I wonder if this optimisation should even exist

Re: [PATCH][GCC][AArch64] Fix subreg bug in scalar copysign

2017-05-02 Thread Tamar Christina
Ping From: gcc-patches-ow...@gcc.gnu.org on behalf of Tamar Christina Sent: Wednesday, March 15, 2017 4:04:35 PM To: GCC Patches Cc: nd; James Greenhalgh; Richard Earnshaw; Marcus Shawcroft Subject: [PATCH][GCC][AArch64] Fix subreg bug in scalar copysign

[Ada] Bug in handling of library-level freeze actions

2017-05-02 Thread Arnaud Charlet
This patch fixes an error in the handling of freeze actions generated for a generic package that is a compilation unit, whose entities carry iterable aspects. The following must compile quietly: --- generic type Data_Type (<>) is limited private; package Data_Streams is type Root_Data_Stre

  1   2   >