Re: [PATCH] Remove .jcr registry from the crtfiles

2016-10-01 Thread Jakub Jelinek
On Sat, Oct 01, 2016 at 10:46:53PM +0200, Florian Weimer wrote: > * Jakub Jelinek: > > > Now that GCJ is gone, I think we should remove the the tests for .jcr > > sections from the crtfiles, which slows down (by a couple of instructions > > and some relocations) every gcc compiled binary/library.

Re: [PATCH] Remove .jcr registry from the crtfiles

2016-10-01 Thread Florian Weimer
* Jakub Jelinek: > Now that GCJ is gone, I think we should remove the the tests for .jcr > sections from the crtfiles, which slows down (by a couple of instructions > and some relocations) every gcc compiled binary/library. Why were they needed *in every DSO* in the first place? We still have _I

Re: [BUILDROBOT] dwarf2out_do_cfi_startproc(bool)’: may write a terminating nul past the end of the destination

2016-10-01 Thread Jakub Jelinek
On Fri, Sep 30, 2016 at 08:59:52PM +0200, Jakub Jelinek wrote: > Ok if it passes bootstrap/regtest? Passed bootstrap/regtest on x86_64-linux and i686-linux. > > 2016-09-30 Jakub Jelinek > > * dwarf2out.c (output_fde, output_call_frame_info, > dwarf2out_do_cfi_startproc, set_indire

[PATCH] Remove .jcr registry from the crtfiles

2016-10-01 Thread Jakub Jelinek
Hi! Now that GCJ is gone, I think we should remove the the tests for .jcr sections from the crtfiles, which slows down (by a couple of instructions and some relocations) every gcc compiled binary/library. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-10-01 Jakub Jeli

Re: [PATCH] Fix (part of) PR77399

2016-10-01 Thread Andreas Schwab
On Okt 01 2016, Richard Biener wrote: > Which architecture? http://gcc.gnu.org/ml/gcc-testresults/2016-10/msg00021.html http://gcc.gnu.org/ml/gcc-testresults/2016-10/msg00049.html Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B

Re: [PATCH] Fix PR77407

2016-10-01 Thread Marc Glisse
On Wed, 28 Sep 2016, Richard Biener wrote: --- gcc/match.pd(revision 240565) +++ gcc/match.pd(working copy) @@ -147,12 +147,25 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (op @0 integer_onep) (non_lvalue @0))) -/* X / -1 is -X. */ (for div (trunc_div ceil_div floor_div roun

Re: Fix PR tree-optimization/77808, ICE in duplicate_ssa_name_ptr_info, at tree-ssanames.c:630 starting with r240439

2016-10-01 Thread Christophe Lyon
Hi Doug, On 1 October 2016 at 03:35, Doug Gilmore wrote: > My commit r240439 didn't handle the situation where setting > --param prefetch-latency=0 can cause the prefetch address to > be the same as the original address. In this case, no > copying of points-to information should be done. > > Bo

Re: [PATCH] Fix (part of) PR77399

2016-10-01 Thread Richard Biener
On Sat, 1 Oct 2016, Andreas Schwab wrote: > /usr/local/gcc/gcc-20161001/gcc/testsuite/gcc.dg/tree-ssa/forwprop-35.c:9:10: > internal compiler error: in expand_float, at optabs.c:4774 > 0x40af810f expand_float(rtx_def*, rtx_def*, int) > ../../gcc/optabs.c:4774 > 0x4

Re: PATCH to fix bogus -Wimplicit-fallthrough warning (PR c++/77803)

2016-10-01 Thread Marek Polacek
On Sat, Oct 01, 2016 at 07:17:50AM +0200, Markus Trippelsdorf wrote: > On 2016.09.30 at 23:31 +0200, Marek Polacek wrote: > > This PR reports a bogus -Wimplicit-fallthrough warning on the attached test. > > The problem is that last_stmt_in_scope should for GIMPLE_TRY, if the last > > statement of t

Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)

2016-10-01 Thread Marek Polacek
On Fri, Sep 30, 2016 at 05:48:03PM -0400, Jason Merrill wrote: > On Fri, Sep 30, 2016 at 12:43 PM, Marek Polacek wrote: > > On Fri, Sep 23, 2016 at 10:31:33AM -0400, Jason Merrill wrote: > >> On Fri, Sep 23, 2016 at 9:15 AM, Marek Polacek wrote: > >> > On Wed, Sep 21, 2016 at 03:52:09PM -0400, Ja

[PATCH] Fix PR77789

2016-10-01 Thread Richard Biener
This fixes a type error. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2016-10-01 Richard Biener PR middle-end/77798 * genmatch.c (get_operand_type): Add operand position arg and handle COND_EXPR comparison operand with fixed boolean_type_nod

Re: [Fortran, Patch, pr77663, v1] libgfortran/caf/single.c: three minor problems and a lost token

2016-10-01 Thread Andre Vehreschild
Hi Paul, thanks for the fast review. Committed as r240695. Regards, Andre On Sat, 1 Oct 2016 14:42:35 +0200 Paul Richard Thomas wrote: > Hi Andre, > > It looks fine to me - OK for trunk. > > Thanks for the patch > > Paul > > On 1 October 2016 at 13:30, Andre Vehreschild wrote: > >

Re: [PATCH] Fix PR77407

2016-10-01 Thread Richard Biener
On October 1, 2016 11:47:45 AM GMT+02:00, Robin Dapp wrote: >This introduces an ICE ("bogus comparison result type") on s390 for the >following test case: > >#include > >void foo(int dim) >{ > int ba, sign; > > ba = abs (dim); > sign = dim / ba; >} > > >Doing > >diff --git a/gcc/match.pd b

Re: [Fortran, Patch, pr77663, v1] libgfortran/caf/single.c: three minor problems and a lost token

2016-10-01 Thread Paul Richard Thomas
Hi Andre, It looks fine to me - OK for trunk. Thanks for the patch Paul On 1 October 2016 at 13:30, Andre Vehreschild wrote: > Hi all, > > attached patch fixes some issue in caf/single.c that were reported as pure > style issues, but uncovered at least one significant error when handling > se

Re: Use version namespace in normal mode

2016-10-01 Thread François Dumont
On 30/09/2016 17:40, Jonathan Wakely wrote: On 29/09/16 21:59 +0200, François Dumont wrote: Hi I think _GLIBCXX_BEGIN_NAMESPACE_ALGO should default to _GLIBCXX_BEGIN_NAMESPACE_VERSION when parallel mode is not active. Same for _GLIBCXX_BEGIN_NAMESPACE_CONTAINER, no ? Hmm, yes, I think th

Re: [Patch 2/11] Implement TARGET_C_EXCESS_PRECISION for i386

2016-10-01 Thread Uros Bizjak
On Fri, Sep 30, 2016 at 6:59 PM, James Greenhalgh wrote: > > Hi, > > This patch ports the logic from i386's TARGET_FLT_EVAL_METHOD to the new > target hook TARGET_C_EXCESS_PRECISION. > > Bootstrapped and tested with no issues. > > OK? > > Thanks, > James > > --- > gcc/ > > 2016-09-30 James Greenh

Re: C/C++ PATCH to implement -Wbool-operation (PR c/77490)

2016-10-01 Thread Marek Polacek
On Sat, Oct 01, 2016 at 01:46:02AM +0200, Jakub Jelinek wrote: > On Fri, Sep 23, 2016 at 12:44:22PM +0200, Marek Polacek wrote: > > 2016-09-23 Marek Polacek > > > > PR c/77490 > ... > > * c-c++-common/Wbool-operation-1.c: New test. > > I've noticed this test fails on i686-linux and lik

[Fortran, Patch, pr77663, v1] libgfortran/caf/single.c: three minor problems and a lost token

2016-10-01 Thread Andre Vehreschild
Hi all, attached patch fixes some issue in caf/single.c that were reported as pure style issues, but uncovered at least one significant error when handling sending data to a remote image when the memory and associated token was not allocated yet. The send_by_ref-routine stored the new token only o

Re: [PATCH] Fix PR77407

2016-10-01 Thread Robin Dapp
This introduces an ICE ("bogus comparison result type") on s390 for the following test case: #include void foo(int dim) { int ba, sign; ba = abs (dim); sign = dim / ba; } Doing diff --git a/gcc/match.pd b/gcc/match.pd index ba7e013..2455592 100644 --- a/gcc/match.pd +++ b/gcc/match.

Re: [PATCH] Fix -Wimplicit-fallthrough -C, handle some more comment styles and comments in between FALLTHRU comment and label

2016-10-01 Thread Jakub Jelinek
On Sat, Oct 01, 2016 at 10:49:03AM +0200, Eric Botcazou wrote: > > See Tom Tromey's explanation why accepting too much is bad (at least unless > > we want multiple levels). > > Tom's changes made to GDB are IMO the perfect examples of what we don't want: > > - /* ... fall through for unsigne

Re: [PATCH] Fix (part of) PR77399

2016-10-01 Thread Andreas Schwab
/usr/local/gcc/gcc-20161001/gcc/testsuite/gcc.dg/tree-ssa/forwprop-35.c:9:10: internal compiler error: in expand_float, at optabs.c:4774 0x40af810f expand_float(rtx_def*, rtx_def*, int) ../../gcc/optabs.c:4774 0x40699f6f expand_expr_real_2(separate_ops*, rtx_def

Re: [PATCH] Fix -Wimplicit-fallthrough -C, handle some more comment styles and comments in between FALLTHRU comment and label

2016-10-01 Thread Eric Botcazou
> See Tom Tromey's explanation why accepting too much is bad (at least unless > we want multiple levels). Tom's changes made to GDB are IMO the perfect examples of what we don't want: - /* ... fall through for unsigned ints ... */ + /* fall through */ -/* For other ins

Re: [PATCH] FALLTHRU markers for sse.md and some cleanups

2016-10-01 Thread Uros Bizjak
On Fri, Sep 30, 2016 at 10:17 PM, Jakub Jelinek wrote: > On Thu, Sep 29, 2016 at 06:21:13PM +0200, Marek Polacek wrote: >> On Tue, Sep 27, 2016 at 09:58:20PM +0200, Jakub Jelinek wrote: >> > On Tue, Sep 27, 2016 at 09:29:10PM +0200, Florian Weimer wrote: >> > > Not sure if I read this code correct

Re: [PATCH] Fix bootstrap with --enable-languages=all,go

2016-10-01 Thread Andrew Haley
On 30/09/16 23:16, Rainer Orth wrote: > me too, though mostly to have maximum test coverage (primarily on > Solaris). As expected, a x86_64-apple-darwin16 bootstrap with > --enable-objc-gc just failed for me. I'm testing the following patch > (on top of Jakub's). > > Rainer > > > 2016-10

Re: [PATCH] Cleanup of input.c

2016-10-01 Thread Bernd Edlinger
On 10/01/16 00:16, David Malcolm wrote: > On Mon, 2016-09-26 at 14:30 +, Bernd Edlinger wrote: >> Hi, >> >> this started, because I saw get_next_line returns -1 on error, >> instead >> of false: PR 77699. >> >> But when I was there I also saw that read_line_num is using memmove >> on >> non-ali