[PR tree-optimization/71328] Fix off-by-one error in CFG/SSA updates for backward threading

2016-06-02 Thread Jeff Law
This bug has actually been around since the introduction of the FSM/backwards threader a few years ago. It was just latent. Essentially we need to look at the copied path for branches back into the path -- due to an off-by-one error, we missed the case where the last block in the path bran

Re: [PATCH v2] gcc/config/tilegx/tilegx.c (tilegx_function_profiler): Save r10 to stack before call mcount

2016-06-02 Thread Richard Henderson
On 06/02/2016 03:23 PM, cheng...@emindsoft.com.cn wrote: fprintf (file, + "\t{\n" + "\taddi\tsp, sp, -8\n" + "\tst\tsp, r10\n" + "\t}\n" "\t{\n" You need only do this if cfun->static_chain_decl is set. r~

Re: [PATCH] integer overflow checking builtins in constant expressions

2016-06-02 Thread Martin Sebor
+{ + /* Perform the computation in the target type and check for overflow. */ + arg0 = fold_convert (type, arg0); + arg1 = fold_convert (type, arg1); + + if (tree result = size_binop_loc (loc, opcode, arg0, arg1)) +return TREE_OVERFLOW (result) ? build_one_cst (boolean

[PATCH] c/71392 - SEGV calling integer overflow built-ins with a null pointer

2016-06-02 Thread Martin Sebor
In a discussion of a patch in a this area (c/68120 and c++/70507) Jakub noticed that the integer arithmetic built-ins with overflow checking that expect a pointer to an integer as the last argument silently (i.e., without a warning) accept a null pointer. As the test case in the bug referenced in

Re: [PATCH] integer overflow checking builtins in constant expressions

2016-06-02 Thread Martin Sebor
+ /* For the "generic" overloads, the first two arguments can have different + types and the last argument determines the target type to use to check + for overflow. The arguments of the other overloads all have the same + type. */ + tree type = TREE_TYPE (TREE_TYPE (arg2)); + boo

Re: [PATCH 01/16] Core of selftest framework (v6)

2016-06-02 Thread Bernd Schmidt
On 06/02/2016 11:06 PM, David Malcolm wrote: gcc/ChangeLog: * Makefile.in (OBJS): Add function-tests.o, hash-map-tests.o, hash-set-tests.o, rtl-tests.o, selftest-run-tests.o. (OBJS-libcommon): Add selftest.o. (OBJS-libcommon-target): Add selftest.o.

[PATCH v2] gcc/config/tilegx/tilegx.c (tilegx_function_profiler): Save r10 to stack before call mcount

2016-06-02 Thread chengang
From: Chen Gang r10 may also be as parameter stack pointer for the nested function, so need save it before call mcount. 2016-06-03 Chen Gang gcc/ PR target/71331 * config/tilegx/tilegx.c (tilegx_function_profiler): Save r10 to stack before call mcount. --- gc

[C++ Patch] Change a few error + error to error + inform

2016-06-02 Thread Paolo Carlini
Hi, while working on c++/70202, I noticed a few more of those pairs for errors which we changed in the past to error + inform. Tested x86_64-linux. Thanks, Paolo. / /cp 2016-06-02 Paolo Carlini * decl.c (xref_tag_1): Change pairs of errors to error + inform

Re: [C++ Patch] Change a few error + error to error + inform

2016-06-02 Thread Jason Merrill
OK. Jason

Re: [PATCH] nvptx per-warp compiler-defined stacks (-msoft-stack)

2016-06-02 Thread Alexander Monakov
On Wed, 25 May 2016, Nathan Sidwell wrote: > > > It seems like we should reject the combination of -msoft-stack -fopenacc? > > > > Possibly; the doc text makes it explicit that the option is exposed only for > > the purpose of testing the compiler, anyway. > > It is always best to prevent the user

[PATCH 11/16] Add hash-set-tests.c

2016-06-02 Thread David Malcolm
Jeff approved an earlier version of this (as unittests/test-hash-set.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03300.html > OK if/when prereqs are approved. Minor twiddling if we end up > moving it elsewhere or standardizing/reducing header files is > pre-approved. This version moves the

[PATCH 06/16] et-forest.c: add selftests

2016-06-02 Thread David Malcolm
Jeff approved an earlier version of this: https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03295.html > OK if/when prereqs are approved. Minor twiddling if we end up > moving it elsewhere or standardizing/reducing header files > is pre-approved. This version has been updated to the new style. gcc/Ch

[PATCH 07/16] fold-const.c: add selftests

2016-06-02 Thread David Malcolm
Jeff approved an older version of this (as a separate unittests/test-folding.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03305.html > OK if/when prereqs are approved. Minor twiddling if we end up > moving it elsewhere or standardizing/reducing header files > is pre-approved. gcc/ChangeLog:

[PATCH 15/16] vec.c: add selftests

2016-06-02 Thread David Malcolm
Jeff approved an earlier version of this (as unittests/test-vec.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03308.html > OK if/when prereqs are approved. Minor twiddling if we end up > moving it elsewhere or standardizing/reducing header files is > pre-approved. gcc/ChangeLog: * vec.

[PATCH 13/16] Add rtl-tests.c

2016-06-02 Thread David Malcolm
Jeff approved an earlier version of this (as unittests/test-rtl.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03302.html > OK if/when prereqs are approved. Minor twiddling if we end up > moving it elsewhere or standardizing/reducing header files is >pre-approved. gcc/ChangeLog: * rtl-t

[PATCH 16/16] wide-int.cc: add selftests

2016-06-02 Thread David Malcolm
Jeff approved an early version of this: https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03309.html > OK if/when prereqs are approved. Minor twiddling if we end up > moving it elsewhere or standardizing/reducing header files is > pre-approved. This version moves it to wide-int.cc and converts it to t

[PATCH 12/16] input.c: add selftests

2016-06-02 Thread David Malcolm
Jeff conditionally approved an earlier version of this (as unittests/test-locations.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03307.html > OK if/when prereqs are approved. Minor twiddling if we end up > moving it elsewhere or standardizing/reducing header files is > pre-approved. gcc/Chang

tuple code simplification patch

2016-06-02 Thread François Dumont
Hi I was trying to play with tuple implementation and was annoyed by repetition of _Head type when instantiating _Head_base so I thought about this patch. How do you like it ? I still need to run tests, will do before commit, ok ? François Index: include/std/tuple ==

[PATCH 14/16] tree.c: add selftests

2016-06-02 Thread David Malcolm
Jeff approved an earlier version of this (as unittests/test-tree.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03303.html > OK if/when prereqs are approved. Minor twiddling if we end up > moving it elsewhere or standardizing/reducing header files is > pre-approved. gcc/ChangeLog: * tre

[PATCH 08/16] Add function-tests.c

2016-06-02 Thread David Malcolm
Jeff approved an earlier version of this (as unittests/test-functions.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03310.html with: > OK if/when prereqs are approved. Minor twiddling if we end up moving > it elsewhere or standardizing/reducing header files is pre-approved. gcc/ChangeLog:

[PATCH, RS6000] Add RS6000_BTM_MODULO to set of RS6000_BTM_COMMON flags

2016-06-02 Thread Kelvin Nilsen
This patch adds the RS6000_BTM_MODULO flag to to the set of flags associated with the RS6000_BTM_COMMON variable. This patch has bootstrapped with the trunk and the gcc-6-branch on powerpc64le-unknown-linux-gnu and there were no regressions. Is it ok to merge this with the trunk? Can I merge w

[PATCH, rs6000] Fix PR70957 (skip vsx-elemrev-[24].c tests for a downlevel assembler)

2016-06-02 Thread Bill Schmidt
Hi, PR70957 reports that the two subject tests fail on an older P7 machine. These tests rely on built-ins that exploit POWER9 vector support. It turns out that the failure occurs because the configured assembler is downlevel, and does not support even POWER8 instructions. This causes TARGET

[PATCH 02/16] diagnostic-show-locus.c: add selftests

2016-06-02 Thread David Malcolm
gcc/ChangeLog: * diagnostic-show-locus.c: Include "selftest.h". (make_range): New function. (test_range_contains_point_for_single_point): New function. (test_range_contains_point_test_for_single_line): New function. (test_range_contains_point_for_multiple_lin

[PATCH 05/16] tree-cfg.c: add selftests

2016-06-02 Thread David Malcolm
Jeff approved an older version of this: https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03285.html with: > Unless there's a good reason, drop the presumably redundant tests > and this is OK. Save preapprovald for these changes as the bitmap > patch. This version removes the redundant tests, moves th

[PATCH 10/16] Add hash-map-tests.c

2016-06-02 Thread David Malcolm
Jeff approved an earlier version of this (as unittests/test-hash-map.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03301.html > OK if/when prereqs are approved. Minor twiddling if we end up > moving it elsewhere or standardizing/reducing header files is > pre-approved. This version moves the

[PATCH 04/16] bitmap.c: add selftests

2016-06-02 Thread David Malcolm
Jeff pre-approved the plugin version of this (as a new file unittests/test-bitmap.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03284.html with: > OK if/when prereqs are approved. Minor twiddling if we end up moving it > elsewhere or standardizing/reducing header files is pre-approved. This v

[PATCH 03/16] spellcheck.c: convert Levenshtein test from a plugin to a selftest

2016-06-02 Thread David Malcolm
This is an example of converting one of our existing plugin-based tests to run within -fself-test instead. gcc/ChangeLog: * spellcheck.c: Include "selftest.h". (levenshtein_distance_unit_test_oneway): New function, adapted from testsuite/gcc.dg/plugin/levenshtein_plugin.c.

[PATCH 09/16] gimple.c: add selftests

2016-06-02 Thread David Malcolm
Jeff approved an earlier version of this (as unittests/test-gimple.c): https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03304.html > OK if/when prereqs are approved. Minor twiddling if we end > up moving it elsewhere or standardizing/reducing header files > is pre-approved. This version moves the te

[PATCH 01/16] Core of selftest framework (v6)

2016-06-02 Thread David Malcolm
gcc/ChangeLog: * Makefile.in (OBJS): Add function-tests.o, hash-map-tests.o, hash-set-tests.o, rtl-tests.o, selftest-run-tests.o. (OBJS-libcommon): Add selftest.o. (OBJS-libcommon-target): Add selftest.o. (all.internal): Add "selftests". (all.

[PATCH 00/16] v6 of -fself-test/unit-testing patch

2016-06-02 Thread David Malcolm
Given that we're now using an "abort on first failure" model, I renamed all of the EXPECT_ macros to ASSERT_ (for consistency with GTest). As per Bernd's suggestions I eliminated the runner class and moved to a more function-based rather than class-based approach. At this point, the only reasons

Re: [PATCH] Fix 416.gamess miscompare (PR71311)

2016-06-02 Thread Bernhard Reutner-Fischer
On June 2, 2016 9:05:36 PM GMT+02:00, Richard Biener wrote: >On June 2, 2016 7:47:19 PM GMT+02:00, Bernhard Reutner-Fischer > wrote: >>On June 1, 2016 9:37:26 AM GMT+02:00, Richard Biener >> wrote: >> PR tree-optimization/71311 * genmatch.c (comparison_code_p): New predicate. >> >>

[PATCH, applied] Backport PowerPC ISA 3.0 C min/max support to GCC 6.2

2016-06-02 Thread Michael Meissner
I backported the changes for adding the ISA 3.0 C min/max and floating point scalar compare generating a mask (for conditional move) to the GCC 6.2 branch. The changes in this patch were checked into the trunk on May 25th (with one patch from May 18th from a patch set that has not been backported y

[PATCH] Fix cgraph edge redirection with non-POD lhs (PR middle-end/71387)

2016-06-02 Thread Jakub Jelinek
Hi! Apparently my r236430 change (trunk) and r236431 (6.x) broke the following testcase. In the later similar change to gimple-fold.c in r236506 I've added code to tweak gimple_call_fntype if we have newly one of the void something (void) __attribute__((noreturn)) functions like __builtin_unreach

Re: [PATCH] Fix 416.gamess miscompare (PR71311)

2016-06-02 Thread Richard Biener
On June 2, 2016 7:47:19 PM GMT+02:00, Bernhard Reutner-Fischer wrote: >On June 1, 2016 9:37:26 AM GMT+02:00, Richard Biener > wrote: > >>> PR tree-optimization/71311 >>> * genmatch.c (comparison_code_p): New predicate. > >TREE_CODE_CLASS (code) == tcc_comparison Only if I'd pull all of t

Re: [PATCH] x86 interrupt attribute patch [2/2]

2016-06-02 Thread Sandra Loosemore
On 06/01/2016 08:19 AM, Koval, Julia wrote: diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index 2d4f028..3e6a796 100644 --- a/gcc/doc/extend.texi +++ b/gcc/doc/extend.texi @@ -5266,6 +5266,79 @@ On x86-32 targets, the @code{stdcall} attribute causes the compiler to assume that the cal

[Patch, fortran] PR70350 - [5 Regression] ICE with -fcheck=all and array initialization

2016-06-02 Thread Paul Richard Thomas
Dear All, I just backported the fix for this as revision 237043. This was fixed on 6-branch, when it was trunk, as r232850. I apologise for not doing this much earlier but, as the fortran list knows, life outside gfortran has intervened big-time over the last few months. I did not add a testcase

Re: [PATCH] Fix 416.gamess miscompare (PR71311)

2016-06-02 Thread Bernhard Reutner-Fischer
On June 1, 2016 9:37:26 AM GMT+02:00, Richard Biener wrote: >> PR tree-optimization/71311 >> * genmatch.c (comparison_code_p): New predicate. TREE_CODE_CLASS (code) == tcc_comparison ? thanks,

[RFC: Patch 6/6] Remove second cost model from noce_try_store_flag_mask

2016-06-02 Thread James Greenhalgh
Hi, This transformation tries two cost models, one estimating the number of insns to use, one estimating the RTX cost of the transformed sequence. This is inconsistent with the other cost models used in ifcvt.c and unnecessary - eliminate the second cost model. Thanks, James --- 2016-06-02 Jam

[RFC: Patch 3/6] Remove if_info->branch_cost

2016-06-02 Thread James Greenhalgh
Hi, This patch removes what is left of branch_cost uses, moving them to use the new hook and tagging each left over spot with a TODO to revisit them. All these uses are in rtx costs units, so we don't have more work to do at this point. OK? Thanks, James --- 2016-06-02 James Greenhalgh

[RFC: Patch 2/6] Factor out the comparisons against magic numbers in ifcvt

2016-06-02 Thread James Greenhalgh
Hi, This patch pulls the comparisons between if_info->branch_cost and a magic number representing an instruction count to a common function. While I'm doing it, I've documented the instructions that the magic numbers relate to, and updated them where they were inconsistent. If our measure of the

[RFC: Patch 5/6] Improve the cost model for multiple-sets

2016-06-02 Thread James Greenhalgh
Hi, This patch is a small rewrite to the cost model for bb_ok_for_noce_multiple_sets to use the new noce_cmove_estimate_cost function added in the previous patches. Thanks, James --- 2016-06-02 James Greenhalgh * ifcvt.c (bb_of_for_noce_convert_multiple_sets): Change cost model. di

[RFC: Patch 0/6] Rewrite the noce-ifcvt cost models

2016-06-02 Thread James Greenhalgh
Hi, When I was working in the area last year, I promised to revisit the cost model for noce if-conversion and see if I could improve the modeling. This turned out to be more tricky than I expected. This patch set rewrites the cost model for noce if-conversion. The goal is to rationalise the units

[RFC: Patch 4/6] Modify cost model for noce_cmove_arith

2016-06-02 Thread James Greenhalgh
Hi, This patch clears up the cost model for noce_try_cmove_arith. We lose the "??? FIXME: Magic number 5" comment, and gain a more realistic cost model for if-converting memory accesses. This is the patch that will cause the largest behavioural change for most targets - the current heuristic doe

[RFC: Patch 1/6] New target hook: rtx_branch_cost

2016-06-02 Thread James Greenhalgh
Hi, This patch introduces a new target hook, to be used like BRANCH_COST but with a guaranteed unit of measurement. We want this to break away from the current ambiguous uses of BRANCH_COST. BRANCH_COST is used in ifcvt.c in two types of comparisons. One against instruction counts - where it is

Re: [PR middle-end/71373] Handle more OMP_CLAUSE_* in nested function decomposition

2016-06-02 Thread Jakub Jelinek
On Thu, Jun 02, 2016 at 06:20:57PM +0200, Thomas Schwinge wrote: > relevant. Nested function decomposition is not applicable to C++, so we > don't need any C++ test cases, right? C++ has lambdas, but those are already lowered in the FE, so yes, from the OpenMP/OpenACC FEs, tree-nested.c is only u

Re: [PATCH][wwwdocs][AArch64] Mention -mcpu=qdf24xx support for GCC 6

2016-06-02 Thread James Greenhalgh
On Thu, Jun 02, 2016 at 03:54:43PM +0100, Kyrill Tkachov wrote: > Hi all, > > As discussed some time ago with Jim, here's the AArch64 note mentioning the > support for Qualcomm QDF24xx that was added in GCC 6. > > Ok to commit? OK. Thanks, James > Index: htdocs/gcc-6/changes.html > ===

Re: [PATCH][AArch64] Add missing fcsel in Cortex-A57 scheduler

2016-06-02 Thread James Greenhalgh
On Thu, Jun 02, 2016 at 04:09:32PM +, Wilco Dijkstra wrote: > The Cortex-A57 scheduler is missing fcsel, so add it. > > OK for commit? OK. Thanks, James > > ChangeLog: > 2016-06-02 Wilco Dijkstra > > * config/arm/cortex-a57.md (cortex_a57_fp_cpys): Add fcsel. > > --- > diff --gi

Re: [PR middle-end/71373] Handle more OMP_CLAUSE_* in nested function decomposition

2016-06-02 Thread Thomas Schwinge
Hi! On Wed, 1 Jun 2016 17:12:17 +0200, Jakub Jelinek wrote: > On Wed, Jun 01, 2016 at 05:06:42PM +0200, Thomas Schwinge wrote: > > Here are the OpenACC bits of . > > > > As we're currently not paying attention to OpenACC tile clauses in the > > middle end, and thus OM

Re: [PATCH][AArch64] Improve aarch64_modes_tieable_p

2016-06-02 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 17 May 2016 17:08 To: James Greenhalgh Cc: gcc-patches@gcc.gnu.org; nd Subject: Re: [PATCH][AArch64] Improve aarch64_modes_tieable_p James Greenhalgh wrote: > It would be handy if you could raise something in bugzilla for th

[PATCH, COMMITTED] Fix display name of PRED_FORTRAN_FAIL_IO

2016-06-02 Thread Martin Liška
Hi. Following patch fixes an obvious typo in definition of a predictor. Installed as r237040. Martin >From f78bf4238b4a3c7d6e03d7c00718204123a2cbfd Mon Sep 17 00:00:00 2001 From: marxin Date: Thu, 2 Jun 2016 18:13:25 +0200 Subject: [PATCH] Fix display name of PRED_FORTRAN_FAIL_IO gcc/ChangeLog

Re: [PATCH][3/3] No need to vectorize simple only-live stmts

2016-06-02 Thread Alan Hayward
>Statements which are live but not relevant need marking to ensure they are >vectorized. > >Live statements which are simple and all uses of them are invariant do not >need >to be vectorized. > >This patch adds a check to make sure those stmts which pass both the above >checks are not vectorized a

Re: [PATCH][2/3] Vectorize inductions that are live after the loop

2016-06-02 Thread Alan Hayward
On 01/06/2016 10:51, "Richard Biener" wrote: >On Wed, Jun 1, 2016 at 10:46 AM, Alan Hayward >wrote: >> >> >> On 30/05/2016 14:22, "Richard Biener" >>wrote: >> >>>On Fri, May 27, 2016 at 5:12 PM, Alan Hayward >>>wrote: On 27/05/2016 12:41, "Richard Biener" wrote: >On F

[PATCH][AArch64] Add missing fcsel in Cortex-A57 scheduler

2016-06-02 Thread Wilco Dijkstra
The Cortex-A57 scheduler is missing fcsel, so add it. OK for commit? ChangeLog: 2016-06-02 Wilco Dijkstra * config/arm/cortex-a57.md (cortex_a57_fp_cpys): Add fcsel. --- diff --git a/gcc/config/arm/cortex-a57.md b/gcc/config/arm/cortex-a57.md index 37912db464315a0d70835b81991e8e07a4

Re: [PATCH][1/3] Add loop_vinfo to vect_get_vec_def_for_operand

2016-06-02 Thread Alan Hayward
> This patch simply adds loop_vinfo as an extra argument to > vect_get_vec_def_for_operand and only generates a stmt_vinfo if required. > This is a required cleanup for patch [2/3]. > Tested on x86 and aarch64. > > gcc/ > * tree-vectorizer.h (vect_get_vec_def_for_operand): Pass loop_vinfo in. > *

Remove duplicated GOMP SIMD LANE code

2016-06-02 Thread Alan Hayward
The IFN_GOMP_SIMD_LANE code in vectorizable_call is essentially a duplicate of the code in vectorizable_live_operation. They both replace all uses outside the loop with the constant VF - 1. Note that my patch to vectorize inductions that are live after the loop will also remove the IFN_GOMP_SIMD_L

Re: [PATCH] microblaze.c: fix warnings

2016-06-02 Thread Michael Eager
OK to apply, On 06/01/2016 01:04 PM, David Malcolm wrote: The two microblaze configurations in contrib/config-list.mk microblaze-elf microblaze-linux currently fail to build due to warnings: microblaze.c: In function 'void insert_wic_for_ilb_runout(rtx_insn*)': microblaze.c:3653:7: e

Re: [C++ PATCH] Fix cp_fold dropping TREE_THIS_VOLATILE flag (PR c++/71372)

2016-06-02 Thread Jakub Jelinek
On Thu, Jun 02, 2016 at 11:14:48AM -0400, Jason Merrill wrote: > On Thu, Jun 2, 2016 at 8:13 AM, Jakub Jelinek wrote: > > When cp_fold is called on INDIRECT_REF and ARRAY*_REF and any of the > > arguments change in the recursive calls, we fail to copy TREE_THIS_VOLATILE > > flag. > > > > P

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-06-02 Thread Christophe Lyon
On 2 June 2016 at 17:04, Jakub Jelinek wrote: > On Thu, Jun 02, 2016 at 04:49:59PM +0200, Christophe Lyon wrote: >> I'm also seeing that the new gcc.dg/cpp/source_date_epoch-1.c fails because >> the output pattern finishes with '\n' instead of the usual '(\n|\r\n|\r)' >> >> Can I add this as obvio

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-06-02 Thread Bernd Schmidt
On 06/02/2016 05:04 PM, Jakub Jelinek wrote: Isn't following just better? Tested on x86_64-linux, ok for trunk? 2016-06-02 Jakub Jelinek * gcc.dg/cpp/source_date_epoch-1.c (main): Test __DATE__ and __TIME__ strings with __builtin_strcmp instead of printf and dg-outpu

Re: [C++ PATCH] Fix cp_fold dropping TREE_THIS_VOLATILE flag (PR c++/71372)

2016-06-02 Thread Jason Merrill
On Thu, Jun 2, 2016 at 8:13 AM, Jakub Jelinek wrote: > When cp_fold is called on INDIRECT_REF and ARRAY*_REF and any of the > arguments change in the recursive calls, we fail to copy TREE_THIS_VOLATILE > flag. > > PR c++/71372 > * cp-gimplify.c (cp_fold): For INDIRECT_REF, if the f

Re: [PATCH] c++/60760 - arithmetic on null pointers should not be allowed in constant expressions

2016-06-02 Thread Jason Merrill
On 06/01/2016 10:49 PM, Martin Sebor wrote: On 06/01/2016 01:20 PM, Jason Merrill wrote: On 06/01/2016 02:44 PM, Martin Sebor wrote: The new code in cxx_eval_component_reference diagnoses the following problem that's not detected otherwise: struct S { const S *s; }; constexpr S s = { 0 };

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-06-02 Thread Jakub Jelinek
On Thu, Jun 02, 2016 at 04:49:59PM +0200, Christophe Lyon wrote: > I'm also seeing that the new gcc.dg/cpp/source_date_epoch-1.c fails because > the output pattern finishes with '\n' instead of the usual '(\n|\r\n|\r)' > > Can I add this as obvious? Some remote test invocations even eat the final

Re: move increase_alignment from simple to regular ipa pass

2016-06-02 Thread Jan Hubicka
> On Thu, 2 Jun 2016, David Edelsohn wrote: > > > > Richard Biener wrote: > > > > >> "This would mean the pass should get its own non-Optimization flag > > >> initialized by targets where section anchors are usually used" > > >> IIUC should we add a new option -fno-increase_alignment and gate

[PATCH][wwwdocs][AArch64] Mention -mcpu=qdf24xx support for GCC 6

2016-06-02 Thread Kyrill Tkachov
Hi all, As discussed some time ago with Jim, here's the AArch64 note mentioning the support for Qualcomm QDF24xx that was added in GCC 6. Ok to commit? Thanks, Kyrill Index: htdocs/gcc-6/changes.html === RCS file: /cvs/gcc/wwwdocs

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-06-02 Thread Christophe Lyon
On 2 June 2016 at 15:01, Christophe Lyon wrote: > On 1 June 2016 at 18:59, Matthias Klose wrote: >> On 01.06.2016 18:29, Bernd Schmidt wrote: >>> On 05/13/2016 07:09 PM, Dhole wrote: +pfile->source_date_epoch = pfile->cb.get_source_date_epoch(pfile); >>> >>> Space before paren. Ok wi

Re: [Patch, ARM] PR71061, length pop* pattern in epilogue correctly

2016-06-02 Thread Jiong Wang
On 31/05/16 15:15, Kyrill Tkachov wrote: +/* Compute the atrribute "length" of insn. Currently, this function is used + for "*load_multiple_with_writeback", "*pop_multiple_with_return" and + "*pop_multiple_with_writeback_and_return". */ + s/atrribute/attribute/ Also, please add a descr

[PATCH][ARM][wwwdocs] Mention some arm port changes for GCC 6

2016-06-02 Thread Kyrill Tkachov
Hi all, A bit belatedly, but here are some arm-related entries for the changes.html page for GCC 6. Is this ok to commit? Thanks, Kyrill Index: htdocs/gcc-6/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v re

Re: [PATCH, i386, AVX-512] Add vectorizer support builtins

2016-06-02 Thread Ilya Verbin
On Mon, May 23, 2016 at 19:11:53 +0300, Ilya Verbin wrote: > This patch adds missed 512-bit rounding builtins for vectorization. > Regtested on x86_64-linux and i686-linux. OK for trunk? > > gcc/ > * config/i386/i386-builtin-types.def: Add V16SI_FTYPE_V16SF, > V8DF_FTYPE_V8DF_ROUND, V

Re: [PATCH, OpenACC] Make reduction arguments addressable

2016-06-02 Thread Jakub Jelinek
On Thu, Jun 02, 2016 at 09:55:05PM +0800, Chung-Lin Tang wrote: > fortran/ > * trans-openmp.c (gfc_trans_omp_clauses): Mark OpenACC reduction > arguments as addressable when async clause exists. Wouldn't it be better to pass either a bool openacc_async flag, or whole clauses, dow

Re: [PATCH, OpenACC] Make reduction arguments addressable

2016-06-02 Thread Chung-Lin Tang
On 2016/6/1 09:38 PM, Jakub Jelinek wrote: >> construct_clauses.lists[OMP_LIST_REDUCTION] = NULL; >> >oacc_clauses = gfc_trans_omp_clauses (&block, &construct_clauses, >> >code->loc); >> > + for (tree c = oacc_clauses; c; c = OMP_CLAUSE_CHAI

Re: [PATCH 00/21] Add -fself-test framework for fast, early unit-testing (unittests v5)

2016-06-02 Thread David Malcolm
On Thu, 2016-06-02 at 12:29 +0200, Bernd Schmidt wrote: > On 06/01/2016 11:19 PM, David Malcolm wrote: > > This is effectively v5 of the unittests proposal; for the earlier > > versions see: > > In general: nice to see this moving forward. Thanks. > There are some issues with the patch kit, some

Re: [middle-end][PATCH] Update alignment_for_piecewise_move

2016-06-02 Thread H.J. Lu
On Tue, Apr 26, 2016 at 11:39 AM, H.J. Lu wrote: > On Tue, Apr 26, 2016 at 11:31 AM, Bernd Schmidt wrote: >> On 04/26/2016 08:21 PM, Richard Sandiford wrote: >>> >>> "H.J. Lu" writes: I am working a patch to enable SSE, AVX and AVX512 for memcpy/memset optimization. x86 backend d

Re: [PATCH, libstdc++/testsuite, ping] 29_atomics/atomic/65913.cc: require atomic-builtins rather than specific target

2016-06-02 Thread Thomas Preudhomme
Ping? On Thursday 26 May 2016 14:00:55 Thomas Preudhomme wrote: > [Sorry for the large recipient list, I wasn't sure who of C++ and x86 > maintainers should approve this] > > Hi, > > 29_atomics/atomic/65913.cc test in libstdc++ is a runtime test that only > rely on atomic and gnu++11 support. Th

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-06-02 Thread Jakub Jelinek
On Thu, Jun 02, 2016 at 03:21:03PM +0200, Christophe Lyon wrote: > Ha, thanks, I had missed it. > > But why do I see "random" failures? > Looking at your patch, I have the impression that the test should always fail? Only with make -j1 -k check it should always FAIL. With -j2 and above, it reall

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-06-02 Thread Christophe Lyon
On 2 June 2016 at 15:05, Jakub Jelinek wrote: > On Thu, Jun 02, 2016 at 03:01:07PM +0200, Christophe Lyon wrote: >> On 1 June 2016 at 18:59, Matthias Klose wrote: >> > On 01.06.2016 18:29, Bernd Schmidt wrote: >> >> On 05/13/2016 07:09 PM, Dhole wrote: >> >>> +pfile->source_date_epoch =

Re: [PATCH 00/21] Add -fself-test framework for fast, early unit-testing (unittests v5)

2016-06-02 Thread David Malcolm
On Wed, 2016-06-01 at 15:20 -0600, Sandra Loosemore wrote: > On 06/01/2016 03:19 PM, David Malcolm wrote: > > This is effectively v5 of the unittests proposal; for the earlier > > versions see: > > * v1: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00765.html > > * v2: https://gcc.gnu.org/ml/g

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-06-02 Thread Jakub Jelinek
On Thu, Jun 02, 2016 at 03:01:07PM +0200, Christophe Lyon wrote: > On 1 June 2016 at 18:59, Matthias Klose wrote: > > On 01.06.2016 18:29, Bernd Schmidt wrote: > >> On 05/13/2016 07:09 PM, Dhole wrote: > >>> +pfile->source_date_epoch = > >>> pfile->cb.get_source_date_epoch(pfile); > >> >

Re: Allow embedded timestamps by C/C++ macros to be set externally (3)

2016-06-02 Thread Christophe Lyon
On 1 June 2016 at 18:59, Matthias Klose wrote: > On 01.06.2016 18:29, Bernd Schmidt wrote: >> On 05/13/2016 07:09 PM, Dhole wrote: >>> +pfile->source_date_epoch = pfile->cb.get_source_date_epoch(pfile); >> >> Space before paren. Ok with that change. >> >>> * c-common.h (c_omp_region_ty

Re: move increase_alignment from simple to regular ipa pass

2016-06-02 Thread Richard Biener
On Thu, 2 Jun 2016, David Edelsohn wrote: > > Richard Biener wrote: > > >> "This would mean the pass should get its own non-Optimization flag > >> initialized by targets where section anchors are usually used" > >> IIUC should we add a new option -fno-increase_alignment and gate the > >> pass

Re: move increase_alignment from simple to regular ipa pass

2016-06-02 Thread David Edelsohn
> Richard Biener wrote: >> "This would mean the pass should get its own non-Optimization flag >> initialized by targets where section anchors are usually used" >> IIUC should we add a new option -fno-increase_alignment and gate the >> pass on it ? Um sorry I didn't understand why targets >> wi

Re: Fix up dg-set-compiler-env-var

2016-06-02 Thread Jakub Jelinek
On Thu, Jun 02, 2016 at 02:26:28PM +0200, Bernd Schmidt wrote: > On 06/02/2016 02:19 PM, Jakub Jelinek wrote: > >The problem is that in cleanup-after-saved-dg-test, there are missing global > >directives, so when it tests/uses the set_compiler_env_var and > >saved_compiler_env_var vars to see if it

Re: Ping Re: Add option for whether ceil etc. can raise "inexact", adjust x86 conditions

2016-06-02 Thread Joseph Myers
On Thu, 2 Jun 2016, Jan Hubicka wrote: > > Ping. This patch > > is pending > > review (for the non-x86-specific parts). > The inliner bits looks fine to me. Of course it is easy to check whether the > function actually calls floor/ceil

Re: Ping Re: Add option for whether ceil etc. can raise "inexact", adjust x86 conditions

2016-06-02 Thread Joseph Myers
On Thu, 2 Jun 2016, Bernd Schmidt wrote: > On 06/02/2016 02:00 PM, Jan Hubicka wrote: > > > Ping. This patch > > > is pending > > > review (for the non-x86-specific parts). > > The inliner bits looks fine to me. > > In case that leaves a

Re: Fix up dg-set-compiler-env-var

2016-06-02 Thread Bernd Schmidt
On 06/02/2016 02:19 PM, Jakub Jelinek wrote: The problem is that in cleanup-after-saved-dg-test, there are missing global directives, so when it tests/uses the set_compiler_env_var and saved_compiler_env_var vars to see if it should call restore-compiler-env-var, it uses local (non-existing) vars

Re: Ping Re: Add option for whether ceil etc. can raise "inexact", adjust x86 conditions

2016-06-02 Thread Bernd Schmidt
On 06/02/2016 02:00 PM, Jan Hubicka wrote: Ping. This patch is pending review (for the non-x86-specific parts). The inliner bits looks fine to me. In case that leaves anything unapproved, the remaining parts are OK too, modulo one qu

Re: [PATCH v4] gcov: Runtime configurable destination output

2016-06-02 Thread Nathan Sidwell
On 05/31/16 11:04, Aaron Conole wrote: Nathan Sidwell writes: On 05/26/16 13:08, Aaron Conole wrote: The previous gcov behavior was to always output errors on the stderr channel. This is fine for most uses, but some programs will require stderr to be untouched by libgcov for certain tests. Th

Fix up dg-set-compiler-env-var

2016-06-02 Thread Jakub Jelinek
Hi! On Fri, May 13, 2016 at 07:09:30PM +0200, Dhole wrote: > --- a/gcc/testsuite/lib/gcc-dg.exp > +++ b/gcc/testsuite/lib/gcc-dg.exp > @@ -451,6 +451,38 @@ proc restore-target-env-var { } { > } > } > > +proc dg-set-compiler-env-var { args } { I've noticed last night pr61861.c FAIL in i686

Re: [PATCH] Fix first match heuristics

2016-06-02 Thread Jan Hubicka
> Hi. > > Following patch fixes a typo in first match heuristics that blocks > selection of best first match heuristics. > > It's questionable whether to add a spacial test-case for that? I'm bit > concerned that it can be a bit fragile. Lets add it now to have better coverage. If it will keep b

[C++ PATCH] Fix cp_fold dropping TREE_THIS_VOLATILE flag (PR c++/71372)

2016-06-02 Thread Jakub Jelinek
Hi! When cp_fold is called on INDIRECT_REF and ARRAY*_REF and any of the arguments change in the recursive calls, we fail to copy TREE_THIS_VOLATILE flag. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/6.2? 2016-06-02 Jakub Jelinek PR c++/71372

Re: Ping Re: Add option for whether ceil etc. can raise "inexact", adjust x86 conditions

2016-06-02 Thread Jan Hubicka
> Ping. This patch > is pending > review (for the non-x86-specific parts). The inliner bits looks fine to me. Of course it is easy to check whether the function actually calls floor/ceil and thus is affected by this flag. Do you expect

[PATCH 2/2] Add edge predictions pruning

2016-06-02 Thread marxin
contrib/ChangeLog: 2016-06-01 Martin Liska * analyze_brprob.py: Cover new dump output format. gcc/ChangeLog: 2016-06-01 Martin Liska * predict.c (dump_prediction): Add new argument. (enum predictor_reason): New enum. (struct predictor_hash): New struct.

[PATCH 0/2] Deduplicate edge predictors

2016-06-02 Thread marxin
Hi. Following small series makes deduplication of predictors in following 2 ways: 1) remove duplicate prediction that is guessed with the same probability (different than 1/2) to both edges 2) remove duplicates for a prediction that belongs with the same probability to a single e

[PATCH 1/2] Introduce filtering for edge_predictions.

2016-06-02 Thread marxin
gcc/ChangeLog: 2016-05-31 Martin Liska * predict.c (filter_predictions): New function. (remove_predictions_associated_with_edge): Use the filter function. (equal_edge_p): New function. --- gcc/predict.c | 38 ++ 1 file change

Ping Re: Add option for whether ceil etc. can raise "inexact", adjust x86 conditions

2016-06-02 Thread Joseph Myers
Ping. This patch is pending review (for the non-x86-specific parts). -- Joseph S. Myers jos...@codesourcery.com

[PR c/71381] C/C++ OpenACC cache directive rejects valid syntax (was: [gomp4] OpenACC cache directive for C.)

2016-06-02 Thread Thomas Schwinge
Hi! On Wed, 05 Nov 2014 17:29:19 +0100, I wrote: > In r217145, I applied Jim's patch to gomp-4_0-branch: > > commit 4361f9b6b2c74c2961c3a5290a4945abe2d7a444 > Author: tschwinge > Date: Wed Nov 5 16:26:47 2014 + > > OpenACC cache directive for C. (That, and the corresponding C++ chang

[PATCH] Fix first match heuristics

2016-06-02 Thread Martin Liška
Hi. Following patch fixes a typo in first match heuristics that blocks selection of best first match heuristics. It's questionable whether to add a spacial test-case for that? I'm bit concerned that it can be a bit fragile. Bootstrapped and regtested on x86_64-linux. Ready for trunk? Thanks, Ma

[ipa-comdats] create a new comdat group for symbol if it's referenced from multiple comdat groups

2016-06-02 Thread Prathamesh Kulkarni
Hi, I was trying to address first TODO from ipa-comdats.c (attached patch) TODO: When symbol is used only by comdat symbols, but from different groups, it would make sense to produce a new comdat group for it with anonymous name. The patch simply puts symbol in a new comdat group and makes symbol

Re: [PATCH] Improve *vec_concatv2si_sse4_1

2016-06-02 Thread Uros Bizjak
On Thu, May 26, 2016 at 9:24 PM, Jakub Jelinek wrote: > On Thu, May 26, 2016 at 07:39:01PM +0200, Uros Bizjak wrote: >> On Thu, May 26, 2016 at 7:05 PM, Jakub Jelinek wrote: >> > Hi! >> > >> > This patch adds an avx512dq alternative (EVEX vpinsrd requires that) and >> > enables EVEX vmovd and vpu

Re: [PATCH] Improve *vec_concatv4si

2016-06-02 Thread Uros Bizjak
On Thu, May 26, 2016 at 7:07 PM, Jakub Jelinek wrote: > Hi! > > Both vpunpcklqdq and vmovhps are available with XMM EVEX args in AVX512VL. > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > 2016-05-26 Jakub Jelinek > > * config/i386/sse.md (*vec_concatv4si): Us

Re: [PATCH] Support for SPARC M7 and VIS 4.0

2016-06-02 Thread Jose E. Marchesi
> I will also fix all the other points you raised. > Thanks! You're welcome. And if you want to have commit rights to the SVN repository, you can put me as your sponsor (Eric Botcazou ). I just sent a request. Thank you.

  1   2   >