Re: [PATCH] PR fortran/67885 -- PARAMETER needs to be marked in BLOCK

2015-10-26 Thread Thomas Koenig
Hi Steve, When an specification statement in a BLOCK construct has a PARAMETER attribute, gfortran currently discards the entity. This patch marks PARAMETER entity if in a BLOCK. I'm not complete convince that this is the right fix, but it does allow the testcase to compile and run. Built and

Re: Add non-constant vector ctors to operand_equal_p

2015-10-26 Thread Thomas Schwinge
Hi! On Thu, 22 Oct 2015 04:09:26 +0200, Jan Hubicka wrote: > this patch adds matching of non-constant CONSTRUCTOR expressions into > operand_equal_p. [...] > --- testsuite/gcc.dg/tree-ssa/operand-equal-2.c (revision 0) > +++ testsuite/gcc.dg/tree-ssa/operand-equal-2.c (revision 0) >

Re: [Ping] Fix 61441

2015-10-26 Thread Sujoy Saraswati
This is a ping for the patch to fix 61441. Regards, Sujoy On Tue, Oct 13, 2015 at 4:16 PM, Sujoy Saraswati wrote: > Hi, > This is another modified version of the patch, incorporating the > previous comments. > > Bootstrap and regression tests on x86_64-linux-gnu and > aarch64-unknown-linux-gnu

[PATCH, GCC 4.9 branch] Fix compile time regression caused by fix to PR64111

2015-10-26 Thread Caroline Tice
Here is my promised backport to the GCC 4.9 branch, for the patch below that went into ToT last week. As with the previous patch, I've verified that it fixes the problem, bootstraps and has no new regression test failures. Is this ok to commit to the gcc-4_9-branch? -- Caroline Tice cmt...@googl

[PATCH, GCC 5 branch] Fix compile time regression caused by fix to PR64111

2015-10-26 Thread Caroline Tice
Here is my promised backport to the GCC 5 branch, for the patch below that went into ToT last week. As with the previous patch, I've verified that it fixes the problem, bootstraps and has no new regression test failures. Is this ok to commit to the gcc-5-branch? -- Caroline Tice cmt...@google.co

Re: [PATCH v4] SH FDPIC backend support

2015-10-26 Thread Rich Felker
On Sun, Oct 25, 2015 at 11:28:51PM +0900, Oleg Endo wrote: > On Fri, 2015-10-23 at 02:32 -0400, Rich Felker wrote: > > Here's my updated version of the FDPIC patch with all requested > > changes made and Changelog added. I've included all the original > > authors. This is my first time writing such

[PING] Re: [PATCH] c++/67913, 67917 - fix new expression with wrong number of elements

2015-10-26 Thread Martin Sebor
[CC Jason] The patch is at the link below: https://gcc.gnu.org/ml/gcc-patches/2015-10/msg01803.html Thanks On 10/19/2015 12:50 PM, Martin Sebor wrote: This is a patch for two C++ bugs: 67913 - new expression with negative size not diagnosed 67927 - array new expression with excessive nu

[PING 2] [PATCH] c++/67942 - diagnose placement new buffer overflow

2015-10-26 Thread Martin Sebor
[CC Jason] When you have a chance, the patch is at the link below for review: https://gcc.gnu.org/ml/gcc-patches/2015-10/msg02001.html On 10/20/2015 01:57 PM, Martin Sebor wrote: Attached is a slightly updated patch that tweaks the diagnostic messages to avoid assuming the English punctuation,

Re: [0/7] Type promotion pass and elimination of zext/sext

2015-10-26 Thread kugan
On 23/10/15 01:23, Richard Biener wrote: On Thu, Oct 22, 2015 at 12:50 PM, Kugan wrote: On 21/10/15 23:45, Richard Biener wrote: On Tue, Oct 20, 2015 at 10:03 PM, Kugan wrote: On 07/09/15 12:53, Kugan wrote: This a new version of the patch posted in https://gcc.gnu.org/ml/gcc-patches

Re: [PATCH] Add missing INCLUDE_DEFAULTS_MUSL_LOCAL

2015-10-26 Thread Rich Felker
On Tue, Oct 27, 2015 at 12:16:16AM +, Joseph Myers wrote: > On Mon, 26 Oct 2015, Rich Felker wrote: > > > On Mon, Oct 26, 2015 at 11:42:37PM +, Joseph Myers wrote: > > > On Mon, 26 Oct 2015, Rich Felker wrote: > > > > > > > musl explicitly does not support using a mix of libc headers and

Re: [PATCH] Add missing INCLUDE_DEFAULTS_MUSL_LOCAL

2015-10-26 Thread Joseph Myers
On Mon, 26 Oct 2015, Rich Felker wrote: > On Mon, Oct 26, 2015 at 11:42:37PM +, Joseph Myers wrote: > > On Mon, 26 Oct 2015, Rich Felker wrote: > > > > > musl explicitly does not support using a mix of libc headers and > > > compiler-provided freestanding headers. While there may be > > > >

Re: [PATCH] Add missing INCLUDE_DEFAULTS_MUSL_LOCAL

2015-10-26 Thread Rich Felker
On Mon, Oct 26, 2015 at 11:42:37PM +, Joseph Myers wrote: > On Mon, 26 Oct 2015, Rich Felker wrote: > > > musl explicitly does not support using a mix of libc headers and > > compiler-provided freestanding headers. While there may be > > In that case the GCC ports for musl should define USER_

Re: [PATCH] Add missing INCLUDE_DEFAULTS_MUSL_LOCAL

2015-10-26 Thread Joseph Myers
On Mon, 26 Oct 2015, Rich Felker wrote: > musl explicitly does not support using a mix of libc headers and > compiler-provided freestanding headers. While there may be In that case the GCC ports for musl should define USER_H = $(EXTRA_HEADERS) like t-openbsd does. (Of course that won't work for

Re: [PATCH] Add missing INCLUDE_DEFAULTS_MUSL_LOCAL

2015-10-26 Thread Joseph Myers
On Mon, 26 Oct 2015, Szabolcs Nagy wrote: > > FLT_ROUNDS is an ordinary compiler bug (bug 30569), should be fixable > > reasonably straightforwardly as outlined at > > , probably within say a > > week's work if most architecture-specific changes ar

Re: [OpenACC 7/11] execution model

2015-10-26 Thread Nathan Sidwell
Jakub, Richard, This is the updated version of patch 7, using target-insns.def for the new insns. Otherwise same as yesterday's, which had the following changes: The significant change is that now the head/tail unique markers are threaded on a data dependency variable. I'd not noticed its

[PATCH] Add contains_symbol_ref_p .

2015-10-26 Thread Anatoliy Sokolov
Hello. This patch add contains_symbol_ref_p function in rtlanal.c and remove contains_symbol_ref_p from lra-constraints.c and contains_symbol_ref from var-tracking.c. Bootstrapped and reg-tested on x86_64-unknown-linux-gnu. OK for trunk? 2015-10-27 Anatoly Sokolov * rtl.h (con

[PATCH] Use subreg_regno instead of subreg_regno_offset

2015-10-26 Thread Anatoliy Sokolov
Hello. This patch change code 'REGNO (subreg) + subreg_regno_offset (...)' with subreg_regno (subreg). Bootstrapped and reg-tested on x86_64-unknown-linux-gnu. OK for trunk? 2015-10-27 Anatoly Sokolov * caller-save.c (add_stored_regs): Use subreg_regno instead of subreg

[MCORE] Hookize GO_IF_LEGITIMATE_ADDRESS

2015-10-26 Thread Anatoliy Sokolov
Hi. This patch removes obsolete GO_IF_LEGITIMATE_ADDRESS macros from the MCORE back end in the GCC and introduce equivalent TARGET_LEGITIMATE_ADDRESS_P target hook. Regression tested on mcore-unknown-elf. Only compile test run. OK for trunk? 2015-08-24 Anatoly Sokolov * config/mcore/mc

Re: [OpenACC 5/11] C++ FE changes

2015-10-26 Thread Cesar Philippidis
On 10/26/2015 03:20 AM, Jakub Jelinek wrote: > On Sat, Oct 24, 2015 at 02:11:41PM -0700, Cesar Philippidis wrote: >> --- a/gcc/cp/semantics.c >> +++ b/gcc/cp/semantics.c >> @@ -5911,6 +5911,31 @@ finish_omp_clauses (tree clauses, bool allow_fields, >> bool declare_simd) >> bitmap_set_bit

Re: [OpenACC 1/11] UNIQUE internal function

2015-10-26 Thread Nathan Sidwell
Richard, Jakub, this updates patch 1 to use the target-insns.def mechanism of detecting conditionally-implemented instructions. Otherwise it's the same as yesterday's patch. To recap: 1) Moved the subcodes to an enumeration in internal-fn.h 2) Remove ECF_LEAF 3) Added check in initialize_c

Re: [OpenACC 4/11] C FE changes

2015-10-26 Thread Cesar Philippidis
On 10/26/2015 01:59 AM, Jakub Jelinek wrote: > Ok for trunk with those changes fixed. Here's the patch with those changes. Nathan will commit this patch the rest of the openacc execution model patches. Thanks, Cesar 2015-10-26 Cesar Philippidis Thomas Schwinge James Norris

[gomp4] reorganize reduction target lowering

2015-10-26 Thread Nathan Sidwell
I've committed this to gomp4. It changes the target reduction lowering to: 1) use a single internal function with initial argument discriminator, in the same manner to IFN_UNIQUE and IFN_GOACC_LOOP 2) Rather than identify reductions with loop-id and reduction-id, which will cause a difficul

Re: [PATCH][wwwdocs] Mention arm target attributes and pragmas in GCC 6 changes

2015-10-26 Thread Gerald Pfeifer
On Mon, 26 Oct 2015, Kyrill Tkachov wrote: Here's a patch to mention the new target attributes for arm, in the same wording as for aarch64. This looks good to me, thanks. Gerald

Re: [PATCH] libffi testsuite: Don't run testsuite/libffi.call/float2.c on hppa*-*-hpux*

2015-10-26 Thread Andreas Tobler
Hi John, On 29.03.15 22:01, Andreas Tobler wrote: On 28.03.15 20:25, John David Anglin wrote: The libffi.call/float2.c test uses fabsl which was introduced in c99 and isn't available on hppa*-*-hpux*. In order to use the target selector with dg-run, I need to load target-supports-dg.exp in li

Re: [PATCH][auto-inc-dec.c] Account for cost of move operation in FORM_PRE_ADD and FORM_POST_ADD cases

2015-10-26 Thread Jeff Law
On 10/26/2015 10:07 AM, Richard Sandiford wrote: Bernd Schmidt writes: I seem to recall Richard had a rewrite of all the autoinc code. I wonder what happened to that? Although it produced more autoincs, it didn't really improve performance that much on the targets I was looking at at the time

C++ PATCH for DR 2179 (ambiguous partial specialization after instantiation)

2015-10-26 Thread Jason Merrill
While discussing issue 2179 at the meeting last week, I noticed that we were crashing when a partial specialization made a previous instantiation ambiguous. Fixed thus. Tested x86_64-pc-linux-gnu, applying to trunk. commit cb0817f19d7f4ce9878922412c2c1b2d07eb66d7 Author: Jason Merrill Date:

Re: [PATCH] rs6000: Fix tests for xvmadd and xvnmsub

2015-10-26 Thread David Edelsohn
On Sun, Oct 25, 2015 at 8:59 PM, Segher Boessenkool wrote: > The patterns involved can create vmadd resp. vnmsub instructions instead. > This patch changes the testcases to allow those. > > Tested with -m32,-m32/-mpowerpc64,-m64; okay for trunk? > > > Segher > > > 2015-10-26 Segher Boessenkool

Re: [PATCH] rs6000: p8vector-builtin-8.c test requires int128

2015-10-26 Thread David Edelsohn
On Sun, Oct 25, 2015 at 8:59 PM, Segher Boessenkool wrote: > For 32-bit targets p8vector_ok does not imply we have int128. > > Tested with -m32,-m32/-mpowerpc64,-m64; okay for trunk? > > > Segher > > > 2015-10-26 Segher Boessenkool > > gcc/testsuite/ > * gcc.target/powerpc/p8vector-buil

Re: [PATCH] Add missing INCLUDE_DEFAULTS_MUSL_LOCAL

2015-10-26 Thread Doug Evans
On Fri, Oct 23, 2015 at 11:34 AM, Szabolcs Nagy wrote: > On 23/10/15 18:39, Doug Evans wrote: >> >> On Fri, Oct 23, 2015 at 10:08 AM, Bernd Schmidt >> wrote: >>> >>> >>> On 10/21/2015 09:00 PM, Doug Evans wrote: I happened to notice local prefixes not working with musl. Fixes

Re: [gomp4] Adjust UNQUE ifn

2015-10-26 Thread Nathan Sidwell
On 10/26/15 07:36, Richard Biener wrote: Looks better now. + { #ifdef HAVE_oacc_fork (etc.) can you use target-insn.def and targetm.have_oacc_fork () instead? I've committed this to gomp4. Will port and update the patches for trunk. nathan 2015-10-26 Nathan Sidwell * inter

[PATCH] PR fortran/67885 -- PARAMETER needs to be marked in BLOCK

2015-10-26 Thread Steve Kargl
When an specification statement in a BLOCK construct has a PARAMETER attribute, gfortran currently discards the entity. This patch marks PARAMETER entity if in a BLOCK. I'm not complete convince that this is the right fix, but it does allow the testcase to compile and run. Built and tested on x86

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-26 Thread Jakub Jelinek
On Mon, Oct 26, 2015 at 10:39:04PM +0300, Ilya Verbin wrote: > > Without declare target link or to, you can't use the global variables > > in orphaned accelerated routines (unless you e.g. take the address of the > > mapped variable in the region and pass it around). > > The to variables (non-defer

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-26 Thread Ilya Verbin
On Mon, Oct 26, 2015 at 20:05:39 +0100, Jakub Jelinek wrote: > On Mon, Oct 26, 2015 at 09:35:52PM +0300, Ilya Verbin wrote: > > On Fri, Jul 17, 2015 at 15:05:59 +0200, Jakub Jelinek wrote: > > > As the testcases show, #pragma omp declare target has now a new form > > > (well, > > > two; with some

[Fortran, committed] Statement label on empty line in derived type declaration (PR 66056)

2015-10-26 Thread Louis Krupp
Revision 229390... Louis

[gomp4.5] Diagnose linear IV on #pragma omp for

2015-10-26 Thread Jakub Jelinek
Hi! linear clause is allowed on omp for, but the IV can only be private or lastprivate, not linear. We weren't diagnosing this. Fixed thusly, regtested on x86_64-linux. 2015-10-26 Jakub Jelinek * gimplify.c (omp_is_private): Diagnose linear iteration variables on non-simd con

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-26 Thread Jakub Jelinek
On Mon, Oct 26, 2015 at 09:35:52PM +0300, Ilya Verbin wrote: > On Fri, Jul 17, 2015 at 15:05:59 +0200, Jakub Jelinek wrote: > > As the testcases show, #pragma omp declare target has now a new form (well, > > two; with some issues on it pending), where it is used just as a single > > declarative dir

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-26 Thread Jeff Law
On 10/26/2015 11:14 AM, Bernd Schmidt wrote: On 10/26/2015 05:59 PM, Jeff Law wrote: I left it as-is. Obviously if you really want the unnecessary braces squashed out, we can do that. It's not a rule I particularly care about myself, but I'm flagging stuff like this for the sake of consistenc

Re: [gomp4.1] Handle new form of #pragma omp declare target

2015-10-26 Thread Ilya Verbin
On Fri, Jul 17, 2015 at 15:05:59 +0200, Jakub Jelinek wrote: > As the testcases show, #pragma omp declare target has now a new form (well, > two; with some issues on it pending), where it is used just as a single > declarative directive rather than a pair of them and allows marking > vars and funct

Re: [Bulk] [OpenACC 0/7] host_data construct

2015-10-26 Thread Jakub Jelinek
On Fri, Oct 23, 2015 at 10:51:42AM -0500, James Norris wrote: > @@ -12942,6 +12961,7 @@ c_finish_omp_clauses (tree clauses, bool is_omp, bool > declare_simd) > case OMP_CLAUSE_GANG: > case OMP_CLAUSE_WORKER: > case OMP_CLAUSE_VECTOR: > + case OMP_CLAUSE_USE_DEVICE: >

Re: [PATCH] libjava: fix locale handling when sorting JNI methods

2015-10-26 Thread Mike Frysinger
On 26 Oct 2015 12:10, Tom Tromey wrote: > Mike> URL: https://bugs.gentoo.org/563710 > Mike> Reported-by: Miroslav Šulc > > Mike> 2015-10-22 Mike Frysinger > > Mike> * scripts/check_jni_methods.sh.in: Run sort with LC_ALL=C, and > Mike> combine `sort|uniq` into `sort -u`. > Mik

Re: [PATCH] libjava: fix locale handling when sorting JNI methods

2015-10-26 Thread Tom Tromey
Mike> URL: https://bugs.gentoo.org/563710 Mike> Reported-by: Miroslav Šulc Mike> 2015-10-22 Mike Frysinger Mike> * scripts/check_jni_methods.sh.in: Run sort with LC_ALL=C, and Mike> combine `sort|uniq` into `sort -u`. Mike> --- Mike> libjava/classpath/scripts/check_jni_methods.sh.in | 4

[C++ Patch] PR c++/67846

2015-10-26 Thread Paolo Carlini
Hi, in mainline this ICE on invalid doesn't exist anymore but we may want to avoid issuing the additional redundant "error: cannot convert ‘A::foo’ from type ‘void (A::)()’ to type ‘void (A::*)()’" and/or make the error message more informative by printing the member used invalidly. Tested x8

Re: [OpenACC 8/11] device-specific lowering

2015-10-26 Thread Nathan Sidwell
On 10/26/15 09:51, Jakub Jelinek wrote: If not, I think the only thing remaining is the IFN_UNIQUE patch, which (At least) needs an update to use targetm.have... conversion. Ok, will wait till you make those changes then? Hope to have that later today. nathan

[PATCH, GCC 4.9 branch] Fix compile time regression caused by fix to PR64111

2015-10-26 Thread Caroline Tice
Here is my promised backport to the GCC 4.9 branch, for the patch below that went into ToT last week. As with the previous patch, I've verified that it fixes the problem, bootstraps and has no new regression test failures. Is this ok to commit to the gcc-4_9-branch? -- Caroline Tice cmt...@googl

[PATCH, GCC 5 branch] Fix compile time regression caused by fix to PR64111

2015-10-26 Thread Caroline Tice
Here is my promised backport to the GCC 5 branch, for the patch below that went into ToT last week. As with the previous patch, I've verified that it fixes the problem, bootstraps and has no new regression test failures. Is this ok to commit to the gcc-5-branch? -- Caroline Tice cmt...@google.co

Re: [Patch] Avoid is_simple_use bug in vectorizable_live_operation

2015-10-26 Thread Alan Hayward
On 26/10/2015 13:35, "Richard Biener" wrote: >On Mon, Oct 26, 2015 at 1:33 PM, Alan Hayward >wrote: >> There is a potential bug in vectorizable_live_operation. >> >> Consider the case where the first op for stmt is valid, but the second >>is >> null. >> The first time through the for () loop,

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-26 Thread Bernd Schmidt
On 10/26/2015 05:59 PM, Jeff Law wrote: I left it as-is. Obviously if you really want the unnecessary braces squashed out, we can do that. It's not a rule I particularly care about myself, but I'm flagging stuff like this for the sake of consistency. Don't change the whitespace here. Looks

Re: Drop types_compatible_p from operand_equal_p

2015-10-26 Thread Jan Hubicka
> On Sat, 24 Oct 2015, Jan Hubicka wrote: > > > Hi, as discussed earlier, the types_compatible_p in operand_equal_p > > seems redundant. (it is callers work to figure out how much of type > > matching it wants. If not, we probably want to treat most of other > > references and casts simlar way

Re: [PATCH 7/9] ENABLE_CHECKING refactoring: middle-end, LTO FE

2015-10-26 Thread Jeff Law
On 10/19/2015 06:13 AM, Bernd Schmidt wrote: diff --git a/gcc/cfgcleanup.c b/gcc/cfgcleanup.c - -#ifdef ENABLE_CHECKING - verify_flow_info (); -#endif + checking_verify_flow_info (); This looks misindented. Looks that way, but it was a spaces vs tabs issue. Oh how I long

Re: [patch] Extend former fold_widened_comparison to all integral types

2015-10-26 Thread Eric Botcazou
> Maybe you should count how many times __atomic_is_lock_free is called > instead of the current patch to the testsuite. I have changed it to make __atomic_is_lock_free set a value through p. -- Eric Botcazou

Re: [OpenACC 8/11] device-specific lowering

2015-10-26 Thread Jakub Jelinek
On Mon, Oct 26, 2015 at 09:13:28AM -0700, Nathan Sidwell wrote: > On 10/26/15 08:13, Jakub Jelinek wrote: > > >>It won't convert them into such representations. > > > >Can you fix that incrementally? I'd expect that code marked with acc loop > >vector > >can't have loop carried backward lexical

Re: [PATCH] Adjust some patterns wrt :c

2015-10-26 Thread Marc Glisse
On Mon, 26 Oct 2015, Richard Biener wrote: @@ -435,7 +435,7 @@ (define_operator_list RINT BUILT_IN_RINT /* Fold (A & ~B) - (A & B) into (A ^ B) - B. */ (simplify - (minus (bit_and:cs @0 (bit_not @1)) (bit_and:s @0 @1)) + (minus (bit_and:cs @0 (bit_not @1)) (bit_and:cs @0 @1)) (minus (bit_xor

Re: [PATCH] PR fortran/36192 -- Check for valid BT_INTEGER

2015-10-26 Thread Dominique d'Humières
> … . The testcase demonstrates that the segfault in F951 (caused by calling > mpz_set with an invalid mpz_t) does not happen. If I am not mistaken, the test compiles without the patch (with different messages at least on x86_64-apple-darwin14 /opt/gcc/work/gcc/testsuite/gfortran.dg/pr36192.f9

Re: abort might not flush all open streams before process termination (was: aarch64-suse-linux-gnu: libgomp.oacc-c-c++-common/abort-1.c, libgomp.oacc-c-c++-common/abort-3.c FAILs)

2015-10-26 Thread Thomas Schwinge
Hi! On Wed, 7 Oct 2015 12:13:41 +0200, I wrote: > Copying glibc for your information/in case anyone has any further > comments, and the man-pages maintainer, Michael Kerrisk. The issue is > that abort might not flush all open streams before process termination; > original thread starting at >

RE: FW: [PATCH] Target hook for disabling the delay slot filler.

2015-10-26 Thread Simon Dardis
> On 10/23/2015 11:31 AM, Bernd Schmidt wrote: > > On 10/23/2015 04:57 PM, Simon Dardis wrote: > > > >> Patch below. Target hook renamed to > >> TARGET_NO_SPECULATION_IN_DELAY_SLOTS_P. > >> > >> Tested on mips-img-elf, no new regressions. > > > > As far as I'm concerned this is ok, and IIUC Jeff wa

Re: [PATCH, 2/2] Handle recursive restrict pointer in create_variable_info_for_1

2015-10-26 Thread Tom de Vries
On 26/10/15 12:23, Tom de Vries wrote: Hi, this patch enables recursive restrict handling in create_variable_info_for_1. This allows us to interpret all restricts in a function parameter "int *restrict *restrict *restrict a". This patch is the first step towards implementing a generic fix for

Re: libgomp testsuite: Remove some explicit acc_device_nvidia usage

2015-10-26 Thread Thomas Schwinge
Hi! On Wed, 14 Oct 2015 14:05:49 +0200, Bernd Schmidt wrote: > On 10/09/2015 05:11 PM, Thomas Schwinge wrote: > > On Wed, 22 Jul 2015 16:39:54 +0200, I wrote: > >> [...] cleanup; committed to > >> gomp-4_0-branch in r226072: [...] > > > > OK for trunk? > > I think all three patches here look OK.

[PATCH][wwwdocs] Mention arm target attributes and pragmas in GCC 6 changes

2015-10-26 Thread Kyrill Tkachov
Hi all, Christian asked me for this patch some time ago, but it slipped under my radar. Here's a patch to mention the new target attributes for arm, in the same wording as for aarch64. Ok to install? Thanks, Kyrill Index: htdocs/gcc-6/changes.html ==

Re: [PR libgomp/65437, libgomp/66518] Initialize runtime in acc_update_device, acc_update_self

2015-10-26 Thread Thomas Schwinge
Hi! On Wed, 14 Oct 2015 14:08:42 +0200, Bernd Schmidt wrote: > On 10/09/2015 05:14 PM, Thomas Schwinge wrote: > > On Fri, 19 Jun 2015 09:47:41 +0200, I wrote: > >> On Tue, 5 May 2015 11:43:20 +0200, I wrote: > >>> On Mon, 4 May 2015 10:20:14 -0400, John David Anglin > >>> wrote: > FAIL: li

[PATCH][AArch64] Fix ICE on (const_double:HF 0.0)

2015-10-26 Thread Alan Lawrence
The included testcase demonstrates the ICE: aarch64_valid_floating_const (via aarch64_float_const_representable_p) disables HFmode immediates, but allows 0.0. However, *movhf_aarch64 does not allow this insn: (insn 7 6 10 2 (set (mem:HF (reg/f:DI 73) [0 *f_2(D)+0 S2 A16]) (const_double:HF

Re: [PATCH, 1/2] Add handle_param parameter to create_variable_info_for_1

2015-10-26 Thread Tom de Vries
On 26/10/15 14:42, Richard Biener wrote: On Mon, Oct 26, 2015 at 12:22 PM, Tom de Vries wrote: >Hi, > >this no-functional-changes patch copies the restrict var declaration code >from intra_create_variable_infos to create_variable_info_for_1. > >The code was copied rather than moved, since in fi

Re: [OpenACC 8/11] device-specific lowering

2015-10-26 Thread Nathan Sidwell
On 10/26/15 08:13, Jakub Jelinek wrote: It won't convert them into such representations. Can you fix that incrementally? I'd expect that code marked with acc loop vector can't have loop carried backward lexical dependencies, at least not within the adjacent number of iterations specified in

Re: [PATCH] PR fortran/36192 -- Check for valid BT_INTEGER

2015-10-26 Thread Steve Kargl
On Mon, Oct 26, 2015 at 03:43:37PM +0100, FX wrote: > > Because the code issues two errors, one for each dimension. > > Then shouldn???t it be ???string.*string??? to match > two occurences of the string, with some stuff (incl. newline) in the middle? > I don't know dejagnu well enough to know i

Re: [PATCH][auto-inc-dec.c] Account for cost of move operation in FORM_PRE_ADD and FORM_POST_ADD cases

2015-10-26 Thread Richard Sandiford
Bernd Schmidt writes: > I seem to recall Richard had a rewrite of all the autoinc code. I wonder > what happened to that? Although it produced more autoincs, it didn't really improve performance that much on the targets I was looking at at the time. I'm afraid the patch is long lost now, and wo

Re: Handle OBJ_TYPE_REF in operand_equal_p

2015-10-26 Thread Jan Hubicka
> > This thing simply stays in GIMPLE and serves no purpose. I tried to remove > > it at one point, but run into some regressions. I plan to return to this. > > Have no idea how this was intended to work. > > Some bits was added by: > > https://gcc.gnu.org/ml/gcc-patches/2005-04/txt00100.txt > >

Re: [PATCH] New attribute to create target clones

2015-10-26 Thread Jeff Law
On 10/12/2015 05:35 PM, Evgeny Stupachenko wrote: Hi All, Here is a new version of patch (attached). Bootstrap and make check are in progress (all new tests passed). New test case g++.dg/ext/mvc4.C fails with ICE, when options lower than "-mavx" are passed. However it has the same behavior if "

Commit: Fix spelling mistake in RL78 documentation

2015-10-26 Thread Nick Clifton
Hi Guys, I am checking in the patch below to fix a small spelling mistake that I recently introduced to the RL78 documentation: gcc/ChangeLog 2015-10-26 Nick Clifton * doc/invoke.texi (RL78 Options): Fix spelling mistake. Index: gcc/doc/invoke.texi ===

[Ada] Renamings of volatile objects

2015-10-26 Thread Arnaud Charlet
This patch implements the following SPARK RM 7.1.3(12) rule: Contrary to the general SPARK 2014 rule that expression evaluation cannot have side effects, a read of an effectively volatile object with the properties Async_Writers or Effective_Reads set to True is considered to have an e

[Ada] Single protected declaration transformation guarantee

2015-10-26 Thread Arnaud Charlet
This patch adds a check to ensure that there is no attempt to expand a single protected declaration as the declaration should have been transformed into a protected type along with an anonymous object. No change in behavior, no test needed. Tested on x86_64-pc-linux-gnu, committed on trunk 2015-1

[Ada] Ghost types, objects and synchronization

2015-10-26 Thread Arnaud Charlet
This patch implements the following SPARK RM 6.9(19) rule: A ghost type shall not have a task or protected part. A ghost object shall not be of a type which yields synchronized objects. A ghost object shall not have a volatile part. A synchronized state abstraction shall not be a ghost

[PATCH] [PR tree-optimization/68013] Make sure first block in FSM path is in VISITED_BBs

2015-10-26 Thread Jeff Law
The problem here is the first block in an FSM path may not be added to VISITED_BBs. That in turn results in the threader finding a path which passes through that initial block a second time, reaching a different destination the second time through. This is caught by the assertion (to avoid

[Ada] References to task and protected types in aspects/pragmas

2015-10-26 Thread Arnaud Charlet
This patch implements the following rules from SPARK RM 6.1.4: For purposes of the rules concerning the Global, Depends, Refined_Global, and Refined_Depends aspects, when any of these aspects are specified for a task unit the task unit's body is considered to be the body of a procedure

Re: [vec-cmp, patch 4/6] Support vector mask invariants

2015-10-26 Thread Richard Biener
On Wed, Oct 14, 2015 at 6:13 PM, Ilya Enkovich wrote: > On 14 Oct 13:50, Ilya Enkovich wrote: >> 2015-10-14 11:49 GMT+03:00 Richard Biener : >> > On Tue, Oct 13, 2015 at 4:52 PM, Ilya Enkovich >> > wrote: >> >> I don't understand what you mean. vect_get_vec_def_for_operand has two >> >> changes

Re: [PATCH] Fix PR67443

2015-10-26 Thread Richard Biener
On Thu, Oct 22, 2015 at 11:58 AM, Dominik Vogt wrote: >> Eventually we'll get another testcase so I'll leave this for >> comments a while and will commit somewhen later this week. > > In case you're referring to my attempt to port the test case to > x86: All the efforts to reproduce the bug on x8

Re: [OpenACC 8/11] device-specific lowering

2015-10-26 Thread Jakub Jelinek
On Wed, Oct 21, 2015 at 03:49:08PM -0400, Nathan Sidwell wrote: > This patch is the device-specific half of the previous patch. It processes > the partition head & tail markers and loop abstraction functions inserted > during omp lowering. > > I don't see anything that would e.g. set the various

Re: [PATCH] Add missing INCLUDE_DEFAULTS_MUSL_LOCAL

2015-10-26 Thread Rich Felker
On Mon, Oct 26, 2015 at 12:32:01PM +, Szabolcs Nagy wrote: > On 23/10/15 21:20, Joseph Myers wrote: > >On Fri, 23 Oct 2015, Szabolcs Nagy wrote: > > > >>i think bsd libcs do the same, compiler headers interfering > >>with libc headers is problematic (e.g. FLT_ROUNDS is wrong > >>in gcc float.h,

Re: [vec-cmp, patch 3/6] Vectorize comparison

2015-10-26 Thread Richard Biener
On Wed, Oct 14, 2015 at 6:12 PM, Ilya Enkovich wrote: > On 14 Oct 15:06, Ilya Enkovich wrote: >> >> Will send an updated version after testing. >> >> Thanks, >> Ilya >> > > Here is an updated patch version. > > Thanks, > Ilya > -- > gcc/ > > 2015-10-14 Ilya Enkovich > > * tree-vect-data

Re: [PATCH] PR/67682, break SLP groups up if only some elements match

2015-10-26 Thread Richard Biener
On Fri, Oct 23, 2015 at 5:20 PM, Alan Lawrence wrote: > vect_analyze_slp_instance currently only creates an slp_instance if _all_ > stores > in a group fitted the same pattern. This patch splits non-matching groups up > on vector boundaries, allowing only part of the group to be SLP'd, or multipl

Re: Handle OBJ_TYPE_REF in operand_equal_p

2015-10-26 Thread Richard Biener
On Mon, Oct 26, 2015 at 3:34 PM, Jan Hubicka wrote: >> > + /* Objective-C frontend produce ill formed OBJ_TYPE_REF which >> > +probably should be dropped before reaching middle-end. */ >> > + if (!virtual_method_call_p (arg0) || !virtual_method_call_p >> > (arg1)) >>

[gomp4.5] target teams expression evaluation

2015-10-26 Thread Jakub Jelinek
Hi! The OpenMP 4.5 spec says that for combined target teams the num_teams and thread_limit expressions are evaluated on the host before the target construct. Additionally, this patch tries to determine during gimplification if it is easily possible to compute those expressions on the host even if

Re: [PATCH] PR fortran/36192 -- Check for valid BT_INTEGER

2015-10-26 Thread FX
> Because the code issues two errors, one for each dimension. Then shouldn’t it be “string.*string” to match two occurences of the string, with some stuff (incl. newline) in the middle? FX

Re: [gomp4] Adjust UNQUE ifn

2015-10-26 Thread Nathan Sidwell
On 10/26/15 07:36, Richard Biener wrote: + { #ifdef HAVE_oacc_fork (etc.) can you use target-insn.def and targetm.have_oacc_fork () instead? I can try ... nathan

Re: C++ PATCH for DR 1518 (c++/54835, c++/60417)

2015-10-26 Thread Jason Merrill
On 10/25/2015 09:04 PM, Ville Voutilainen wrote: On 25 October 2015 at 22:15, Ville Voutilainen wrote: It seems to me that there's a discrepancy in handling explicit default constructors. Based on my tests, this works: struct X {explicit X() {}}; void f(X) {} int main() { f({}); } Howe

Re: [PATCH] Fix PR68087

2015-10-26 Thread Markus Trippelsdorf
On 2015.10.26 at 13:26 +0100, Richard Biener wrote: > On Mon, Oct 26, 2015 at 12:32 PM, Markus Trippelsdorf > wrote: > > diff --git a/gcc/cp/constexpr.c b/gcc/cp/constexpr.c > > index ebca411b3eb4..0828a90b0e75 100644 > > --- a/gcc/cp/constexpr.c > > +++ b/gcc/cp/constexpr.c > > @@ -1782,8 +1782,

Re: [PATCH 0/4] OpenMP 4.0 offloading to Intel MIC

2015-10-26 Thread Ilya Verbin
On Fri, Oct 23, 2015 at 10:10:06 +0200, Jakub Jelinek wrote: > On Thu, Oct 22, 2015 at 09:26:37PM +0300, Ilya Verbin wrote: > > On Mon, Dec 22, 2014 at 13:01:40 +0100, Thomas Schwinge wrote: > > > By chance (when tracking down a different problem), I've found the > > > following. Would you please

Re: [gomp4] Adjust UNQUE ifn

2015-10-26 Thread Richard Biener
On Mon, Oct 26, 2015 at 3:26 PM, Nathan Sidwell wrote: > On 10/26/15 02:10, Thomas Schwinge wrote: >> >> Hi Nathan! > > } >> >> >> [...]/source-gcc/gcc/internal-fn.c: In function 'void >> expand_UNIQUE(gcall*)': >> [...]/source-gcc/gcc/internal-fn.c:1982:6: error: variable 'target' >> s

Re: Handle OBJ_TYPE_REF in operand_equal_p

2015-10-26 Thread Jan Hubicka
> > + /* Objective-C frontend produce ill formed OBJ_TYPE_REF which > > +probably should be dropped before reaching middle-end. */ > > + if (!virtual_method_call_p (arg0) || !virtual_method_call_p > > (arg1)) > > + return false; > > So what kind of brokeness

Re: [gomp4] Adjust UNQUE ifn

2015-10-26 Thread Nathan Sidwell
On 10/26/15 02:10, Thomas Schwinge wrote: Hi Nathan! } [...]/source-gcc/gcc/internal-fn.c: In function 'void expand_UNIQUE(gcall*)': [...]/source-gcc/gcc/internal-fn.c:1982:6: error: variable 'target' set but not used [-Werror=unused-but-set-variable] rtx target = const0_rt

[PATCH] Remove fold_call_stmt calls, cleanup DOM threadedge a bit

2015-10-26 Thread Richard Biener
The following removes calls to fold_call_stmt as that does not end up exercising all the match.pd rules we have for builtins now. Instead use gimple_fold_stmt_to_constant[_1]. It also removes some awkward manual re-folding code from tree-ssa-threadedge.c and notes further cleanup opportunities a

Re: [vec-cmp, patch 6/6, i386] Add i386 support for vector comparison

2015-10-26 Thread Kirill Yukhin
Hi Ilya, On 08 Oct 18:32, Ilya Enkovich wrote: > Hi, > > This patch adds patterns for vec_cmp optabs. Vector comparison expand code > was moved from VEC_COND_EXPR expanders into a separate functions. AVX-512 > patterns use more simple masked versions. > > Thanks, > Ilya > -- > gcc/ > > 2015-

Re: [gomp4.1] map clause parsing improvements

2015-10-26 Thread Ilya Verbin
On Mon, Oct 26, 2015 at 14:07:13 +0100, Jakub Jelinek wrote: > On Mon, Oct 26, 2015 at 03:53:57PM +0300, Ilya Verbin wrote: > > @@ -7363,7 +7363,7 @@ gimplify_adjust_omp_clauses (gimple_seq *pre_p, tree > > *list_p, > > n = splay_tree_lookup (ctx->variables, (splay_tree_key) decl); > >

Re: [PATCH] Pass manager: add support for termination of pass list

2015-10-26 Thread Richard Biener
On Mon, Oct 26, 2015 at 2:48 PM, Richard Biener wrote: > On Thu, Oct 22, 2015 at 1:02 PM, Martin Liška wrote: >> On 10/21/2015 04:06 PM, Richard Biener wrote: >>> On Wed, Oct 21, 2015 at 1:24 PM, Martin Liška wrote: On 10/21/2015 11:59 AM, Richard Biener wrote: > On Wed, Oct 21, 2015 at

Re: [PATCH] Pass manager: add support for termination of pass list

2015-10-26 Thread Richard Biener
On Thu, Oct 22, 2015 at 1:02 PM, Martin Liška wrote: > On 10/21/2015 04:06 PM, Richard Biener wrote: >> On Wed, Oct 21, 2015 at 1:24 PM, Martin Liška wrote: >>> On 10/21/2015 11:59 AM, Richard Biener wrote: On Wed, Oct 21, 2015 at 11:19 AM, Martin Liška wrote: > On 10/20/2015 03:39 PM,

Re: [PATCH] PR fortran/36192 -- Check for valid BT_INTEGER

2015-10-26 Thread Steve Kargl
On Mon, Oct 26, 2015 at 09:49:10AM +0100, FX wrote: > > 2015-10-25 Steven G. Kargl > > > > PR fortran/36192 > > * array.c (gfc_ref_dimen_size): Check for BT_INTEGER before calling > > mpz_set. > > > > > > 2015-10-25 Steven G. Kargl > > > > PR fortran/36192 > > * gfortr

Re: [PATCH, 1/2] Add handle_param parameter to create_variable_info_for_1

2015-10-26 Thread Richard Biener
On Mon, Oct 26, 2015 at 12:22 PM, Tom de Vries wrote: > Hi, > > this no-functional-changes patch copies the restrict var declaration code > from intra_create_variable_infos to create_variable_info_for_1. > > The code was copied rather than moved, since in fipa-pta mode the varinfo p > for the para

Re: [Patch] Avoid is_simple_use bug in vectorizable_live_operation

2015-10-26 Thread Richard Biener
On Mon, Oct 26, 2015 at 1:33 PM, Alan Hayward wrote: > There is a potential bug in vectorizable_live_operation. > > Consider the case where the first op for stmt is valid, but the second is > null. > The first time through the for () loop, it will call out to > vect_is_simple_use () which will set

Re: [RFC] Improving alias dumps

2015-10-26 Thread Richard Biener
On Mon, Oct 26, 2015 at 1:26 PM, Tom de Vries wrote: > Hi, > > After spending some time looking at ealias/pta dumps, I realized that > they're hard to understand because we use varinfo names to identify > varinfos, while those names are not necessarily unique. > > F.i., for a function f: > ... > v

[PATCH] Adjust some patterns wrt :c

2015-10-26 Thread Richard Biener
This removes the genmatch warnings. Bootstrapped / tested on x86_64-unknown-linux-gnu, applied. Richard. 2015-10-26 Richard Biener * match.pd ((A & ~B) - (A & B) -> (A ^ B) - B): Add missing :c. ( (X & ~Y) | (~X & Y) -> X ^ Y): Remove redundant :c. Index: gcc/match.pd =

Re: [PATCH]Add -fprofile-use option for check_effective_target_freorder.

2015-10-26 Thread Bernd Schmidt
On 10/26/2015 02:17 PM, Teresa Johnson wrote: On Mon, Oct 26, 2015 at 2:00 AM, Renlin Li wrote: * lib/target-supports.exp (check_effective_target_freorder): Add -fprofile-use flag. Hmmm, the testcases themselves which use this predicate only use -freorder-and-partition, so maybe th

Re: [PATCH]Add -fprofile-use option for check_effective_target_freorder.

2015-10-26 Thread Teresa Johnson
Looks good to me, but I don't have approval rights. Thanks for fixing, Teresa On Mon, Oct 26, 2015 at 2:00 AM, Renlin Li wrote: > Hi all, > > After r228136, flag_reorder_blocks_and_partition is canceled when > -fprofile-use is not specified. > > In this case check_effective_target_freorder() is n

  1   2   3   >