Re: C++ delayed folding branch review

2015-08-02 Thread Jason Merrill
On 07/31/2015 05:54 PM, Kai Tietz wrote: The "STRIP_NOPS-requirement in 'reduced_constant_expression_p'" I could remove, but for one case in constexpr. Without folding we don't do type-sinking/raising. Right. So binary/unary operations might be containing cast, which were in the past unexp

Re: [C++/66443] virtual base of abstract class

2015-08-02 Thread Jason Merrill
On 08/01/2015 07:31 PM, Nathan Sidwell wrote: Ok, this patch fixes things up. The previous version was a little too lax, extending the logic of DR1611 to all synthesized functions. However, this broke virtual synthesized dtors, in that an abstract class's synthesized dtor's exception specificati

[gomp4] expand acc_on_device earlier

2015-08-02 Thread Nathan Sidwell
I've committed this to gomp4 branch. It expands the acc_on_device builtin earlier in the new oacc_xform pass. This will allow more optimization earlier on. The existing expansion point now only needs to deal with the host-side case. nathan 2015-08-02 Nathan Sidwell gcc/ * omp-low.c (oac

Re: [PATCH] warn for unsafe calls to __builtin_return_address

2015-08-02 Thread Martin Sebor
OK for the trunk. Sorry for the delay. Thank you. Committed in revision 226480. Martin

Re: [PATCH] Avoid recomputing multiple times the defining predicate-chain for the same PHI

2015-08-02 Thread Patrick Palka
On Sun, Aug 2, 2015 at 2:44 PM, Bernhard Reutner-Fischer wrote: > On August 2, 2015 8:18:51 PM GMT+02:00, Patrick Palka > wrote: > > No comment on the patch itself, but please > s/visted/visited/ > s/VISIED_PHIS/VISITED_PHIS/ > > while at it. > TIA, > Sure, no problem.

Re: [PATCH] Avoid recomputing multiple times the defining predicate-chain for the same PHI

2015-08-02 Thread Bernhard Reutner-Fischer
On August 2, 2015 8:18:51 PM GMT+02:00, Patrick Palka wrote: No comment on the patch itself, but please s/visted/visited/ s/VISIED_PHIS/VISITED_PHIS/ while at it. TIA,

[PATCH] Avoid recomputing multiple times the defining predicate-chain for the same PHI

2015-08-02 Thread Patrick Palka
In the uninit pass, the function is_use_properly_guarded is called consecutively by find_uninit_use, each time being passed the same PHI parameter, and each time we needlessly compute, simplify and normalize the same defining predicate-chain of that PHI. This patch fixes this inefficiency by tweak

RE: [RFC] [Patch]: Try and vectorize with shift for mult expr with power 2 integer constant.

2015-08-02 Thread Kumar, Venkataramanan
Hi Jakub, Thank you for reviewing the patch. I have incorporated your comments in the attached patch. > -Original Message- > From: Jakub Jelinek [mailto:ja...@redhat.com] > Sent: Wednesday, July 29, 2015 1:24 AM > To: Kumar, Venkataramanan > Cc: Richard Beiner (richard.guent...@gmail.c

Re: [PATCH] Simplify vector compare-not-select sequence

2015-08-02 Thread Andreas Schwab
Bill Schmidt writes: > * gcc.target/powerpc/vec-cmp-sel.c: New test. FAIL: gcc.target/powerpc/vec-cmp-sel.c (test for excess errors) Excess errors: /daten/gcc/gcc-20150801/gcc/testsuite/gcc.target/powerpc/vec-cmp-sel.c:14:1: error: use of 'long long' in AltiVec types is invalid without -m