Fix Ada bootstrap with LTO

2015-05-30 Thread Jan Hubicka
Hi, this patch fixes the cddce ICE reproducing during Ada bootstrap. The problem is forward_edge_to_pdom which does not know how to update PHIs. Due to presence of abnormal edges there is not unique predecestor the code looks for. I decided to simply remove the code and go for alternative solution

Re: [patch 10/10] debug-early merge: compiler proper

2015-05-30 Thread Aldy Hernandez
On 05/29/2015 03:33 PM, Jason Merrill wrote: On 05/29/2015 03:26 PM, Richard Biener wrote: ISTR I had to mark the gimple reg used for the bound as non-DECL_IGNORED for the LTO stuff. Let's go with that, then. Well, I did play around with that option originally, but temporaries do not end up

Re: Fwd: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-05-30 Thread H.J. Lu
On Sat, May 30, 2015 at 2:18 PM, Andreas Schwab wrote: > "H.J. Lu" writes: > >> What is wrong with it? > > It tests nothing. > Can you explain? -- H.J.

Re: Do less generous pointer globbing in alias.c

2015-05-30 Thread Jan Hubicka
> Jan Hubicka writes: > > > * alias.c (alias_set_entry_d): Add is_pointer and has_pointer. > > (alias_stats): Add num_universal. > > (alias_set_subset_of): Special case pointers; be ready for NULL > > children. > > (alias_sets_conflict_p): Special case pointers; be ready for N

Re: RFC: Add C++ warnings for unnecessarily general return types

2015-05-30 Thread Trevor Saunders
On Fri, May 29, 2015 at 11:14:46PM -0600, Jeff Law wrote: > On 05/29/2015 11:39 AM, Richard Sandiford wrote: > >One of the main early aims of the rtl refactoring is to finally separate > >instructions (rtx_insns) from other rtxes. I thought it would help if the > >compiler could warn about cases w

Re: Fwd: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-05-30 Thread Andreas Schwab
"H.J. Lu" writes: > What is wrong with it? It tests nothing. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

[Ada] Use underscored preprocessor symbols in C files

2015-05-30 Thread Eric Botcazou
This changes 4 preprocessor symbols tested in the C files (linux, sun, i386 and sparc) to their underscored variants. Both forms are defined by the compiler in normal mode, but the former is not in strictly conformant mode and this is problematic on Solaris now. The other preprocessor symbols

Re: Do less generous pointer globbing in alias.c

2015-05-30 Thread Andreas Schwab
Jan Hubicka writes: > * alias.c (alias_set_entry_d): Add is_pointer and has_pointer. > (alias_stats): Add num_universal. > (alias_set_subset_of): Special case pointers; be ready for NULL > children. > (alias_sets_conflict_p): Special case pointers; be ready for NULL

Re: Fwd: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-05-30 Thread H.J. Lu
On Sat, May 30, 2015 at 9:44 AM, Andreas Schwab wrote: > "H.J. Lu" writes: > >> There is no harm and the message is gone in stage 2 and 3, >> We can treat it the same as other spurious messages from the >> bootstrap compiler. > > But you still need to fix the first test, since it doesn't test > a

Compute canonical type by main variants

2015-05-30 Thread Jan Hubicka
Richard, this patch makes canonical_type to be computed via the hash only for main variants of types. The idea is to save some lookups because most types are variants and should match. I also added sanity checking about that. Bootstrapped/regtested ppc-linux, OK? Honza * lto.c (iterat

Re: Teach gimple_canonical_types_compatible_p about incomplete types

2015-05-30 Thread Jan Hubicka
> On May 30, 2015 12:56:26 AM GMT+02:00, Jan Hubicka wrote: > > >Index: tree.h > >=== > >--- tree.h (revision 223877) > >+++ tree.h (working copy) > >@@ -4598,7 +4598,28 @@ > > extern void DEBUG_FUNCTION verify_type (const_tree t

Re: Fwd: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-05-30 Thread Andreas Schwab
Andreas Schwab writes: > "H.J. Lu" writes: > >> diff --git a/gcc/config/m68k/m68k.h b/gcc/config/m68k/m68k.h >> index 88356cc..74ebff7 100644 >> --- a/gcc/config/m68k/m68k.h >> +++ b/gcc/config/m68k/m68k.h >> @@ -40,7 +40,8 @@ along with GCC; see the file COPYING3. If not see >> %{m68020-40:-m

Re: Fwd: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-05-30 Thread Andreas Schwab
"H.J. Lu" writes: > There is no harm and the message is gone in stage 2 and 3, > We can treat it the same as other spurious messages from the > bootstrap compiler. But you still need to fix the first test, since it doesn't test anything. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG K

Re: Fwd: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-05-30 Thread Andreas Schwab
"H.J. Lu" writes: > diff --git a/gcc/config/m68k/m68k.h b/gcc/config/m68k/m68k.h > index 88356cc..74ebff7 100644 > --- a/gcc/config/m68k/m68k.h > +++ b/gcc/config/m68k/m68k.h > @@ -40,7 +40,8 @@ along with GCC; see the file COPYING3. If not see > %{m68020-40:-m68040}%{m68020-60:-m68040}\ > %{m

Re: [PATCH] nios2-linux: add missing cpp specs

2015-05-30 Thread Mike Frysinger
On 30 May 2015 09:38, Sandra Loosemore wrote: > On 05/29/2015 09:28 PM, Mike Frysinger wrote: > > On 29 May 2015 12:32, Sandra Loosemore wrote: > >> On 05/29/2015 11:36 AM, Mike Frysinger wrote: > >>> On 29 May 2015 08:44, Sandra Loosemore wrote: > On 05/27/2015 10:00 AM, Mike Frysinger wrote:

Re: Fwd: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-05-30 Thread H.J. Lu
On Sat, May 30, 2015 at 8:54 AM, Andreas Schwab wrote: > "H.J. Lu" writes: > >> Starting GCC 4.6, the unrecognized option became an error. >> Before 4.6, it was ignored. Does it cause any problems for >> bootstrap? > > No, only spurious messages. > There is no harm and the message is gone in st

Re: Fwd: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-05-30 Thread Andreas Schwab
"H.J. Lu" writes: > Starting GCC 4.6, the unrecognized option became an error. > Before 4.6, it was ignored. Does it cause any problems for > bootstrap? No, only spurious messages. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214

Re: GIMPLE syntax highlighting for vim

2015-05-30 Thread Marek Polacek
On Sat, May 30, 2015 at 08:56:09AM +0300, Mikhail Maltsev wrote: > >> The attached vim script can be used to highlight syntax in GIMPLE dumps > >> making them somewhat easier to read. Which reminds me that we could have something similar for match.pd. I might take a crack at that next week.

Re: Fwd: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-05-30 Thread H.J. Lu
On Sat, May 30, 2015 at 8:10 AM, Andreas Schwab wrote: > "H.J. Lu" writes: > >> +# Check if -fno-PIE works. >> +AC_CACHE_CHECK([for -fno-PIE option], >> + [gcc_cv_c_no_fpie], >> + [saved_CFLAGS="$CFLAGS" >> + CFLAGS="$CFLAGS -fno-PIE" >> + AC_COMPILE_IFELSE([int main(void) {return 0;}], >>

Re: [PATCH] nios2-linux: add missing cpp specs

2015-05-30 Thread Sandra Loosemore
On 05/29/2015 09:28 PM, Mike Frysinger wrote: On 29 May 2015 12:32, Sandra Loosemore wrote: On 05/29/2015 11:36 AM, Mike Frysinger wrote: On 29 May 2015 08:44, Sandra Loosemore wrote: On 05/27/2015 10:00 AM, Mike Frysinger wrote: Define CPP_SPEC for nios2 linux targets so that -posix & -pthre

Re: Do less generous pointer globbing in alias.c

2015-05-30 Thread H.J. Lu
On Thu, May 28, 2015 at 1:12 PM, Jan Hubicka wrote: > hello, > only providing you the testcase why I need transitive closure of "contains > pointer" via the extra child I noticed that there is extra symmetry to handle: > > struct a {void *ptr;} > char **ptr = (char **)&a.ptr; > ptr

Re: Fwd: PING^3: [PATCH]: New configure options that make the compiler use -fPIE and -pie as default option

2015-05-30 Thread Andreas Schwab
"H.J. Lu" writes: > +# Check if -fno-PIE works. > +AC_CACHE_CHECK([for -fno-PIE option], > + [gcc_cv_c_no_fpie], > + [saved_CFLAGS="$CFLAGS" > + CFLAGS="$CFLAGS -fno-PIE" > + AC_COMPILE_IFELSE([int main(void) {return 0;}], > + [gcc_cv_c_no_fpie=yes], > + [gcc_cv_c_no_fpie=no]) > +

[PATCH] netbsd: respect -symbolic

2015-05-30 Thread Mike Frysinger
The current netbsd elf spec doesn't respect -symbolic which prevents passing -Bsymbolic down to the linker. This causes problems when you try to link the runtime linker as it creates an ELF with incorrect sections in it leading it to crash at startup. 2015-05-30 Benigno B. Junior * co

Re: [patch] libstdc++/66327 don't pass null pointers to memcmp

2015-05-30 Thread Jonathan Wakely
On 30/05/15 09:36 +, Jörg Richter wrote: >How about comparing only the length against 0? >The pointers must be != 0 if length > 0. Like so? Yes, that's probably an improvement, because we need that length anyway. Yes, that is what I had in mind. I think the second case can be handled equal

Re: Teach gimple_canonical_types_compatible_p about incomplete types

2015-05-30 Thread Bernhard Reutner-Fischer
On May 30, 2015 12:56:26 AM GMT+02:00, Jan Hubicka wrote: >Index: tree.h >=== >--- tree.h (revision 223877) >+++ tree.h (working copy) >@@ -4598,7 +4598,28 @@ > extern void DEBUG_FUNCTION verify_type (const_tree t); >extern b

Re: [RFA] Reimplement canonicalization of comparison arguments in match.pd

2015-05-30 Thread Marc Glisse
On Fri, 29 May 2015, Jeff Law wrote: c-common.c::shorten_compare has code to canonicalize the arguments of a comparison so that the constant is the second argument. This patch removes the implementation from c-common.c and instead implements it in match.pd. Note the match.pd tries to match t

Re: ping: [gcc patch] libcc1: '@' GDB array operator

2015-05-30 Thread Jan Kratochvil
On Sat, 30 May 2015 07:42:35 +0200, Jeff Law wrote: > We're still digging out a > bit from the patches queued while preparing for the gcc5 release. gcc6 > So I guess at some level it's not clear to me why we need to support the @ > operator in

Re: [patch] fix bootstrap on FreeBSD i386/arm

2015-05-30 Thread Andreas Tobler
Hi Steve, On 29.05.15 19:18, Steve Ellcey wrote: On Thu, 2015-05-28 at 23:54 +0200, Eric Botcazou wrote: This patch restores bootstrap on i386-*-freebsd*. The build was failing after the introduction of -std=c++98 configure/build flag. The -std=c++98 enables strict_ansi and on FreeBSD the libc

Re: [RFA] Factor conversion out of COND_EXPR using match.pd pattern

2015-05-30 Thread Marc Glisse
(only commenting on the technique, not on the transformation itself) +(simplify + (cond @0 (convert @1) INTEGER_CST@2) + (if (INTEGRAL_TYPE_P (TREE_TYPE (@1)) + && COMPARISON_CLASS_P (@0) If you add COMPARISON_CLASS_P to define_predicates, you could write: (cond COMPARISON_CLASS_P@0 (c

Re: [RFA] Factor conversion out of COND_EXPR using match.pd pattern

2015-05-30 Thread Bernhard Reutner-Fischer
On May 30, 2015 6:22:59 AM GMT+02:00, Jeff Law wrote: +/* { dg-final { cleanup-tree-dump "original" } } */ Please drop this cleanup dg-final, trunk now does this automatically. Thanks,