[PATCH] Fix PR rtl-optimization/65067

2015-03-04 Thread Bernd Edlinger
Hi, on ARM we have a code quality regression, because of the strict volatile bitfields handing.  The reason is that the current implementation directly jumps to store_fixed_bit_field_1 which emits a sequence of and/or/shift expressions.  This turns out to be too complex for combine to figure out t

Re: [PATCH][ARM]Automatically add -mthumb for thumb-only target when mode isn't specified

2015-03-04 Thread Maxim Kuvyrkov
> On Mar 5, 2015, at 9:14 AM, Terry Guo wrote: > >> >> Thanks Terry (and everyone else) for explaining why we want to do this in >> the driver. The substance of the patch looks good to me, and below are some >> comments and nit-picks. (Also, I'm not an ARM maintainer, so this is a >> review

[PATCH, AArch64] [4.8] [4.9] Backport PR64304 fix (miscompilation with -mgeneral-regs-only )

2015-03-04 Thread Chen Shanyao
This backports the fixes for PR target/64304 , miscompilation with -mgeneral-regs-only, to the 4.8 & 4.9 branch from trunk** r219844. Tested on x86_64 by using qemu of aarch64. OK for 4.8 & 4.9 ? ---gcc-4.8--- diff -rupN gcc-4.8-20150226/g

Re: [PATCH][ARM]Automatically add -mthumb for thumb-only target when mode isn't specified

2015-03-04 Thread Terry Guo
> > Thanks Terry (and everyone else) for explaining why we want to do this in the > driver. The substance of the patch looks good to me, and below are some > comments and nit-picks. (Also, I'm not an ARM maintainer, so this is a > review, not an approval to commit). > > Please make sure to upd

Re: [PATCH] target/65286 - Disable multilib for ppc64le

2015-03-04 Thread Alan Modra
On Wed, Mar 04, 2015 at 01:22:02PM -0700, Martin Sebor wrote: > On 03/04/2015 10:17 AM, Andreas Schwab wrote: > >Martin Sebor writes: > > > >>The configure script explicitly adds --enable-multilib unless > >>--disable-multilib is specified. This then results in libraries > >>being built with the -

Re: [patch/committed] PR middle-end/65233 make walk-ssa_copies handle empty PHIs

2015-03-04 Thread Jan Hubicka
> > > > It gets passed the valueize callback now which returns NULL_TREE for > > SSA names we can't follow. > > Btw, for match-and-simplify I had to use that as default for fold_stmt > _exactly_ because of the call to fold_stmt from replace_uses_by > via merge-blocks from cfgcleanup. This is beca

Partial fix for ipa/65270 (ICF needs to check some type flags)

2015-03-04 Thread Jan Hubicka
Hi, this patch adds checking virtual_p flag of refernces (to ensure proper answers of polymorphic-call-context analysis), of resrict flags on parameters, and of type attributes on functions (because these do matter for codegen if we decide to redirect). I am leavin the PR open, there are remaining

RFC: PATCHES: Properly handle reference to protected data on x86

2015-03-04 Thread H.J. Lu
Protected symbol means that it can't be pre-emptied. It doesn't mean its address won't be external. This is true for pointer to protected function. With copy relocation, address of protected data defined in the shared library may also be external. We only know that for sure at run-time. Here ar

Re: Fix oversight in round_up_loc change

2015-03-04 Thread Eric Botcazou
> There might be a similar issue in the block of code just above: > > wide_int val = value; > bool overflow_p; > > if ((val & (divisor - 1)) == 0) > return value; > > overflow_p = TREE_OVERFLOW (value); > val &= ~(divisor - 1); > > but I don't h

Re: [PATCH,rs6000] Change -mcrypto to only affect Category:Vector.Crypto instructions

2015-03-04 Thread David Edelsohn
On Wed, Mar 4, 2015 at 3:14 PM, Bill Schmidt wrote: > Hi, > > I recently observed that -mno-crypto disables all instructions in > section 5.11 of the 2.07 ISA, rather than just those flagged as > Category:Vector.Crypto. This patch fixes that undesirable situation. > > The main fix is to ensure th

Re: [patch] FreeBSD powerpc64 remove 32-bit soft-float multilibs.

2015-03-04 Thread Andreas Tobler
On 04.03.15 22:55, Jeff Law wrote: On 03/01/15 11:59, Andreas Tobler wrote: Hi all, the appended patch removes the soft-float multilib build option from powerpc64-*-freebsd*. These libraries are rarely to never used on 64-bit FreeBSD PowerPC machines. But the build time of these libraries coun

Re: [patch] FreeBSD powerpc64 remove 32-bit soft-float multilibs.

2015-03-04 Thread Jeff Law
On 03/01/15 11:59, Andreas Tobler wrote: Hi all, the appended patch removes the soft-float multilib build option from powerpc64-*-freebsd*. These libraries are rarely to never used on 64-bit FreeBSD PowerPC machines. But the build time of these libraries counts. Is this ok for trunk? If yes, a

Re: [patch/committed] PR middle-end/65233 make walk-ssa_copies handle empty PHIs

2015-03-04 Thread Jan Hubicka
> > I'd say that the devirtualization code is quite a heavy thing do to from > fold_stmt. Yes - it want's to catch all cases if a stmt is modified > (after which passes should fold it). Yep, I have no prolem doing the heavy part just at a specified point. (it usually converges quickly, but there

Re: Strengthen ICF hash

2015-03-04 Thread Jan Hubicka
> On March 4, 2015 9:22:24 PM CET, Jan Hubicka wrote: > >> On Wed, Mar 4, 2015 at 2:20 PM, Andi Kleen > >wrote: > >> > Hi Honza, > >> > > >> > Regarding modern hash functions, as far as I understand the trend > >> > is to just stop doing anything fancy and just use the CRC > >instructions > >> >

Re: [PATCH] fix URL

2015-03-04 Thread Gerald Pfeifer
On Mon, 2 Mar 2015, Ulrich Drepper wrote: > 2015-03-02 Ulrich Drepper > > * doc/invoke.texi (Options for Code Generation Conventions): > Fix URL of DSO paper. Note, you do not need approval for changes like this. ;-) Just go ahead and commit (and thanks for thinking of it). Ger

Re: Strengthen ICF hash

2015-03-04 Thread Richard Biener
On March 4, 2015 9:22:24 PM CET, Jan Hubicka wrote: >> On Wed, Mar 4, 2015 at 2:20 PM, Andi Kleen >wrote: >> > Hi Honza, >> > >> > Regarding modern hash functions, as far as I understand the trend >> > is to just stop doing anything fancy and just use the CRC >instructions >> > in modern CPUs >>

Fix can_remove_if_no_direct_calls WRT comdat groups

2015-03-04 Thread Jan Hubicka
Hi, this patch fixes correctness issue in cgraph_node::can_remove_if_no_direct_calls_p and cgraph_node::will_be_removed_from_program_if_no_direct_calls_p WRT to comdat groups. The predicate basically test if only uses of a symbol are calls and if the visibility prevents inlining. It forgets about

Re: Strengthen ICF hash

2015-03-04 Thread Jan Hubicka
> On Wed, Mar 4, 2015 at 2:20 PM, Andi Kleen wrote: > > Hi Honza, > > > > Regarding modern hash functions, as far as I understand the trend > > is to just stop doing anything fancy and just use the CRC instructions > > in modern CPUs > > I wonder if we can use intrinsics for CRC in place of the >

Re: [PATCH] target/65286 - Disable multilib for ppc64le

2015-03-04 Thread Martin Sebor
On 03/04/2015 10:17 AM, Andreas Schwab wrote: Martin Sebor writes: The configure script explicitly adds --enable-multilib unless --disable-multilib is specified. This then results in libraries being built with the -m32 option, which fails with errors like the one below: /usr/include/gnu/stubs

[PATCH,rs6000] Change -mcrypto to only affect Category:Vector.Crypto instructions

2015-03-04 Thread Bill Schmidt
Hi, I recently observed that -mno-crypto disables all instructions in section 5.11 of the 2.07 ISA, rather than just those flagged as Category:Vector.Crypto. This patch fixes that undesirable situation. The main fix is to ensure the remaining instructions are gated by TARGET_P8_VECTOR rather tha

[Patch] PR 65315 - Fix alignment of local variables

2015-03-04 Thread Steve Ellcey
While examining some MIPS code I noticed that GCC did not seem to be fully honoring the aligned attribute on some local variables. I submitted PR middle-end/65315 to record the bug and I think I now understand it and have a fix. The problem was that expand_stack_vars seemed to think that the fir

RE: [PATCH] Fix a typo in the german language translation

2015-03-04 Thread Bernd Edlinger
On Wed, 4 Mar 2015 17:52:11, Jospeh S. Myers wrote: > > On Wed, 4 Mar 2015, Bernd Edlinger wrote: > >> if nobody objects, I'd like to fix this in the german language >> translation file locally. I have already informed the german language > > All local changes to .po files get lost every time new .

Re: [Patch 2/2, v2, Fortran, pr60322 a.o.] [OOP] Incorrect bounds on polymorphic dummy array

2015-03-04 Thread Andre Vehreschild
Dear all, during his initial tests Dominique pointed out, that my patch did not fix all issues in the comments of pr60322. This new version of the patch fixes this issue now. The trick is to use a temporary array in the variable association of select type statements. The old code referenced the in

[C++ Patch/RFC] PR 64085

2015-03-04 Thread Paolo Carlini
Hi, today while working a bit on Bugzilla I found this issue which should be easy to fix, not a regression, therefore possibly post 5.0. At parsing time, cp_parser_lambda_introducer ends up calling real_lvalue_p on the lambda initializer (via add_capture), but then the initializer, which is a

Re: [PATCH] Fix a typo in the german language translation

2015-03-04 Thread Joseph Myers
On Wed, 4 Mar 2015, Bernd Edlinger wrote: > if nobody objects, I'd like to fix this in the german language > translation file locally. I have already informed the german language All local changes to .po files get lost every time new .po files are imported from upstream. So no such changes sh

Re: [PATCH] target/65286 - Disable multilib for ppc64le

2015-03-04 Thread Jeff Law
On 03/04/15 06:43, Andreas Schwab wrote: Martin Sebor writes: The attached patch resolves PR 65286 by adding --disable-multilib when configuring for a ppc64le target. If powerpc64le doesn't want multilib it should not set any multilib parameters. Agreed, and it's debatable whether or not ppc

[PATCH] Fix a typo in the german language translation

2015-03-04 Thread Bernd Edlinger
Hi, if nobody objects, I'd like to fix this in the german language translation file locally. I have already informed the german language translation team and yesterday this message has been fixed upstream.  But this typo is just too ugly to leave it for another year! Bernd. 2015-03-04  Bernd

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2015-03-04 Thread Jeff Law
On 03/02/15 09:19, Ilya Enkovich wrote: On 09 Dec 23:56, Ilya Enkovich wrote: 2014-12-09 22:57 GMT+03:00 Jeff Law : Wasn't this duplicated in the mpx-wrapper patch? Wrappers patch introduces similar option static-libmpxwrappers. I think this is OK on the technical side. I need to do to s

Re: [PATCH] Remove inefficient branchless conditional negate optimization

2015-03-04 Thread H.J. Lu
On Wed, Mar 4, 2015 at 9:10 AM, Jeff Law wrote: > On 03/04/15 09:18, Wilco Dijkstra wrote: >>> >>> Jeff Law wrote: >>> On 02/26/15 10:30, Wilco Dijkstra wrote: Several GCC versions ago a conditional negate optimization was introduced as a workaround >>> >>> for PR45685. Ho

Re: [PATCH] Fix PR65261

2015-03-04 Thread Jeff Law
On 03/02/15 11:56, Markus Trippelsdorf wrote: On 2015.03.02 at 18:53 +0100, Marek Polacek wrote: On Mon, Mar 02, 2015 at 06:22:49PM +0100, Markus Trippelsdorf wrote: --- a/libcpp/lex.c +++ b/libcpp/lex.c @@ -519,6 +519,7 @@ init_vectorized_lexer (void) and VSX unaligned loads (when VSX is

[patch] libstdc++/64797 fix handling of incomplete multibyte characters

2015-03-04 Thread Jonathan Wakely
To fix the non-portable 22_locale/conversions/string/2.cc test I changed it to use char16_t and char32_t where I can reliably create an invalid sequence that causes a conversion error. That revealed some more problems in the Unicode conversion utilities, fixed by this patch and verified by the new

Re: [PATCH] target/65286 - Disable multilib for ppc64le

2015-03-04 Thread Andreas Schwab
Martin Sebor writes: > The configure script explicitly adds --enable-multilib unless > --disable-multilib is specified. This then results in libraries > being built with the -m32 option, which fails with errors like > the one below: > > /usr/include/gnu/stubs.h:8:27: fatal error: gnu/stubs-32.h:

Re: [PATCH] Workaround -Wmaybe-uninitialized false positives during profiledbootstrap

2015-03-04 Thread Jeff Law
On 03/04/15 06:18, Martin Liška wrote: Hello. There is a patch with 2 hunks that are related to the same problem on powerpc64le-unknown-linux-gnu. Ready for trunk? Thanks, Martin 0001-Fix-warnings-occured-during-profiledboostrap-on-powe.patch From ea05ba5d0e4a5963e063564ffbec84f90fac

Re: [PATCH] Remove inefficient branchless conditional negate optimization

2015-03-04 Thread Jeff Law
On 03/04/15 09:18, Wilco Dijkstra wrote: Jeff Law wrote: On 02/26/15 10:30, Wilco Dijkstra wrote: Several GCC versions ago a conditional negate optimization was introduced as a workaround for PR45685. However the branchless expansion for conditional negate is extremely inefficient on most

Re: [PATCH] target/65286 - Disable multilib for ppc64le

2015-03-04 Thread Jeff Law
On 03/04/15 09:40, Martin Sebor wrote: On 03/04/2015 09:19 AM, Jeff Law wrote: On 03/04/15 06:43, Andreas Schwab wrote: Martin Sebor writes: The attached patch resolves PR 65286 by adding --disable-multilib when configuring for a ppc64le target. If powerpc64le doesn't want multilib it shou

Re: [PATCH] target/65286 - Disable multilib for ppc64le

2015-03-04 Thread Martin Sebor
On 03/04/2015 09:19 AM, Jeff Law wrote: On 03/04/15 06:43, Andreas Schwab wrote: Martin Sebor writes: The attached patch resolves PR 65286 by adding --disable-multilib when configuring for a ppc64le target. If powerpc64le doesn't want multilib it should not set any multilib parameters. Agr

RE: [PATCH] Remove inefficient branchless conditional negate optimization

2015-03-04 Thread Wilco Dijkstra
> Jeff Law wrote: > On 02/26/15 10:30, Wilco Dijkstra wrote: > > Several GCC versions ago a conditional negate optimization was introduced > > as a workaround > for > > PR45685. However the branchless expansion for conditional negate is > > extremely inefficient on > most > > targets (5 sequentia

Re: [Patch,microblaze]: Optimized usage of fint instruction.

2015-03-04 Thread Michael Eager
On 03/04/15 03:53, Ajit Kumar Agarwal wrote: -Original Message- From: Michael Eager [mailto:ea...@eagerm.com] Sent: Thursday, February 26, 2015 4:33 AM To: Ajit Kumar Agarwal; GCC Patches Cc: Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re: [Patch,mi

Re: [PR58315] reset inlined debug vars at return-to point

2015-03-04 Thread Richard Biener
On Wed, Feb 25, 2015 at 10:40 AM, Alexandre Oliva wrote: > This patch fixes a problem that has been with us for several years. > Variable tracking has no idea about the end of the lifetime of inlined > variables, so it keeps on computing locations for them over and over, > even though the computed

[PATCH][AArch64] Fix aarch64_rtx_costs of PLUS/MINUS

2015-03-04 Thread Wilco Dijkstra
Include the cost of op0 and op1 in all cases in PLUS and MINUS in aarch64_rtx_costs. Bootstrap & regression OK. ChangeLog: 2015-03-04 Wilco Dijkstra * gcc/config/aarch64/aarch64.c (aarch64_rtx_costs): Calculate cost of op0 and op1 in PLUS and MINUS cases. --- gcc/config/aarc

Re: [PATCH][AArch64] Use conditional negate for abs expansion

2015-03-04 Thread Maxim Kuvyrkov
On Mar 4, 2015, at 6:00 PM, Wilco Dijkstra wrote: > >> Maxim Kuvyrkov wrote: >>> On Mar 4, 2015, at 3:30 PM, Wilco Dijkstra wrote: >>> Maxim Kuvyrkov wrote: You are removing the 2nd alternative that generates "abs" with your patch. While I agree >> that using "csneg"

[Committed] S/390: Fix check for builtins valid with -mhtm

2015-03-04 Thread Andreas Krebbel
Committed to mainline. 2015-03-04 Andreas Krebbel * gcc/config/s390/s390.c (s390_expand_builtin): Exlude non-htm builtins from checking for -mhtm option. diff --git a/gcc/config/s390/s390.c b/gcc/config/s390/s390.c index 1924f2a..593c0cc 100644 --- a/gcc/config/s390/s390.c +++

RE: [PATCH][AArch64] Use conditional negate for abs expansion

2015-03-04 Thread Wilco Dijkstra
> Maxim Kuvyrkov wrote: > > On Mar 4, 2015, at 3:30 PM, Wilco Dijkstra wrote: > > > >> Maxim Kuvyrkov wrote: > >> > >> You are removing the 2nd alternative that generates "abs" with your patch. > >> While I agree > that > >> using "csneg" is faster on all implementations, can you say the same fo

[Ada] Fix problem with unnesting of subprograms

2015-03-04 Thread Arnaud Charlet
The subprogram unnesting circuit did not properly handle the case where we are adding an ARECnF formal, and there are already extra formals present. This is fixed by now using the normal Extra_Formal circuit for adding the ARECnF formal. This also required significant repair to Sprint, which was no

Go testsuite patch committed: Disable nilptr test on s390*

2015-03-04 Thread Ian Lance Taylor
This patch to the Go testsuite driver disables the nilptr test on s390*. Committed to mainline. Ian 2015-03-04 Ian Lance Taylor * go.test/go-test.exp (go-gc-tests): Skip nilptr test on s390*. Index: go.test/go-test.exp === --- g

Re: [PATCH, alpha]: Fix PR/47230 [4.6/4.7 Regression] gcc fails to bootstrap on alpha in stage2 with "relocation truncated to fit: GPREL16 against ..."

2015-03-04 Thread Uros Bizjak
On Wed, Mar 4, 2015 at 2:56 PM, Uros Bizjak wrote: >> Unfortunately, while "normal" bootstrap works OK with alpha-linux-gnu >> and alphaev68-linux-gnu, the bootstrap still fails when configured >> --with-build-config=bootstrap-lto: [...] >> ../../gcc-svn/trunk/gcc/lto/Make-lang.in:71: recipe fo

Re: [PATCH] PR target/65248: [5 Regression] Copy relocation in PIE against protected symbol

2015-03-04 Thread H.J. Lu
On Tue, Mar 3, 2015 at 7:13 PM, Alan Modra wrote: > On Tue, Mar 03, 2015 at 06:20:05AM -0800, H.J. Lu wrote: >> For x86-64, protected data symbols are impossible. > > Impossible? This is not even true currently since -fPIC emits code > that looks like it would fully support protected visibiliy va

RE: [PATCH] Fix another wrong-code bug with -fstrict-volatile-bitfields

2015-03-04 Thread Bernd Edlinger
ad of GET_MODE_ALIGNMENT here. testsuite: 2015-03-04 Bernd Edlinger * gcc.dg/20150304-1.c: New test. patch-volatile-bitfields-1.diff Description: Binary data

Re: [PATCH, alpha]: Fix PR/47230 [4.6/4.7 Regression] gcc fails to bootstrap on alpha in stage2 with "relocation truncated to fit: GPREL16 against ..."

2015-03-04 Thread Uros Bizjak
On Fri, Feb 27, 2015 at 2:11 PM, Uros Bizjak wrote: > On Wed, Feb 25, 2015 at 8:18 PM, Richard Henderson wrote: >> On 02/25/2015 09:02 AM, Uros Bizjak wrote: >>> The patch was tested on alpha-linux-gnu and alphaev68-linux-gnu for >>> all default languages plus obj-c++ and go. >>> >>> OK for mainl

Re: Strengthen ICF hash

2015-03-04 Thread Richard Biener
On Wed, Mar 4, 2015 at 2:20 PM, Andi Kleen wrote: > Hi Honza, > > Regarding modern hash functions, as far as I understand the trend > is to just stop doing anything fancy and just use the CRC instructions > in modern CPUs I wonder if we can use intrinsics for CRC in place of the existing iterativ

Re: [PATCH] target/65286 - Disable multilib for ppc64le

2015-03-04 Thread Andreas Schwab
Martin Sebor writes: > The attached patch resolves PR 65286 by adding --disable-multilib > when configuring for a ppc64le target. If powerpc64le doesn't want multilib it should not set any multilib parameters. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BA

[PATCH] Fix PR65310

2015-03-04 Thread Richard Biener
This fixes a wrong-code bug in vectorization which extracts alignment from something not (enough) related to the original memory reference in the IL. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2015-03-04 Richard Biener PR tree-optimization/65310

[PATCH] Fix PR65270 some more

2015-03-04 Thread Richard Biener
The following two patches should address all issues regarding to alias analysis, restrict and ICF. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2015-03-04 Richard Biener PR ipa/65270 * ipa-icf-gimple.c (func_checker::compare_memory_operand):

Re: [patch/committed] PR middle-end/65233 make walk-ssa_copies handle empty PHIs

2015-03-04 Thread Richard Biener
On Wed, Mar 4, 2015 at 1:41 PM, Richard Biener wrote: > On Wed, Mar 4, 2015 at 6:27 AM, Jeff Law wrote: >> On 03/02/15 01:38, Richard Biener wrote: >>> >>> On Mon, Mar 2, 2015 at 6:34 AM, Aldy Hernandez wrote: As I mention in the PR... What's happening here is that the ipa_po

Re: [PATCH] target/65286 - Disable multilib for ppc64le

2015-03-04 Thread Segher Boessenkool
On Tue, Mar 03, 2015 at 05:59:07PM -0700, Martin Sebor wrote: > The attached patch resolves PR 65286 by adding --disable-multilib > when configuring for a ppc64le target. Why? The PR does not say; it suggests there is an error somewhere that configuring with --disable-multilib papers over. Segh

Re: Strengthen ICF hash

2015-03-04 Thread Andi Kleen
Hi Honza, Regarding modern hash functions, as far as I understand the trend is to just stop doing anything fancy and just use the CRC instructions in modern CPUs (unless you need a somewhat cryto hash to guard against DoS attacks). spooky doesn't do that though, it's just a highly optimized classi

Re: [PATCH] Workaround -Wmaybe-uninitialized false positives during profiledbootstrap

2015-03-04 Thread Martin Liška
On 01/27/2015 01:31 PM, Martin Liška wrote: On 01/27/2015 05:23 AM, DJ Delorie wrote: +/* Workaround -Wstrict-overflow false positive during profiledbootstrap. */ + +# if GCC_VERSION >= 4004 +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wstrict-overflow" +#endif + #pragma dia

Re: [PATCH][AArch64] Use conditional negate for abs expansion

2015-03-04 Thread Maxim Kuvyrkov
> On Mar 4, 2015, at 3:30 PM, Wilco Dijkstra wrote: > >> Maxim Kuvyrkov wrote: >> >> You are removing the 2nd alternative that generates "abs" with your patch. >> While I agree that >> using "csneg" is faster on all implementations, can you say the same for >> "abs"? Especially >> given the

Re: [patch/committed] PR middle-end/65233 make walk-ssa_copies handle empty PHIs

2015-03-04 Thread Richard Biener
On Wed, Mar 4, 2015 at 6:27 AM, Jeff Law wrote: > On 03/02/15 01:38, Richard Biener wrote: >> >> On Mon, Mar 2, 2015 at 6:34 AM, Aldy Hernandez wrote: >>> >>> As I mention in the PR... >>> >>> What's happening here is that the ipa_polymorphic_call_context >>> constructor >>> is calling walk_ssa_c

RE: [PATCH][AArch64] Use conditional negate for abs expansion

2015-03-04 Thread Wilco Dijkstra
> Maxim Kuvyrkov wrote: > > You are removing the 2nd alternative that generates "abs" with your patch. > While I agree that > using "csneg" is faster on all implementations, can you say the same for > "abs"? Especially > given the fact that csneg requires 4 operands instead of abs'es 2? Yes, g

RE: [Patch,microblaze]: Optimized usage of fint instruction.

2015-03-04 Thread Ajit Kumar Agarwal
-Original Message- From: Michael Eager [mailto:ea...@eagerm.com] Sent: Thursday, February 26, 2015 4:33 AM To: Ajit Kumar Agarwal; GCC Patches Cc: Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re: [Patch,microblaze]: Optimized usage of fint instruction

[PATCH][ARM][stage-1] Use correct scheduling type for rbit instruction

2015-03-04 Thread Kyrill Tkachov
Hi all, This obvious patch changes the type of the rbit instruction to 'rbit' rather than clz. Tested arm-none-linux-gnueabihf. P.S. The pipeline descriptions we have handle rbit, except marvell-pj4.md but that one doesn't handle the current 'clz' type either, so it will have not have a cod

[PATCH][AArch64][stage-1] Fix type of *_one_cmpl_3 pattern

2015-03-04 Thread Kyrill Tkachov
Hi all, This pattern doesn't set condition flags, so it shouldn't have the logics_shift_imm type but rather logic_shift_imm. Tested aarch64-none-elf. Ok for next stage 1? 2015-03-04 Kyrylo Tkachov * config/aarch64/aarch64.md (*_one_cmpl_3): Change type attr to logic_shift_imm.com

[PATCH] [ARM] PR45701 testcase fix.

2015-03-04 Thread Alex Velenko
Hi, This patch fixes arm pr45701 scan assembly tests. Those test register r3 being used to maintain stack double word alignment. Recent optimizations reduced number of local variables needed in those tests, removing necessity to push r3. Testcase fixed by adding additional local variable. Is patc

[PATCH] [RTL] Relax CSE check to set REG_EQUAL notes.

2015-03-04 Thread Alex Velenko
Hi, This patch permits CSE to add REG_EQUAL notes when single setting a constant to a register even if REG_EQUAL constant rtx is the same as the set source rtx. This enables optimizations in later passes looking for REG_EQUAL notes, like jump2 pass. For example, in arm testcase pr43920-2.c, CSE p

Re: [PATCH][simplify-rtx] PR 65235: Calculate element size correctly when simplifying (vec_select (vec_concat (const_int) (...)) [...])

2015-03-04 Thread Kyrill Tkachov
On 04/03/15 10:41, Marc Glisse wrote: On Wed, 4 Mar 2015, Kyrill Tkachov wrote: Hi all, This patch fixes PR rtl-optimization 65235. As mentioned in bugzilla: Combine tries to combine: (insn 72 71 73 2 (set (reg:V2DI 117 [ D.18177 ]) (vec_concat:V2DI (reg:DI 176 [ D.18179 ])

Re: [PATCH][simplify-rtx] PR 65235: Calculate element size correctly when simplifying (vec_select (vec_concat (const_int) (...)) [...])

2015-03-04 Thread Marc Glisse
On Wed, 4 Mar 2015, Kyrill Tkachov wrote: Hi all, This patch fixes PR rtl-optimization 65235. As mentioned in bugzilla: Combine tries to combine: (insn 72 71 73 2 (set (reg:V2DI 117 [ D.18177 ]) (vec_concat:V2DI (reg:DI 176 [ D.18179 ]) (reg:DI 114 [ D.18168 ]))) (expr_li

[Ada] Wrong runtime check on function returning interface type

2015-03-04 Thread Arnaud Charlet
For functions returning class-wide interface types the compiler may generate erroneous code implementing the Ada rule 6.5(8/3), thus causing an unexpected exception at runtime. After this patch the following test compiles and executes without errors. package Ifaces is type Iface is limited int

[Patch] OPT: Update heuristics for loop-invariant for address arithmetic.

2015-03-04 Thread Ajit Kumar Agarwal
Hello All: The changes are made in the patch to update the heuristics for loop invariant for address arithemetic at RTL Level. The heuristics are updated with the consideration of single def and use for register pressure calculation instead Of ignoring it and also to update the estimated regis

[Ada] Bounded string slice fails when passed superflat bounds

2015-03-04 Thread Arnaud Charlet
If a bounded string slice operation has a lower bound less than the higher bound minus one, the resulting length can be negative leading to failures and exceptions. The following must compile and execute cleanly: 1. with Ada.Strings.Bounded; use Ada.Strings.Bounded; 2. with Ada.Text_IO;

[Ada] Syntax error detection on Ghost abstract states

2015-03-04 Thread Arnaud Charlet
This patch modifies the analysis of pragma Abstract_State to detect a syntax error related to a state with a simple option. -- Source -- -- malformed_state.ads package Malformed_State with SPARK_Mode, Abstract_State => (State1, State2 => Ghost) is end Malforme

[Ada] Spurious runtime failure on Default_Initial_Condition

2015-03-04 Thread Arnaud Charlet
This patch ensures that the expression of pragma Default_Initial_Condition is verified against an object with default initialization. -- Source -- -- dic_pack.ads generic type Element_Typ is private; No_Element : Element_Typ; package DIC_Pack is type List (Ca

Re: ipa-icf::merge TLC

2015-03-04 Thread James Greenhalgh
On Sat, Feb 28, 2015 at 06:08:33PM +, Jan Hubicka wrote: > > > > Hi Honza, > > > > This is more a note for other interested AArch64 testers, but this patch > > breaks some tests on aarch64-none-elf. Looking at the test output, this > > is a problem with the tests than with your patch. We now

[PATCH][simplify-rtx] PR 65235: Calculate element size correctly when simplifying (vec_select (vec_concat (const_int) (...)) [...])

2015-03-04 Thread Kyrill Tkachov
Hi all, This patch fixes PR rtl-optimization 65235. As mentioned in bugzilla: Combine tries to combine: (insn 72 71 73 2 (set (reg:V2DI 117 [ D.18177 ]) (vec_concat:V2DI (reg:DI 176 [ D.18179 ]) (reg:DI 114 [ D.18168 ]))) (expr_list:REG_DEAD (reg:DI 176 [ D.18179 ])

Re: [PATCH][AArch64] Use conditional negate for abs expansion

2015-03-04 Thread Maxim Kuvyrkov
> On Mar 3, 2015, at 7:19 PM, Wilco Dijkstra wrote: > > Expand abs into a compare and conditional negate. This is the most obvious > expansion, enables > merging of the comparison into ALU instructions and is faster on all > implementations. > Bootstrapped & > regression tested. > > int f(i

Re: ipa-icf::merge TLC

2015-03-04 Thread Christophe Lyon
On 3 March 2015 at 21:01, Jan Hubicka wrote: >> > Hi, >> > >> > I built with r221117. I see errors while building following targets: >> > aarch64_be-none-linux-gnu, aarch64_be-none-linux-gnu, >> > arm-none-linux-gnueabihf, arm-none-linux-gnueabi. >> >> Indeed, it's broken again since r221099. > >

RE: [PATCH, GCC, stage1] Fallback to copy-prop if constant-prop not possible

2015-03-04 Thread Thomas Preud'homme
Ping? > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Thomas Preud'homme [SNIP] > > > > Likewise for the REG_P and ">= FIRST_PSEUDO_REGISTER" tests here > > (with > > the equivalent and IMHO preferable HARD_REGISTER_P test in > > find_avail_set()). >

Re: [PATCH][ARM]Automatically add -mthumb for thumb-only target when mode isn't specified

2015-03-04 Thread Maxim Kuvyrkov
> On Mar 4, 2015, at 5:46 AM, Terry Guo wrote: > > On Wed, Mar 4, 2015 at 10:44 AM, Terry Guo wrote: >> On Mon, Mar 2, 2015 at 9:08 PM, Maxim Kuvyrkov >> wrote: On Mar 2, 2015, at 4:44 AM, Terry Guo wrote: Hi there, If target mode isn't specified via either gcc confi

Re: [PATCH] ASan on unaligned accesses

2015-03-04 Thread Andrew Pinski
On Wed, Mar 4, 2015 at 12:00 AM, Marat Zakirov wrote: > Hi all! > > Here is the patch which forces ASan to work on memory access without proper > alignment. it's useful because some programs like linux kernel often cheat > with alignment which may cause false negatives. This patch needs additional

[PATCH] ASan on unaligned accesses

2015-03-04 Thread Marat Zakirov
Hi all! Here is the patch which forces ASan to work on memory access without proper alignment. it's useful because some programs like linux kernel often cheat with alignment which may cause false negatives. This patch needs additional support for proper work on unaligned accesses in global da