Re: [PATCH] Use x{v,}asprintf some more

Uros Bizjak writes: > Hello! > > This patch uses x{v,}asprintf where the result of the function is unused. I would be careful with it. Some old glibc versions have an asprintf that corrupts memory. If you do this force the libiberty version unconditionally. -Andi -- a...@linux.intel.com -- Sp

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

On 22 Dec 12:48, Thomas Schwinge wrote: > What is the reason for adding paths if $tgt_dir is empty? (I mean, if > properly installed and $tgt_dir empty, this should just work, because > that's what a user will be doing, so why does the libgomp testsuite have > to do differently?) The case for emp

Re: [GOOGLE] Make LIPO aux function removal consistent

Ok (perhaps merge DECL_EXTERNAL and cgraph_is_aux_decl_external checks together). David On Mon, Dec 22, 2014 at 4:57 PM, Teresa Johnson wrote: > Ping. > Teresa > > On Fri, Dec 19, 2014 at 5:40 PM, Teresa Johnson wrote: >> Passes regression tests, ok for google 4_9? >> >> Thanks, >> Teresa >> >

PATC: PR target/64409: ICE building Mesa 10.4.0 for x32 ABI

There is no counter part of x32 in MS ABI. Issue an error when ms_abi attribute is used with x32. OK for trunk and branches? Thanks. H.J. --- gcc/ PR target/64409 * config/i386/i386.c (ix86_function_type_abi): Issue an error when ms_abi attribute is used with x32. gc

Re: [PATCH] X86-64: Add -mskip-rax-setup

On Thu, Dec 25, 2014 at 9:07 PM, Gerald Pfeifer wrote: > On Thursday 2014-12-18 11:35, H.J. Lu wrote: >> Updated. > > "the RAX register" (i.e., add "the"), and I suggest to make > this a sentence, similar to my previous mail for the other > update. > > This is fine with these changes. Done. > Th

Re: PATCH: PR target/61296: Excessive alignment in ix86_data_alignment

On Thu, Dec 25, 2014 at 8:56 PM, Gerald Pfeifer wrote: > On Wednesday 2014-12-17 06:49, H.J. Lu wrote: >> Index: gcc-5/changes.html >> === >> RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v >> retrieving revision 1.52 >> diff -

Re: OMP builtins in offloading (was: [PATCH 1/4] Add mkoffload for Intel MIC)

On 22 Dec 12:26, Jakub Jelinek wrote: > On Mon, Dec 22, 2014 at 12:20:58PM +0100, Thomas Schwinge wrote: > > What is the reason that you're adding -fopenmp here? I assume it is that > > otherwise you'd get tree streaming errors because of different builtins > > configurations, like this? > > > >

[PATCH] Use x{v,}asprintf some more

Hello! This patch uses x{v,}asprintf where the result of the function is unused. 2014-12-26 Uros Bizjak * diagnostic.c (build_message_string): Use xvasprintf. * final.c (output_operand_lossage): Use xvasprintf and xasprintf. * lto-wrapper.c (merge_and_complain): Use xasprintf.