[PATCH 4.8] libstdc++ pretty-printers: Backport Python 3 support from mainline

2014-08-12 Thread Samuel Bronson
This was a bit trickier than the backport to 4.9: but the tests pass, except this one: UNSUPPORTED: libstdc++-prettyprinters/shared_ptr.cc This is a bit puzzling, but seems unrelated to my change. 2014-08-13 Samuel Bronson Backport r212453 from trunk 2014-07-11 Samuel Bron

Re: PING – Re: [Patch, Fortran] -fcoarray=lib - support CRITICAL, prepare for locking support

2014-08-12 Thread Tobias Burnus
*PING**2 Tobias PS: Now being back from vacation, I will try to review pending patches this evening. On 6 August 2014 08:46, Tobias Burnus wrote: * PING * – of the patch with the obvious change mentioned by Alessandro (i.e. using "if(is_lock_type)")? Tobias On 1 August 2014 21:57, Alessan

[PATCH] cygwin: fix --tsaware, add --large-address-aware

2014-08-12 Thread Yaakov Selkowitz
This patch fixes two issues with LINK_SPEC on Cygwin targets: 1) --tsaware makes sense only for EXEs, not DLLs. 2) Under WoW64 (32-bit Cygwin on 64-bit Windows), Cygwin applications can access up to 4 GiB of address space (for DLLs, Cygwin heap, mmap()s, etc.) if they are linked with --large-a

Re: [PATCH 026/236] bb_note returns a rtx_note *

2014-08-12 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * basic-block.h (bb_note): Strengthen return type from rtx to rtx_note *. * sched-int.h (bb_note): Likewise. * cfgrtl.c (bb_note): Likewise. Add a checked cast to rtx_note *. OK. Jeff

Re: [PATCH 027/236] asan_emit_stack_protection returns an insn

2014-08-12 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * asan.h (asan_emit_stack_protection): Strengthen return type from rtx to rtx_insn *. * asan.c (asan_emit_stack_protection): Likewise. Add local "insns" to hold the return value. OK. Jeff

Re: [PATCH] Add -ffat-lto-objects to gcc.dg/torture/pr61772.c

2014-08-12 Thread Jeff Law
On 08/07/14 08:58, Kyrill Tkachov wrote: Hi all, This test in the torture suite fails on -flto because it scans for a sentinel string inside an asm block that it wants to make sure is not optimised away. However, with -flto gcc uses slim LTO objects which contain a binary representation of the s

Re: [PATCH 025/236] make_insn_raw returns an rtx_insn

2014-08-12 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: Doing so means strengthening the types of the make_raw callbacks within emit-rtl.c from rtx to rtx_insn * as used by the emit_pattern_* internal functions. There's more that could be done in terms of the params to these functions, but we'll save that for l

Re: [PATCH 024/236] last_call_insn returns an rtx_call_insn *

2014-08-12 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * emit-rtl.c (last_call_insn): Strengthen return type from rtx to rtx_call_insn *. * rtl.h (is_a_helper ::test): New overload, accepting an rtx_insn *. (last_call_insn): Strengthen return type from rtx to

Re: [PATCH 022/236] Make tablejump_p accept a rtx_jump_table_data **

2014-08-12 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * rtl.h (tablejump_p): Strengthen third param from rtx * to rtx_jump_table_data **. * cfgbuild.c (make_edges): Introduce local "table", using it in place of "tmp" for jump table data. (find_bb_boundaries): Stren

Re: [PATCH 023/236] delete_trivially_dead_insns works on insns

2014-08-12 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * rtl.h (delete_trivially_dead_insns): Strengthen initial param "insns" from rtx to rtx_insn *. * cse.c (delete_trivially_dead_insns): Likewise, also do it for locals "insn" and "prev". OK. Jeff

Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.

2014-08-12 Thread Chen Gang
On 8/12/14 4:20, Chen Gang wrote: > On 08/10/2014 04:22 PM, Chen Gang wrote: >> >> I guess, I find the root cause: >> I have given the test, if remove the hardcoded "--disable-core-jni" from libjava/configure, we can let "JNIDIR" enabled. So I am sure, it must be the root cause. Thanks. > >

Re: [C PATCH] Discard P - (P + CST) optimization in pointer_diff (PR c/61240)

2014-08-12 Thread DJ Delorie
> Ah, cool, I didn't know all that was in. Well, the precision part is in, but the __intN part isn't yet. Each time I do a "final" check for regressions, something new has been added to gcc which breaks it all again... :-P

Re: [patch,gomp4] make fortran loop variables implicitly private in openacc

2014-08-12 Thread Cesar Philippidis
On 08/11/2014 04:55 PM, Cesar Philippidis wrote: > According to section 2.6.1 in the openacc spec, fortran loop variables > should be implicitly private like in openmp. This patch does just so. > Also, while working on this patch, I noticed that I made the check for > variables appearing in multipl

Re: [PATCH, Cilk+] Fix for PR62008

2014-08-12 Thread Jeff Law
On 08/07/14 16:06, Zamyatin, Igor wrote: Hi! Following patch adds necessary handling of the cases with incorrect type of an array in ArrayNotation and thus avoids ICE. Regtested on x86_64. Ok for trunk/4.9? Thanks, Igor gcc/c/ChangeLog: 2014-08-07 Igor Zamyatin PR other/62008

Re: [C PATCH] Discard P - (P + CST) optimization in pointer_diff (PR c/61240)

2014-08-12 Thread Jeff Law
On 08/06/14 13:45, DJ Delorie wrote: That's one of the things that would be largely made irrelevant by DJ's proposed changes. Instead of using PSImode, What’s PSImode? PSImode is a mode with more precision than HImode, but less than SImode. we'd be able to define modes of precisely the num

Re: [PATCH 017/236] Add subclasses for the various kinds of instruction

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: gcc/ * coretypes.h (class rtx_real_insn): Add forward declaration. (class rtx_debug_insn): Likewise. (class rtx_nonjump_insn): Likewise. (class rtx_jump_insn): Likewise. (class rtx_call_insn): Likewise. (class

Re: [PATCH 021/236] entry_of_function returns an insn

2014-08-12 Thread Jeff Law
On 08/06/14 11:20, David Malcolm wrote: gcc/ * rtl.h (entry_of_function): Strengthen return type from rtx to rtx_insn *. * cfgrtl.c (entry_of_function): Likewise. OK. Jeff

Re: RFC: Patch for switch elimination (PR 54742)

2014-08-12 Thread Bin.Cheng
On Wed, Aug 13, 2014 at 4:40 AM, Jeff Law wrote: > On 08/12/14 14:23, Richard Biener wrote: >> >> On August 12, 2014 8:31:16 PM CEST, Jeff Law wrote: >>> >>> On 08/12/14 11:46, Steve Ellcey wrote: After talking to Jeff Law at the GCC Cauldron I have updated my >>> >>> switch s

Re: [PATCH 001/236] Convert lab_rtx_for_bb from pointer_map_t to pointer_map

2014-08-12 Thread Jeff Law
On 08/12/14 18:45, David Malcolm wrote: On Tue, 2014-08-12 at 17:15 -0400, Trevor Saunders wrote: On Tue, Aug 12, 2014 at 02:50:39PM -0600, Jeff Law wrote: On 08/06/14 11:19, David Malcolm wrote: This gives a slight improvement in typesafety in cfgexpand.c gcc/ * cfgexpand.c (lab_rtx_

Re: [PATCH AArch64 3/3] Fix XOR_one_cmpl pattern; add SIMD-reg variants for BIC,ORN,EON

2014-08-12 Thread Kugan
On 13/08/14 00:55, Alan Lawrence wrote: > ...patch attached... > > Alan Lawrence wrote: >> [When I wrote that xor was broken on GPRs and this fixes it, I meant >> xor_one_cmpl rather than xor, sorry!] >> >> The pattern for xor_one_cmpl never matched, due to the action of >> combine_simplify_rtx;

Re: [PATCH 001/236] Convert lab_rtx_for_bb from pointer_map_t to pointer_map

2014-08-12 Thread David Malcolm
On Tue, 2014-08-12 at 17:15 -0400, Trevor Saunders wrote: > On Tue, Aug 12, 2014 at 02:50:39PM -0600, Jeff Law wrote: > > On 08/06/14 11:19, David Malcolm wrote: > > >This gives a slight improvement in typesafety in cfgexpand.c > > > > > >gcc/ > > > * cfgexpand.c (lab_rtx_for_bb): Convert from po

Re: [PATCH 000/236] Introduce rtx subclasses

2014-08-12 Thread David Malcolm
On Tue, 2014-08-12 at 14:39 -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > > > > The aim of the patch series is to improve the type-safety and > > readability of the backend by introducing subclasses of rtx (actually > > rtx_def) for *instructions*, and also for EXPR_LIST, INSN_

Re: RFC: Patch for switch elimination (PR 54742)

2014-08-12 Thread Steve Ellcey
On Tue, 2014-08-12 at 14:40 -0600, Jeff Law wrote: > On 08/12/14 14:23, Richard Biener wrote: > > On August 12, 2014 8:31:16 PM CEST, Jeff Law wrote: > >> Try setting the header & latch fields for the loop structure to NULL, > >> then call loops_set_state (LOOPS_NEED_FIXUP). > > > > But that is _n

Re: [PATCH 020/236] Return rtx_insn from get_insns/get_last_insn

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: Ultimately, the underlying fields should become rtx_insn *, but for now we can do this with a checked cast. Note to self: config/m32c/m32c.c: m32c_leaf_function_p directly manipulates x_first_insn and x_last_insn, using sequence_stack. gcc/

Re: [PATCH 019/236] Strengthen return type of gen_label_rtx

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: gcc/ * rtl.h (gen_label_rtx): Strengthen return type from rtx to rtx_code_label *. * emit-rtl.c (gen_label_rtx): Likewise. Presumably at some point we'll look at the gen_XXX and split out those which return items for the chain

Re: [PATCH 018/236] Strengthen return types of various {next|prev}_*insn from rtx to rtx_insn *

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: These should all eventually require an rtx_insn * as an argument, but we'll save that for a later patch. gcc/ * rtl.h (previous_insn): Strengthen return type from rtx to rtx_insn *. (next_insn): Likewise. (prev_nonnote_insn)

Re: [PATCH, C/C++] Add -fno-float to forbid floating point data types

2014-08-12 Thread Hans-Peter Nilsson
On Tue, 12 Aug 2014, Thomas Preud'homme wrote: > As mentioned in PR60070, there is many cases when a programmer want to ensure > that a program does not use any floating point data type. Other cases to > consider > is when a target has several floating point ABI and user want to ensure > his/her

Re: [PATCH] Fix cygwin-stdint.h

2014-08-12 Thread Kai Tietz
2014-08-12 22:00 GMT+02:00 Yaakov Selkowitz : > This patch fixes an error in r197168 where type definitions were made > dependent on the host architecture instead of the target. This causes > cross-compilation issues, particularly in a --host=x86_64-* > --target=i686-pc-cygwin configuration. > > A

Re: Patch for constexpr variable templates

2014-08-12 Thread Jason Merrill
On 08/12/2014 05:17 PM, Andrew Sutton wrote: Oohh... I can commit to trunk? Yes, you're on the write-after-approval list in MAINTAINERS. :) Jason

Re: [PATCH 212/236] Use rtx_expr_list for expr_status.x_forced_labels

2014-08-12 Thread Jeff Law
On 08/07/14 05:32, Bernd Schmidt wrote: On 08/06/2014 07:23 PM, David Malcolm wrote: diff --git a/gcc/function.h b/gcc/function.h index 28a20f3..ba7597c 100644 --- a/gcc/function.h +++ b/gcc/function.h @@ -135,7 +135,7 @@ struct GTY(()) expr_status { rtx x_apply_args_value; /* List of l

Re: [PATCH 016/236] BND_TO scaffolding

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: gcc/ * sel-sched-ir.h (BND_TO): insn_t will eventually be an rtx_insn *. To help with transition, for now, convert from an access macro into a pair of functions: BND_TO, returning an rtx_insn *, and... (SET_BND_TO):

Re: [PATCH 014/236] VINSN_INSN_RTX scaffolding

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: For now, convert into VINSN_INSN_RTX a pair of functions. We will eventually change them back to a macro once the relevant field is of type rtx_insn *. gcc/ * sel-sched-ir.h (VINSN_INSN_RTX): struct vinsn_def's "insn_rtx" field will eventu

Re: [PATCH 015/236] BB_NOTE_LIST scaffolding

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: gcc/ * sel-sched-ir.h (BB_NOTE_LIST): struct sel_region_bb_info_def's "note_list" field will eventually be an rtx_insn *. To help with transition, for now, convert from an access macro into a pair of functions: BB_NOTE_LIST,

Re: [PATCH 013/236] DEP_PRO/DEP_CON scaffolding

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: For now, convert DEP_PRO and DEP_CON into functions. We will eventually change them back to macros once the relevant fields are of type rtx_insn *. gcc/ * sched-int.h (DEP_PRO): struct _dep's "pro" and "con" fields will eventually be rtx_i

Re: [PATCH 011/236] Replace PREV_INSN et al macros with functions

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: Yet more scaffolding: convert the NEXT_INSN/PREV_INSN macros and their SET_* variants into functions. Convert the rvalue-style functions into returning rtx_insn * rather than plain rtx. For now, this is done by adding a checked cast, but I hope this can e

Re: [PATCH 012/236] Convert DF_REF_INSN to a function for now

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: DF_REF_INSN looks up the "insn" field of the referenced df_insn_info. This will eventually be an rtx_insn *, but for now is just an rtx. As further scaffolding: for now, convert DF_REF_INSN to a function, adding a checked downcast to rtx_insn *. This can

Re: Patch for constexpr variable templates

2014-08-12 Thread Andrew Sutton
Oohh... I can commit to trunk? I can do it tomorrow morning. Andrew Sutton On Tue, Aug 12, 2014 at 4:59 PM, Jason Merrill wrote: > On 08/12/2014 04:21 PM, Andrew Sutton wrote: * pt.c (lookup_template_variable): Make the type unspecified if any template ar

Re: [PATCH 010/236] Split NEXT_INSN/PREV_INSN into lvalue and rvalue forms

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: gcc/ * rtl.h (PREV_INSN): Split macro in two: the existing one, for rvalues, and... (SET_PREV_INSN): New macro, for use as an lvalue. (NEXT_INSN, SET_NEXT_INSN): Likewise. * caller-save.c (save_call_clobbered_regs):

Re: [PATCH 009/236] Replace BB_HEAD et al macros with functions

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: This is further scaffolding; convert the BB_* and SET_BB_* macros into functions. Convert the BB_* rvalue-style functions into returning rtx_insn * rather than plain rtx. For now, this is done by adding a checked cast, but this will eventually become a fi

Re: [PATCH 001/236] Convert lab_rtx_for_bb from pointer_map_t to pointer_map

2014-08-12 Thread Trevor Saunders
On Tue, Aug 12, 2014 at 02:50:39PM -0600, Jeff Law wrote: > On 08/06/14 11:19, David Malcolm wrote: > >This gives a slight improvement in typesafety in cfgexpand.c > > > >gcc/ > > * cfgexpand.c (lab_rtx_for_bb): Convert from pointer_map_t to > > pointer_map. > > (label_rtx_for_bb): Upda

Re: [PATCH 008/236] Split BB_HEAD et al into BB_HEAD/SET_BB_HEAD variants

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: This is an enabling patch, splitting existing macros in two, covering the rvalue and lvalue uses separately. Followup patches will replace these with functions, and gradually convert the types from rtx to rtx_insn *, but we need to do this separately for t

Re: [PATCH] Fix find_inc in the scheduler (PR target/62025)

2014-08-12 Thread Vladimir Makarov
On 08/12/2014 03:35 PM, Jakub Jelinek wrote: > Hi! > > As detailed in the PR, find_inc ignored any possible clobbers on > inc_insn (typically %cc/flags/etc. register) and thus we could ignore > all register dependencies between mem_insn and inc_insn even when > we could only safely ignore the mem_r

Re: [PATCH 007/236] New function: for_each_rtx_in_insn

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: gcc/ * rtl.h (for_each_rtx_in_insn): New function. * rtlanal.c (for_each_rtx_in_insn): Likewise. OK. Note that we're moving away from for_each_rtx... I haven't looked, but there's a reasonable chance we may not need it after Richard S.'

Re: [PATCH 006/236] Introduce rtx_insn subclass of rtx_def

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: gcc/ * coretypes.h (class rtx_insn): Add forward declaration. * rtl.h: Include is-a.h (struct rtx_def): Add dummy "desc" and "tag" GTY options as a workaround to ensure gengtype knows inheritance is occurring, whilst

Re: [PATCH 005/236] Introduce as_a_nullable

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: In many circumstances, is_a_helper ::test assumes that the pointer is non-NULL, but sometimes you have a pointer of type T that can be NULL. Earlier versions of this patch kit made numerous uses of the ternary operator to handle nullable pointers e.g.:

Re: Patch for constexpr variable templates

2014-08-12 Thread Jason Merrill
On 08/12/2014 04:21 PM, Andrew Sutton wrote: * pt.c (lookup_template_variable): Make the type unspecified if any template arguments are dependent. This hunk is OK. Hi Jason, did you apply this hunk of the patch, or should I just resend this by itself? I thought you woul

Re: [PATCH, PR61776] verify_flow_info failed: control flow in the middle of basic block with -fprofile-generate

2014-08-12 Thread Wei Mi
Ping. On Sun, Jul 27, 2014 at 11:08 PM, Wei Mi wrote: >> But fact is that it is _not_ necessary to split the block because there >> are no outgoing abnormal edges from it. >> >> The verifier failure is an artifact from using the same predicates during >> CFG building and CFG verifying (usually ok

Re: [PATCH 004/236] PHASE 1: Initial "scaffolding" commits

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: This commit is a placeholder for me when rebasing, to help organize the patch kit. / * rtx-classes-status.txt: New file OK. For those who may be watching, patch #236 removes this file. jeff

Re: [PATCH 003/236] config/mn10300: Fix missing PATTERN in PARALLEL handling

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: gcc/ * config/mn10300/mn10300.c (mn10300_adjust_sched_cost): Fix the handling of PARALLEL to work on PATTERN (insn) and PATTERN (dep), rather than just on insn, dep themselves. The latter are insns, and thus can't be PARALLE

Re: [PATCH 002/236] JUMP_LABEL is not always a LABEL

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: gcc/ * rtl.h (JUMP_LABEL): Add a note that this isn't always a LABEL. Egad. I would assert that both combine & shrink-wrap shouldn't be doing that (without looking at either to see why they're doing what they're doing). Approved. Again, this p

Re: [PATCH 001/236] Convert lab_rtx_for_bb from pointer_map_t to pointer_map

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: This gives a slight improvement in typesafety in cfgexpand.c gcc/ * cfgexpand.c (lab_rtx_for_bb): Convert from pointer_map_t to pointer_map. (label_rtx_for_bb): Update for conversion of lab_rtx_for_bb to a pointer_map, elimi

Re: RFC: Patch for switch elimination (PR 54742)

2014-08-12 Thread Jeff Law
On 08/12/14 14:23, Richard Biener wrote: On August 12, 2014 8:31:16 PM CEST, Jeff Law wrote: On 08/12/14 11:46, Steve Ellcey wrote: After talking to Jeff Law at the GCC Cauldron I have updated my switch shortcut plugin pass to try and address this optimization in the hopes of getting it ad

Re: [PATCH 000/236] Introduce rtx subclasses

2014-08-12 Thread Jeff Law
On 08/06/14 11:19, David Malcolm wrote: The aim of the patch series is to improve the type-safety and readability of the backend by introducing subclasses of rtx (actually rtx_def) for *instructions*, and also for EXPR_LIST, INSN_LIST, SEQUENCE. That way we can document directly in the code the

Re: RFC: Patch for switch elimination (PR 54742)

2014-08-12 Thread Richard Biener
On August 12, 2014 8:31:16 PM CEST, Jeff Law wrote: >On 08/12/14 11:46, Steve Ellcey wrote: >> After talking to Jeff Law at the GCC Cauldron I have updated my >switch >> shortcut plugin pass to try and address this optimization in the >hopes of >> getting it added to GCC as a static pass. I fixed

Re: [PATCH 1/2] dwarf2out.c: Pass one cv_quals argument instead of two for const and volatile.

2014-08-12 Thread Jason Merrill
OK. Jason

Re: Patch for constexpr variable templates

2014-08-12 Thread Andrew Sutton
>> * pt.c (lookup_template_variable): Make the type unspecified if >> any template arguments are dependent. > > > This hunk is OK. Hi Jason, did you apply this hunk of the patch, or should I just resend this by itself? Andrew

Re: [PATCH 40/50] rtlanal.c:for_each_inc_dec

2014-08-12 Thread Jeff Law
On 08/09/14 04:13, Richard Sandiford wrote: Jeff Law writes: On 08/03/14 08:32, Richard Sandiford wrote: The old for_each_inc_dec callback had a for_each_rtx-like return value, with >0 being returned directly, 0 meaning "continue" and <0 meaning "skip subrtxes". But there's no reason to disti

[GSoC][match-and-simplify] add few constant-folding tests

2014-08-12 Thread Prathamesh Kulkarni
[gcc/testsuite/gcc.dg/tree-ssa] * match-constant-folding.c: New test-case. Thanks, Prathamesh Index: gcc/testsuite/gcc.dg/tree-ssa/match-constant-folding.c === --- gcc/testsuite/gcc.dg/tree-ssa/match-constant-folding.c (revision 0)

Re: [PATCH 2/2] DWARF5: Add DW_TAG_aligned_type support.

2014-08-12 Thread Jason Merrill
I'm dubious about adding a tag for alignment, because it doesn't participate in the type system; in C and C++, it's an attribute of a struct or variable declaration, but the variable has the same type as another variable without the explicit alignment. In the GNU extension it can also be appli

[PATCH] Fix cygwin-stdint.h

2014-08-12 Thread Yaakov Selkowitz
This patch fixes an error in r197168 where type definitions were made dependent on the host architecture instead of the target. This causes cross-compilation issues, particularly in a --host=x86_64-* --target=i686-pc-cygwin configuration. Attached patch was tested by comparing output of './gcc

Re: [patch] No allocation for empty unordered containers

2014-08-12 Thread François Dumont
On 12/08/2014 21:39, Marc Glisse wrote: On Tue, 12 Aug 2014, François Dumont wrote: Based on your feedbacks I think we should stay with just targeting good QoI by not allocating on default construction. As I said the noexcept qualification would need to not conform strictly to the Standard

Re: [patch] No allocation for empty unordered containers

2014-08-12 Thread Marc Glisse
On Tue, 12 Aug 2014, François Dumont wrote: Based on your feedbacks I think we should stay with just targeting good QoI by not allocating on default construction. As I said the noexcept qualification would need to not conform strictly to the Standard. The standard explicitly says that you

[PATCH] Fix find_inc in the scheduler (PR target/62025)

2014-08-12 Thread Jakub Jelinek
Hi! As detailed in the PR, find_inc ignored any possible clobbers on inc_insn (typically %cc/flags/etc. register) and thus we could ignore all register dependencies between mem_insn and inc_insn even when we could only safely ignore the mem_reg0 register dependency. Bootstrapped/regtested on x86_

Re: [PATCH 1/2] DWARFv5 Emit DW_TAG_atomic_type.

2014-08-12 Thread Jason Merrill
On 08/12/2014 11:35 AM, Mark Wielaard wrote: Ping. This patch is based on the proposed patches to support the restrict type. But isn't meant to be integrated at this time. DWARFv5 is still only a collection of proposals and hasn't seen any draft yet. But feedback is highly appreciated. Also if th

Re: [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-12 Thread Arnaud Charlet
> I don't know when I last built it but it has been broken for a while and > I didn't get a chance to track it down and submit patches. OK well as I said, as long as your change doesn't break other targets, that's OK. > I have had local patches but didn't like them. Ada is just a volunteer > act

Re: [PATCH 2/2] Emit DW_tag_restrict_type for restrict-qualified pointers.

2014-08-12 Thread Jason Merrill
OK. Jason

Re: [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-12 Thread Joel Sherrill
On 8/12/2014 2:22 PM, Arnaud Charlet wrote: >> It was in the rts Makefile back when it was under gcc. I suspect it >> disappeared when this >> all moved to libada. Could check the history if we need to. > Well, libada has been introduced many many years ago. Are you saying you > haven't built Ada

Re: [patch] No allocation for empty unordered containers

2014-08-12 Thread François Dumont
On 05/08/2014 22:23, Paolo Carlini wrote: Hi, On 08/05/2014 10:10 PM, Jonathan Wakely wrote: It doesn't have to be noexcept, but IMHO there is no point changing the containers to avoid allocation unless that allows us to mark it noexcept. If it can throw anyway, we might as well allocate the i

Re: [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-12 Thread Arnaud Charlet
> It was in the rts Makefile back when it was under gcc. I suspect it > disappeared when this > all moved to libada. Could check the history if we need to. Well, libada has been introduced many many years ago. Are you saying you haven't built Ada since then, or were using local patches? Arno

Re: [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-12 Thread Joel Sherrill
On 8/12/2014 12:33 PM, Arnaud Charlet wrote: >> This didn't get any comments earlier. Is it OK to comment? > This one is a bit tricky so requires more thoughts. On which targets did > you test it? native CentOS and sparc-rtems4.11. I don't have access to much else except *-rtems* which is basical

Re: [C PATCH] Diagnose predefined identifiers in pedantic mode

2014-08-12 Thread Marek Polacek
On Tue, Aug 12, 2014 at 05:46:09PM +, Joseph S. Myers wrote: > On Sun, 10 Aug 2014, Marek Polacek wrote: > > > We weren't properly diagnosing neither the __func__ (introduced in C99), > > nor the __FUNCTION__/__PRETTY_FUNCTION__ (GNU extension) predefined > > identifiers. I believe we should;

Re: [Patch] Enable libatomic for cygwin targets

2014-08-12 Thread Kai Tietz
2014-08-12 20:40 GMT+02:00 Yaakov Selkowitz : > The attached patch enabled libatomic for Cygwin targets. > > check-target-libatomic for i686-pc-cygwin: > > Running gcc/libatomic/testsuite/libatomic.c/c.exp ... > === libatomic Summary === > # of expected passes44 > # of u

[Patch] Enable libatomic for cygwin targets

2014-08-12 Thread Yaakov Selkowitz
The attached patch enabled libatomic for Cygwin targets. check-target-libatomic for i686-pc-cygwin: Running gcc/libatomic/testsuite/libatomic.c/c.exp ... === libatomic Summary === # of expected passes44 # of unsupported tests 5 check-target-libatomic results

Re: [PATCH] fix FTBFS with --target=i686-pc-cygwin

2014-08-12 Thread Kai Tietz
2014-08-12 20:34 GMT+02:00 Yaakov Selkowitz : > There is a syntax error in r213009 causing a FTBFS in trunk with > --target=i686-pc-cygwin. Patch attached, with which trunk now builds for > said target. > > -- > Yaakov Selkowitz > Associate Software Engineer, ARM > Red Hat, Inc. Patch is ok. Plea

[PATCH] fix FTBFS with --target=i686-pc-cygwin

2014-08-12 Thread Yaakov Selkowitz
There is a syntax error in r213009 causing a FTBFS in trunk with --target=i686-pc-cygwin. Patch attached, with which trunk now builds for said target. -- Yaakov Selkowitz Associate Software Engineer, ARM Red Hat, Inc. 2014-08-12 Yaakov Selkowitz * config/i386/cygming-crtbegin.c (de

Re: RFC: Patch for switch elimination (PR 54742)

2014-08-12 Thread Jeff Law
On 08/12/14 11:46, Steve Ellcey wrote: After talking to Jeff Law at the GCC Cauldron I have updated my switch shortcut plugin pass to try and address this optimization in the hopes of getting it added to GCC as a static pass. I fixed the code to build with the various C++ changes that have been

Re: [PATCH i386 AVX512] [8/n] Extend substs for new patterns.

2014-08-12 Thread Uros Bizjak
On Tue, Aug 12, 2014 at 2:58 PM, Kirill Yukhin wrote: > Hello, > This patch extends substs/subst_attrs to be used > with new patterns. > > Bootstrapped. > > Is it ok for trunk? In a couple of places, checks are changed to GET_MODE_SIZE (GET_MODE (operands[0])) and in a similar way, mode checks w

Re: [PATCH i386 AVX512] [7/n] Extend mask logic.

2014-08-12 Thread Uros Bizjak
On Tue, Aug 12, 2014 at 1:29 PM, Kirill Yukhin wrote: > This patch extends support of masking instructions. > > Bootstrapped. > > Is it ok for trunk? > > gcc/ > * config/i386/i386.md > (define_attr "isa"): Add avx512bw,noavx512bw. > (define_attr "enabled"): Ditto. >

Re: [PATCH mips] Do not compile mips16.S in soft-float mode

2014-08-12 Thread Eric Christopher
Thanks! -eric On Tue, Aug 12, 2014 at 8:33 AM, Steve Ellcey wrote: > On Tue, 2014-08-12 at 00:07 -0700, Eric Christopher wrote: >> >> >> >> -#ifdef __mips_micromips >> >> +#if defined(__mips_micromips) || defined(__mips_soft_float) >> >>/* DO NOTHING */ >> >> #else >> >> >> >> Mind adding a

Re: RFC: Patch for switch elimination (PR 54742)

2014-08-12 Thread Jakub Jelinek
On Tue, Aug 12, 2014 at 10:46:46AM -0700, Steve Ellcey wrote: > --- /dev/null > +++ b/gcc/tree-switch-shortcut.c > +/* This file implements an optimization where, when a variable is set > + to a constant value and there is a path that leads from this definition > + to a switch statement that us

Re: [PATCH i386 AVX512] [6/n] Update prefered modes for vectorizer.

2014-08-12 Thread Uros Bizjak
On Tue, Aug 12, 2014 at 12:49 PM, Kirill Yukhin wrote: > Hello, > Patch allows wider vec int modes. > > Bootstrapped. > > Is it ok for trunk? > > gcc/ > * config/i386/i386.c (ix86_preferred_simd_mode): Allow V64QImode and > V32HImode. OK. Thanks, Uros.

Re: [PATCH i386 AVX512] [5/n] Adjust register's availabilty, allow wider masks.

2014-08-12 Thread Uros Bizjak
On Tue, Aug 12, 2014 at 12:45 PM, Kirill Yukhin wrote: > Hello, > Attached patch allows wider mask types. > > Is it ok for trunk? > > Bootstrapped. > > gcc/ > * config/i386/i386.c (print_reg): Сorrectly print 64-bit mask > registers. > (inline_secondary_memory_needed): Allo

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-08-12 Thread Sylvestre Ledru
On 12/08/2014 19:48, Joseph S. Myers wrote: > On Mon, 11 Aug 2014, Sylvestre Ledru wrote: > >>> The test Wmissing-return2.c only has one of the two warnings. But as per >>> "-Wreturn-type => Run both", and for backwards compatibility with the >>> existing definition of -Wreturn-type, both warnin

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Jason Merrill
On 08/12/2014 01:10 PM, Manuel López-Ibáñez wrote: Wouldn't the folding that already occurs in the FEs prevent this anyway? Currently, probably. But we're planning to delay that folding for other reasons. In any case, we don't need to fix location info for constants/decls in order to fix l

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-08-12 Thread Joseph S. Myers
On Mon, 11 Aug 2014, Sylvestre Ledru wrote: > > The test Wmissing-return2.c only has one of the two warnings. But as per > > "-Wreturn-type => Run both", and for backwards compatibility with the > > existing definition of -Wreturn-type, both warnings should appear for this > > test. > Make s

Re: [C PATCH] Diagnose predefined identifiers in pedantic mode

2014-08-12 Thread Joseph S. Myers
On Sun, 10 Aug 2014, Marek Polacek wrote: > We weren't properly diagnosing neither the __func__ (introduced in C99), > nor the __FUNCTION__/__PRETTY_FUNCTION__ (GNU extension) predefined > identifiers. I believe we should; the compiler ought to have a > compile-time switch for turning off extensi

RFC: Patch for switch elimination (PR 54742)

2014-08-12 Thread Steve Ellcey
After talking to Jeff Law at the GCC Cauldron I have updated my switch shortcut plugin pass to try and address this optimization in the hopes of getting it added to GCC as a static pass. I fixed the code to build with the various C++ changes that have been happening in GCC but the current version

Re: [PATCH] Fix some typos

2014-08-12 Thread Marc Glisse
On Tue, 12 Aug 2014, Sylvestre Ledru wrote: The patch fixes some typos found by Lintian, the Debian static analyzer. Did you check them yourself? We end up with "these information" which doesn't seem correct to me. -- Marc Glisse

Re: [PATCH] Fix some typos

2014-08-12 Thread Arnaud Charlet
> gcc/ada/ChangeLog: > > 2014-08-12 Sylvestre Ledru > > * 9drpc.adb: Fix a typo > * s-interr.ads: Likewise > * s-taskin.ads: Likewise > * s-traces.ads: Likewise > * sysdep.c: Likewise The Ada part is OK.

Re: [PATCH 1/2] libada/Makefile.in: Add CFLAGS_FOR_TARGET to GNATLIBCFLAGS_FOR_C

2014-08-12 Thread Arnaud Charlet
> This didn't get any comments earlier. Is it OK to comment? This one is a bit tricky so requires more thoughts. On which targets did you test it? > Somewhere along the way, the Ada run-time Makefile's quit > honoring CFLAGS_FOR_TARGET. This just adds it back. > > 2014-08-12 Joel Sherrill > >

Re: [PATCH 2/2] gcc/ada/socket.c, gsocket.h: Add conditionals for RTEMS

2014-08-12 Thread Arnaud Charlet
> Hopefully this addresses the comments. > > OK to comment? > > 2014-08-12 Joel Sherrill > > * socket.c: For RTEMS, use correct prototype of gethostbyname_r(). > * gsocket.h Add include of on RTEMS. OK

[PATCH] Fix some typos

2014-08-12 Thread Sylvestre Ledru
Hello The patch fixes some typos found by Lintian, the Debian static analyzer. (it is mainly the opportunity to test my commit permissions). Thanks, Sylvestre libstdc++-v3/ChangeLog: 2014-08-12 Sylvestre Ledru * include/profile/impl/profiler_hash_func.h: Fix a typo gcc/fortran/Cha

Re: [PATCH] Demangler fuzzer

2014-08-12 Thread Ian Lance Taylor
On Tue, Aug 12, 2014 at 10:11 AM, Gary Benson wrote: > Ian Lance Taylor wrote: >> >> I think that by default the program should stop. That will make it >> possible to eventually run as part of "make check". Give it some >> number of iterations that stops it in a second or so. You can still >> h

Re: [PATCH] Demangler fuzzer

2014-08-12 Thread Gary Benson
Ian Lance Taylor wrote: > On Tue, Aug 12, 2014 at 2:02 AM, Gary Benson wrote: > > +#include > > Include demangle.h with "". Ok. > > +int > > +main (int argc, char *argv[]) > > +{ > > + char symbol[2 + MAXLEN + 1] = "_Z"; > > + int seed = -1, seed_set = 0; > > + int count = 0, maxcount = -1;

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Manuel López-Ibáñez
> On Tue, 12 Aug 2014, Jason Merrill wrote: > >> On 08/12/2014 11:09 AM, Marek Polacek wrote: >> > One possibility (and I think you mentioned this at Cauldron) would be to >> > create a new tree code, called e.g. LOCATION_EXPR. >> >> I don't think it needs a new code: I think we can use VIEW_CONVER

Re: [C++ patch] Reject virt-specifiers on friends and member templates

2014-08-12 Thread Jason Merrill
Applied, thanks. Jason

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Jason Merrill
On 08/12/2014 12:22 PM, Paolo Carlini wrote: why wrapping ("somebody" also suggested a NOP_EXPR at some point ;) instead of simply changing integer_cst & co to natively have a location?!? That also seems like a possibility, though I don't know to what extent different parts of the compiler rel

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Jason Merrill
On 08/12/2014 12:48 PM, Joseph S. Myers wrote: For C, it is definitely expected within the front end that anything that is an integer constant expression is an INTEGER_CST and that a NOP_EXPR wrapping an INTEGER_CST is something folded to an integer constant that is neither an integer constant ex

Re: [C++ PATCH] Improve location info [1/many]

2014-08-12 Thread Joseph S. Myers
On Tue, 12 Aug 2014, Jason Merrill wrote: > On 08/12/2014 11:09 AM, Marek Polacek wrote: > > One possibility (and I think you mentioned this at Cauldron) would be to > > create a new tree code, called e.g. LOCATION_EXPR. > > I don't think it needs a new code: I think we can use VIEW_CONVERT_EXPR

Re: [PATCH] Fix for PR62037

2014-08-12 Thread Felix Yang
Hi Richard, I find that you missed the testcase with when committing the patch. GCC 4.8 & 4.9 branch also has the same issue, may be we need to fix for them too? Cheers, Felix On Mon, Aug 11, 2014 at 7:24 PM, Richard Biener wrote: > On Sat, Aug 9, 2014 at 6:28 AM, Felix Yang wrote: >>

  1   2   >