Re: [PATCH] IPA REF: alias refactoring

2014-06-30 Thread Martin Liška
On 07/01/2014 12:21 AM, Jan Hubicka wrote: gcc/ChangeLog: * cgraph.h (iterate_direct_aliases): New function. (FOR_EACH_ALIAS): New macro iterates all direct aliases for a node. * cgraph.c (cgraph_for_node_thunks_and_aliases): Usage of FOR_EACH_ALIAS added. (cgraph_for_n

Re: [DOC Patch] Explicit Register Variables

2014-06-30 Thread David Wohlferd
On 6/30/2014 6:30 PM, Mike Stump wrote: On Jun 30, 2014, at 4:10 PM, David Wohlferd wrote: - Vague descriptions of things that "are reported" to work on certain platforms are not useful ("On the SPARC, there are reports that"). I'd disagree. But what's more important here is the registers th

Re: [Patch, testsuite]: Add MicroBlaze pattern for dg-function-on-line

2014-06-30 Thread Michael Eager
On 02/13/14 22:06, David Holsgrove wrote: Hi, Attached patch adds a MicroBlaze specific pattern for checking line number and generation of function in dg-function-on-line, in line with the mips method. Changelog/testsuite 2014-02-13 David Holsgrove * gcc/testsuite/lib/scanasm.exp (dg-func

Re: [Patch, microblaze]: Add optimized lshrsi3

2014-06-30 Thread Michael Eager
On 02/13/14 21:48, David Holsgrove wrote: Hi Michael, -Original Message- From: Michael Eager [mailto:ea...@eagerm.com] Sent: Sunday, 9 February 2014 2:58 am To: David Holsgrove; gcc-patches@gcc.gnu.org Cc: Edgar Iglesias; John Williams; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re:

Re: [PATCH, 2/10] prepare ccmp

2014-06-30 Thread Zhenqiang Chen
On 25 June 2014 22:41, Richard Earnshaw wrote: > On 23/06/14 07:57, Zhenqiang Chen wrote: >> Hi, >> >> The patch makes several functions global, which will be used when >> expanding ccmp instructions. >> >> The other change in this patch is to check CCMP when turning code into >> jumpy sequence. >

Re: [patch 1/4] change specific int128 -> generic intN

2014-06-30 Thread DJ Delorie
> If you find a particular use of TYPE_SIZE is using a size that isn't > correct for your type whose precision is not a multiple of > BITS_PER_UNIT, then in my model the correct fix is to change that > use of TYPE_SIZE rather than to change the value of TYPE_SIZE for > that type - and such a chang

Re: [PR 61424] std::regex matches right to left, not leftmost longest

2014-06-30 Thread Tim Shen
On Sat, Jun 28, 2014 at 2:45 AM, Jonathan Wakely wrote: > On 28/06/14 00:18 -0700, Tim Shen wrote: > Please put a space above this new function, otherwise it looks like > the "Dummy implementations" comment applies to this function, but in > fact that function is used for dfs mode. > > Similarly,

Update my email address

2014-06-30 Thread Tim Shen
Committed. -- Regards, Tim Shen commit 295f1677d75c28a4fda6bbc6652f7237c08276c0 Author: timshen Date: Tue Jul 1 01:46:57 2014 + * MAINTAINERS: Update my email address. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@212183 138bc75d-0d04-0410-961f-82ee72b054a4 diff

Re: [DOC Patch] Explicit Register Variables

2014-06-30 Thread Mike Stump
On Jun 30, 2014, at 4:10 PM, David Wohlferd wrote: > >>> - Vague descriptions of things that "are reported" to work on certain >>> platforms are not useful ("On the SPARC, there are reports that"). >> I'd disagree. But what's more important here is the registers that are >> available are a func

Re: [patch libstdc++] Add xmethods for std::vector and std::unique_ptr

2014-06-30 Thread Siva Chandra
On Mon, Jun 30, 2014 at 8:00 AM, Tom Tromey wrote: >> "Siva" == Siva Chandra writes: > > Siva> +# Load the xmethods. > Siva> +from libstdcxx.v6.xmethods import register_libstdcxx_xmethods > Siva> +register_libstdcxx_xmethods (gdb.current_objfile ()) > > I don't think any addition to the hook

Re: [GOOGLE] Report the difference between profiled and guessed or annotated branch probabilities.

2014-06-30 Thread Yi Yang
Fixed a style error (missing a space before a left parenthesis) On Mon, Jun 30, 2014 at 5:41 PM, Yi Yang wrote: > Done. > > On Mon, Jun 30, 2014 at 5:20 PM, Dehao Chen wrote: >> For get_locus_information, can you cal get_inline_stack and directly use its >> output to get the function name inste

Re: [GOOGLE] Report the difference between profiled and guessed or annotated branch probabilities.

2014-06-30 Thread Yi Yang
Done. On Mon, Jun 30, 2014 at 5:20 PM, Dehao Chen wrote: > For get_locus_information, can you cal get_inline_stack and directly use its > output to get the function name instead? > > Dehao > > > On Mon, Jun 30, 2014 at 4:47 PM, Yi Yang wrote: >> >> Removed fill_invalid_locus_information. Change

Re: [GOOGLE] Report the difference between profiled and guessed or annotated branch probabilities.

2014-06-30 Thread Yi Yang
Removed fill_invalid_locus_information. Change the function call to a return statement. On Mon, Jun 30, 2014 at 4:42 PM, Dehao Chen wrote: > There is no need for fill_invalid_locus_information, just initialize > every field to 0, and if it's unknown location, no need to output this > line. > > De

Re: [GOOGLE] Report the difference between profiled and guessed or annotated branch probabilities.

2014-06-30 Thread Dehao Chen
There is no need for fill_invalid_locus_information, just initialize every field to 0, and if it's unknown location, no need to output this line. Dehao On Mon, Jun 30, 2014 at 4:26 PM, Yi Yang wrote: > Instead of storing percentages of the branch probabilities, store them > times REG_BR_PROB_BAS

Re: [GOOGLE] Report the difference between profiled and guessed or annotated branch probabilities.

2014-06-30 Thread Yi Yang
Instead of storing percentages of the branch probabilities, store them times REG_BR_PROB_BASE. On Mon, Jun 30, 2014 at 3:26 PM, Yi Yang wrote: > Fixed. (outputting only the integer percentage) > > On Mon, Jun 30, 2014 at 2:20 PM, Yi Yang wrote: >> This is intermediate result, which is meant to b

Re: [DOC Patch] Explicit Register Variables

2014-06-30 Thread David Wohlferd
On 6/30/2014 2:01 PM, Jeff Law wrote: On 06/30/14 02:18, David Wohlferd wrote: I don't have permissions to commit this patch, but I do have a release on file with the FSF. Problem description: The text for using Explicit Register Variables is confusing, redundant, and fails to make certain ess

Re: [PATCH] Don't ICE with huge alignment (PR middle-end/60226)

2014-06-30 Thread Mike Stump
On Jun 30, 2014, at 3:40 PM, Mike Stump wrote: >> Is this still applicable after the wide-int changes? I haven't looked >> closely. Oops, forgot to state what I wanted to state… Yes, it still aborts post wide-int…

Re: [PATCH] Don't ICE with huge alignment (PR middle-end/60226)

2014-06-30 Thread Mike Stump
On Jun 30, 2014, at 12:50 PM, Jeff Law wrote: > On 03/04/14 09:40, Marek Polacek wrote: >> This should fix ICE on insane alignment. Normally, check_user_alignment >> detects e.g. alignment 1 << 32, but not 1 << 28. However, record_align >> is in bits, so it's actually 8 * (1 << 28) and that's gr

Make TYPE_DECLs public in common code

2014-06-30 Thread Jan Hubicka
Jason, this is non-C++ specific part where I needed updating. The i386.c change will need to be propagated into other backends. I also wonder if I should copy PUBLIC flag from component type in complex numbers - can we produce complex number from anonymous type? Finally type_in_anonymous_namespa

[C++] make TYPE_DECLs public for builtin type and templates

2014-06-30 Thread Jan Hubicka
Jason, I made a verifier that types not considered anonymous are not built from types that are anonymous and that public types have TREE_PUBLIC flag on their TYPE_DECLS (as that seem to be what tree.h says). This catches two cases in C++ FE and several other cases elsewhere. Does something like th

Re: [GOOGLE] Report the difference between profiled and guessed or annotated branch probabilities.

2014-06-30 Thread Yi Yang
Fixed. (outputting only the integer percentage) On Mon, Jun 30, 2014 at 2:20 PM, Yi Yang wrote: > This is intermediate result, which is meant to be consumed by further > post-processing. For this reason I'd prefer to put a number without > that percentage sign. > > I'd just output (int)(probabili

Re: [PATCH] IPA REF: alias refactoring

2014-06-30 Thread Jan Hubicka
> > gcc/ChangeLog: > > * cgraph.h (iterate_direct_aliases): New function. > (FOR_EACH_ALIAS): New macro iterates all direct aliases for a node. > * cgraph.c (cgraph_for_node_thunks_and_aliases): Usage of > FOR_EACH_ALIAS added. > (cgraph_for_node_and_aliases): Likewise. >

Re: Optimize type streaming

2014-06-30 Thread Jan Hubicka
> On June 29, 2014 9:53:03 PM CEST, Jan Hubicka wrote: > >> In addition of pr61644 and pr61646, this commit breaks a lot of > >> fortran tests with -flto -O0. > >Hello, > >the problem here is that we have POINTER_TYPE that points to array of > >variable > >length (not sure why it happens only with

[wwwdocs] /projects: make relative, simplify a reference

2014-06-30 Thread Gerald Pfeifer
Applied. Gerald Index: projects/cfg.html === RCS file: /cvs/gcc/wwwdocs/htdocs/projects/cfg.html,v retrieving revision 1.19 diff -u -r1.19 cfg.html --- projects/cfg.html 3 Dec 2013 01:04:42 - 1.19 +++ projects/cfg.html

Re: Warn when returning the address of a temporary (middle-end) v2

2014-06-30 Thread Marc Glisse
On Mon, 30 Jun 2014, Jeff Law wrote: On 06/29/14 03:22, Marc Glisse wrote: After looking at PR 61597, I updated the 2 conditions to: + if ((TREE_CODE (valbase) == VAR_DECL + && !is_global_var (valbase)) + || TREE_CODE (valbase) == PARM_DECL) a PARM_DECL is

Re: [GOOGLE] Report the difference between profiled and guessed or annotated branch probabilities.

2014-06-30 Thread Yi Yang
This is intermediate result, which is meant to be consumed by further post-processing. For this reason I'd prefer to put a number without that percentage sign. I'd just output (int)(probability*1+0.5). Does this look good for you? Or maybe change that to 100 since six digits are more t

Re: [PATCH] IPA REF: alias refactoring

2014-06-30 Thread Martin Liška
On 06/28/2014 08:49 AM, Jan Hubicka wrote: Hi, this patch enhances alias manipulation for symtab_node. Honza suggested following changes. Patch is pre approved, will be committed if no comments and regressions. Bootstrapped on x86_64-pc-linux-gnu, regression tests have been running. Than

Re: [GOOGLE] Report the difference between profiled and guessed or annotated branch probabilities.

2014-06-30 Thread Dehao Chen
Let's use %d to replace %f (manual conversion, let's do xx%). Dehao On Mon, Jun 30, 2014 at 2:06 PM, Yi Yang wrote: > Fixed. > > Also, I spotted some warnings caused by me using "%lf"s in snprintf(). > I changed these to "%f" and tested. > > > On Mon, Jun 30, 2014 at 1:49 PM, Dehao Chen wrote:

Re: [PATCH] Relax check against commuting XOR and ASHIFTRT in combine.c

2014-06-30 Thread Jeff Law
On 06/30/14 13:05, Alan Lawrence wrote: combine.c includes a check which prevents (ashiftrt (xor A C2) C1) from being commuted to (xor (ashiftrt A C1) (ashiftrt C2 C1)) for constants C1, C2 if C2 has its sign bit set. Specifically, this prevents (ashiftrt (not A) C1) from being commuted to

Re: [C PATCH] Add -Wint-conversion option

2014-06-30 Thread Gerald Pfeifer
On Mon, 30 Jun 2014, Jakub Jelinek wrote: > We don't have gcc-4.10/ directory, because the version of the next > release is still to be decided (hopefully at Cauldron next month). I'm a bit worried we'll miss entries in the meantime. Can we use gcc-4.10/ for now and rename later if we go for GCC

Re: [GOOGLE] Report the difference between profiled and guessed or annotated branch probabilities.

2014-06-30 Thread Yi Yang
Fixed. Also, I spotted some warnings caused by me using "%lf"s in snprintf(). I changed these to "%f" and tested. On Mon, Jun 30, 2014 at 1:49 PM, Dehao Chen wrote: > You don't need extra space to store file name in locus_information_t. > Use pointer instead. > > Dehao > > > On Mon, Jun 30, 201

Re: Warn when returning the address of a temporary (middle-end) v2

2014-06-30 Thread Jeff Law
On 06/29/14 03:22, Marc Glisse wrote: After looking at PR 61597, I updated the 2 conditions to: + if ((TREE_CODE (valbase) == VAR_DECL + && !is_global_var (valbase)) + || TREE_CODE (valbase) == PARM_DECL) a PARM_DECL is a local variable and returning its add

Re: [DOC Patch] Explicit Register Variables

2014-06-30 Thread Jeff Law
On 06/30/14 02:18, David Wohlferd wrote: I don't have permissions to commit this patch, but I do have a release on file with the FSF. Problem description: The text for using Explicit Register Variables is confusing, redundant, and fails to make certain essential information clear. Some specific

Re: [PATCH, alpha]: Wrap {un,}aligned_store sequence with memory blockages.

2014-06-30 Thread Uros Bizjak
On Mon, Jun 30, 2014 at 5:54 PM, Richard Henderson wrote: > On 06/29/2014 11:14 AM, Uros Bizjak wrote: >>if (MEM_READONLY_P (x)) >> +if (GET_CODE (mem_addr) == AND) >> + return 1; >> return 0; > > Certainly missing braces here. But with that fixed the patch looks plausible. > I

Re: [C PATCH] Add -Wint-conversion option

2014-06-30 Thread Jakub Jelinek
On Mon, Jun 30, 2014 at 10:51:59PM +0200, Gerald Pfeifer wrote: > Can you please add this and the other one to gcc-4.10/changes.html? > > I can provide help if you need any. We don't have gcc-4.10/ directory, because the version of the next release is still to be decided (hopefully at Cauldron ne

Re: [C PATCH] Add -Wint-conversion option

2014-06-30 Thread Gerald Pfeifer
Can you please add this and the other one to gcc-4.10/changes.html? I can provide help if you need any. Gerald

Re: [GOOGLE] Report the difference between profiled and guessed or annotated branch probabilities.

2014-06-30 Thread Dehao Chen
You don't need extra space to store file name in locus_information_t. Use pointer instead. Dehao On Mon, Jun 30, 2014 at 1:36 PM, Yi Yang wrote: > > I refactored the code and added comments. A bug (prematurely breaking > from a loop) was fixed during the refactoring. > > (My last mail was wrong

Re: Fix var-tracking ICE with COND_EXEC

2014-06-30 Thread Jeff Law
On 06/27/14 08:49, Joseph S. Myers wrote: With a 4.8-based compiler for ARM, I've observed an ICE in the var-tracking.c:add_stores handling of COND_EXEC. A large testcase from building Qt can be found at ; a somewhat reduced version (for the co

Re: Fix finding reg-sets of call insn in collect_fn_hard_reg_usage

2014-06-30 Thread Jeff Law
On 06/26/14 04:56, Tom de Vries wrote: On 19-06-14 18:47, Richard Henderson wrote: And I forgot to mention it might be worth while to notice simple recursion. Avoid the early exit path if caller == callee, despite the caller-save info not being valid. Richard, attached patch enables handlin

Re: [PATCH][sched-deps] Generalise usage of macro fusion to work on any two insns

2014-06-30 Thread Jeff Law
On 06/27/14 02:29, Kyrill Tkachov wrote: Hi all, This patch generalises the TARGET_MACRO_FUSION_PAIR_P hook usage to work on more than just compares and conditional branches for which it was initially designed for (for x86). There are some instructions in arm and aarch64 that can be fused toget

Re: [GOOGLE] Report the difference between profiled and guessed or annotated branch probabilities.

2014-06-30 Thread Yi Yang
I refactored the code and added comments. A bug (prematurely breaking from a loop) was fixed during the refactoring. (My last mail was wrongly set to HTML instead of plain text. I apologize for that.) 2014-06-30 Yi Yang * auto-profile.c (get_locus_information) (fill_invalid_locus_info

Re: [PATCH] Improve -fdump-tree-all efficiency

2014-06-30 Thread Marek Polacek
On Thu, Jun 26, 2014 at 06:42:09AM -0700, Teresa Johnson wrote: > 2014-06-26 Teresa Johnson > > * c-family/c-common.h (get_dump_info): Declare. > * c-family/c-gimplify.c (c_genericize): Use saved dump files. > * c-family/c-opts.c (c_common_parse_file): Begin and end dump

C++ PATCH for c++/61659 (undefined symbol with devirtualization)

2014-06-30 Thread Jason Merrill
When we're devirtualizing, we need to make sure that any virtual functions are synthesized or instantiated even if the vtable isn't going to be emitted. My earlier patches for 53808 handled this for synthesized destructors, but the issue is more general. Tested x86_64-pc-linux-gnu, applying t

Re: [C PATCH] Add -Wint-conversion option

2014-06-30 Thread Joseph S. Myers
On Mon, 30 Jun 2014, Marek Polacek wrote: > Basically everything I wrote in the patch for -Wincompatible-pointer-types > applies here as well. A new option, -Wint-conversion (to be compatible > with clang), is added to allow more fine-grained control over the warnings. > I think we should print t

Re: [C PATCH] Add -Wincompatible-pointer-types option (PR c/58286)

2014-06-30 Thread Joseph S. Myers
On Mon, 30 Jun 2014, Marek Polacek wrote: > This patch adds the -Wincompatible-pointer-types option for a warning > we already have, so it's possible to suppress this specific warning, or > use it with -Werror= and so on. > As a followup change, I'm considering printing the types of the pointers;

Re: [PATCH] Improve -fdump-tree-all efficiency

2014-06-30 Thread Jeff Law
On 06/26/14 07:42, Teresa Johnson wrote: The following patch fixes a big inefficiency when using -fdump-tree-all for large source files. I found that when using this option the compile time became unreasonably slow, and I traced this to the fact that dump_begin/dump_end are called around every fu

[PATCH, alpha]: Introduce handle_trap_shadows and align_insns passes

2014-06-30 Thread Uros Bizjak
Hello! After fixing _.barriers and _.eh_range passes w.r.t. CALL_ARG_LOCATION notes, we can finaly move handling of trap shadows (PR 56858) and insn alignments into their own passes. Additionally, the patch skips handling of BARRIERs in alpha_pad_function_end, since CALL_ARG_LOCATION notes are no

Re: [PATCH] Don't ICE with huge alignment (PR middle-end/60226)

2014-06-30 Thread Jeff Law
On 03/04/14 09:40, Marek Polacek wrote: This should fix ICE on insane alignment. Normally, check_user_alignment detects e.g. alignment 1 << 32, but not 1 << 28. However, record_align is in bits, so it's actually 8 * (1 << 28) and that's greater than INT_MAX. This patch rejects such code. In t

Re: update address taken: don't drop clobbers

2014-06-30 Thread Jeff Law
On 06/28/14 16:33, Marc Glisse wrote: In an earlier version of the patch, I was using get_or_create_ssa_default_def (cfun, sym); (I was reusing the same variable). This passed bootstrap+testsuite on all languages except for ada. Indeed, the compiler wanted to coalesce several SSA_NAMEs, including

Re: [PATCH 3/5] IPA ICF pass

2014-06-30 Thread Jeff Law
On 06/26/14 12:46, Jan Hubicka wrote: So you've added this at -O2, what is the general compile-time impact? Would it make more sense to instead have it be part of -O3, particularly since ICF is rarely going to improve performance (sans icache issues). I think code size optimization not sacrify

[PATCH] Relax check against commuting XOR and ASHIFTRT in combine.c

2014-06-30 Thread Alan Lawrence
combine.c includes a check which prevents (ashiftrt (xor A C2) C1) from being commuted to (xor (ashiftrt A C1) (ashiftrt C2 C1)) for constants C1, C2 if C2 has its sign bit set. Specifically, this prevents (ashiftrt (not A) C1) from being commuted to (not (ashiftrt A C1)) because the former

Re: [PATCH 2/5] Existing call graph infrastructure enhancement

2014-06-30 Thread Jeff Law
On 06/30/14 05:49, Martin Liška wrote: On 06/17/2014 10:00 PM, Jeff Law wrote: On 06/13/14 04:26, mliska wrote: Hi, this small patch prepares remaining needed infrastructure for the new pass. Changelog: 2014-06-13 Martin Liska Honza Hubicka * ipa-utils.h (polymorphic_t

Re: [C++] Avoid producing duplicate binfos for member pointers

2014-06-30 Thread Jason Merrill
On 06/30/2014 11:58 AM, Jason Merrill wrote: On 06/30/2014 08:42 AM, Jason Merrill wrote: Hmm, I wonder why we need BINFOs at all for the ptrmemfunc RECORD_TYPEs, which are not classes. I'm working on removing both BINFO and TYPE_LANG_SPECIFIC. Like so. Applying to trunk. commit 8988eb91d4

C++ PATCH for c++/61566 (ICE with lambda in template default arg)

2014-06-30 Thread Jason Merrill
decl_mangling_context was failing to recognize a lambda in template context as a lambda. Tested x86_64-pc-linux-gnu, applying to 4.9 and trunk. commit 1ba7cf95c0b024c7a3372e0734d7bf620f31dd14 Author: Jason Merrill Date: Mon Jun 30 12:08:09 2014 -0400 PR c++/61566 * mangle.c (decl_m

Re: [PING*3][PATCH RTL] Extend mode-switching to support toggle

2014-06-30 Thread Jeff Law
On 06/30/14 06:14, Christian Bruel wrote: Hello, I still miss an approval for the middle-end part of http://gcc.gnu.org/ml/gcc-patches/2014-06/msg01038.html Didn't I ack that patch last week? https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01401.html Thanks, Jeff

C++ PATCH for c++/61647 (ICE with call to conversion op)

2014-06-30 Thread Jason Merrill
We were missing a way the function being called can be dependent. Tested x86_64-pc-linux-gnu, applying to 4.8, 4.9, trunk. commit 687aa57720473c7962c9eb9cf79c67cf068ba005 Author: Jason Merrill Date: Mon Jun 30 13:50:38 2014 -0400 PR c++/61647 * pt.c (type_dependent_expression_p): Ch

[C PATCH] Add -Wint-conversion option

2014-06-30 Thread Marek Polacek
Basically everything I wrote in the patch for -Wincompatible-pointer-types applies here as well. A new option, -Wint-conversion (to be compatible with clang), is added to allow more fine-grained control over the warnings. I think we should print the types here as well, and moreover, we could hint

[C PATCH] Add -Wincompatible-pointer-types option (PR c/58286)

2014-06-30 Thread Marek Polacek
This patch adds the -Wincompatible-pointer-types option for a warning we already have, so it's possible to suppress this specific warning, or use it with -Werror= and so on. As a followup change, I'm considering printing the types of the pointers; saying merely e.g. "assignment from incompatible po

Re: [C++] Avoid producing duplicate binfos for member pointers

2014-06-30 Thread Jan Hubicka
> On 06/30/2014 08:42 AM, Jason Merrill wrote: > >Hmm, I wonder why we need BINFOs at all for the ptrmemfunc RECORD_TYPEs, > >which are not classes. > > I'm working on removing both BINFO and TYPE_LANG_SPECIFIC. Works for me! :) Thanks, Honza

Re: [PATCH, rs6000, testsuite] Skip gfortran.dg/round_4.f90 for PowerPC Linux

2014-06-30 Thread Mike Stump
On Jun 29, 2014, at 6:48 PM, Bill Schmidt wrote: > +! { dg-skip-if "IBM long double 31 bits of precision, test requires 38" { > powerpc*-*-linux* } } Thanks for the comment. Can someone confirm that this fails on darwin and should be skipped there as well?

Re: [PATCH, alpha]: Wrap {un,}aligned_store sequence with memory blockages.

2014-06-30 Thread Richard Henderson
On 06/29/2014 11:14 AM, Uros Bizjak wrote: >if (MEM_READONLY_P (x)) > +if (GET_CODE (mem_addr) == AND) > + return 1; > return 0; Certainly missing braces here. But with that fixed the patch looks plausible. I'll look at it closer later today. r~

Re: [C++] Avoid producing duplicate binfos for member pointers

2014-06-30 Thread Jason Merrill
On 06/30/2014 08:42 AM, Jason Merrill wrote: Hmm, I wonder why we need BINFOs at all for the ptrmemfunc RECORD_TYPEs, which are not classes. I'm working on removing both BINFO and TYPE_LANG_SPECIFIC. Jason

Re: [PATCH v2, rtl]: Teach _.barriers and _.eh_range passes to not split a call and its corresponding CALL_ARG_LOCATION note.

2014-06-30 Thread Richard Henderson
On 06/29/2014 12:51 PM, Uros Bizjak wrote: > I believe that attached v2 patch addresses all your review comments. > > Patch was bootstrapped and regression tested on x86_64-linux-gnu {,-m32}. Looks good, thanks. r~

Re: Optimize type streaming

2014-06-30 Thread Dominique Dhumieres
> Note that testusite passes with the patch; ... Confirmed. There is a typo s/fileds/fields/ I have seen the failures because I now run the gfortran testsuite with

Re: [PATCH, rs6000, testsuite] Skip gfortran.dg/round_4.f90 for PowerPC Linux

2014-06-30 Thread David Edelsohn
On Sun, Jun 29, 2014 at 9:48 PM, Bill Schmidt wrote: > Hi, > > The test in gfortran.dg/round_4.f90, introduced in GCC 4.9, checks for > correct behavior of different rounding modes. However, for > quad-precision floating-point, it requires that the number > 0.10048

[PING][PATCH] Fix for PR 61561

2014-06-30 Thread Marat Zakirov
This is a reminder message on fix for PR 61561 which is ICE while compiling something which is valid* 'C' code. (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61561). Ramana, Richard, I am very appreciated for your attention and error indication, your work made my patch simple and tiny. And I h

Re: [PATCH PR C++/58781, 59867, 60249 ] Various user-defined string literal issues involving character encodings, dropped bytes, semi-infinite loops

2014-06-30 Thread Jason Merrill
On 06/28/2014 05:57 PM, Ed Smith-Rowland wrote: OK? I would also like to apply this to 4.9. OK. Jason

Re: [C++ Patch] PR 51400

2014-06-30 Thread Jason Merrill
OK. Jason

Re: Regimplification enhancements 3/3

2014-06-30 Thread Bernd Schmidt
On 06/17/2014 04:54 PM, Martin Jambor wrote: Weird... does the following (untested) patch help? diff --git a/gcc/tree-sra.c b/gcc/tree-sra.c index 0afa197..747b1b6 100644 --- a/gcc/tree-sra.c +++ b/gcc/tree-sra.c @@ -3277,6 +3277,8 @@ sra_modify_assign (gimple *stmt, gimple_stmt_iterator *gsi)

C++ PATCH for c++/61539 (type/value mismatch in variadic deduction)

2014-06-30 Thread Jason Merrill
unify_one_argument was assuming that there's no way we can get a type/value mismatch in a nested deduction, but it can happen with variadic templates; deduction should just fail in that case. Tested x86_64-pc-linux-gnu, applying to trunk. commit 40c2934a737ba5d2e406e079a2b249245dfb17ab Author:

Re: [patch libstdc++] Add xmethods for std::vector and std::unique_ptr

2014-06-30 Thread Tom Tromey
> "Siva" == Siva Chandra writes: Siva> +# Load the xmethods. Siva> +from libstdcxx.v6.xmethods import register_libstdcxx_xmethods Siva> +register_libstdcxx_xmethods (gdb.current_objfile ()) I don't think any addition to the hook file should be needed. Siva> +# The object to be retur

Re: [PATCH][sched-deps] Generalise usage of macro fusion to work on any two insns

2014-06-30 Thread Kyrill Tkachov
On 27/06/14 09:29, Kyrill Tkachov wrote: Hi all, This patch generalises the TARGET_MACRO_FUSION_PAIR_P hook usage to work on more than just compares and conditional branches for which it was initially designed for (for x86). There are some instructions in arm and aarch64 that can be fused toge

Re: [C++ Patch] PR 54891

2014-06-30 Thread Jason Merrill
OK. Jason

[C++ Patch] PR 54891

2014-06-30 Thread Paolo Carlini
Hi, I think it's fair to say that this issue is rather tricky, considering that among the compilers I have at hand none gets it right without regressing on parse/pr26997.C. The basic issue is simple: in C++11 (void)[]{}; is well formed, thus cp_parser_tokens_start_cast_expression should

Re: Optimize type streaming

2014-06-30 Thread Dominique Dhumieres
> Note that testusite passes with the patch; ... Confirmed. There is a typo s/fileds/fields/ I have seen the failures because I now run the gfortran testsuite with the addition of '-g -flto'. Is it worth pushing in this direction? Cheers, Dominique

Re: [patch] Honor the vxworks options overrides on VxWorksae

2014-06-30 Thread Olivier Hainque
With the patch attached ... On Jun 30, 2014, at 15:29 , Olivier Hainque wrote: > Hello, > > The vxworks_override_option code is general enough to apply to both regular > VxWorks and VxWorksAE configurations. > > The VxWorksAE configuration files miss the triggering bits, however, with > variou

Re: [PATCH][AArch64] Implement vfma_f64, vmla_f64, vfms_f64, vmls_f64 intrinsics

2014-06-30 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01615.html Kyrill On 20/06/14 15:17, Kyrill Tkachov wrote: Hi all, Now that Alan fixed the float64x1_t machinery, this patch implements some low-hanging intrinsics in arm_neon.h. Tested aarch64-none-elf and bootstrapped on aarch64-linux. Ok

Re: [AArch64] Implement some vca*_f[32,64] intrinsics

2014-06-30 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01771.html Kyrill On 23/06/14 15:30, Kyrill Tkachov wrote: Hi all, This patch implements some absolute compare intrinsics in arm_neon.h. Execution tests are added. Tested aarch64-none-elf, aarch64_be-none-elf, bootstrapped on aarch64 linux

[patch] Honor the vxworks options overrides on VxWorksae

2014-06-30 Thread Olivier Hainque
Hello, The vxworks_override_option code is general enough to apply to both regular VxWorks and VxWorksAE configurations. The VxWorksAE configuration files miss the triggering bits, however, with various kinds of consequences. One example is -fPIC being accepted without -mrtp, while it should be r

Re: [PATCH] [ARM] [RFC] Fix longstanding push_minipool_fix ICE (PR49423, lp1296601)

2014-06-30 Thread Richard Earnshaw
On 30/06/14 13:53, Charles Baylis wrote: > On 18 June 2014 00:02, Ramana Radhakrishnan wrote: >> >> Interesting workaround but can we investigate further how to fix this >> at the source rather than working around in the backend in this form. >> It's still a kludge that we carry in the backend rat

Re: [PATCH] Properly honor no_sanitize_undefined attribute

2014-06-30 Thread Marek Polacek
On Mon, Jun 30, 2014 at 03:00:11PM +0200, Jakub Jelinek wrote: > Actually, please change current_function_decl != 0 to > current_function_decl != NULL_TREE everywhere in the patch. > Ok with that change. Ok, I'm applying the following then. 2014-06-30 Marek Polacek * convert.c (conver

Re: [PATCH v2] typeof: Remove type qualifiers for atomic types

2014-06-30 Thread Marek Polacek
On Fri, Jun 27, 2014 at 08:49:24AM +0200, Marek Polacek wrote: > On Fri, Jun 27, 2014 at 08:36:38AM +0200, Sebastian Huber wrote: > > Thanks for your patience. It would be nice if this can be applied to GCC > > 4.9 as well. > > > > Can someone please commit this for me, since I don't have write a

Re: [PATCH] Properly honor no_sanitize_undefined attribute

2014-06-30 Thread Jakub Jelinek
On Mon, Jun 30, 2014 at 02:58:53PM +0200, Jakub Jelinek wrote: > On Mon, Jun 30, 2014 at 02:08:26PM +0200, Marek Polacek wrote: > > Apparently I didn't pay much attention to no_sanitize_undefined > > attribute when adding new features to ubsan, so we would instrument > > stuff even though the funct

Re: [PATCH] Properly honor no_sanitize_undefined attribute

2014-06-30 Thread Jakub Jelinek
On Mon, Jun 30, 2014 at 02:08:26PM +0200, Marek Polacek wrote: > Apparently I didn't pay much attention to no_sanitize_undefined > attribute when adding new features to ubsan, so we would instrument > stuff even though the function is marked with this attribute. > Thus fixed & new testcases added.

[committed] Fix up -fsanitize=bounds documentation

2014-06-30 Thread Jakub Jelinek
Hi! -fsanitize=bounds is one of the -fsanitize=undefined suboptions, therefore it should be documented as such. Fixed thusly, committed to trunk as obvious. 2014-06-30 Jakub Jelinek * doc/invoke.texi (-fsanitize=bounds): Move to the table with -fsanitize=undefined suboptions.

Re: [PATCH] [ARM] [RFC] Fix longstanding push_minipool_fix ICE (PR49423, lp1296601)

2014-06-30 Thread Charles Baylis
On 18 June 2014 00:02, Ramana Radhakrishnan wrote: > > Interesting workaround but can we investigate further how to fix this > at the source rather than working around in the backend in this form. > It's still a kludge that we carry in the backend rather than fix the > problem at it's source. I'd

Re: [C++] Avoid producing duplicate binfos for member pointers

2014-06-30 Thread Jason Merrill
Hmm, I wonder why we need BINFOs at all for the ptrmemfunc RECORD_TYPEs, which are not classes. Jason

[PING*3][PATCH RTL] Extend mode-switching to support toggle

2014-06-30 Thread Christian Bruel
Hello, I still miss an approval for the middle-end part of http://gcc.gnu.org/ml/gcc-patches/2014-06/msg01038.html thanks, Christian

Re: [PATCH 5/5] New tests introduction

2014-06-30 Thread Martin Liška
On 06/17/2014 09:53 PM, Jeff Law wrote: On 06/13/14 05:16, mliska wrote: Hi, this is a new collection of tests for IPA ICF pass. Martin Changelog: 2014-06-13 Martin Liska Honza Hubicka * gcc/testsuite/g++.dg/ipa/ipa-se-1.C: New test. * gcc/testsuite/g++.dg/ipa/ipa-s

Re: [PATCH 4/5] Existing tests fix

2014-06-30 Thread Martin Liška
On 06/17/2014 09:52 PM, Jeff Law wrote: On 06/13/14 04:48, mliska wrote: Hi, many tests rely on a precise number of scanned functions in a dump file. If IPA ICF decides to merge some function and(or) read-only variables, counts do not match. Martin Changelog: 2014-06-13 Martin Liska

[PATCH] Properly honor no_sanitize_undefined attribute

2014-06-30 Thread Marek Polacek
Apparently I didn't pay much attention to no_sanitize_undefined attribute when adding new features to ubsan, so we would instrument stuff even though the function is marked with this attribute. Thus fixed & new testcases added. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2014-06-30 Mar

Re: [PATCH 2/5] Existing call graph infrastructure enhancement

2014-06-30 Thread Martin Liška
On 06/17/2014 10:00 PM, Jeff Law wrote: On 06/13/14 04:26, mliska wrote: Hi, this small patch prepares remaining needed infrastructure for the new pass. Changelog: 2014-06-13 Martin Liska Honza Hubicka * ipa-utils.h (polymorphic_type_binfo_p): Function marked external

Re: [commit] Fix ABI fallout (Re: wide-int, rs6000)

2014-06-30 Thread Ulrich Weigand
Mike Stump wrote: > On Jun 28, 2014, at 3:31 AM, Ulrich Weigand wrote: > > Mike Stump wrote: > > > >>(rs6000_aggregate_candidate): Use wide-int interfaces. > > [snip] > >> - /* Can't handle incomplete types. */ > >> - if (!COMPLETE_TYPE_P (type)) > >> -return -1; > >> + /* Can't handl

Re: [Patch ARM/testsuite 03/22] Add binary operators: vadd, vand, vbic, veor, vorn, vorr, vsub.

2014-06-30 Thread Marcus Shawcroft
On 30 June 2014 09:03, Ramana Radhakrishnan wrote: > + Move the tests to gcc.target/arm/ to gcc.target/aarch64 if the > AArch64 maintainers agree. For the extra AArch64 variants guard them > with #ifdef __aarch64__ #endif. Given that the intrinsics in aarch64 are a superset of those in aarch32

Re: [PATCH][AArch64] Fix some saturating math NEON intrinsics types

2014-06-30 Thread Kyrill Tkachov
On 30/06/14 11:44, Marcus Shawcroft wrote: On 30 June 2014 10:41, Kyrill Tkachov wrote: Here it is. Now it applies cleanly to 4.9 and the tests are in gcc.target/aarch64 instead of gcc.target/aarch64/simd Tested on aarch64-none-elf and aarch64_be-none-elf. Ok to apply? OK, thanks. /Marcus

Re: [PATCH][AArch64] Fix some saturating math NEON intrinsics types

2014-06-30 Thread Marcus Shawcroft
On 30 June 2014 10:41, Kyrill Tkachov wrote: > > Here it is. > Now it applies cleanly to 4.9 and the tests are in gcc.target/aarch64 > instead of gcc.target/aarch64/simd > > Tested on aarch64-none-elf and aarch64_be-none-elf. > > Ok to apply? OK, thanks. /Marcus

Re: [PATCH, rs6000, testsuite] Skip gfortran.dg/round_4.f90 for PowerPC Linux

2014-06-30 Thread Tobias Burnus
Hi Bill, Bill Schmidt wrote: > The test in gfortran.dg/round_4.f90, introduced in GCC 4.9, checks for > correct behavior of different rounding modes. However, for > quad-precision floating-point, it requires that the number > 0.100481 be exactly represented. Since

Re: AARCH64 configure check for gas -mabi support

2014-06-30 Thread Yufeng Zhang
Looks good to me. Thanks for the fix. Yufeng On 06/30/14 10:44, Gerald Pfeifer wrote: I applied the small patch on top of this, mostly triggered by the markup issue. Let me know if there is anything you'd like to see differently; I am thinking to push back to GCC 4.9 as well later. Gerald

Re: AARCH64 configure check for gas -mabi support

2014-06-30 Thread Gerald Pfeifer
I applied the small patch on top of this, mostly triggered by the markup issue. Let me know if there is anything you'd like to see differently; I am thinking to push back to GCC 4.9 as well later. Gerald 2014-06-30 Gerald Pfeifer * doc/install.texi (Specific, aarch64*-*-*): Fix mark

[wwwdocs,Java] Remove separate java/build-snapshot.html

2014-06-30 Thread Gerald Pfeifer
When we integrated GCJ/libgcj, it looks like we did not proceed doing that fully as it came to the web pages, and sadly nobody else has been looking after them for a while. 2014-06-30 Gerald Pfeifer * build-snapshot.html: Remove. * gcj2.html: Remove link to build-snapshot.html

  1   2   >