Re: [PATCH, i386, Pointer Bounds Checker 17/x] Pointer bounds constants support

2014-06-03 Thread Jeff Law
On 06/02/14 04:25, Ilya Enkovich wrote: Hi, This patch adds support for pointer bounds constants to be used as DECL_INITIAL for constant bounds (like zero bounds). Bootstrapped and tested on linux-x86_64. Thanks, Ilya -- gcc/ 2014-05-30 Ilya Enkovich * emit-rtl.c (immed_double_co

[PATCH]Code size optimization for the fmul/fdiv and dmul/ddiv function in libgcc

2014-06-03 Thread Tony Wang
Hi there, In libgcc the file ieee754-sf.S and ieee754-df.S have some function pairs which will be bundled into one .o file and sharing the same .text section. For example, the fmul and fdiv, the libgcc makefile will build them into one .o file and archived into libgcc.a. So when user only call sin

Re: [PATCH, Pointer Bounds Checker 13/x] Early versioning

2014-06-03 Thread Jeff Law
On 06/03/14 03:29, Richard Biener wrote: On Tue, Jun 3, 2014 at 7:55 AM, Ilya Enkovich wrote: 2014-06-02 21:27 GMT+04:00 Jeff Law : On 06/02/14 04:48, Ilya Enkovich wrote: Hmm, so if I understand things correctly, src_fun has no loop structures attached, thus there's nothing to copy. Presum

[C PATCH] Better location for switch warnings (PR c/30020)

2014-06-03 Thread Marek Polacek
It is trivial to pass the location from c_add_case_label down to check_case_bounds, so do that. With it, we instead of i.c:4:3: warning: case label value is less than minimum value for type switch (c) { case 42: case -1: return -1; }; ^ output i.c:4:25: warning: case label value is less tha

Re: [PATCH, i386, Pointer Bounds Checker 10/x] Partitions

2014-06-03 Thread Jeff Law
On 06/02/14 05:50, Ilya Enkovich wrote: On 30 May 11:10, Jeff Law wrote: On 05/28/14 10:06, Ilya Enkovich wrote: Hi, This patch keeps instrumented and original versions together and preserve tranparent alias chain during symbol name privatization. Bootstrapped and tested on linux-x86_64. Th

Re: Fix a function decl in gfortran

2014-06-03 Thread Tobias Burnus
Tobias Burnus wrote: There are two functions groups called with mask, cf. iresolve.c's gfc_resolve_minloc. Namely, without dim "mmin0__" and with dim "mmin1__". – The latter takes "dim" as additional argument. Thus, for mmin1_* the generated decl is fine, for mmin0_ is is not. I do not immed

[PATCH] Fix PR61320: disable bswap for unaligned access on SLOW_UNALIGNED_ACCESS targets

2014-06-03 Thread Thomas Preud'homme
Hi there, It seems from PR61320 that the bswap pass causes some problems when it replaces an OR expression by an unaligned access. Although it's not clear yet why the unaligned load does not go through the extract_bit_field codepath, it is necessary to provide a solution as this prevent sparc fro

[PATCH] Fix PR61306: improve handling of sign and cast in bswap

2014-06-03 Thread Thomas Preud'homme
When bswap replace a bitwise expression involving a memory source by a load possibly followed by a bswap, it is possible that the load has a size smaller than that of the target expression where the bitwise expression was affected. So some sort of cast is needed. But there might also be a differ

Re: [PATCH][AARCH64]Support full addressing modes for ldr/str in vectorization scenarios

2014-06-03 Thread Bin.Cheng
On Wed, Jun 4, 2014 at 1:50 AM, Marcus Shawcroft wrote: > > > > >> On 3 Jun 2014, at 18:08, Charles Baylis wrote: >> >>> On 3 June 2014 12:08, Marcus Shawcroft wrote: >>> On 28 May 2014 08:30, Bin.Cheng wrote: > So is it OK? > > > 2014-05-28 Bin Cheng > >* con

Re: [PATCH] Dumping Fields of A Class When -fdump-class-hierarchy

2014-06-03 Thread lin zuojian
Hi, I have no idea why nobody show his interest in my patch, but it's very helpful to boost the efficiency of debugging optimized binary and help recognizing which expression the crash happens in. For example: struct A { int a; }; struct B { int b; }; struct C : public A,

[AArch64,PATCH] Refactor acquire/release determination into output template

2014-06-03 Thread Jones, Joel
There is duplicate code for determining whether a load or store instruction needs acquire or release semantics. This patch removes the duplicated code and uses a modifying operator to output a/l instead. Since the testsuite already contains tests for the atomic functions, no new testcases are

Re: [build, driver] RFC: Support compressed debug sections

2014-06-03 Thread Gerald Pfeifer
On Tue, 3 Jun 2014, Rainer Orth wrote: > It's been another week, and I still need approval for the build, doc, > and Darwin changes: > > https://gcc.gnu.org/ml/gcc-patches/2014-05/msg01860.html On the doc side, things are fine. Just a suggestion or two: +Produce compressed debug sections

[patch][gomp4] openacc loops

2014-06-03 Thread Cesar Philippidis
This patch, which is derived from Ilmir Usmanov's work posted here , implements the loop directive in openacc. The original patch is mostly intact, however, I did disable support for do concurrent loops since openacc 2.0a supports fortran up

Re: [patch recog.c]: Copy sibcall-flags for calls also in peep2_attempt

2014-06-03 Thread Jeff Law
On 06/03/14 15:58, Kai Tietz wrote: Hi, this patch adds copying of SIBLING_CALL_P flag to new call-instruction. This behavior is by this patch consistent to the try_split function in emit-rtl.c. This patch is a prerequisite for my updated sibling-tail-call optimization patch. ChangeLog 2014-

Re: patch to fix PR61325

2014-06-03 Thread James Greenhalgh
nfigure --with-cpu=cortex-a15.cortex-a7 --with-fpu=neon-vfpv4 --with-float=hard --prefix=/home/jamgre01/build//clean//install --enable-languages=c,c++,fortran Thread model: posix gcc version 4.10.0 20140603 (experimental) (GCC) COLLECT_GCC_OPTIONS='-O3' '-v' '-mcpu=c

Re: [PATCH 5/5] Reuse recog_op_alt cache in LRA

2014-06-03 Thread Jeff Law
On 05/31/14 03:22, Richard Sandiford wrote: The operand_alternative cache was LRA's only per-subtarget state so a lot of this patch is removing the associated initialisation and target_globals stuff. I called the preprocess_constraints functions in lra_set_insn_recog_data rather than setup_opera

Re: [PATCH 4/5] Cache recog_op_alt by insn code: main patch

2014-06-03 Thread Jeff Law
On 05/31/14 03:17, Richard Sandiford wrote: This is the refreshed main patch. I've rearranged the preprocess_constraints code into three functions so that LRA can use it in patch 5. Thanks, Richard gcc/ * recog.h (operand_alternative): Convert reg_class, reject, matched and ma

Re: [PATCH 3/5] Make recog_op_alt consumers check the enabled attribute

2014-06-03 Thread Jeff Law
On 05/31/14 03:15, Richard Sandiford wrote: As described in the covering note, it seems better to put the onus of checking the enabled attribute on the passes that are walking each alternative, like LRA does for its internal subpasses. That leads to a nicer interface in patch 4 and would make it

[patch recog.c]: Copy sibcall-flags for calls also in peep2_attempt

2014-06-03 Thread Kai Tietz
Hi, this patch adds copying of SIBLING_CALL_P flag to new call-instruction. This behavior is by this patch consistent to the try_split function in emit-rtl.c. This patch is a prerequisite for my updated sibling-tail-call optimization patch. ChangeLog 2014-06-03 Kai Tietz * recog.c

Re: [PATCH 2/5] Don't modify recog_op_alt after preprocess_constraints

2014-06-03 Thread Jeff Law
On 05/31/14 03:09, Richard Sandiford wrote: Since the aim of this series is to cache the result of preprocess_constraints, we need to make sure that passes don't modify the information afterwards. This patch deals with the places that did. Patch 4 will make the information properly const. Thank

Re: [PATCH 1/5] Flatten recog_op_alt and reorder entries

2014-06-03 Thread Jeff Law
On 05/31/14 03:06, Richard Sandiford wrote: As described in the covering note, this patch converts recog_op_alt into a flat array and orders the entries in the same way as the LRA cache. Several places just want the information for alternative which_alternative, so I added a convenience function

Re: Fix a function decl in gfortran

2014-06-03 Thread Tobias Burnus
Bernd Schmidt wrote: There's at least one more such problem with gfortran, which I'm having a harder time debugging. It occurs in gfortran.fortran-torture/compile/mloc.f90 That's minloc/maxloc, which takes three arguments on the Fortran side: An array, optionally a dimension ("dim") and optio

Re: [PATCH 0/5] Cache recog_op_alt by insn code, take 2

2014-06-03 Thread Jeff Law
On 05/31/14 03:02, Richard Sandiford wrote: Sorry Jeff, while working on the follow-on LRA patch I came across a couple of problems, so I need another round on this. It happens, particularly for conceptual changes like this. I don't consider that a problem at all -- we're already in agreement o

[patch] libstdc++/56166 avoid allocation in basic_string::clear()

2014-06-03 Thread Jonathan Wakely
Instead of cloning the string and then setting its length to zero, just point to the empty rep instead. I'm not sure if this is conforming in C++03, because it modifies the capacity(), whereas clear() is specified as if it called erase(begin(), end()), which typically wouldn't alter the capacity

Re: [PATCH, i386, Pointer Bounds Checker 10/x] Partitions

2014-06-03 Thread Jeff Law
On 06/02/14 05:41, Richard Biener wrote: this should be all moved to the symbol table level. (and IDENTIFIER_NODE shouldn't have to have tree_common.chain and thus become smaller). Which ought to be independent of the pointer checking work. There's been some proposals for making first class s

Re: Create a library for tools like collect2 and lto-wrapper (2/2)

2014-06-03 Thread Joseph S. Myers
On Tue, 27 May 2014, Bernd Schmidt wrote: > > Thus, as an initial step I'd suggest instead converting lto-wrapper to use > > the common functionality where possible (fatal_error with %m replacing > > fatal_perror), making it use atexit in the process. Don't move code using > > legacy fatal / fata

Re: RFA: Make LRA temporarily eliminate addresses before testing constraints

2014-06-03 Thread Vladimir Makarov
On 06/02/2014 03:36 PM, Richard Sandiford wrote: > Ping. Imagination's copyright assignment has now gone through and so > in principle we're ready for the MIPS LRA switch to go in. We need > this LRA patch as a prequisite though. > > Robert: you also had an LRA change, but is it still needed afte

[patch] No allocation for empty unordered containers

2014-06-03 Thread François Dumont
Hi Thanks to the single bucket introduced to make move semantic noexcept we can also avoid some over allocations. Here is a patch to avoid any allocation on default instantiation, on range constructor when range is empty and on construction from an initialization list when this list is em

Re: [patch i386]: Fix PR/46219 Generate indirect jump instruction

2014-06-03 Thread Richard Henderson
On 06/03/2014 01:15 PM, Kai Tietz wrote: > - Original Message - >> On 06/03/2014 12:56 PM, Kai Tietz wrote: >>> +(define_insn "*sibcall_intern" >>> + [(call (unspec [(mem:QI (match_operand:W 0 "memory_operand"))] >>> UNSPEC_PEEPSIB) >>> +(match_operand 1))] >>> + "" >>> + "* SIBLING_

Re: [patch i386]: Fix PR/46219 Generate indirect jump instruction

2014-06-03 Thread Kai Tietz
- Original Message - > On 06/03/2014 12:56 PM, Kai Tietz wrote: > > +(define_insn "*sibcall_intern" > > + [(call (unspec [(mem:QI (match_operand:W 0 "memory_operand"))] > > UNSPEC_PEEPSIB) > > +(match_operand 1))] > > + "" > > + "* SIBLING_CALL_P (insn) = 1; return ix86_output_call_i

Re: [patch i386]: Fix PR/46219 Generate indirect jump instruction

2014-06-03 Thread Richard Henderson
On 06/03/2014 12:56 PM, Kai Tietz wrote: > +(define_insn "*sibcall_intern" > + [(call (unspec [(mem:QI (match_operand:W 0 "memory_operand"))] > UNSPEC_PEEPSIB) > + (match_operand 1))] > + "" > + "* SIBLING_CALL_P (insn) = 1; return ix86_output_call_insn (insn, > operands[0]);" > + [(set_

Re: [patch i386]: Prevent to assume for 64-bit ms-abi that DX_REG is used as function-value

2014-06-03 Thread Richard Henderson
On 06/03/2014 11:21 AM, Kai Tietz wrote: > case AX_REG: > case DX_REG: > - return true; > + return (regno != DX_REG || !TARGET_64BIT || ix86_abi != MS_ABI); You might as well eliminate the first test, and split the case entries: case AX_REG: return true; case DX_REG:

[patch i386]: Fix PR/46219 Generate indirect jump instruction

2014-06-03 Thread Kai Tietz
Hello, This patch fixes PR/46219 by introducing special peephole-optimization. As we can't set for new statement in peephole2-define SIBLING_CALL_P easily, I use UNSPEC_PEEPSIB to do indentify sibling tail-call-case. For avoiding modification of ix86_output_call_insn, I set SIBLING_CALL_P dir

Re: Fix a function decl in gfortran

2014-06-03 Thread Bernd Schmidt
On 05/27/2014 04:01 PM, Tobias Burnus wrote: Bernd Schmidt wrote: Compiling Fortran code with the ptx backend I'm working on results in assembler warnings about mismatch between function calls and function decls. Bootstrapped and tested on x86_64-linux. Ok? OK. The change/bug is due to my fo

Re: [PATCH, PR 61340] Add default label to two switches on enum ipa_ref_use

2014-06-03 Thread Jan Hubicka
> Hi, > > in PR 61340 it has been reported that clang warns about unhandeld enum > values in a switch (gcc does not, I guess I'll open a new PR for > that). > > Fixed thusly by adding a default label with a gcc_unreachable() in > both. The potentially unhandled enum value in both cases is > IPA_

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-06-03 Thread Richard Sandiford
Sandra Loosemore writes: > Catherine included an earlier version of this patch with the microMIPS > submission a couple years ago: > > https://gcc.gnu.org/ml/gcc-patches/2012-07/msg00972.html > > Richard's response was: > >> Looks like the wrong place to do this. Please treat this as a separate

Re: [MIPS] Add sbasic supoert ffor MSA (SIMD)

2014-06-03 Thread Richard Sandiford
Matthew Fortune writes: > Mike Stump writes: >> On May 28, 2014, at 7:27 AM, Richard Earnshaw wrote: >> > >> > Speed of implementation. We're gradually replacing these with proper >> > builtins, but that takes a lot more work. >> >> As an owner of a port with more builtins that yours, I can of

[patch i386]: Prevent to assume for 64-bit ms-abi that DX_REG is used as function-value

2014-06-03 Thread Kai Tietz
Hello, this patch fixes a nit detected in ix86_function_value_regno_p. For x64 ms-abi we don't have DX_REG-register as valid function-value register. ChangeLog 2014-06-03 Kai Tietz * config/i386/i386.c (ix86_function_value_regno_p): Disallow DX_REG for 64-bit ms-abi. Tested

[PATCH, testsuite]: Fix g++.dg/ext/mv[14,15].C spurious failure on corei7

2014-06-03 Thread Uros Bizjak
Hello! When configured with "--with-arch=core-avx-i --with-cpu=core-avx-i", g++.dg/ext/mv[14,15].C tests fail on corei7 [1] since the default CPU is the same as the checked cpu in the test. The patch compiles the testcase with -march=x86-64 as the generic CPU 2014-06-03 Uros Bizjak * g++.

Re: PR61385: phiopt drops some PHIs

2014-06-03 Thread Jeff Law
On 06/03/14 08:08, Richard Biener wrote: On Tue, Jun 3, 2014 at 3:48 PM, Marc Glisse wrote: Hello, apparently it is possible to have a PHI in the middle basic block of value_replacement, so I need to move it as well when I move the statement and remove the block. Bootstrap and testsuite on x8

Re: [PATCH][AARCH64]Support full addressing modes for ldr/str in vectorization scenarios

2014-06-03 Thread Marcus Shawcroft
> On 3 Jun 2014, at 18:08, Charles Baylis wrote: > >> On 3 June 2014 12:08, Marcus Shawcroft wrote: >> On 28 May 2014 08:30, Bin.Cheng wrote: So is it OK? 2014-05-28 Bin Cheng * config/aarch64/aarch64.c (aarch64_classify_address) (aarch

Re: [C PATCH] Warn if switch has boolean value (PR c/60439)

2014-06-03 Thread Jason Merrill
OK. Jason

Re: [C++ Patch] PR 52174 aka DR 1423

2014-06-03 Thread Jason Merrill
OK, thanks. Jason

Re: [PATCH][AARCH64]Support full addressing modes for ldr/str in vectorization scenarios

2014-06-03 Thread Charles Baylis
On 3 June 2014 12:08, Marcus Shawcroft wrote: > On 28 May 2014 08:30, Bin.Cheng wrote: >>> So is it OK? >>> >>> >>> 2014-05-28 Bin Cheng >>> >>> * config/aarch64/aarch64.c (aarch64_classify_address) >>> (aarch64_legitimize_reload_address): Support full addressing modes >>>

Re: [C PATCH] Use inform for "shadowed decl" (PR c/48062)

2014-06-03 Thread Marek Polacek
On Tue, Jun 03, 2014 at 06:07:03PM +0200, Jakub Jelinek wrote: > On Tue, Jun 03, 2014 at 06:01:57PM +0200, Marek Polacek wrote: > > For "shadowed declaration" note we were calling warning_at, while we > > should use inform. > > > > Regtested/bootstrapped on x86_64-linux, ok for trunk? > > Shouldn

Re: [C++ Patch] PR 52174 aka DR 1423

2014-06-03 Thread Paolo Carlini
Hi, On 06/03/2014 05:41 PM, Jason Merrill wrote: On 06/03/2014 11:24 AM, Paolo Carlini wrote: + if (NULLPTR_TYPE_P (from) && (flags & LOOKUP_ONLYCONVERTING)) +conv->bad_p = true; Thanks. What kind of error message do we get with this change? Would adding something to convert_li

Re: [patch,avr] atmel avr new devices set-2

2014-06-03 Thread Denis Chertykov
2014-06-03 18:26 GMT+04:00 S, Pitchumani : > Hi, > > Attached patch adds support for Atmel devices tiny441, tiny828 and tiny841. > > Please commit if the patch is OK. > > Note: This is continuation of patch attached in > https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00049.html > > Regards, > Pitchu

Re: [patch,avr] atmel avr new devices set-1

2014-06-03 Thread Denis Chertykov
2014-06-02 13:47 GMT+04:00 S, Pitchumani : > Hi, > > Attached patch adds support for Atmel ATA devices (ata6616c, > ata6617c, ata664251, ata6612c, ata6613c and ata6614q). > > Please commit if the patch is OK. I do not have commit access. > > Regards, > Pitchumani > > gcc/ChangeLog > 2014-06-02 Vis

Re: [build, driver] RFC: Support compressed debug sections

2014-06-03 Thread Mike Stump
On Jun 3, 2014, at 3:40 AM, Rainer Orth wrote: > It's been another week, and I still need approval for the build, doc, > and Darwin changes: So, the darwin bits look trivial enough, if the entire scheme is what people want to do. My question would be, why do we want an option for this? If the

Re: Eliminate write-only variables

2014-06-03 Thread Jan Hubicka
> On Mon, Jun 2, 2014 at 8:59 PM, Jan Hubicka wrote: > >> > >> Yeah, I discussed this with martin today on irc. For aliasing we'd like > >> to know whether a decl possibly has its address taken. Currently we only > >> trust TREE_ADDRESSABLE for statics - and lto might change those to hidden >

Re: [C PATCH] Use inform for "shadowed decl" (PR c/48062)

2014-06-03 Thread Jakub Jelinek
On Tue, Jun 03, 2014 at 06:01:57PM +0200, Marek Polacek wrote: > For "shadowed declaration" note we were calling warning_at, while we > should use inform. > > Regtested/bootstrapped on x86_64-linux, ok for trunk? Shouldn't you remember the return value from warning/warning_at calls which fall thr

[C PATCH] Use inform for "shadowed decl" (PR c/48062)

2014-06-03 Thread Marek Polacek
For "shadowed declaration" note we were calling warning_at, while we should use inform. Regtested/bootstrapped on x86_64-linux, ok for trunk? 2014-06-03 Marek Polacek PR c/48062 * c-decl.c (warn_if_shadowing): Call inform instead of warning_at. * gcc.dg/Wshadow-1.c: U

[PATCH, PR 61340] Add default label to two switches on enum ipa_ref_use

2014-06-03 Thread Martin Jambor
Hi, in PR 61340 it has been reported that clang warns about unhandeld enum values in a switch (gcc does not, I guess I'll open a new PR for that). Fixed thusly by adding a default label with a gcc_unreachable() in both. The potentially unhandled enum value in both cases is IPA_REF_ALIAS which we

Re: [C PATCH] Warn if switch has boolean value (PR c/60439)

2014-06-03 Thread Marek Polacek
On Tue, Jun 03, 2014 at 11:46:35AM -0400, Jason Merrill wrote: > On 06/03/2014 10:57 AM, Marek Polacek wrote: > >+ if (TREE_CODE (orig_type) == BOOLEAN_TYPE > >+ || (truth_value_p (TREE_CODE (cond)) > >+ && TREE_CODE (orig_type) != INTEGER_TYPE)) > > I don't think you ne

Re: [C PATCH] Warn if switch has boolean value (PR c/60439)

2014-06-03 Thread Jason Merrill
On 06/03/2014 10:57 AM, Marek Polacek wrote: + if (TREE_CODE (orig_type) == BOOLEAN_TYPE + || (truth_value_p (TREE_CODE (cond)) + && TREE_CODE (orig_type) != INTEGER_TYPE)) I don't think you need the truth_value_p check, either, just the BOOLEAN_TYPE check.

Re: [C++ Patch] PR 52174 aka DR 1423

2014-06-03 Thread Jason Merrill
On 06/03/2014 11:24 AM, Paolo Carlini wrote: + if (NULLPTR_TYPE_P (from) && (flags & LOOKUP_ONLYCONVERTING)) + conv->bad_p = true; Thanks. What kind of error message do we get with this change? Would adding something to convert_like_real provide a more helpful diagnostic?

Re: C++ PATCH for c++/60992 (lambda and constant variable)

2014-06-03 Thread Jason Merrill
A small further tweak: let's try lookup first and when we do create a new decl, stash it in local_specializations. Tested x86_64-pc-linux-gnu, applying to trunk. commit 92a208c9176551243e305e779c7aaa730cace8f5 Author: Jason Merrill Date: Tue Jun 3 10:09:23 2014 -0400 PR c++/60992 *

Re: [C++ Patch] PR 52174 aka DR 1423

2014-06-03 Thread Paolo Carlini
Hi, On 06/03/2014 05:02 PM, Jason Merrill wrote: Right. In the case of + TDerived() + : TBase(nullptr) { } we have direct-initialization of TBase, but the parameter of the TBase constructor is copy-initialized, so nullptr32.C is ill-formed; please drop this hunk of the patch. Oops, now

Re: [C++ Patch] PR 52174 aka DR 1423

2014-06-03 Thread Jason Merrill
On 06/03/2014 10:30 AM, Paolo Carlini wrote: implementing the resolution seems rather straightforward, just check LOOKUP_ONLYCONVERTING in standard_conversion. Yep. Though it would be better to return a bad_p conversion than none at all. However, while playing with some additional tests ou

Re: [C PATCH] Warn if switch has boolean value (PR c/60439)

2014-06-03 Thread Marek Polacek
On Mon, Jun 02, 2014 at 06:00:04PM -0400, Jason Merrill wrote: > On 05/24/2014 04:00 AM, Marek Polacek wrote: > >+ /* Warn if the condition has boolean value. */ > >+ tree e = cond; > >+ while (TREE_CODE (e) == COMPOUND_EXPR) > >+e = TREE_OPERAND (e, 1); > >+ > >+ if (T

Re: [C++ Patch] PR 52174 aka DR 1423

2014-06-03 Thread Paolo Carlini
.. wondering if I should check DECL_CONSTRUCTOR_P (fn) too. Paolo.

Re: PR61385: phiopt drops some PHIs

2014-06-03 Thread Marc Glisse
On Tue, 3 Jun 2014, Richard Biener wrote: On Tue, Jun 3, 2014 at 3:48 PM, Marc Glisse wrote: Hello, apparently it is possible to have a PHI in the middle basic block of value_replacement, so I need to move it as well when I move the statement and remove the block. Bootstrap and testsuite on

[C++ Patch] PR 52174 aka DR 1423

2014-06-03 Thread Paolo Carlini
Hi, implementing the resolution seems rather straightforward, just check LOOKUP_ONLYCONVERTING in standard_conversion. However, while playing with some additional tests outside bug & testsuite (similar to nullptr32.C), I noticed a latent issue: in case of base initializers we were setting any

[patch,avr] atmel avr new devices set-2

2014-06-03 Thread S, Pitchumani
Hi, Attached patch adds support for Atmel devices tiny441, tiny828 and tiny841. Please commit if the patch is OK. Note: This is continuation of patch attached in https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00049.html Regards, Pitchumani gcc/ChangeLog 2014-06-03 Vishnu K S * config/av

Re: [PATCH, Pointer Bounds Checker 25/x] DCE

2014-06-03 Thread Ilya Enkovich
2014-06-03 17:41 GMT+04:00 Richard Biener : > On Tue, Jun 3, 2014 at 3:27 PM, Ilya Enkovich wrote: >> 2014-06-03 15:56 GMT+04:00 Richard Biener : >>> On Tue, Jun 3, 2014 at 1:36 PM, Ilya Enkovich >>> wrote: 2014-06-03 13:45 GMT+04:00 Richard Biener : > On Tue, Jun 3, 2014 at 9:23 AM, Il

C++ PATCH for c++/60848 (ICE with user-defined std::initializer_list)

2014-06-03 Thread Jason Merrill
Here the testcase defines std::initializer_list as a non-template class, so looking up its argument fails. I don't want to get into a lot of sanity checking for the definition of initializer_list, but this seems simple enough. Tested x86_64-pc-linux-gnu, applying to trunk. commit ea126f002069

Re: PR61385: phiopt drops some PHIs

2014-06-03 Thread Richard Biener
On Tue, Jun 3, 2014 at 3:48 PM, Marc Glisse wrote: > Hello, > > apparently it is possible to have a PHI in the middle basic block of > value_replacement, so I need to move it as well when I move the statement > and remove the block. > > Bootstrap and testsuite on x86_64-linux-gnu (re-running for v

Re: calloc = malloc + memset

2014-06-03 Thread Marc Glisse
Ping? On Sat, 17 May 2014, Marc Glisse wrote: Ping Jakub? https://gcc.gnu.org/ml/gcc-patches/2014-04/msg01104.html On Wed, 23 Apr 2014, Richard Biener wrote: On Fri, Apr 18, 2014 at 8:27 PM, Marc Glisse wrote: Thanks for the comments! On Fri, 18 Apr 2014, Jakub Jelinek wrote: The passe

Re: ipa-visibility TLC 2/n

2014-06-03 Thread David Edelsohn
Honza, How can we make further progress with the large regression on AIX? Thanks, David On Fri, May 30, 2014 at 1:24 PM, David Edelsohn wrote: > Honza, > > For example g++.dg/abi/vcall1.C fails at a call in a "localalias" > function, which jumps to a bad location: > > > (gdb) up > #1 0x14c

PR61385: phiopt drops some PHIs

2014-06-03 Thread Marc Glisse
Hello, apparently it is possible to have a PHI in the middle basic block of value_replacement, so I need to move it as well when I move the statement and remove the block. Bootstrap and testsuite on x86_64-linux-gnu (re-running for various reasons but they had completed successfully yesterda

Re: [PATCH, Pointer Bounds Checker 25/x] DCE

2014-06-03 Thread Richard Biener
On Tue, Jun 3, 2014 at 3:27 PM, Ilya Enkovich wrote: > 2014-06-03 15:56 GMT+04:00 Richard Biener : >> On Tue, Jun 3, 2014 at 1:36 PM, Ilya Enkovich wrote: >>> 2014-06-03 13:45 GMT+04:00 Richard Biener : On Tue, Jun 3, 2014 at 9:23 AM, Ilya Enkovich wrote: > Hi, > > This pa

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

2014-06-03 Thread Peter Bergner
On Tue, 2014-06-03 at 15:21 +0200, Jakub Jelinek wrote: > On Tue, Jun 03, 2014 at 08:06:41AM -0500, Peter Bergner wrote: > > No LD_PRELOAD. It adds -lasan "early", but after the libraries and > > object files that are explicitly added to the linker command. > > Since -lm is explicitly added to the

Re: [PATCH, Pointer Bounds Checker 25/x] DCE

2014-06-03 Thread Ilya Enkovich
2014-06-03 15:56 GMT+04:00 Richard Biener : > On Tue, Jun 3, 2014 at 1:36 PM, Ilya Enkovich wrote: >> 2014-06-03 13:45 GMT+04:00 Richard Biener : >>> On Tue, Jun 3, 2014 at 9:23 AM, Ilya Enkovich >>> wrote: Hi, This patch adjusts alloc-free removal algorithm in DCE to take into >

Re: [PING, PATCH2/2, PR52252] Vectorization for load/store groups of size 3.

2014-06-03 Thread Evgeny Stupachenko
I've added a bug report for the stores group case: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61403 On Wed, May 28, 2014 at 5:18 PM, Evgeny Stupachenko wrote: > Ping. > Test is modified according to the fix in the test for loads. > > diff --git a/gcc/testsuite/gcc.dg/vect/pr52252-st.c > b/gcc/

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

2014-06-03 Thread Jakub Jelinek
On Tue, Jun 03, 2014 at 08:06:41AM -0500, Peter Bergner wrote: > On Tue, 2014-06-03 at 08:41 +0200, Jakub Jelinek wrote: > > On Tue, Jun 03, 2014 at 10:19:48AM +0400, Yury Gribov wrote: > > > >I took that patch and applied it to the gcc sources, > > > >but I still see the error on ppc: > > > >... >

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

2014-06-03 Thread Yury Gribov
> It adds -lasan "early", but after the libraries and > object files that are explicitly added to the linker command. > Since -lm is explicitly added to the linker command, the implicitly > added -lasan comes after. The -v command is below. Hm, -lasan manages to override user-specified -lm on gc

[PATCH][match-and-simplify] Get rid of some stmt expressions

2014-06-03 Thread Richard Biener
The following arranges for complex C-expressions (multi-stmt ones) in the transform pattern to be outlined to a separate function. This avoids the need for using stmt expressions which are not necessarily supported by all C++ host compilers. The patch doesn't address the stmt expressions being us

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

2014-06-03 Thread Peter Bergner
On Tue, 2014-06-03 at 08:41 +0200, Jakub Jelinek wrote: > On Tue, Jun 03, 2014 at 10:19:48AM +0400, Yury Gribov wrote: > > >I took that patch and applied it to the gcc sources, > > >but I still see the error on ppc: > > >... > > >[bergner@makalu-lp1 asan]$ > > >LD_LIBRARY_PATH=:/home/bergner/gcc/b

Re: [AArch64/ARM 2/3] Detect EXT patterns to vec_perm_const, use for EXT intrinsics

2014-06-03 Thread Alan Lawrence
Pushed as r211177. Thanks, Alan Marcus Shawcroft wrote: On 3 June 2014 12:19, Alan Lawrence wrote: gcc/ChangeLog: * config/aarch64/aarch64.c (aarch64_evpc_ext): Allow+handle location==0. ? Allow and handle location == 0. Otherwise OK /Marcus

Re: [PATCH, Pointer Bounds Checker 25/x] DCE

2014-06-03 Thread Richard Biener
On Tue, Jun 3, 2014 at 1:36 PM, Ilya Enkovich wrote: > 2014-06-03 13:45 GMT+04:00 Richard Biener : >> On Tue, Jun 3, 2014 at 9:23 AM, Ilya Enkovich wrote: >>> Hi, >>> >>> This patch adjusts alloc-free removal algorithm in DCE to take into account >>> BUILT_IN_CHKP_BNDRET call returning bounds of

Re: [AArch64/ARM 2/3] Recognize shuffle patterns for REV instructions on AArch64, rewrite intrinsics.

2014-06-03 Thread Alan Lawrence
I've pushed this as r211174, after merging with the EXT changes (r211058): the following instructions are equivalent ext v.8b, v.8b, v.8b, #4 rev64 v.2s, v.2s and can both be output for a __builtin_shuffle mask of {1,0}. The latter seems more readable and so I've put the call to aarch64_evpc_r

Re: [PATCH, Pointer Bounds Checker 25/x] DCE

2014-06-03 Thread Ilya Enkovich
2014-06-03 13:45 GMT+04:00 Richard Biener : > On Tue, Jun 3, 2014 at 9:23 AM, Ilya Enkovich wrote: >> Hi, >> >> This patch adjusts alloc-free removal algorithm in DCE to take into account >> BUILT_IN_CHKP_BNDRET call returning bounds of allocated memory. >> >> Bootstrapped and tested on linux-x86

Re: [AArch64/ARM 2/3] Detect EXT patterns to vec_perm_const, use for EXT intrinsics

2014-06-03 Thread Marcus Shawcroft
On 3 June 2014 12:19, Alan Lawrence wrote: > gcc/ChangeLog: > > * config/aarch64/aarch64.c (aarch64_evpc_ext): Allow+handle > location==0. > > ? Allow and handle location == 0. Otherwise OK /Marcus

Re: [AArch64/ARM 2/3] Detect EXT patterns to vec_perm_const, use for EXT intrinsics

2014-06-03 Thread Alan Lawrence
gcc/ChangeLog: * config/aarch64/aarch64.c (aarch64_evpc_ext): Allow+handle location==0. ? --Alan Marcus Shawcroft wrote: On 3 June 2014 11:21, Alan Lawrence wrote: Ok, this fixes it. We'll output an ext...#0, which is little more than a MOV, but that seems appropriate in the circumst

Re: [AArch64/ARM 2/3] Detect EXT patterns to vec_perm_const, use for EXT intrinsics

2014-06-03 Thread Marcus Shawcroft
On 3 June 2014 11:21, Alan Lawrence wrote: > Ok, this fixes it. We'll output an ext...#0, which is little more than a > MOV, > but that seems appropriate in the circumstance. > > Regression tested check-gcc and check-g++ on aarch64-none-elf and > aarch64_be-none-elf. > > Ok for trunk? ChangeLog

Re: [PATCH][AARCH64]Support full addressing modes for ldr/str in vectorization scenarios

2014-06-03 Thread Marcus Shawcroft
On 28 May 2014 08:30, Bin.Cheng wrote: > Missing patch. > > On Wed, May 28, 2014 at 3:02 PM, bin.cheng wrote: >> Hi, >> I was surprised that GCC didn't support addressing modes like >> [REG+OFF]/[REG_REG] for instructions ldr/str in vectorization scenarios. >> The generated assembly is bad since

Re: [RFC] optimize x - y cmp 0 with undefined overflow

2014-06-03 Thread Richard Biener
On Tue, Jun 3, 2014 at 10:11 AM, Eric Botcazou wrote: >> Looks mostly ok. Any reason why you are not re-creating >> MINUS_EXPR in build_symbolic_expr? That is, build >> inv - t (for non-pointers, of course)? > > It's more uniform and compare_values expects an INTEGER_CST on the RHS, > although t

Re: [PATCH, Pointer Bounds Checker 21/x] Weakrefs output

2014-06-03 Thread Ilya Enkovich
2014-06-03 13:02 GMT+04:00 Richard Biener : > On Mon, Jun 2, 2014 at 5:22 PM, Ilya Enkovich wrote: >> Hi, >> >> This patch prevents output of both instrumented and not instrumented weakref >> variants. > > Shouldn't one of them be reclaimed instead at some point? Actually both version may be use

Re: libgo patch committed: Make libgo C code more portable

2014-06-03 Thread Rainer Orth
Ian Lance Taylor writes: > This patch to libgo, from Peter Collingbourne, changes some of the C > code to make it easier to compile libgo with a compiler other than GCC. > Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. > Committed to mainline. [...] > diff -r d73f07d002ef libgo/ru

Re: [build, driver] RFC: Support compressed debug sections

2014-06-03 Thread Rainer Orth
Rainer Orth writes: > "Joseph S. Myers" writes: [...] >> Thanks for the explanation. The driver changes are OK. > > Thanks. I still need approval for the doc and build parts, as well as > the Darwin and DJGPP changes. For the latter two, I've included the > patch in a x86_64-apple-darwin11.4.

Re: [build, doc, testsuite] Centralise clearing hardware capabilities with Sun ld

2014-06-03 Thread Rainer Orth
Hi Gerald, > On Tue, 27 May 2014, Mike Stump wrote: >> So, I read the doc bits, and they look fine. I’m not a doc reviewer, >> but, the changes are usual and customary for a port, and trivial. > > Yes, and I'd like to emphasize this point: Just because a file > matches *.texi doesn't mean that

Re: [AArch64/ARM 2/3] Detect EXT patterns to vec_perm_const, use for EXT intrinsics

2014-06-03 Thread Alan Lawrence
Ok, this fixes it. We'll output an ext...#0, which is little more than a MOV, but that seems appropriate in the circumstance. Regression tested check-gcc and check-g++ on aarch64-none-elf and aarch64_be-none-elf. Ok for trunk? --Alan Alan Lawrence wrote: Yes, reproduced. Seems the mid-end doe

Re: config-ml.in: Robustify ac_configure_args parsing.

2014-06-03 Thread Thomas Schwinge
Hi! Ping. On Thu, 22 May 2014 12:58:05 +0200, I wrote: > Ping. > > > On Fri, 14 Mar 2014 12:22:29 +0100, I wrote: > > $ ../configure --enable-foo='--enable-a=1 --enable-b=2 --enable-c=3' > > [...] > > $ make configure-zlib > > config.status: creating Makefile > > config.sta

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

2014-06-03 Thread Thomas Schwinge
Hi! Ping -- OK to commit to trunk? On Wed, 28 May 2014 23:55:31 +0200, Jan Hubicka wrote: > > On Mon, 26 May 2014 02:16:35 -0700, Andrew Pinski wrote: > > > On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres > > > wrote: > > > > r210901 breaks bootstrap on targets not supporting strnlen, e.

Re: [PATCH, Pointer Bounds Checker 26/x] CCP

2014-06-03 Thread Richard Biener
On Tue, Jun 3, 2014 at 9:38 AM, Ilya Enkovich wrote: > Hi, > > This patch allows BUILT_IN_CHKP_BNDRET as a consumer of a result of > BUILT_IN_STACK_SAVE call. > > Bootstrapped and tested on linux-x86_64. > > Thanks, > Ilya > -- > gcc/ > > 2014-06-03 Ilya Enkovich > > * tree-ssa-ccp.c (

Re: [PATCH][match-and-simplify]

2014-06-03 Thread Richard Biener
On Tue, 3 Jun 2014, Marc Glisse wrote: > On Tue, 3 Jun 2014, Richard Biener wrote: > > > On Mon, 2 Jun 2014, Marc Glisse wrote: > > > > > > > > >(plus (bit_not @0) @0) > > > >if (INTEGRAL_TYPE_P (TREE_TYPE (@0))) > > > >{ build_int_cst (TREE_TYPE (@0), -1); }) > > > > +(match_and_si

Re: [PATCH, Pointer Bounds Checker 25/x] DCE

2014-06-03 Thread Richard Biener
On Tue, Jun 3, 2014 at 9:23 AM, Ilya Enkovich wrote: > Hi, > > This patch adjusts alloc-free removal algorithm in DCE to take into account > BUILT_IN_CHKP_BNDRET call returning bounds of allocated memory. > > Bootstrapped and tested on linux-x86_64. > > Thanks, > Ilya > -- > gcc/ > > 2014-06-03

Re: [PATCH][match-and-simplify]

2014-06-03 Thread Marc Glisse
On Tue, 3 Jun 2014, Richard Biener wrote: On Mon, 2 Jun 2014, Marc Glisse wrote: (plus (bit_not @0) @0) if (INTEGRAL_TYPE_P (TREE_TYPE (@0))) { build_int_cst (TREE_TYPE (@0), -1); }) +(match_and_simplify + (plus @0 (bit_not @0)) + if (INTEGRAL_TYPE_P (TREE_TYPE (@0))) + { build_i

[COMMITTED] Add myself to MAINTAINERS file

2014-06-03 Thread Andrew Bennett
Hi, This patch adds myself to the MAINTAINERS file. Commmitted as r211167. The ChangeLog and patch are shown below. Regards, Andrew Andrew Bennett Software Design Engineer, MIPS Processor IP Imagination Technologies Limited t: +44 (0)113 2429814 www.imgtec.com 2014-06-03 Andrew Bennett

Re: [PATCH] Support asan-instrumentation-with-call-threshold in GCC (second try)

2014-06-03 Thread Konstantin Serebryany
On Tue, Jun 3, 2014 at 1:33 PM, Yury Gribov wrote: >> Any reason why the BUILT_IN_* names so differ from the actual function >> names? I.e. why not use BUILT_IN_ASAN_{LOAD,STORE}{1,2,4,8,16,N} >> (no underscore before N, no CHECK_)? > > > Makes sense. > >> Wouldn't it be better to do >> ... >> >>

  1   2   >