Re: Ping2: [PATCH] PR debug/16063. Add DW_AT_type to DW_TAG_enumeration.

2014-05-19 Thread Mark Wielaard
On Mon, May 19, 2014 at 04:50:35PM -0400, Jason Merrill wrote: > On 05/13/2014 03:21 AM, Mark Wielaard wrote: > >So the debugger doesn't have to guess the properties of the enum's > >underlying base type, like size, encoding and signedness. > > Well, the enum already has DW_AT_byte_size. It seems

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-19 Thread Xinliang David Li
Why duplicating the merger functions in dyn-ipa.c? Should those in libgcov-merge.c be reused? The refactoring of gcov_exit_write_gcda should probably be done in a separate patch -- preferably submitted to trunk too. David On Mon, May 19, 2014 at 10:08 PM, Teresa Johnson wrote: > Ping. > Teresa

Re: [PATCH, AArch64] Fix for PR61202

2014-05-19 Thread James Greenhalgh
On Tue, May 20, 2014 at 07:18:40AM +0100, Carrot Wei wrote: > Hi Hi, > The last operand of instruction sqdmulh can only be low fp registers, > so we should use constraint "x". But the intrinsic functions use "w". > This patch fixed the constrains in these intrinsics. This restriction is only on

[PATCH, AArch64] Fix for PR61202

2014-05-19 Thread Carrot Wei
Hi The last operand of instruction sqdmulh can only be low fp registers, so we should use constraint "x". But the intrinsic functions use "w". This patch fixed the constrains in these intrinsics. Passed dejagnu test on aarch64 qemu. OK for trunk, 4.9 and 4.8? thanks Guozhi Wei 2014-05-19 Guoz

Re: [PATCH, sched] Fix sched_insn debug counter

2014-05-19 Thread Jeff Law
On 05/19/14 18:47, Maxim Kuvyrkov wrote: Hi, This patch fixes sched_insn debug counter that was broken by modulo/backtracking changes. Tested on arm-linux-gnueabihf and x86_64-linux-gnu, though testsuite does not exercise this execution path. Real testing was done by me debugging an unrelated

Re: [PATCH, ia64] Remove IA64 speculation tweaking flags

2014-05-19 Thread Jeff Law
On 05/19/14 22:00, Maxim Kuvyrkov wrote: Hi, This patch removes msched-prefer-non-data-spec-insns and msched-prefer-non-control-spec-insns IA64 options and handling thereof. I have implemented these option during my youthful indiscrimination and, as far as I can tell, no one uses them. Yet, ha

Re: [PATCH, sched]

2014-05-19 Thread Jeff Law
On 05/19/14 21:39, Maxim Kuvyrkov wrote: This patch improves debug printouts for scheduling passes. Tested on arm-linux-gnueabihf and x86_64-linux-gnu. OK to apply? Yes. This is fine. jeff

Re: [Google/4_8] LIPO COMDAT profile fixups

2014-05-19 Thread Teresa Johnson
Ping. Teresa On Wed, May 14, 2014 at 4:39 PM, Teresa Johnson wrote: > This patch applies profile fixups to COMDATs on the dyn ipa callgraph > at the end of LIPO module grouping (either in the profile gen run or > in gcov-tool). This is to address issues with missing profiles in the > out-of-line

Re: [libstdc++/61227] Support regex like "[\w]"

2014-05-19 Thread Tim Shen
On Mon, May 19, 2014 at 11:49 AM, Jonathan Wakely wrote: > The patch is OK with the ChangeLog tweak and omitting the new file. Booted, tested and committed. Thanks! -- Regards, Tim Shen

Re: Eliminate write-only variables

2014-05-19 Thread Jan Hubicka
> On 05/18/2014 08:45 PM, Sandra Loosemore wrote: > >On 05/18/2014 02:59 PM, Jan Hubicka wrote: > >>For cases like local-statics-7 your approach can be "saved" by adding > >>simple IPA analysis > >>to look for static vars that are used only by one function and keeping > >>your DSE code active > >>f

[PATCH, sched] Cleanup and improve multipass_dfa_lookahead_guard

2014-05-19 Thread Maxim Kuvyrkov
Hi, This patch cleans up haifa-sched.c:choose_ready() function while allow more powerful customization by backends at the same time. The primary change is that targetm.sched.first_cycle_multipass_dfa_lookahead_guard hook is converted from returning a boolean OK/Nada value to returning an actio

Re: Eliminate write-only variables

2014-05-19 Thread Sandra Loosemore
On 05/18/2014 08:45 PM, Sandra Loosemore wrote: On 05/18/2014 02:59 PM, Jan Hubicka wrote: For cases like local-statics-7 your approach can be "saved" by adding simple IPA analysis to look for static vars that are used only by one function and keeping your DSE code active for them, so we can sti

[PATCH, ia64] Remove IA64 speculation tweaking flags

2014-05-19 Thread Maxim Kuvyrkov
Hi, This patch removes msched-prefer-non-data-spec-insns and msched-prefer-non-control-spec-insns IA64 options and handling thereof. I have implemented these option during my youthful indiscrimination and, as far as I can tell, no one uses them. Yet, handling of these options complicate logic

[PATCH, sched]

2014-05-19 Thread Maxim Kuvyrkov
This patch improves debug printouts for scheduling passes. Tested on arm-linux-gnueabihf and x86_64-linux-gnu. OK to apply? Thank you, -- Maxim Kuvyrkov www.linaro.org 0002-Improve-scheduling-debug-output.patch Description: Binary data

Re: [C++ Patch] PR 58664

2014-05-19 Thread Jason Merrill
On 05/19/2014 06:43 PM, Paolo Carlini wrote: if (unqualified_id) - error ("field %qD has incomplete type %qT", -unqualified_id, type); + cxx_incomplete_type_error (unqualified_id, type); else error ("name %qT has in

Re: [PATCH] Fix PR54733 Optimize endian independent load/store

2014-05-19 Thread Andrew Pinski
On Fri, May 16, 2014 at 9:58 AM, wrote: > > >> On May 16, 2014, at 4:13 AM, Richard Biener >> wrote: >> >> On Fri, May 16, 2014 at 1:03 PM, Richard Biener >> wrote: >>> On Fri, May 16, 2014 at 12:56 PM, wrote: > On May 16, 2014, at 3:48 AM, Richard Biener > wrote: > >

RE: [PATCH] Fix PR54733 Optimize endian independent load/store

2014-05-19 Thread Thomas Preud'homme
> From: Richard Biener [mailto:richard.guent...@gmail.com] > > Agreed, but I am happy with doing that as a followup. Btw, > a very simple one would be to reject unaligned > SLOW_UNALIGNED_ACCESS (TYPE_MODE (load_type), align). > [of course that may be true on MIPS even for the cases where > a "re

[PATCH, sched] Fix sched_insn debug counter

2014-05-19 Thread Maxim Kuvyrkov
Hi, This patch fixes sched_insn debug counter that was broken by modulo/backtracking changes. Tested on arm-linux-gnueabihf and x86_64-linux-gnu, though testsuite does not exercise this execution path. Real testing was done by me debugging an unrelated problem in the scheduler using sched_ins

Re: [libstdc++/61227] Support regex like "[\w]"

2014-05-19 Thread Tim Shen
On Mon, May 19, 2014 at 11:28 AM, Paolo Carlini wrote: > I suggest rewording this or avoiding it completely. Sorry, I just can't tolerate my former quick & dirty code. On Mon, May 19, 2014 at 2:49 PM, Jonathan Wakely wrote: > I'm going to check in my factoring patches soon, so there's no need t

Re: [PATCH] Fix ARM NAN fraction bits

2014-05-19 Thread Maciej W. Rozycki
Ian, On Sat, 17 May 2014, Richard Biener wrote: > On May 17, 2014 12:22:23 AM CEST, "Maciej W. Rozycki" > wrote: > >On Fri, 16 May 2014, Joseph S. Myers wrote: > > > >> > 2014-05-16 Maciej W. Rozycki > >> > > >> > PR libgcc/60166 > >> > * sysdeps/arm/soft-fp/sfp-machine.h (_FP_NANFRAC_S,

Re: patch to fix PR60969

2014-05-19 Thread H.J. Lu
On Mon, May 19, 2014 at 2:37 PM, James Greenhalgh wrote: > On Fri, May 16, 2014 at 06:49:45PM +0100, Vladimir Makarov wrote: >>The following patch fixes >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60969 >> >> The patch was bootstrapped and tested on x86/x86-64. >> >> Committed as rev. 2

Re: [C++ Patch] PR 58664

2014-05-19 Thread Paolo Carlini
... in fact, I need to be more careful when comparing the types, also because of cv-qualifiers, eg, for: struct S { const S s[1] = { 0 }; }; the trees for S and const S are definitely different. Done in the attached. Thanks, Paolo. /// /cp 2014-05-20 Paolo Carlini

[C++ Patch] PR 58664

2014-05-19 Thread Paolo Carlini
Hi, first blush, this is just an ICE on invalid for a quite special case. However, comparing the union case to the struct case (on which we don't ICE): struct S { S s[1] = { 0 }; }; xxx.C:3:16: error: could not convert ‘0’ from ‘int’ to ‘S’ S s[1] = { 0 }; shows that in this area there is d

Re: [PATCH] Ensure count_scale is no larger than REG_BR_PROB_BASE

2014-05-19 Thread Jan Hubicka
> On Mon, May 19, 2014 at 1:40 PM, Jan Hubicka wrote: > >> I've updated the patch. Shall I move the check inside cgraph_clone_node? > > > > Thanks, > > I think it is OK as it is. I belive individual users should know what do to > > in such cases themselves. > > You may want to also check what ipa-

Re: RFA: PATCH to allow DECL_COMDAT_GROUP to be a DECL

2014-05-19 Thread Jan Hubicka
> I was playing around with this a few months ago but set it aside > because we weren't in stage 1 at the time. The way we currently set > up comdat groups early means that we need to mangle decls early, > significantly negating the earlier work to lazily set > DECL_ASSEMBLER_NAME. This patch imp

[patch] Use Python3 raise syntax in printers

2014-05-19 Thread Jonathan Wakely
This is a partial patch to make the printers work with Python2 and Python3, there are more changes needed but this bit is simple. Tested x86_64-linux, committed to trunk. commit 0f4c27366c14976900d0420c7c4318d6cc1cbf67 Author: Jonathan Wakely Date: Mon May 19 22:18:13 2014 +0100 * python

Re: [PATCH, libgfortran] Add overflow check to xmalloc

2014-05-19 Thread Janne Blomqvist
On Thu, May 15, 2014 at 1:00 AM, Janne Blomqvist wrote: > Hi, > > a common malloc() pattern is "malloc(num_foo * sizeof(foo_t)", that > is, create space for an array of type foo_t with num_foo elements. > There is a slight danger here in that the multiplication can overflow > and wrap around, and

Re: patch to fix PR60969

2014-05-19 Thread James Greenhalgh
On Fri, May 16, 2014 at 06:49:45PM +0100, Vladimir Makarov wrote: >The following patch fixes > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60969 > > The patch was bootstrapped and tested on x86/x86-64. > > Committed as rev. 210519 to gcc 4.9 branch and as rev. 210520 to trunk. > > 2014-0

Re: [PATCH] Fix PR middle-end/61141

2014-05-19 Thread John David Anglin
Hi Jeff, On 19-May-14, at 1:51 PM, Jeff Law wrote: On 05/18/14 09:33, John David Anglin wrote: The attached change appears to fix PR middle-end/61141. On PA, we can get deleted insn notes in call sequences. The attached change checks to make sure we have a valid insn before calling reset_i

Re: [PATCH] Ensure count_scale is no larger than REG_BR_PROB_BASE

2014-05-19 Thread Dehao Chen
On Mon, May 19, 2014 at 1:40 PM, Jan Hubicka wrote: >> I've updated the patch. Shall I move the check inside cgraph_clone_node? > > Thanks, > I think it is OK as it is. I belive individual users should know what do to > in such cases themselves. > You may want to also check what ipa-cp is doing.

Re: [GCC RFC]A new and simple pass merging paired load store instructions

2014-05-19 Thread Mike Stump
On May 19, 2014, at 10:30 AM, Jeff Law wrote: >> Yes, I think it's more than upsizing the mode. There is another >> example from one of x86's candidate peephole patch at >> https://gcc.gnu.org/ml/gcc-patches/2014-04/msg00467.html >> >> The patch wants to do below transformation, which I think is

Re: [patch ping] libstdc++ testsuite cxxflags

2014-05-19 Thread Sandra Loosemore
On 05/17/2014 04:07 AM, Jonathan Wakely wrote: On 17 May 2014 10:50, Jonathan Wakely wrote: On 17 May 2014 01:16, Sandra Loosemore wrote: It appears that this patch from last fall never got reviewed. https://gcc.gnu.org/ml/gcc-patches/2013-10/msg02340.html Can someone take a look? I'll commi

Re: Ping2: [PATCH] PR debug/16063. Add DW_AT_type to DW_TAG_enumeration.

2014-05-19 Thread Jason Merrill
On 05/13/2014 03:21 AM, Mark Wielaard wrote: So the debugger doesn't have to guess the properties of the enum's underlying base type, like size, encoding and signedness. Well, the enum already has DW_AT_byte_size. It seems to me that it should also have DW_AT_encoding to provide the other two

Re: RFA: Fix PR rtl-optimization/60651

2014-05-19 Thread Jeff Law
On 04/02/14 11:40, Joern Rennecke wrote: On 2 April 2014 17:34, Joern Rennecke wrote: Hmm, the sanity check in new_seginfo caused a boostrap failure building libjava on x86. There was a block with CODE_LABEL as basic block head, otherwise empty. I've added the testcase - and a bit more detail

Re: [PATCH] Ensure count_scale is no larger than REG_BR_PROB_BASE

2014-05-19 Thread Jan Hubicka
> I've updated the patch. Shall I move the check inside cgraph_clone_node? Thanks, I think it is OK as it is. I belive individual users should know what do to in such cases themselves. You may want to also check what ipa-cp is doing. Patch is OK (with Changelog) Honza > > Thanks, > Dehao > > In

Re: [libstdc++/61227] Support regex like "[\w]"

2014-05-19 Thread Jonathan Wakely
On 19/05/14 11:08 -0400, Tim Shen wrote: * testsuite/28_regex/algorithms/regex_match/ecma/char/quoted_char.cc: New testcase. This sounds like it's adding a new file, not extending it with new tests. @@ -435,6 +439,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION std::vector<_CharT>

[PATCH, libgfortran] PR60324 Handle arbitrarily long path names

2014-05-19 Thread Janne Blomqvist
Hello, some systems such as GNU Hurd, don't define PATH_MAX at all, and on some other systems many syscalls apparently work for paths longer than PATH_MAX. Thus GFortran shouldn't truncate paths to PATH_MAX characters, but rather use heap allocated buffers limited only by the available memory. The

Re: [PATCH] Ensure count_scale is no larger than REG_BR_PROB_BASE

2014-05-19 Thread Dehao Chen
I've updated the patch. Shall I move the check inside cgraph_clone_node? Thanks, Dehao Index: gcc/ipa-inline-transform.c === --- gcc/ipa-inline-transform.c (revision 210535) +++ gcc/ipa-inline-transform.c (working copy) @@ -183,8 +18

RFA: PATCH to allow DECL_COMDAT_GROUP to be a DECL

2014-05-19 Thread Jason Merrill
I was playing around with this a few months ago but set it aside because we weren't in stage 1 at the time. The way we currently set up comdat groups early means that we need to mangle decls early, significantly negating the earlier work to lazily set DECL_ASSEMBLER_NAME. This patch improves

Re: [patch] libstdc++/61143 make unordered containers usable after move

2014-05-19 Thread François Dumont
On 15/05/2014 22:52, Jonathan Wakely wrote: On 15/05/14 22:20 +0200, François Dumont wrote: Hi Here is a proposal to fix PR 61143. As explained in the PR I finally prefer to leave the container in a valid state that is to say with a non zero number of bucket, that is to say 1, after a move

Re: [C++ Patch/RFC] PR 58753 & 58930

2014-05-19 Thread Paolo Carlini
Hi, > On 19/mag/2014, at 20:28, Jason Merrill wrote: > > How about doing digest_init in get_nsdmi, so that the conversion is also > exposed to walk_field_subobs? Thanks, I'll look into that. Paolo

[patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-05-19 Thread Sandra Loosemore
Catherine included an earlier version of this patch with the microMIPS submission a couple years ago: https://gcc.gnu.org/ml/gcc-patches/2012-07/msg00972.html Richard's response was: Looks like the wrong place to do this. Please treat this as a separate patch and get a tree expert to comment

Ping4: [PATCH] PR debug/16063. Add DW_AT_type to DW_TAG_enumeration.

2014-05-19 Thread Mark Wielaard
Rebased patch to current master attached. DWARF parts approved by Cary Coutant, GDB already contains Tom Tromey's code to take advantage of the new information. Earlier discussions: https://gcc.gnu.org/ml/gcc-patches/2014-04/msg00713.html https://gcc.gnu.org/ml/gcc-patches/2014-04/msg01859.html htt

Re: [libcpp] modify undef diagnostic

2014-05-19 Thread Jeff Law
On 04/29/14 09:28, Prathamesh Kulkarni wrote: Append "evaluates to 0", in Wundef diagnostic. clang prints the following diagnostic for -Wundef: undef.c:1:5: warning: 'FOO' is not defined, evaluates to 0 [-Wundef] #if FOO ^ OK to commit ? [libcpp] * expr.c (eval_token): Modify Wundef diagno

Re: [RFC] HOST_WIDE_INT transition steps

2014-05-19 Thread Richard Sandiford
Richard Biener writes: > The following is my current idea on progressing on the HOST_WIDE_INT > removal > > 1) https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00381.html (ping) > > 2) make sure [u]int64_t is available and use that to define HOST_WIDE_INT > > 3) s/HOST_WIDE_INT/int64_t/ (same for uns

Re: RFA: speeding up dg-extract-results.sh

2014-05-19 Thread Charles Baylis
On 19 May 2014 19:07, Richard Sandiford wrote: > > Sorry for the breakage. I wanted to make the script as picky as I could > get away with though, so that results aren't lost accidentally. > > Could you try the attached? That works for me. Thanks for looking into it.

Re: RFC: Faster for_each_rtx-like iterators

2014-05-19 Thread Richard Sandiford
Jeff Law writes: > On 05/17/14 01:33, Richard Sandiford wrote: >> I suppose we could put the onus on the users of the iterator to invoke >> a "handle subrtxes of this code" routine once they know what the code is. >> That could make things a bit ugly though. E.g.: >> >>FOR_EACH_SUBRTX (iter,

C++ PATCH for c++/58761 (lambda 'this' capture in NSDMI)

2014-05-19 Thread Jason Merrill
The problem in this testcase was that when we go to instantiate the lambda in the NSDMI, since it wasn't defined in a function we push_to_top_level and thereby clobber the current_class_ptr we set up. Tested x86_64-pc-linux-gnu, applying to trunk. commit e9fdfb3ea5ea6672a2dd72d3ed717686fe060cef

Re: [C++ Patch/RFC] PR 58753 & 58930

2014-05-19 Thread Jason Merrill
How about doing digest_init in get_nsdmi, so that the conversion is also exposed to walk_field_subobs? Jason

Re: [PATCH] C++ thunk section names

2014-05-19 Thread Sriraman Tallam
Ping. On Thu, Apr 17, 2014 at 10:41 AM, Sriraman Tallam wrote: > Ping. > > On Wed, Feb 5, 2014 at 4:31 PM, Sriraman Tallam wrote: >> Hi, >> >> I would like this patch reviewed and considered for commit when >> Stage 1 is active again. >> >> Patch Description: >> >> A C++ thunk's section name i

Re: RFC: Faster for_each_rtx-like iterators

2014-05-19 Thread Jeff Law
On 05/17/14 01:33, Richard Sandiford wrote: I suppose we could put the onus on the users of the iterator to invoke a "handle subrtxes of this code" routine once they know what the code is. That could make things a bit ugly though. E.g.: FOR_EACH_SUBRTX (iter, array, expr, NONCONST) if (

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

2014-05-19 Thread Sriraman Tallam
Ping. On Thu, May 15, 2014 at 11:34 AM, Sriraman Tallam wrote: > Optimize access to globals with -fpie, x86_64 only: > > Currently, with -fPIE/-fpie, GCC accesses globals that are extern to the > module > using the GOT. This is two instructions, one to get the address of the global > from the G

Re: RFA: speeding up dg-extract-results.sh

2014-05-19 Thread Richard Sandiford
Charles Baylis writes: > On 13 February 2014 09:18, Richard Sandiford > wrote: >> This patch tries to reduce that by providing an alternative single-script >> version. I was torn between Python and Tcl, but given how most people >> tend to react to Tcl, I thought I'd better go for Python. I wo

Re: [PATCH] Fix PR middle-end/61141

2014-05-19 Thread Jeff Law
On 05/18/14 09:33, John David Anglin wrote: The attached change appears to fix PR middle-end/61141. On PA, we can get deleted insn notes in call sequences. The attached change checks to make sure we have a valid insn before calling reset_insn_used_flags and verify_insn_sharing. Tested on hppa-

Re: [GCC RFC]A new and simple pass merging paired load store instructions

2014-05-19 Thread Jeff Law
On 05/19/14 00:38, Bin.Cheng wrote: On Sat, May 17, 2014 at 12:32 AM, Jeff Law wrote: On 05/16/14 04:07, Bin.Cheng wrote: Yes, I think this one does have a good reason. The target independent pass just makes sure that two consecutive memory access instructions are free of data-dependency wit

Re: Eliminate write-only variables

2014-05-19 Thread Joseph S. Myers
On Sun, 18 May 2014, Sandra Loosemore wrote: > H, I'm guessing this was some concern about invalid code motion around a > setjmp. Our original analysis document lists "F does not call setjmp" as a > requirement for the optimization, so this was probably a case where we were > being excessivel

Re: [DOC Patch] Label attributes

2014-05-19 Thread Jeff Law
On 05/18/14 22:36, David Wohlferd wrote: 2014-05-18 David Wohlferd * doc/extend.texi: Create Label Attributes section, move all label attributes into it and reference it. THanks. Installed. If you're going to continue to submit changes with any regularity, then it would

Re: [C++ Patch] Use inform in 2 places

2014-05-19 Thread Jason Merrill
OK. Jason

Re: we are starting the wide int merge

2014-05-19 Thread Richard Sandiford
Richard Sandiford writes: > Gerald Pfeifer writes: >> On Sat, 17 May 2014, Richard Sandiford wrote: >>> To rule out one possibility: which GCC are you using for stage1? >> >> I think that may the smoking gun. When I use GCC 4.7 to bootstrap, >> FreeBSD 8, 9 and 10 all build fine on i386 (= i486)

Re: [PATCH, i386, Pointer Bounds Checker 2/x] Intel Memory Protection Extensions (MPX) instructions support

2014-05-19 Thread Jeff Law
On 05/19/14 02:19, Ilya Enkovich wrote: On 16 May 13:39, Jeff Law wrote: On 04/16/14 05:35, Ilya Enkovich wrote: Hi, This patch introduces Intel MPX bound registers and instructions. It was approved earlier for 4.9 and had no significant changes since then. I'll assume patch is OK if no ob

Add wide-int reviewers

2014-05-19 Thread Mike Stump
So, before we forget to do this… https://gcc.gnu.org/ml/gcc/2014-04/msg00284.html Index: MAINTAINERS === --- MAINTAINERS (revision 210619) +++ MAINTAINERS (working copy) @@ -301,6 +301,9 @@ register allocation Kenneth Zadeck

Re: [PATCH PING^2] Simplify a VEC_SELECT fed by its own inverse

2014-05-19 Thread Jeff Law
On 05/19/14 07:10, Bill Schmidt wrote: Hi, I'd like to once again ping this patch from 2014-04-22: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01319.html OK for the trunk. Thanks for your patience. jeff

Re: [GCC RFC]A new and simple pass merging paired load store instructions

2014-05-19 Thread Jeff Law
On 05/19/14 00:38, Bin.Cheng wrote: 1) Should we do it in a separated pass, or just along with scheduler? ISTM that when we're able to combine insns that can impact the schedule we'd like to generate, possibly in significant ways. That argues for a separate pass that runs before the scheduler.

Re: [PATCH][1/n] Always-64bit HWI cleanups

2014-05-19 Thread Jeff Law
On 05/19/14 07:58, Richard Biener wrote: On Wed, 7 May 2014, Richard Biener wrote: This removes the need_64bit_hwi logic, nothing else (well, brings libcpp in line with gcc). Bootstrap / regtest pending on x86_64-unknown-linux-gnu. Bootstrapped and tested on x86_64-unknown-linux-gnu, ok for

Re: [PATCH 1/3] Handwritten part of conversion of "gimple" to "gimple *"

2014-05-19 Thread David Malcolm
On Wed, 2014-05-14 at 12:09 -0600, Jeff Law wrote: > On 05/12/14 15:36, David Malcolm wrote: > [ ... Big Snip ... ] > This series of 3 patches is approved. FWIW, I've been working my way through the remainder of the patches, updating them to take account of the largely mechanical changes [1] for t

Re: [patch] Fix over-optimization of calls to pure function

2014-05-19 Thread Jeff Law
On 05/19/14 02:58, Eric Botcazou wrote: Hi, this fixes an over-optimization of the GIMPLE optimizer, whereby two otherwise identical calls to a pure function present in different EH regions are CSEd, which changes the semantics of the program because the second EH handler is not invoked: beg

Re: [PATCH] Fix PR61221

2014-05-19 Thread Richard Biener
On May 19, 2014 6:57:52 PM CEST, Jeff Law wrote: >On 05/19/14 06:54, Richard Biener wrote: >> >> In this PR we run into the issue that releasing SSA names from >> FRE/PRE elimination corrupts the VN lattice and thus the VN lookup >> we perform for removing redudnant stores ICEs. The patch works >

Re: [PATCH i386 5/8] [AVX-512] Extend vectorizer hooks.

2014-05-19 Thread H.J. Lu
On Mon, May 19, 2014 at 9:45 AM, Uros Bizjak wrote: > On Mon, May 19, 2014 at 6:42 PM, H.J. Lu wrote: > Uros, I am looking into libreoffice size and the data alignment seems to make huge difference. Data section has grown from 5.8MB to 6.3MB in between GCC 4.8 and 4.9,

Re: [PATCH] Fix PR61221

2014-05-19 Thread Jeff Law
On 05/19/14 06:54, Richard Biener wrote: In this PR we run into the issue that releasing SSA names from FRE/PRE elimination corrupts the VN lattice and thus the VN lookup we perform for removing redudnant stores ICEs. The patch works around the particular case by making unreachable code detecti

Re: [PATCH i386 5/8] [AVX-512] Extend vectorizer hooks.

2014-05-19 Thread Uros Bizjak
On Mon, May 19, 2014 at 6:42 PM, H.J. Lu wrote: >>> Uros, >>> I am looking into libreoffice size and the data alignment seems to make huge >>> difference. Data section has grown from 5.8MB to 6.3MB in between GCC 4.8 >>> and 4.9, >>> while clang produces 5.2MB. >>> >>> The two patches I posted t

Re: [PATCH i386 5/8] [AVX-512] Extend vectorizer hooks.

2014-05-19 Thread H.J. Lu
On Mon, May 19, 2014 at 9:14 AM, Uros Bizjak wrote: > On Mon, May 19, 2014 at 6:48 AM, Jan Hubicka wrote: >>> > Thanks for the pointer, there is indeed the recommendation in >>> > optimization manual [1], section 3.6.4, where it is said: >>> > >>> > --quote-- >>> > Misaligned data access can incu

Re: PR 61084: Use widest_int in sparc_fold_builtin

2014-05-19 Thread Mike Stump
On May 19, 2014, at 12:27 AM, Richard Sandiford wrote: > Does anyone have any suggestions for a better name than "wide_int" though? Please, no. > The main property of wide_int is that it has a variable precision, whereas > widest_int and offset_int have constant precisions. Right, I'd clarify

[PATCH, ARM] Fix segfault in thumb1_reorg

2014-05-19 Thread Richard Earnshaw
A fault in thumb1_reorg means we can try to get the insn_code of something that isn't an insn. This appears to be a latent problem that's suddenly started to bite on trunk. The code in question appears to go back to gcc-4.8. RTL checking would probably have found this quickly, but that's very ex

Re: [PATCH 2/2, x86] Add palignr support for AVX2.

2014-05-19 Thread Richard Henderson
On 05/05/2014 09:54 AM, Evgeny Stupachenko wrote: > @@ -42943,6 +42944,10 @@ expand_vec_perm_1 (struct expand_vec_perm_d *d) >if (expand_vec_perm_vpermil (d)) > return true; > > + /* Try palignr on one operand. */ > + if (d->one_operand_p && expand_vec_perm_palignr (d)) > +return t

Re: [PATCH i386 5/8] [AVX-512] Extend vectorizer hooks.

2014-05-19 Thread Uros Bizjak
On Mon, May 19, 2014 at 6:48 AM, Jan Hubicka wrote: >> > Thanks for the pointer, there is indeed the recommendation in >> > optimization manual [1], section 3.6.4, where it is said: >> > >> > --quote-- >> > Misaligned data access can incur significant performance penalties. >> > This is particular

Re: [libstdc++/61227] Support regex like "[\w]"

2014-05-19 Thread Paolo Carlini
Hi, On 05/19/2014 05:08 PM, Tim Shen wrote: + // TODO Refactor this piece of junk. I suggest rewording this or avoiding it completely. Paolo.

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-05-19 Thread Richard Henderson
On 05/05/2014 09:49 AM, Evgeny Stupachenko wrote: > @@ -42946,6 +42948,10 @@ expand_vec_perm_1 (struct expand_vec_perm_d *d) >if (expand_vec_perm_pshufb (d)) > return true; > > + /* Try the AVX2 vpshufb. */ > + if (expand_vec_perm_vpshufb2_vpermq (d)) > +return true; Why is this h

Re: add dbgcnt and opt-info support for devirtualization

2014-05-19 Thread Xinliang David Li
Sorry about it. Here is the patch. There is one remaining case where cgraph_dump_file and dump_enable_p are checked separately -- cgraph_dump_file is set up differently from 'dump_file'. David On Mon, May 19, 2014 at 2:21 AM, Richard Biener wrote: > On Fri, May 16, 2014 at 11:19 PM, Xinliang

[libstdc++/61227] Support regex like "[\w]"

2014-05-19 Thread Tim Shen
Here's the patch. I did a simple test on 28_regex/*. A bootstrap may be needed, but I can't do it now. -- Regards, Tim Shen commit 2fd6be816c1d1797b3aad228b9fb2cfb7374483c Author: tim Date: Mon May 19 10:40:16 2014 -0400 2014-05-19 Tim Shen PR libstdc++/61227 * include

Re: [C++ patch] Reduce vtable alignment

2014-05-19 Thread Jan Hubicka
> > Hmm, but if the optimizers or the target can rely on DATA_ABI_ALIGNMENT > > then we can't really lower it. Because we can make the vtable escape > > to another unit that sees it as just an array of pointers? > > Sure, they can rely on DATA_ABI_ALIGNMENT (if that macro is defined), but > anyth

Re: [C++ patch] Enable constructor decloning by default

2014-05-19 Thread Jakub Jelinek
On Mon, May 19, 2014 at 04:45:02PM +0200, Jan Hubicka wrote: > > On Sun, May 18, 2014 at 9:32 PM, Jan Hubicka wrote: > > > Hi, > > > this patch enables -fdeclone-ctor-dtor by default: I believe it is up to > > > the > > > optimizers to decide when the actual worker body should be inlined into >

Re: [C++ patch] Enable constructor decloning by default

2014-05-19 Thread Jan Hubicka
> On Sun, May 18, 2014 at 9:32 PM, Jan Hubicka wrote: > > Hi, > > this patch enables -fdeclone-ctor-dtor by default: I believe it is up to the > > optimizers to decide when the actual worker body should be inlined into the > > thunks. > > > > Bootstrapped/regtested x86_64-linux, OK? > > Please ma

Re: [PATCH] aarch64 suuport for libitm

2014-05-19 Thread Richard Henderson
On 05/19/2014 05:15 AM, Marcus Shawcroft wrote: > On 1 April 2014 23:24, Richard Henderson wrote: >> Comments? If approved, should this go in for 4.9, or wait for stage1? >> Certainly it's self-contained... > > > Hi, I think this should go in, with the cache line increased to 128 as > discussed

Re: [patch] Fix over-optimization of calls to pure function

2014-05-19 Thread Jan Hubicka
> Hi, > > this fixes an over-optimization of the GIMPLE optimizer, whereby two > otherwise > identical calls to a pure function present in different EH regions are CSEd, > which changes the semantics of the program because the second EH handler is > not invoked: > > begin > I := F(0); >

Re: -fuse-caller-save - Collect register usage information

2014-05-19 Thread Tom de Vries
On 17-05-14 12:51, Eric Botcazou wrote: This is the updated version of the previously approved patch submitted here (http://gcc.gnu.org/ml/gcc-patches/2013-03/msg01320.html ). The changes are: - using a new hook call_fusage_contains_non_callee_clobbers, - incorporating minor review comments from

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-19 Thread Arnaud Charlet
> > That's actually the biggest concern when people submit a new port: they > > submit it, get it approved, commit it and then are no longer available > > for any maintenance when these files need to be updated/become outdated/ > > no longer compile or run. > > I can try to do that in the near fut

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-19 Thread Svante Signell
On Mon, 2014-05-19 at 15:53 +0200, Arnaud Charlet wrote: > > Do you want me to remove all GNU/Hurd specific header file info? > > No, I want you to remove commented out code, such as: > > > +-- SIGLTHRRES : constant := 32; -- GNU/LinuxThreads restart signal > > +-- SIGLTHRCAN : constant := 3

Re: [PATCH][1/n] Always-64bit HWI cleanups

2014-05-19 Thread Richard Biener
On Wed, 7 May 2014, Richard Biener wrote: > > This removes the need_64bit_hwi logic, nothing else (well, brings > libcpp in line with gcc). > > Bootstrap / regtest pending on x86_64-unknown-linux-gnu. Bootstrapped and tested on x86_64-unknown-linux-gnu, ok for trunk? Thanks, Richard. > Just a

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-19 Thread Arnaud Charlet
> Do you want me to remove all GNU/Hurd specific header file info? No, I want you to remove commented out code, such as: > +-- SIGLTHRRES : constant := 32; -- GNU/LinuxThreads restart signal > +-- SIGLTHRCAN : constant := 33; -- GNU/LinuxThreads cancel signal > +-- SIGLTHRDBG : constant :

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-19 Thread Svante Signell
On Mon, 2014-05-19 at 14:50 +0200, Arnaud Charlet wrote: > > The build went fine. Is something still missing? > > We never keep commented out code, except with a ??? comment explaining why. Do you want me to remove all GNU/Hurd specific header file info? > We don't use 'FIXME', we use ??? instea

[PATCH PING^2] Simplify a VEC_SELECT fed by its own inverse

2014-05-19 Thread Bill Schmidt
Hi, I'd like to once again ping this patch from 2014-04-22: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01319.html Thanks! Bill

Re: [GCC RFC]A new and simple pass merging paired load store instructions

2014-05-19 Thread Jeff Law
On 05/19/14 00:38, Bin.Cheng wrote: On Sat, May 17, 2014 at 12:52 AM, Mike Stump wrote: On May 16, 2014, at 3:07 AM, Bin.Cheng wrote: I don't see how regrename will help resolve [base+offset] false dependencies. Can you explain? I'd expect effects from hardreg-copyprop "commoning" a base re

Re: [AArch64/ARM 2/3] Recognize shuffle patterns for REV instructions on AArch64, rewrite intrinsics.

2014-05-19 Thread Marcus Shawcroft
On 15 May 2014 16:52, Alan Lawrence wrote: > 2014-05-15 Alan Lawrence > > * config/aarch64/aarch64-simd.md > (aarch64_rev): > New pattern. > * config/aarch64/aarch64.c (aarch64_evpc_rev): New function. > (aarch64_expand_vec_perm_const_1): Add call to aarch64_evp

[PATCH] Fix PR61221

2014-05-19 Thread Richard Biener
In this PR we run into the issue that releasing SSA names from FRE/PRE elimination corrupts the VN lattice and thus the VN lookup we perform for removing redudnant stores ICEs. The patch works around the particular case by making unreachable code detection in SCCVN more optimistic by ignoring bac

Re: [AArch64/ARM 2/3] Detect EXT patterns to vec_perm_const, use for EXT intrinsics

2014-05-19 Thread Marcus Shawcroft
On 23 April 2014 21:22, Alan Lawrence wrote: > 2014-03-27 Alan Lawrence > * config/aarch64/aarch64-builtins.c > (aarch64_types_binopv_qualifiers, > TYPES_BINOPV): New static data. > * config/aarch64/aarch64-simd-builtins.def (im_lane_bound): New > builtin. > * c

[PATCH] Fix PR61209

2014-05-19 Thread Richard Biener
This fixes PR61209, we were leaking VN_TOP into the cached expr used for folding. That's of course a no-no. Bootstrap and regtest ongoing on x86_64-unknown-linux-gnu. Richard. 2014-05-19 Richard Biener PR tree-optimization/61209 * tree-ssa-sccvn.c (visit_phi): Avoid setting

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-19 Thread Arnaud Charlet
> The build went fine. Is something still missing? We never keep commented out code, except with a ??? comment explaining why. We don't use 'FIXME', we use ??? instead. Also, some of the comments seem to be copy/paste from freebsd, which is likely not appropriate for GNU Hurd, so need to be revis

[RFC] HOST_WIDE_INT transition steps

2014-05-19 Thread Richard Biener
The following is my current idea on progressing on the HOST_WIDE_INT removal 1) https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00381.html (ping) 2) make sure [u]int64_t is available and use that to define HOST_WIDE_INT 3) s/HOST_WIDE_INT/int64_t/ (same for unsigned HOST_WIDE_INT) Leaves us with

Re: [aarch64] Remove aarch64_function_profiler prototype

2014-05-19 Thread Marcus Shawcroft
On 30 April 2014 18:42, Ryan Mansfield wrote: > aarch64_function_profiler was removed in rev203028 but the prototype was > left behind. If OK, can someone apply? Thanks. > > Regards, > > Ryan Mansfield > > 2014-04-30 Ryan Mansfield > > * config/aarch64/aarch64-protos.h (aarch64_function

Re: [patch] Fix over-optimization of calls to pure function

2014-05-19 Thread Richard Biener
On Mon, May 19, 2014 at 12:11 PM, Eric Botcazou wrote: >> I thought we had decided a long time ago that pure and const functions could >> not throw and that was the documented behavior. > > No, it's precisely the opposite. Btw, I agree. For this and other attributes the behavior is that it speci

  1   2   >