On Fri, 4 Apr 2014 08:18:26 +0200
Jan Hubicka wrote:
> Hi,
> here is an updated version of my earlier ipa.c change. It turns out that the
> problem was that I did not drop always_inline.
> In this version I just drop always_inline attribute on all functions whose
> body is removed. The patch wi
On Sat, Apr 05, 2014 at 05:22:09PM +0200, Bernd Schmidt wrote:
> On 04/05/2014 05:04 PM, Thomas Schwinge wrote:
> >Is it a linker bug that I need to add something like the following?
> >
> >--- libgcc/ompstuff.c
> >+++ libgcc/ompstuff.c
> >@@ -40,6 +40,12 @@ see the files COPYING3 and COPYING.RUNTI
On Mon, Apr 07, 2014 at 01:23:57PM -0700, Steve Ellcey wrote:
> This test that you added on March 12th has always been failing
> for me on MIPS. It looks like you expect MIPS to optimize the
> if statement but mips.h has:
>
> #define LOGICAL_OP_NON_SHORT_CIRCUIT 0
I wasn't aware of this.
> So
On Mon, 7 Apr 2014, Jeff Law wrote:
I am also afraid we may get more false positives, but maybe not.
The only false positives should come from paths which are unexecutable. One
could argue that if we find any that we should warn, then isolate the path so
that we get an immediate runtime trap
Hi,
while looking into devirtualization dumps, I noticed that I got one "false"
typed out as "true". Not sure what I was thinking of.
Martin, this may fix the wrong code issue you see in Firefox, hopefully.
Will commit it after x86_64-linux testing finishes tomorrow.
Honza
* ipa-devirt.c
Hi,
I'm withdrawing this request as I just discovered it will sometimes be
advantageous to use vnand rather than vnor; will rework this and get
back to you.
Thanks,
Bill
On Fri, 2014-04-04 at 15:45 -0500, Bill Schmidt wrote:
> On Thu, 2014-03-20 at 20:38 -0500, Bill Schmidt wrote:
> > The origin
On 04/07/14 12:51, Marc Glisse wrote:
I would tend to start from the return statements (assuming the return
type is a pointer), look at the defining statement, do things if it is
an assignment of an addr_expr, and recurse if it is a PHI. But maybe my
brain is cabled backwards ;-)
It works eith
On Apr 7, 2014, at 10:57 AM, Marek Polacek wrote:
> On Sun, Apr 06, 2014 at 09:46:12AM -0700, Mike Stump wrote:
>> On Apr 5, 2014, at 10:36 AM, Marek Polacek wrote:
>>>
>>> I'll wait a day or two for possible comments.
>>
>> So, my only comment would be it would be nice to document the flags th
Hi,
This patch teaches the C++ frontend how to handle function attributes
attached to pointer-to-member-function declarations.
I bootstrapped and regtested this patch on x86_64-unknown-linux-gnu.
2014-04-05 Patrick Palka
PR c++/60765
* decl2.c (cplus_decl_attributes): Handle
Hello,
This patch fixes fixes an erroneous -Wnonnull warning when calling a
constructor declared with __attribute__ ((nonnull (1))). The issue is
that a NULL pointer is used as the placeholder object for the "this"
parameter of the constructor method call until a target object is
determined and s
Jakub,
This test that you added on March 12th has always been failing
for me on MIPS. It looks like you expect MIPS to optimize the
if statement but mips.h has:
#define LOGICAL_OP_NON_SHORT_CIRCUIT 0
So the if always shows up in ssa-ifcombine-13.c.169t.optimized.
Should MIPS be removed from t
ok (after fixing the format -- a function name starts a new line in
function def).
David
On Mon, Apr 7, 2014 at 12:49 PM, Dehao Chen wrote:
> This patch calls add_fake_edge for the AutoFDO+LIPO path.
>
> Bootstrapped and passed regression test and performance test.
>
> OK for google-4_8?
>
> Th
This patch calls add_fake_edge for the AutoFDO+LIPO path.
Bootstrapped and passed regression test and performance test.
OK for google-4_8?
Thanks,
Dehao
Index: gcc/auto-profile.c
===
--- gcc/auto-profile.c (revision 209123)
+++ gcc
On 04/07/2014 03:46 PM, Jason Merrill wrote:
I guess we need to call complete_type before aggregate_value_p.
complete_type_or_else, actually.
Jason
On 04/07/2014 12:56 PM, Dinar Temirbulatov wrote:
/* We can't initialize a register from a AGGR_INIT_EXPR. */
else if (! cfun->returns_struct
&& TREE_CODE (retval) == TARGET_EXPR
&& TREE_CODE (TREE_OPERAND (retval, 1)) == AGGR_INIT_EXPR)
retval =
This fixes some errors in the testsuite which aren't caught by G++
(for known reasons).
Tested x86_64-linux, committed to trunk.
commit 9c8945c0d7adf909f8b46c0331d66a00af4187b9
Author: Jonathan Wakely
Date: Mon Apr 7 18:17:03 2014 +0100
Fix testsuite bugs.
* testsuite/20_ut
In the patch of
PR60656(http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01668.html), the
test case requires GCC to vectorize the widen-mult pattern from si to
di types. This may result in test failures on some platforms that
don't support this pattern. This patch adds a new target
vect_widen_mult_si_t
On Mon, 7 Apr 2014, Jeff Law wrote:
On 04/05/14 07:52, Marc Glisse wrote:
Hello,
we have front-end warnings about returning the address of a local
variable. However, quite often in C++, people don't directly return the
address of a temporary, it goes through a few functions which hide that
fac
On 04/05/14 07:52, Marc Glisse wrote:
Hello,
we have front-end warnings about returning the address of a local
variable. However, quite often in C++, people don't directly return the
address of a temporary, it goes through a few functions which hide that
fact. After some inlining, the fact that
On Sun, Apr 06, 2014 at 09:46:12AM -0700, Mike Stump wrote:
> On Apr 5, 2014, at 10:36 AM, Marek Polacek wrote:
> >
> > I'll wait a day or two for possible comments.
>
> So, my only comment would be it would be nice to document the flags that can
> vary between pch creation and use time, and wh
Hi,
I revised the patch from
http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00083.html.
This change fixes PR57958 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57958)
For this code:
auto fn = [] (const Foo& x) {
return (x);
};
{
Foo a;
fn(a);
}
Current version of trunk generates fol
On Mon, Apr 07, 2014 at 04:19:06PM +0200, Richard Biener wrote:
> The adjusted testcases now fail on x86_64/i?86 at least. See PR60776.
They seem to require at least -O2 on x86 with that change. Ok to apply?
diff --git a/gcc/testsuite/gcc.dg/builtin-bswap-6.c
b/gcc/testsuite/gcc.dg/builtin-bswa
On 4 April 2014 15:50, Ramana Radhakrishnan wrote:
> Additionally the testing has only considered Thumb2 - since we also do
> jumptable shortening for Thumb1 and given this late change it's worth
> also testing this on Thumb1 and making sure there are no regressions.
> Maybe Joey can help there if
On 04/07/2014 04:33 AM, Rainer Orth wrote:
> The patch allowed i386-pc-solaris2.11 bootstraps to finish without
> regressions on trunk and 4.8 branch, still need to test 4.7 branch.
>
> Ok for trunk, 4.8 and 4.7 branches once testing completes?
>
> Rainer
>
>
> 2014-04-07 Rainer Orth
>
Sorry about the delayed review. I seem to have missed this earlier.
On Tue, Mar 25, 2014 at 12:21 PM, Eric Botcazou wrote:
> Hi,
>
> because of popular demand we switched the Ada compiler to ZCX, i.e. table-
> driven EH scheme, on ARM/Linux, only to discover that GCC doesn't generate
> correct EH
On Fri, Apr 4, 2014 at 7:51 PM, Jeff Law wrote:
> On 04/04/14 10:18, Andreas Krebbel wrote:
>>
>> Hi,
>>
>> the attached patch modifies the builtin-bswap-6/7 testcases in order
>> to prevent GCC from using math instead of a compare. Only with a
>> compare the folding in combine actually takes pla
This fixes PR60766, a case where IVOPTs generating signed expressions
from originally unsigned ones breaks because that introduces undefined
overflow and VRP manages to exploit that fact. The solution is to
use unsigned arithmetic when doing simplification using tree-affine.
In general that's alw
Hi all,
Currently if we specify something like -march=armv8-a+nosimd or
-mcpu=+nosimd the backend will not use it properly to setup the
TARGET_SIMD internal boolean that the backend checks for SIMD availability. In the
end, the only effective way of disabling SIMD instructions was to specify
As subject says.
Applied as obvious.
Ramana
2014-04-07 Ramana Radhakrishnan
* gcc.target/arm/pr60657.c: Fix missing curly brace.
--
Ramana Radhakrishnan
Principal Engineer
ARM Ltd.Index: gcc/testsuite/ChangeLog
===
-
On 04/07/2014 03:39 AM, Nathan Sidwell wrote:
Jason, I shall leave it to your discretion as to whether we should
continue with this patch, or revert the original one (for 4.9).
This is OK. Post 4.9 we might try removing the warn_ecpp check and see
how that is received.
Jason
Hi all,
I've committed the attached patch to the introductory comment in haifa-sched.c
as obvious with r209184.
The function compute_block_backward_dependences was renamed to
compute_block_dependences in 2007but the comment was not updated.
Kyrill
2014-04-07 Kyrylo Tkachov
* haifa-sc
OK.
Jason
The Solaris 11.2 x86 assembler is going to gain support for the cfi
directives. To do things right this time, it will create read-only
.eh_frame sections, unlike what gas and gcc currently do. The goal is
to let /bin/ld handle the required merging of read-only and read-write
.eh_frame sections, b
> One hard part is avoiding duplicate warnings. Replacing the address with 0
> is a convenient way to do that, so I did it both for my new warning and
> for the existing C/C++ ones. The patch breaks
> gfortran.dg/warn_target_lifetime_2.f90 because it ends up warning twice. I
> didn't touch that fro
On Mon, 7 Apr 2014, Richard Biener wrote:
One hard part is avoiding duplicate warnings. Replacing the address with 0
is a convenient way to do that, so I did it both for my new warning and for
the existing C/C++ ones. The patch breaks
gfortran.dg/warn_target_lifetime_2.f90 because it ends up war
On Sun, Apr 6, 2014 at 6:21 PM, Mike Stump wrote:
> On Apr 4, 2014, at 9:53 AM, Jason Merrill wrote:
>> richi asked for a testcase for 60731, and since we didn't already have
>> support for tests using dlopen, I had to add it. Does this approach make
>> sense?
>
> Seems reasonable. I wonder i
On Sat, Apr 5, 2014 at 3:52 PM, Marc Glisse wrote:
> Hello,
>
> we have front-end warnings about returning the address of a local variable.
> However, quite often in C++, people don't directly return the address of a
> temporary, it goes through a few functions which hide that fact. After some
> i
On 2014.04.07 at 08:39 +0100, Nathan Sidwell wrote:
> On 04/06/14 10:50, Markus Trippelsdorf wrote:
> > On 2014.04.06 at 09:13 +0100, Nathan Sidwell wrote:
> >> On 04/04/14 18:33, Nathan Sidwell wrote:
> >>
> >>> I'm testing a patch that makes the test in the loop:
> >>>
> >>> if (TREE_PUBL
On Mon, 7 Apr 2014, Gerald Pfeifer wrote:
> On Tue, 18 Mar 2014, Richard Biener wrote:
> > Committed as obvious.
>
> htdocs/svn.html has four occurrences, and a few other pages also
> have some. Though I don't think it's appropriate to adjust the
> like of news.html, should I update svn.html?
On Fri, 4 Apr 2014, Jan Hubicka wrote:
> > On Fri, 4 Apr 2014, Jan Hubicka wrote:
> >
> > > Hi,
> > > here is an updated version of my earlier ipa.c change. It turns out that
> > > the
> > > problem was that I did not drop always_inline.
> > > In this version I just drop always_inline attribute
On 04/06/14 10:50, Markus Trippelsdorf wrote:
On 2014.04.06 at 09:13 +0100, Nathan Sidwell wrote:
On 04/04/14 18:33, Nathan Sidwell wrote:
I'm testing a patch that makes the test in the loop:
if (TREE_PUBLIC (base_binfo)
Hm, binfo's aren't noted that way, it's encoded in BINFO_ACCES
This fixes the broken EH tables generated for the ARM:
http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01333.html
Thanks in advance.
--
Eric Botcazou
Added comment to avr.c on why disabling -fdelete-null-pointer-checks. Patch
Attached in the mail.
Previously approved patch can be found here -
http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01697.html.
I don't have commit access to the source, please commit both the patches
If they are OK.
Rega
43 matches
Mail list logo
