PR ipa/58555

2014-02-19 Thread Jan Hubicka
Hi, this patch fies the division by zero in recursive_inlining by adding a non-zero guard. More importantly it however fixed ages long bug in clone_inlined_nodes that does not update properly frequencies of edges when function with already inlined edges is inlined into another function. Bootstra

[PATCH] Fix PR c++/60065.

2014-02-19 Thread Adam Butcher
PR c++/60065 * parser.c (cp_parser_parameter_declaration_list): Use current_template_parms and scope check as predicate for inspecting current function template parameter list length rather than num_template_parameter_lists. PR c++/60065 * g+

Re: [PATCH] Fix PR c++/60052 and c++/60053

2014-02-19 Thread Adam Butcher
On 2014-02-20 1:24, Adam Butcher wrote: PR c++/60052 * parser.c (cp_parser_parameter_declaration_list): Correctly reset implicit_template_scope upon leaving an out-of-line generic member function definition. Turns out this fixes 60053 too.

[PATCH] Fix PR c++/60052.

2014-02-19 Thread Adam Butcher
PR c++/60052 * parser.c (cp_parser_parameter_declaration_list): Correctly reset implicit_template_scope upon leaving an out-of-line generic member function definition. PR c++/60052 * g++.dg/cpp1y/pr60052.C: New testcase. --- gcc/cp/parser.c

Re: [PATCH 1/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-19 Thread Tobias Burnus
Hi Ilmir, thanks for your reply; I am looking forward to your updated patch. Ilmir Usmanov wrote: I have tested your notes on two compilers which support OpenACC: PGI 14.1 and CAPS 3.4.1. I can add Cray ftn results, if you want me to cross-check something. On 10.02.2014 02:22, Tobias Burnus

Re: [Patch, fortran] PR51976 - [F2003] Support deferred-length character components of derived types (allocatable string length)

2014-02-19 Thread Tobias Burnus
Hi Paul, Paul Richard Thomas wrote: I had completely forgotten about this patch... I even thought that it had been applied :-) I'll have time, either tomorrow evening or Saturday to take a look. After nearly 11 months, a couple more days will not hurt! I think it went as follows: We found out

Re: [PATCH] Use __UINT{16,32,64}_TYPE__ for builtins when available (PR c/37743)

2014-02-19 Thread Joseph S. Myers
On Wed, 19 Feb 2014, Jakub Jelinek wrote: > Hi! > > This patch changes the return type of the __builtin_bswap{16,32,64} builtins > to the __UINT{16,32,64}_TYPE__ types if the target defines them, instead > of a nonstandard integer type, which is a problem for -Wformat warnings > or for C++ overlo

Re: [Patch, fortran] PR51976 - [F2003] Support deferred-length character components of derived types (allocatable string length)

2014-02-19 Thread Paul Richard Thomas
Dear Janus, I had completely forgotten about this patch... I even thought that it had been applied :-) I'll have time, either tomorrow evening or Saturday to take a look. After nearly 11 months, a couple more days will not hurt! Thanks for bringing it to my attention. Paul On 19 February 2014

[PATCH] Use __UINT{16,32,64}_TYPE__ for builtins when available (PR c/37743)

2014-02-19 Thread Jakub Jelinek
Hi! This patch changes the return type of the __builtin_bswap{16,32,64} builtins to the __UINT{16,32,64}_TYPE__ types if the target defines them, instead of a nonstandard integer type, which is a problem for -Wformat warnings or for C++ overload resolution. Bootstrapped/regtested on x86_64-linux

[PATCH, rs6000, committed] Most significant bit of zero is not one.

2014-02-19 Thread Bill Schmidt
Hi, I ran across this obvious error when developing a test case for another patch. The value assigned for the most significant bit of a value is obviously wrong for zero here. I haven't added a test case because this will be covered by the test case added for the other patch. Bootstrapped and t

C++ PATCH for c++/60046 (ICE with noexcept)

2014-02-19 Thread Jason Merrill
In this testcase, when we see a non-dependent use of a function template instance we mark it as used, but we don't want to instantiate the noexcept-specification at that point because we aren't doing full expression evaluation yet. Tested x86_64-pc-linux-gnu, applying to trunk, 4.8, 4.7. commi

PATCH: PR target/60207: Wrong TFmode check in construct_container

2014-02-19 Thread H.J. Lu
Hi, There is no need to check TFmode for X86_64_INTEGER_CLASS since TFmode is passed in vector register. This patch has been pre-approved for mainline and release branches. I checked it into mainline and will backport it to 4.7/4.8 branch. H.J. --- Index: gcc/ChangeLog =

Re: c-parser.c replace error() by error_at()

2014-02-19 Thread Marek Polacek
On Wed, Feb 19, 2014 at 06:02:23PM +, Joseph S. Myers wrote: > On Wed, 19 Feb 2014, Prathamesh Kulkarni wrote: > > > I have sent it attached this time. > > Thanks, this version is OK. Please start the copyright assignment > paperwork process if you haven't already done so, if you may be >

Re: [gomp4] libgomp: plugin for non-shared memory host execution (was: libgomp.c/target-1.c failing in fn2's GOMP_target_update)

2014-02-19 Thread Jakub Jelinek
On Wed, Feb 19, 2014 at 09:49:20PM +0400, Ilya Verbin wrote: > 2014-02-19 20:10 GMT+04:00 Thomas Schwinge : > > Here is such a libgomp plugin plus the infrastructure for initial support > > of non-shared memory host execution. Any comments? > > > > Grüße, > > Thomas > > This plugin looks good. >

Re: c-parser.c replace error() by error_at()

2014-02-19 Thread Joseph S. Myers
On Wed, 19 Feb 2014, Prathamesh Kulkarni wrote: > I have sent it attached this time. Thanks, this version is OK. Please start the copyright assignment paperwork process if you haven't already done so, if you may be contributing more changes in future. http://git.savannah.gnu.org/cgit/gnulib.g

Re: [C++ PATCH] Handle #pragma GCC ivdep during tsubst (PR c++/60267)

2014-02-19 Thread Jason Merrill
OK. Jason

Re: [C++ PATCH] Fix up DW_AT_explicit handling (PR debug/56563)

2014-02-19 Thread Jason Merrill
OK. Jason

Re: [patch c++]: Fix pr/58835 [4.7/4.8/4.9 Regression] ICE with __PRETTY_FUNCTION__ in broken function

2014-02-19 Thread Jason Merrill
OK. Jason

Re: [gomp4] libgomp: plugin for non-shared memory host execution (was: libgomp.c/target-1.c failing in fn2's GOMP_target_update)

2014-02-19 Thread Ilya Verbin
2014-02-19 20:10 GMT+04:00 Thomas Schwinge : > Here is such a libgomp plugin plus the infrastructure for initial support > of non-shared memory host execution. Any comments? > > Grüße, > Thomas This plugin looks good. I think the function call in GOMP_target also should be replaced with a call

Re: [gomp4] libgomp: Don't update copy_from for the existing mappings.

2014-02-19 Thread Thomas Schwinge
Hi Ilya! On Tue, 18 Feb 2014 20:49:39 +0400, Ilya Verbin wrote: > 2014-02-18 20:25 GMT+04:00 Thomas Schwinge : > > Sure; this was the consensus, as I understand it. Though, wouldn't it > > make sense to also add a test case to a) test for this behavior, and also > > b) to document the "GCC inter

Re: [PATCH] Fix libjava install with --enable-version-specific-runtime-libs

2014-02-19 Thread Andrew Haley
On 02/19/2014 04:38 PM, Sandra Loosemore wrote: > I am OK with Richard's fix. Fine by me then, Andrew.

Re: [PATCH 2/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-19 Thread Ilmir Usmanov
Hi Tobias! On 10.02.2014 03:10, Tobias Burnus wrote: Shouldn't you also reject polymorphic types ("BT_CLASS" and "BT_ASSUMED")? [BT_CLASS = "class(derived_type_name)" or "class(*)"; BT_ASSUMED = "type(*)"] + if (n->sym->attr.pointer) +gfc_error ("POINTER object '%s' in %s clause

Re: c-parser.c replace error() by error_at()

2014-02-19 Thread Prathamesh Kulkarni
On Wed, Feb 19, 2014 at 9:41 PM, Marek Polacek wrote: > On Wed, Feb 19, 2014 at 08:45:04PM +0530, Prathamesh Kulkarni wrote: >> Index: gcc/c/c-parser.c >> === >> --- gcc/c/c-parser.c (revision 207700) >> +++ gcc/c/c-parser.c (working

Re: [PATCH] Fix libjava install with --enable-version-specific-runtime-libs

2014-02-19 Thread Sandra Loosemore
On 02/19/2014 02:43 AM, Andrew Haley wrote: On 02/19/2014 09:34 AM, Richard Biener wrote: Sandras patch was supposed to introduce support for --enable-version-specific-runtime-libs in libgcj (but obviously it failed, given the result above). Sandra? You're very quiet. What say you? I don't

Re: [PATCH] Fix up preprocessing of #pragma GCC ivdep (PR c++/60267)

2014-02-19 Thread Jeff Law
On 02/19/14 07:52, Jakub Jelinek wrote: Hi! In #pragma GCC ivdep there is nothing the preprocessor should care about, thus there is no reason to register it when doing just -E (and, otherwise we'd have to handle PRAGMA_IVDEP in pragma lookups). Fixed thusly, bootstrapped/regtested on x86_64-lin

Re: c-parser.c replace error() by error_at()

2014-02-19 Thread Marek Polacek
On Wed, Feb 19, 2014 at 08:45:04PM +0530, Prathamesh Kulkarni wrote: > Index: gcc/c/c-parser.c > === > --- gcc/c/c-parser.c (revision 207700) > +++ gcc/c/c-parser.c (working copy) > @@ -2223,7 +2223,7 @@ c_parser_declspecs (c_parser *p

[gomp4] libgomp: plugin for non-shared memory host execution (was: libgomp.c/target-1.c failing in fn2's GOMP_target_update)

2014-02-19 Thread Thomas Schwinge
Hi! On Thu, 12 Dec 2013 12:31:40 +0100, I wrote: > On Fri, 8 Nov 2013 16:40:00 +0100, Jakub Jelinek wrote: > > [...], device 257 is just a temporary testing hack, [...] > > > [...], once we have at least one supported offloading target, > > hopefully we'll nuke device 257. > > Hmm, in contrast,

Re: [Patch, fortran] PR51976 - [F2003] Support deferred-length character components of derived types (allocatable string length)

2014-02-19 Thread Janus Weil
The patch was not applying cleanly any more, so here is a re-diffed version for current trunk. It works nicely on the included test case as well as the one provided by Walter Spector in comment 12 of the PR. Since, also in the current state, "character(:)" works only in a subset of all cases, I th

Re: [patch c++]: Fix pr/58835 [4.7/4.8/4.9 Regression] ICE with __PRETTY_FUNCTION__ in broken function

2014-02-19 Thread Kai Tietz
Ping? 2014-02-11 15:11 GMT+01:00 Kai Tietz : > Hi, > > the following patch adds missing handling of error_mark_node result of > fname_decl within finish_fname. > > ChangeLog > > 2014-02-11 Kai Tietz > > PR c++/58835 > * semantics.c (finish_fname): Handle error_mark_node. > > Reg

[jit] Add some type-checking to parameters requiring pointers

2014-02-19 Thread David Malcolm
Committed to branch dmalcolm/jit: gcc/jit/ * libgccjit.c (gcc_jit_context_new_rvalue_from_ptr): Verify that pointer_type is indeed a pointer type. (gcc_jit_context_null): Likewise. (gcc_jit_context_new_array_access): Verify that ptr is indeed a pointer.

[S390] Fix scheduling performance regression from my shrink-wrap patches

2014-02-19 Thread Richard Sandiford
In the covering message for the shrink-wrap patch I said: Perhaps the only subtle thing is the handling of call-clobbered base registers. The idea is to emit the initialising main_pool pattern in both early_mach -- at the very beginning of the function -- and in the prologue. Then, if sh

Re: [PATCH 1/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

2014-02-19 Thread Ilmir Usmanov
Hi Tobias! Thanks a lot for your review! I have tested your notes on two compilers which support OpenACC: PGI 14.1 and CAPS 3.4.1. If I made a mistake and you've collected results which differ from mine (whether you compiler is one of the above or not), please, let me know. Unfortunally, n

[C++ PATCH] Fix up DW_AT_explicit handling (PR debug/56563)

2014-02-19 Thread Jakub Jelinek
Hi! Say on struct S { explicit S () {}; } s; struct T { explicit T (int x) {}; } t(2); struct U { explicit operator int () { return 6; } } u; G++ mysteriously emits DW_AT_explicit only on T::T(int) and not on S::S() nor U::operator int(). Fixed thusly, ok for trunk? 2014-02-19 Jakub Jelinek

[C++ PATCH] Handle #pragma GCC ivdep during tsubst (PR c++/60267)

2014-02-19 Thread Jakub Jelinek
Hi! This patch fixes ICE on #pragma GCC ivdep used in templates. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-02-19 Jakub Jelinek PR c++/60267 * pt.c (tsubst_expr): Handle ANNOTATE_EXPR. * g++.dg/ext/ivdep-1.C: New test. --- gcc/cp/pt.c.

Re: [Patch, fortran] PR51976 - [F2003] Support deferred-length character components of derived types (allocatable string length)

2014-02-19 Thread Janus Weil
Hi all, the patch below has been posted a long time ago, but was never actually committed (although it seems close to being finished). Could it still be considered for trunk? I think it is a rather popular feature, which would be helpful for many users ... Cheers, Janus 2013-03-19 22:17 GMT+0

RFA: fix compile/pr17906.c / compile/pr35432.c -O3 -g ICEs

2014-02-19 Thread Joern Rennecke
When compiling compile/pr17906.c, compute_frame_pointer_to_fb_displacement passes the argument pointer to eliminate_regs. This eliminates it to the frame pointer, which later causes and ICE because frame_pointer_needed is not set. The problem is that ELIMINABLE_REGS in avr.h does not specify a di

Re: c-parser.c replace error() by error_at()

2014-02-19 Thread Prathamesh Kulkarni
On Wed, Feb 19, 2014 at 7:56 PM, Marek Polacek wrote: > On Wed, Feb 19, 2014 at 07:43:56PM +0530, Prathamesh Kulkarni wrote: >> Index: gcc/testsuite/gcc.dg/decl-9.c >> === >> --- gcc/testsuite/gcc.dg/decl-9.c (revision 207700) >> +++

[PATCH] Fix up preprocessing of #pragma GCC ivdep (PR c++/60267)

2014-02-19 Thread Jakub Jelinek
Hi! In #pragma GCC ivdep there is nothing the preprocessor should care about, thus there is no reason to register it when doing just -E (and, otherwise we'd have to handle PRAGMA_IVDEP in pragma lookups). Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-02-

[Ada] Duplicate projects due to symbolic links

2014-02-19 Thread Arnaud Charlet
When the same projec is imported by several projects in the project tree through different paths that includes symbolic links, the Project Manager may reported an error indicating that two different projects have the same name. This is corrected by this patch. Tested on x86_64-pc-linux-gnu, commit

[PATCH ARM] Fix PR60264 (ICE in dwarf2out_frame_debug_adjust_cfa) part 2

2014-02-19 Thread Christian Bruel
Hello, This patch is a followup of http://gcc.gnu.org/ml/gcc-patches/2014-02/msg01042.html If fixes a bunch of ICEs for the testsuite ran with --target_board=arm-sim/\{-mapcs-frame\}, noticed on a reference branch for testing the former patch. One of the strange issue I had to deal with, for in

[Ada] Do not perform expansion of generics even in GNATprove mode

2014-02-19 Thread Arnaud Charlet
In GNATprove mode for formal verification, some treatment typically only done during expansion needs to be performed on the tree, but it should not be applied inside generics. Otherwise, this breaks the name resolution mechanism for genetic instances. This completes a previous similar fix. Tested

Re: [AArch64 00/14] Pipeline-independent changes for XGene-1

2014-02-19 Thread Ramana Radhakrishnan
On Tue, Feb 18, 2014 at 9:09 PM, Philipp Tomsich wrote: > The following patch-set contains the pipeline-independent changes to gcc > to support the APM XGene-1 and contains various enhancements derived from > real-world applications and benchmarks running on XGene-1. > > As the pipeline model has

Re: c-parser.c replace error() by error_at()

2014-02-19 Thread Marek Polacek
On Wed, Feb 19, 2014 at 07:43:56PM +0530, Prathamesh Kulkarni wrote: > Index: gcc/testsuite/gcc.dg/decl-9.c > === > --- gcc/testsuite/gcc.dg/decl-9.c (revision 207700) > +++ gcc/testsuite/gcc.dg/decl-9.c (working copy) > @@ -30,3 +30,1

Re: [PATCH] Allow cfgcleanup to remove forwarder loop preheaders and latches

2014-02-19 Thread Bin.Cheng
On Wed, Feb 19, 2014 at 10:06 PM, Richard Biener wrote: > On Wed, 19 Feb 2014, Bin.Cheng wrote: > >> Hi Richard, >> Does this have to wait for stage 1? Or I will try to work out a full >> patch with loop recreating issue fixed. > > If it is a regression and there is a bugzilla about it it doesn't

Re: c-parser.c replace error() by error_at()

2014-02-19 Thread Prathamesh Kulkarni
On Wed, Feb 19, 2014 at 7:01 PM, Marek Polacek wrote: > On Wed, Feb 19, 2014 at 06:05:12PM +0530, Prathamesh Kulkarni wrote: >> Replace calls to error() by error_at(). >> >> * c-parser.c (c_parser_declspecs): replace call to error () by error_at () > > "Replace", drop ()'s, full stop at the end. >

Re: [PATCH] Allow cfgcleanup to remove forwarder loop preheaders and latches

2014-02-19 Thread Richard Biener
On Wed, 19 Feb 2014, Bin.Cheng wrote: > Hi Richard, > Does this have to wait for stage 1? Or I will try to work out a full > patch with loop recreating issue fixed. If it is a regression and there is a bugzilla about it it doesn't have to wait. The patch should be complete (but is untested yet)

Re: [AArch64 00/14] Pipeline-independent changes for XGene-1

2014-02-19 Thread Richard Earnshaw
On 18/02/14 21:09, Philipp Tomsich wrote: > The following patch-set contains the pipeline-independent changes to gcc > to support the APM XGene-1 and contains various enhancements derived from > real-world applications and benchmarks running on XGene-1. > > As the pipeline model has not been fully

Re: [PATCH] Allow cfgcleanup to remove forwarder loop preheaders and latches

2014-02-19 Thread Bin.Cheng
Hi Richard, Does this have to wait for stage 1? Or I will try to work out a full patch with loop recreating issue fixed. On Wed, Feb 19, 2014 at 7:57 PM, Richard Biener wrote: > > This allows cfgcleanup to remove some of the extra CFG that exists > just for loop analysis passes convenience (those

Re: [PATCH] Properly check for _Cilk_spawn in return stmt (PR c/60197)

2014-02-19 Thread Marek Polacek
On Tue, Feb 18, 2014 at 10:06:14PM +, Iyer, Balaji V wrote: > This is invalid. Thanks. In that case, this patch should error out on such invalid uses as well, instead of ICEing. Regtested/bootstrapped on x86_64-linux. 2014-02-19 Marek Polacek PR c/60197 c-family/ * cilk.

Re: [PATCH][i386][AVX512] PR60204 - update abi for large structs.

2014-02-19 Thread Uros Bizjak
On Wed, Feb 19, 2014 at 2:30 PM, Ilya Tocar wrote: > Hi everyone, > As AVX512 abi for passing/returing structs was recently changed in > https://github.com/hjl-tools/x86-64-psABI/commit/6d7ccd614fe67111d2aecec853c3df0310b372d2 > We need to update GCC accordingly. This patch does it. > It bootstrap

Re: c-parser.c replace error() by error_at()

2014-02-19 Thread Marek Polacek
On Wed, Feb 19, 2014 at 06:05:12PM +0530, Prathamesh Kulkarni wrote: > Replace calls to error() by error_at(). > > * c-parser.c (c_parser_declspecs): replace call to error () by error_at () "Replace", drop ()'s, full stop at the end. > * c-parser.c (c_parser_parameter_declaration): Likewise Ful

[PATCH][i386][AVX512] PR60204 - update abi for large structs.

2014-02-19 Thread Ilya Tocar
Hi everyone, As AVX512 abi for passing/returing structs was recently changed in https://github.com/hjl-tools/x86-64-psABI/commit/6d7ccd614fe67111d2aecec853c3df0310b372d2 We need to update GCC accordingly. This patch does it. It bootstraps, passes make check (including updated abi tests), spec2006 i

[PATCH] Missing __divtf3@@GCC_4.4.0 on ia64

2014-02-19 Thread Andreas Schwab
Since there is already the __divtf3@GCC_3.0 compatibility alias in libgcc we need to attach an explicit symbol version to the real __divtf3 in order to get it exported. This fixes the unversioned reference in libgfortran.so, and fixes the failure of gfortran.dg/erf_3.F90. Tested on ia64-suse-linu

Re: [PATCH] Fix sanitizer build on sparc (PR sanitizer/59758)

2014-02-19 Thread Jose E. Marchesi
> On Tue, Feb 18, 2014 at 06:55:51PM +0100, Jose E. Marchesi wrote: > > This patch fixes builds with --enable-sanitizer, which seems to be the > > default for sparc now. > > > > Build tested in a sparc64-*-linux-gnu system with linux 3.8.13 headers. > > > > 2014-02-18

c-parser.c replace error() by error_at()

2014-02-19 Thread Prathamesh Kulkarni
Replace calls to error() by error_at(). * c-parser.c (c_parser_declspecs): replace call to error () by error_at () * c-parser.c (c_parser_parameter_declaration): Likewise Bootstrapped on x86_64-unknown-linux-gnu Ok for trunk ? Thanks and Regards, Prathamesh Index: gcc/c/c-parser.c =

Re: RFA: Fix some gcc tests for 16-bit targets

2014-02-19 Thread Richard Biener
On Tue, Feb 18, 2014 at 5:39 PM, nick clifton wrote: > Hi Richard, > > >> Instead of modifying testcases I'd be less nervous if you'd make them >> require 32bit. Otherwise you should reproduce the original issues with the >> modified testcases. > > > OK, I can do that. How about this patch. > > >

Re: [patch] Fix wrong code with VCE to bit-field type at -O

2014-02-19 Thread Richard Biener
On Wed, Feb 19, 2014 at 12:55 PM, Eric Botcazou wrote: >> Woudln't it be better to do this in the series of "conversions", that is >> inside the preceeding if-statement? (the integral type case using >> convert_modes looks weird enough, so adding this kind-of "less" >> weird one there looks sensi

[PATCH] Allow cfgcleanup to remove forwarder loop preheaders and latches

2014-02-19 Thread Richard Biener
This allows cfgcleanup to remove some of the extra CFG that exists just for loop analysis passes convenience (those can be and are easily re-created by passes doing loop_optimizer_init ()). It may fix a regression uncovered in private communication. Untested - my original idea how to fix this (t

Re: [patch] Fix wrong code with VCE to bit-field type at -O

2014-02-19 Thread Eric Botcazou
> Woudln't it be better to do this in the series of "conversions", that is > inside the preceeding if-statement? (the integral type case using > convert_modes looks weird enough, so adding this kind-of "less" > weird one there looks sensible) Yes, the integral type case is very strange: it was in

Re: [Patch, Fortran, OOP] PR 60232: The rank of the element in the structure constructor does not match that of the component

2014-02-19 Thread Janus Weil
Hi, >> The problem is this: When using a dimensionful function as an >> EXPR_VARIABLE (e.g. as the target in a procedure pointer assignment), >> we wrongly add a REF_ARRAY, because we are tricked to believe that the >> expression is dimensionful > >> The patch was regtested on x86_64-unknown-linux

Re: [PING] [PATCH] _Cilk_for for C and C++

2014-02-19 Thread Jakub Jelinek
On Wed, Feb 19, 2014 at 04:43:06AM +, Iyer, Balaji V wrote: > Attached, please find a patch with the test case attached (for1.cc). The > patch is the same but the cp-changelog has been modified to reflect the > new test-case. Is this OK to install? 1) have you tested the patch at all? I see

[Ada] Fix removal of side-effects in GNATprove mode

2014-02-19 Thread Arnaud Charlet
In the GNATprove mode for formal verification, side-effects are removed from expressions when the corresponding procedure is called in the frontend. This should only be done when not inside a generic, which is both useless and harmful as it deactivates the mechanism for name resolution of generic i

[Ada] Legality rules for Synchronization aspect on protected operations

2014-02-19 Thread Arnaud Charlet
This patch detects additional errors when a Synchronization aspect on an overriding protected operation does not match the given aspect on the overridden operation of an ancestor interface. Compiling b95000g.ads must yield: b95000g.ads:29:13: type "Lock_Type" must implement abstract subprogr

[Ada] Semantics of attribute 'Old in aspect/pragma Contract_Cases

2014-02-19 Thread Arnaud Charlet
This patch implements rule SPARK RM 6.1.3 (5) which states: If an Old attribute_reference occurs within a consequence other than the consequence selected for (later) evaluation as described above, then the associated implicit constant declaration (see Ada RM 6.1.1) is not elaborated. [

[Ada] Missing parentheses on [Refined_]Global and [Refined_]Depends

2014-02-19 Thread Arnaud Charlet
This patch modifies the parser to detect missing parentheses on SPARK aspects Global, Depends, Refined_Global and Refined_Depends. -- Source -- -- malformed_contracts.ads package Malformed_Contracts with Abstract_State => (State_1, State_2) is procedure OK_1

Re: [PATCH] Fixing SEH exceptions for languages != C++

2014-02-19 Thread Jonathan Schleifer
Am Tue, 18 Feb 2014 17:51:00 +0100 schrieb Kai Tietz : > So patch is ok with proper ChangeLog mentioning PR. Patch is ok for > back-port too. I wonder if the instaned of RtlUnwindEx that come before the patched line should be changed as well, though. -- Jonathan

[Ada] GNAT driver and externally built library project files

2014-02-19 Thread Arnaud Charlet
When the GNAT driver is invoked to bind a main of a project file, and there are externally built library projects in the closure of the main project file, the invocation of gnatbind may fail if the object directory does not contain any ALI files. Tested on x86_64-pc-linux-gnu, committed on trunk

[Ada] Incorrect error on valid global refinement

2014-02-19 Thread Arnaud Charlet
This patch updates the analysis of aspect/pragma Refined_Global to interpret states and variables with an encapsulating state as constituents only when the related state has visible refinement. -- Source -- -- parent.ads package Parent with Abstract_State => State is

[Ada] Error recovery in task body

2014-02-19 Thread Arnaud Charlet
This patch fixes a crash in a task body with a single statement missing a terminating semicolon. The tree can be repaired locally so further compilation can proceed. Compiling libthr3.adb must yield: libthr3.adb:10:18: missing ";" libthr3.adb:13:04: warning: no accept for entry "Test" --

[Ada] Accept a constituent in a null dependency clause

2014-02-19 Thread Arnaud Charlet
This patch implements the following SPARK RM rule from 7.2.5 (3g): at least one of its constituents shall be denoted in the input_list of a null_dependency_clause; or -- Source -- -- null_dependency.ads package Null_Dependency with Abstract_State => (Input_Sta

[PATCH, ARM] Support ORN for DImode

2014-02-19 Thread Ian Bolton
Hi, Patterns had previously been added to thumb2.md to support ORN, but only for SImode. This patch adds DImode support, to cover the full 64|64->64 operation and the various 32|64->64 operations (see AND:DI variants that use NOT). The patch comes with its own execution test and looks for correc

Re: [Patch, Fortran, OOP] PR 60232: The rank of the element in the structure constructor does not match that of the component

2014-02-19 Thread Tobias Burnus
Hi Janus, Janus Weil wrote: > The problem is this: When using a dimensionful function as an > EXPR_VARIABLE (e.g. as the target in a procedure pointer assignment), > we wrongly add a REF_ARRAY, because we are tricked to believe that the > expression is dimensionful > The patch was regtested on x8

Re: [PATCH] Fix libjava install with --enable-version-specific-runtime-libs

2014-02-19 Thread Andrew Haley
On 02/19/2014 09:34 AM, Richard Biener wrote: > Sandras patch was supposed to introduce support > for --enable-version-specific-runtime-libs in libgcj (but obviously > it failed, given the result above). Sandra? You're very quiet. What say you? I don't want this ping-ponging. Andrew.

[Patch, Fortran, OOP] PR 60232: The rank of the element in the structure constructor does not match that of the component

2014-02-19 Thread Janus Weil
Hi all, here is a small patch for an OOP-related rejects-valid problem, which is technically not a regression, but I hope the patch is simple enough to still make it into trunk. The problem is this: When using a dimensionful function as an EXPR_VARIABLE (e.g. as the target in a procedure pointer

Re: [PATCH] Fix libjava install with --enable-version-specific-runtime-libs

2014-02-19 Thread Richard Biener
On Wed, 19 Feb 2014, Andrew Haley wrote: > On 02/19/2014 09:03 AM, Richard Biener wrote: > > On Tue, 18 Feb 2014, Richard Biener wrote: > > > >> > >> The following two pieces fix the fallout of > >> > >> 2013-05-22 Mark Mitchell > >> Sandra Loosemore > >> > >> * configure

Re: [PATCH] Fix libjava install with --enable-version-specific-runtime-libs

2014-02-19 Thread Andrew Haley
On 02/19/2014 09:03 AM, Richard Biener wrote: > On Tue, 18 Feb 2014, Richard Biener wrote: > >> >> The following two pieces fix the fallout of >> >> 2013-05-22 Mark Mitchell >> Sandra Loosemore >> >> * configure.ac (dbexecdir): Base on $(toolexeclibdir), not >> $(l

RE: [PATCH][4.8] Backport strict-volatile-bitfields fixes to 4.8

2014-02-19 Thread Joey Ye
Ping ^ 4 > -Original Message- > From: Joey Ye [mailto:joey...@arm.com] > Sent: Friday, February 14, 2014 9:58 > To: gcc-patches@gcc.gnu.org > Subject: RE: [PATCH][4.8] Backport strict-volatile-bitfields fixes to 4.8 > > Ping ^3 > > These fixes are very important to 4.8 ARM embedded users

Re: [PATCH] Remove N^2 update-ssa calls in IPA SRA

2014-02-19 Thread Jakub Jelinek
On Mon, Feb 17, 2014 at 02:38:42PM +0100, Richard Biener wrote: > > This removes the update_ssa call in ipa_modify_call_arguments by > keeping virtual SSA form up-to-date. It also avoids leaking > the virtual SSA name defined by the replaced call (and thus > keeping more than necessary memory liv

[PATCH] Fix up -save-temps with #pragma simd

2014-02-19 Thread Jakub Jelinek
Hi! While fixing PR60267, I've noticed that #pragma simd is not registered when -E -fcilkplus, even when it asks for macro replacements in the clauses. So, either we have to register it even when preprocessing, so that say for -save-temps, or other cases of separate preprocessing and separate com

Re: [PATCH] Fix libjava install with --enable-version-specific-runtime-libs

2014-02-19 Thread Richard Biener
On Tue, 18 Feb 2014, Richard Biener wrote: > > The following two pieces fix the fallout of > > 2013-05-22 Mark Mitchell > Sandra Loosemore > > * configure.ac (dbexecdir): Base on $(toolexeclibdir), not > $(libdir). > ... > > that makes a wreck out of my 4.9-bas

Re: FRE may run out of memory

2014-02-19 Thread dxq
Richard Biener-2 wrote > On Fri, Feb 14, 2014 at 3:50 AM, dxq < > ziyan01@ > > wrote: > > What compiler version did you check? I think that 4.8 has improvements > for 1. and 2. (SMS is unmaintained). Note that we only spent time to > make -O1 behave sanely with extremely large functions. > >

Re: [testsuite] XFAIL gcc.dg/torture/pr60092.c execution on Solaris 11

2014-02-19 Thread Richard Biener
On Tue, 18 Feb 2014, Rainer Orth wrote: > As described in PR middle-end/60092, gcc.dg/torture/pr60092.c execution > FAILs at -O0 on Solaris 11. posix_memalign modifies it's first arg in > the error case, which is at least a QOI issue. > > Therefore I'd like to XFAIL the test like this. Tested w

Re: [PATCH] Fix -ftrack-macro-expansion preprocessing of A######A (PR preprocessor/58844)

2014-02-19 Thread Dodji Seketeli
Jakub Jelinek writes: > Hi! > > The following testcase build with -ftrack-macro-expansion=0, > but don't build otherwise. The problem seems to be that > the libcpp for macro redefinition warning/error purposes if it sees > more than one paste operator adds those extra CPP_PASTE tokens at the end