Re: [PATCH] Keep REG_INC note in subreg2 pass

On 30 October 2013 02:47, Jeff Law wrote: > On 10/24/13 02:20, Zhenqiang Chen wrote: >> >> Hi, >> >> REG_INC note is lost in subreg2 pass when resolve_simple_move, which >> might lead to wrong dependence for ira. e.g. In function >> validate_equiv_mem of ira.c, it checks REG_INC note: >> >>

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

On Tue, Oct 29, 2013 at 3:28 AM, Richard Biener wrote: > On Sun, Oct 27, 2013 at 7:55 PM, Andrew Pinski wrote: >> On Sat, Oct 26, 2013 at 4:49 PM, Andrew Pinski wrote: >>> On Sat, Oct 26, 2013 at 2:30 PM, Andrew Pinski wrote: On Fri, Oct 18, 2013 at 2:21 AM, Zhenqiang Chen wrote: >>>

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

On Oct 29, 2013, at 3:20 AM, Richard Biener wrote: > Can you please get rid of PARTIAL_INT_MODE_NAME by > making the name a required argument to PARTIAL_INT_MODE? Sure, easy to do. * machmode.def (PARTIAL_INT_MODE): Add precision and name. * genmodes.c (PARTIAL_INT_MODE): Add pre

Re: [wide-int] Various minor tweaks

On Oct 29, 2013, at 2:21 PM, Richard Sandiford wrote: > I looked through the diff of wide-int with mainline and noticed a few > minor things to tweak. > It all seemed pretty obvious, and the patch is long and mechanical, > so I went ahead and installed it. I reviewed it, looks good.

Re: Add predefined macros for library use in defining __STDC_IEC_559*

On Tue, Oct 15, 2013 at 5:22 PM, Joseph S. Myers wrote: > Bootstrapped with no regressions on x86_64-unknown-linux-gnu, and > tested with no regressions with cross to powerpc-linux-gnu > (soft-float). OK to commit (hook addition, rs6000/powerpc changes)? > > 2013-10-15 Joseph Myers > >

Re: [wide-int] More optimisations

On Oct 29, 2013, at 5:43 AM, Richard Sandiford wrote: > Richard Biener writes: >> >> I think the cases Mike added should only be enabled when we can figure >> them out at compile-time, too. > > Well, the idea with most of these functions was to handle the simple > "everything is one HWI" cases

[PATCH] Fix PR middle-end/58134

This patch removes a deprecated option -ftree-vectorizer-verbose. It was already implemented in terms of -fopt-info and makes little sense to keep it around longer. It causes needless confusion as reported in PR middle-end/58134. I noticed that several gettext related gcc/po files contain help tra

Re: [wide-int] More optimisations

On 10/29/2013 08:43 AM, Richard Sandiford wrote: Richard Biener writes: On Sun, 27 Oct 2013, Richard Sandiford wrote: This patch adds some more optimisations to the wi:: comparison functions. It uses the: #define CONSTANT(X) (__builtin_constant_p (X) && (X)) idiom that was mentioned befor

Re: libsanitizer merge from upstream r191666

Actually, I guessed the flags: % ../gcc-inst/bin/g++ -g -fsanitize=address -static-libasan -O2 -flto -fno-use-linker-plugin -flto-partition=none ../gcc/gcc/testsuite/c-c++-common/asan/stack-overflow-1.c; ./a.out 2>&1 /tmp/ccgSw6NI.lto.o: In function `main': ../gcc/gcc/testsuite/c-c++-common/asan

Re: [Patch, committed] libcilkrts - add AM_MAINTAINER_MODE; update "gcc_update" for libcilkrts

I missed to attach the patch. I now did. Tobias Tobias Burnus: I have committed the following as obvious: * Added AM_MAINTAINER_MODE to libcilkrtl's configure.ac (and reconfigured) Before, building failed on a system which had the wrong version of autoconf. * As suggested by Joseph, I adde

[Patch, committed] libcilkrts - add AM_MAINTAINER_MODE; update "gcc_update" for libcilkrts

I have committed the following as obvious: * Added AM_MAINTAINER_MODE to libcilkrtl's configure.ac (and reconfigured) Before, building failed on a system which had the wrong version of autoconf. * As suggested by Joseph, I added the relevant files for libcilkrtl to contrib/gcc_update Committe

Re: Aliasing: look through pointer's def stmt

On Tue, 29 Oct 2013, Richard Biener wrote: For the POINTER_PLUS_EXPR offset argument you should use int_cst_value () to access it (it will unconditionally sign-extend) and use host_integerp (..., 0). That leaves the overflow possibility in place (and you should multiply by BITS_PER_UNIT) which

Re: libsanitizer merge from upstream r191666

Jakub, Your patch seems to do what it should: % ../gcc-inst/bin/g++ -gdwarf-2 -fsanitize=address -static-libasan ../gcc/gcc/testsuite/c-c++-common/asan/stack-overflow-1.c && ./a.out ... Address 0x7fffb8ec95ca is located in stack of thread T0 at offset 42 in frame #0 0x44bd73 in main ../gcc/gc

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

Cong, Please don't do the following. >+++ b/gcc/testsuite/gcc.dg/vect/ vect-reduc-sad.c @@ -0,0 +1,54 @@ +/* { dg-require-effective-target sse2 { target { i?86-*-* x86_64-*-* } } } */ you are adding a test to gcc.dg/vect - It's a common directory containing tests that need to run on multiple arc

[Patch, libgfortran] Set close-on-exec flag when opening files

Hello, the attached patch sets the close-on-exec flag when opening files, as is usually considered good practice these days. See e.g. http://www.python.org/dev/peps/pep-0446/ and links therein for more information. The preconnected units INPUT_UNIT, OUTPUT_UNIT, ERROR_UNIT are not affected, only

Ping^2 Re: Add predefined macros for library use in defining __STDC_IEC_559*

Ping^2. This patch is still pending review (hook addition, rs6000/powerpc changes). -- Joseph S. Myers jos...@codesourcery.com

Re: [wide-int] Update main comment

On 10/29/2013 06:37 PM, Richard Sandiford wrote: This patch tries to update the main wide_int comment to reflect the current implementation. - bitsizetype is TImode on x86_64 and others, so I don't think it's necessarily true that all offset_ints are signed. (widest_int are though.) i am

[wide-int] Update main comment

This patch tries to update the main wide_int comment to reflect the current implementation. - bitsizetype is TImode on x86_64 and others, so I don't think it's necessarily true that all offset_ints are signed. (widest_int are though.) - As discussed in the early threads, I think the first re

Re: [RFA][PATCH] Minor fix to aliasing machinery

On Tue, 29 Oct 2013, Jeff Law wrote: Marc pointed out that the handling of various BUILT_IN_MEM* and BUILT_IN_STR* functions in tree-ssa-alias.c probably wasn't working as intended because the code wasn't prepared for a common return value from ao_ref_base, particularly returns of MEM_REFs.

[PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

Hi SAD (Sum of Absolute Differences) is a common and important algorithm in image processing and other areas. SSE2 even introduced a new instruction PSADBW for it. A SAD loop can be greatly accelerated by this instruction after being vectorized. This patch introduced a new operation SAD_EXPR and a

Re: [patch] fix libstdc++/58839

On 29 October 2013 21:33, Jonathan Wakely wrote: > This change fixes the unique_ptr testcase in the PR while > preserving the extension that we allow initializing a shared_ptr from > a unique_ptr that uses a custom pointer. > > I've added a test for that extension, and for assignment of > enable_sh

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

On 29 Oct 13:39, Jeff Law wrote: > On 10/24/13 08:43, Ilya Enkovich wrote: > > > >+/* Return the number of arguments used by call statement GS. */ > >+ > >+static inline unsigned > >+gimple_call_num_nobnd_args (const_gimple gs) > >+{ > >+ unsigned num_args = gimple_call_num_args (gs); > >+ unsig

Re: patch to fix a LRA crash on ppc

On Oct 28, 2013, at 4:20 PM, Vladimir Makarov wrote: >* lra-spills.c (lra_final_code_change): Remove useless move insns >originated from moves of pseudos. So I was facing a problem of extraneous moves of multiple registers: (set (reg:TI 1) (mem …)) === (set (reg:DI 2) (subreg:D

[RFA][PATCH] Minor fix to aliasing machinery

Marc pointed out that the handling of various BUILT_IN_MEM* and BUILT_IN_STR* functions in tree-ssa-alias.c probably wasn't working as intended because the code wasn't prepared for a common return value from ao_ref_base, particularly returns of MEM_REFs. This patch fixes the code to handle t

[patch] fix libstdc++/58839

This change fixes the unique_ptr testcase in the PR while preserving the extension that we allow initializing a shared_ptr from a unique_ptr that uses a custom pointer. I've added a test for that extension, and for assignment of enable_shared_from this. 2013-10-29 Jonathan Wakely PR l

[wide-int] Various minor tweaks

I looked through the diff of wide-int with mainline and noticed a few minor things to tweak. This patch: - Fixes comment typos that I'd introducted. - Fixes spurious whitespace differences. - Uses const X & instead of X for *wide_int parameters. - Fuses declarations and initialisers. - Avoids unn

Re: [SH] PR 54236 - add some more addc patterns

On Tue, 2013-10-29 at 11:43 +0900, Kaz Kojima wrote: > Oleg Endo wrote: > > This adds some more patterns to utilize the SH addc instruction. > > Tested on rev 204111 with > > make -k check RUNTESTFLAGS="--target_board=sh-sim > > \{-m2a/-mb,-m2a-single/-mb,-m4/-ml,-m4-single/-ml,-m4/-mb,-m4-single/

Re: [Patch, fortran] PRs 57893 and 58858

Dear Tobias, The .diff does not seem to reflect what is in the file - I am at a loss to explain why. Committed as revision 204177. Thanks for the review. Paul On 29 October 2013 07:32, Tobias Burnus wrote: > Am 28.10.2013 23:26, schrieb Paul Richard Thomas: > >> This patch addresses issues ar

Re: [PATCH] Fix PR ipa/58862 (profiled bootstrap failure)

> This patch fixes a profiledbootstrap failure that occurred after I > added some profile fixup. The initial profile insanity occurred > upstream of my change, but my change caused the insanity to spread to > the edge probability, resulting in a verify failure. The patch below > ensures this doesn'

Re: Fix scheduler ix86_issue_rate and ix86_adjust_cost for modern x86 chips

> On Fri, 25 Oct 2013, Jan Hubicka wrote: > > > > > OK, so it is about 2%. Did you try if you need lookahead even in the > > > > early pass (before reload)? My guess would be so, but if not, it could > > > > cut the cost to half. For -Ofast/-O3 it looks resonable to me, but we > > > > will

Re: [Patch, Fortran] PR44350 - add constraint check for BLOCK DATA

Dear Tobias, Your patch is OK for trunk. Thanks for the patch Are you sure that PR58857 is valid? If so, I stick my legs up in the air and give up :-) Cheers Paul On 24 October 2013 00:09, Tobias Burnus wrote: > A rather simple patch, which tries to implement Fortran 2008's C1116 (see > als

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013/10/29 Jeff Law : > On 10/29/13 07:52, Ilya Enkovich wrote: >> >> >> Yeah. I'm working on it right now. I've fixed known issues and now >> I'm looking for others. Meanwhile here is a new patch version with >> required renames and without LTO restriction. > > I can't help but but curious, wha

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

On 10/24/13 08:43, Ilya Enkovich wrote: +/* Return the number of arguments used by call statement GS. */ + +static inline unsigned +gimple_call_num_nobnd_args (const_gimple gs) +{ + unsigned num_args = gimple_call_num_args (gs); + unsigned res = num_args; + for (unsigned n = 0; n < num_args;

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

On 10/29/13 07:52, Ilya Enkovich wrote: Yeah. I'm working on it right now. I've fixed known issues and now I'm looking for others. Meanwhile here is a new patch version with required renames and without LTO restriction. I can't help but but curious, what turned out to be the root cause of th

Re: Symtab, cgraph and varpool nodes are now a real class hierarchy

> > The conversion of the symtab types from inheritance-in-C to a C++ class > hierarchy is now in trunk: I committed the manual parts of the > conversion as r204170, and the automated part as r204171. I then > noticed that this broke the gdb debugging hooks for printing a > (cgraph_node *). I te

Re: free is a killer

On 10/29/13 00:38, Marc Glisse wrote: On Mon, 28 Oct 2013, Jeff Law wrote: On 10/28/13 16:05, Marc Glisse wrote: I checked and it does the wrong thing (I don't have the testcase handy anymore, but it shouldn't be hard to recreate one), I even wrote a patch (attached) but it is related to: htt

Symtab, cgraph and varpool nodes are now a real class hierarchy

On Mon, 2013-10-28 at 23:37 -0600, Jeff Law wrote: > On 10/28/13 20:57, David Malcolm wrote: > >>> * cgraph.h (symtab_node_base): Convert to a class; > >>> add GTY((desc ("%h.type"), tag ("SYMTAB_SYMBOL"))). > >>> (cgraph_node): Inherit from symtab_node; add GTY option > >>> tag ("SYMTAB_FU

Re: [PATCH] Keep REG_INC note in subreg2 pass

On 10/24/13 02:20, Zhenqiang Chen wrote: Hi, REG_INC note is lost in subreg2 pass when resolve_simple_move, which might lead to wrong dependence for ira. e.g. In function validate_equiv_mem of ira.c, it checks REG_INC note: for (note = REG_NOTES (insn); note; note = XEXP (note, 1))

[PATCH] Fix PR ipa/58862 (profiled bootstrap failure)

This patch fixes a profiledbootstrap failure that occurred after I added some profile fixup. The initial profile insanity occurred upstream of my change, but my change caused the insanity to spread to the edge probability, resulting in a verify failure. The patch below ensures this doesn't occur.

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

On Tue, Oct 29, 2013 at 10:34 AM, Uros Bizjak wrote: > On Tue, Oct 29, 2013 at 6:18 PM, Cong Hou wrote: > For the define_expand I added as below, the else body is there to avoid fall-through transformations to ABS operation in optabs.c. Otherwise ABS will be converted to other oper

Re: [RFC] [Testsuite,ARM] Neon intrinsics executable tests

On 29 October 2013 03:24, Ramana Radhakrishnan wrote: > On 10/09/13 23:16, Christophe Lyon wrote: > Irrespective of our earlier conversations on this now I'm actually wondering > if instead of doing this and integrating this in the GCC source base it > maybe easier to write a harness to test this

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

On 10/29/13 09:14, Andrew Pinski wrote: On Mon, Oct 28, 2013 at 10:51 PM, Jeff Law wrote: On 10/27/13 12:55, Andrew Pinski wrote: Here is my latest patch which adds the testcases from Zhenqiang's patch and fixes item 1 and 2. OK? Bootstrapped and tested on x86_64-linux-gnu with no regressio

Re: [PATCH] tree-ssa documetation fix

On 10/29/13 03:53, Martin Liška wrote: Hello, I've noticed that some part of documentation is obsolete and this patch adds documentation for new functions that replace old macros. [ ... ] Thanks. Installed on the trunk. jeff

Re: [GOOGLE] Don't update the callee count if caller is not resolved node

The situation you described is worse -- hopefully it will be addressed in the next version of lipo. The change is ok. David On Tue, Oct 29, 2013 at 10:08 AM, Dehao Chen wrote: > On Mon, Oct 28, 2013 at 9:49 PM, Xinliang David Li wrote: >> Is it sufficient to check if the final caller is define

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

On Tue, Oct 29, 2013 at 7:58 AM, Jason Merrill wrote: > On 10/28/2013 06:12 PM, Dehao Chen wrote: >> >> ping... > > > Sorry for the slow response. > > If we're actually emitting the name now, we need to give it a name different > from the complete constructor. I suppose it makes sense to go with

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

On Tue, Oct 29, 2013 at 6:18 PM, Cong Hou wrote: >>> For the define_expand I added as below, the else body is there to >>> avoid fall-through transformations to ABS operation in optabs.c. >>> Otherwise ABS will be converted to other operations even that we have >>> corresponding instructions from

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

On 10/29/13 10:46, Vladimir Makarov wrote: On 10/29/2013 12:26 PM, Jeff Law wrote: On 10/29/13 09:12, Vladimir Makarov wrote: I've found only one useful transformations in regmove pass: dst = srcdst = src (src dies) ... no dst or src

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

On Tue, Oct 29, 2013 at 1:38 AM, Uros Bizjak wrote: > Hello! > >> For the define_expand I added as below, the else body is there to >> avoid fall-through transformations to ABS operation in optabs.c. >> Otherwise ABS will be converted to other operations even that we have >> corresponding instruct

Re: [PATCH] Introduce [sg]et_nonzero_bits

Hi! On Tue, Oct 29, 2013 at 04:29:56PM +0100, Jakub Jelinek wrote: > > Surely you can't rely on CCP and VRP compute exactly the same > > nonzero_bits. As you don't record/compute zero_bits you can't > > tell whether a not set bit in nonzer_bits is "don't know" or > > if it is "zero". And you can

Re: [GOOGLE] Don't update the callee count if caller is not resolved node

On Mon, Oct 28, 2013 at 9:49 PM, Xinliang David Li wrote: > Is it sufficient to check if the final caller is defined in primary module? This might not be sufficient because the final caller may come from comdat of aux-modules (not defined in the primary module). > > Note that in some cases, doin

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

On 10/29/2013 12:44 PM, Joseph S. Myers wrote: > Please change the .opt entries to > > foptimize-register-move > Common Ignore > Does nothing. Preserved for backward compatibility. > > and > > fregmove > Common Ignore > Does nothing. Preserved for backward compatibility. > > rather than removing th

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

On 10/29/2013 12:43 PM, Alexander Monakov wrote: > Hello, > > A very minor nit: in common.opt, entries for the options should be changed to > > fregmove > Common Ignore > Does nothing. Preserved for backward compatibility. > > instead of removing them altogether, so the compiler does not start reje

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

On 10/29/2013 12:26 PM, Jeff Law wrote: > On 10/29/13 09:12, Vladimir Makarov wrote: >>I've found only one useful transformations in regmove pass: >> >>dst = srcdst = src (src dies) >>... no dst or src modification => src changed on

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

Please change the .opt entries to foptimize-register-move Common Ignore Does nothing. Preserved for backward compatibility. and fregmove Common Ignore Does nothing. Preserved for backward compatibility. rather than removing them completely. In general, when removing an option that's purely ab

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

Hello, A very minor nit: in common.opt, entries for the options should be changed to fregmove Common Ignore Does nothing. Preserved for backward compatibility. instead of removing them altogether, so the compiler does not start rejecting build commands with such options. There are now a few suc

Re: [PATCH i386 4/8] [AVX512] [1/n] Add substed patterns.

On 10/29/2013 03:02 AM, Kirill Yukhin wrote: > Hello Richard, > > On 28 Oct 14:45, Richard Henderson wrote: >> On 10/28/2013 01:58 PM, Kirill Yukhin wrote: >>> Hello Richard, >>> On 28 Oct 08:20, Richard Henderson wrote: Why is a masked *scalar* operation useful? >>> >>> The reason the instru

Re: [patch] Mostly remove tree-core.h from other .h files.

On 10/28/2013 03:38 PM, Andrew MacLeod wrote: I noticed there were a few .h files which we including tree-core.h themselves. expr.h was one of them, and many of the rtl files used that to get at the basic tree structure for various bits. I moved the include of tree-core.h to rtl.h instead.

Re: RFA: Andes nds32 port v4 patch

On Tue, 29 Oct 2013, Chung-Ju Wu wrote: > Thank you very much for the comments on libgcc and documentation parts. > Here I re-list the v4 patch of nds32 port: > > Machine Description -- > http://gcc.gnu.org/ml/gcc-patches/2013-10/msg02153.html > http://gcc.gnu.org/ml/gcc-patches/2013-10

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

On 10/29/13 09:12, Vladimir Makarov wrote: Tomorrow I'd like commit the following patch. The patch removes regmove pass. I'm buying next time we get together :-) You have my eternal gratitude. I've found only one useful transformations in regmove pass: dst = src

Re: RE : Problem with _Hashtable_ebo_helper

This patch replaces the problematic use of _Hashtable_ebo_helper with a new type. 2013-10-29 Jonathan Wakely * include/bits/hashtable.cc (__access_protected_ctor): Define and use new type instead of _Hashtable_ebo_helper. * testsuite/23_containers/unordered_set/

Re: [Fwd: Re: [PATCH (updated)] Convert symtab, cgraph and varpool nodes into a real class hierarchy]

On 10/29/13 10:03, David Malcolm wrote: commit 739276306f1d8f5d0b1202da21cc29b5fcac102e Author: David Malcolm Date: Mon Oct 28 22:25:38 2013 -0400 Add chain_next and chain_prev options back to symtab_node_base gcc/ * cgraph.h (symtab_node_base): Add missing chain_next and

Re: [PATCH, PR 10474] Split live-ranges of function arguments to help shrink-wrapping

On 10/25/2013 11:19 AM, Martin Jambor wrote: > Hi, > > On Thu, Oct 24, 2013 at 01:02:51AM +0200, Steven Bosscher wrote: >> On Wed, Oct 23, 2013 at 6:46 PM, Martin Jambor wrote: >> >>> /* Perform the second half of the transformation started in >>> @@ -4522,7 +4704,15 @@ ira (FILE *f) >>> all

Re: [PATCH] Use get_nonzero_bits to improve vectorization

On Tue, Oct 29, 2013 at 01:11:53PM +0100, Richard Biener wrote: > > +/* Return number of known trailing zero bits in EXPR, or, if the value of > > + EXPR is known to be zero, the precision of it's type. */ > > + > > +int > > unsigned int? Ok. > > +case PLUS_EXPR: > > +case MINUS_EXPR:

Re: free is a killer

On 10/29/13 00:38, Marc Glisse wrote: Indeed. Do you want to commit it xfailed or put it in bugzilla so we don't lose it? (it becomes harder if you replace p with p-1 in the memset arguments). I'll either add it as xfailed, or I'll add it as-is if I fix the alias code. It'd primarly be to add

Re: RFC/A: PR 58079: CONST_INT mode assert in combine.c:do_SUBST

On Mon, Oct 28, 2013 at 5:28 PM, Uros Bizjak wrote: >> PR 58079 is about the do_SUBST assert: >> >> /* Sanity check that we're replacing oldval with a CONST_INT >> that is a valid sign-extension for the original mode. */ >> gcc_assert (INTVAL (newval) >> == trunc_int_for_mode (INTVA

[patch] fix fallout from lto-streamer.h not including gimple.h

2 target files also included lto-streamer.h but did not include gimple.h.Fixed thusly. Applied as revision 204166 Andrew * config/darwin.c: Include gimple.h. * config/i386/winnt.c: Likewise. Index: config/darwin.c === ***

Re: [PATCH] fixing typo in expr.c to allow proper recognition of complex addresses in some arches.

On 10/29/13 06:10, Eric Botcazou wrote: My reading of memory_address_addr_space is that MODE is the mode of the memory reference, not the mode of the address. I fail to see how passing in the mode of the address in the first call can be correct. What am I missing? Nothing, it's me confusing

Re: free is a killer

On 10/29/13 09:15, Richard Biener wrote: On Tue, Oct 29, 2013 at 4:01 PM, Jeff Law wrote: On 10/29/13 04:40, Richard Biener wrote: Of course in the example we have the "global memory" storage class (incoming function argument) and "malloc memory" which is really the same storage class. It o

Re: [PATCH] Introduce [sg]et_nonzero_bits

On Tue, Oct 29, 2013 at 12:55:04PM +0100, Richard Biener wrote: > Surely you can't rely on CCP and VRP compute exactly the same > nonzero_bits. As you don't record/compute zero_bits you can't > tell whether a not set bit in nonzer_bits is "don't know" or > if it is "zero". And you cannot do an as

Re: [wide-int] More optimisations

On 10/29/2013 08:43 AM, Richard Sandiford wrote: Richard Biener writes: On Sun, 27 Oct 2013, Richard Sandiford wrote: This patch adds some more optimisations to the wi:: comparison functions. It uses the: #define CONSTANT(X) (__builtin_constant_p (X) && (X)) idiom that was mentioned befor

Re: free is a killer

On Tue, Oct 29, 2013 at 4:01 PM, Jeff Law wrote: > On 10/29/13 04:40, Richard Biener wrote: >> >> >> Of course in the example we have the "global memory" storage class >> (incoming function argument) and "malloc memory" which is really >> the same storage class. It only becomes a different storag

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

On Mon, Oct 28, 2013 at 10:51 PM, Jeff Law wrote: > On 10/27/13 12:55, Andrew Pinski wrote: >> >> Here is my latest patch which adds the testcases from Zhenqiang's >> patch and fixes item 1 and 2. >> >> OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. >> >> Thanks, >> Andrew P

Re: [PATCH 1/2] fix PR49847 ICE-on-HAVE_cc0 regression from PR50780 changes

On Wed, Aug 28, 2013 at 10:06 PM, Jeff Law wrote: > On 08/28/2013 03:50 AM, Mikael Pettersson wrote: >> >> This patch fixes an ICE that occurs in #ifdef HAVE_cc0 code. The ICE >> breaks both Java and Ada bootstrap on m68k-linux. There is also a >> tiny C++ test case in the BZ entry. >> >> The IC

Re: free is a killer

On 10/29/13 04:40, Richard Biener wrote: Of course in the example we have the "global memory" storage class (incoming function argument) and "malloc memory" which is really the same storage class. It only becomes a different storage class if you factor in flow analysis (for which the current PT

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

On 10/28/2013 06:12 PM, Dehao Chen wrote: ping... Sorry for the slow response. If we're actually emitting the name now, we need to give it a name different from the complete constructor. I suppose it makes sense to go with C4/D4 as in the decloning patch, http://gcc.gnu.org/ml/gcc-patches

[PATCH] Fix PR 58867: asan and ubsan tests not run for installed testing

Hi, The problem here is that both asan and ubsan testsuite test if we have set a library path before running the testsuite. This is incorrect when running the already installed testing as there is no path to set. This patch changes it so it tests if the executable is able to be built/linked bef

Re: [PATCH] Testcase for nonzero_bits & __builtin_unreachable

On Tue, 29 Oct 2013, Jakub Jelinek wrote: > On Sat, Oct 26, 2013 at 12:19:33AM +0200, Jakub Jelinek wrote: > > And here is a patch that allows vectorization without peeling for alignment > > and scalar loop for bound even for fn2, fn3 and fn4 in the following > > testcase, though as with the range

Re: [PATCH] Compute nonzero_bits from __builtin_unreachable assertions

On Sat, 26 Oct 2013, Jakub Jelinek wrote: > Hi! > > And here is a patch that allows vectorization without peeling for alignment > and scalar loop for bound even for fn2, fn3 and fn4 in the following > testcase, though as with the range __builtin_unreachable () notes, it is > quite fragile, becaus

Re: [C++ Patch] PR 58888

OK. Jason

Re: [Patch, C, C++] Accept GCC ivdep for 'do' and 'while', and for C++11's range-based loops

On 10/28/2013 05:48 PM, Tobias Burnus wrote: I am not completely sure whether you had the following in mind, but that's what I have now implemented: DEFTREECODE (RANGE_FOR_STMT, "range_for_stmt", tcc_statement, 4) has now a 5th operator (RANGE_FOR_IVDEP), which has the value boolean_true_node

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

On 10/29/2013 02:51 AM, Bernd Edlinger wrote: On Mon, 28 Oct 2013 21:29:24, Sandra Loosemore wrote: I again tried backporting the patch series along with your fix to GCC 4.8 and tested on arm-none-eabi. I found that it was still getting stuck in infinite recursion unless the test from this patc

[PATCH, 4.8, PR 58789] Backport cgraph_get_create_real_symbol_node and PR 57084 fix

Hi, PR 58789 has been fixed on trunk by revision 198743 which needs cgraph_get_create_real_symbol_node introduced in revision 196750. This patch backports both. It has been pre-approved by Honza in person and passed bootstrap and testing on the branch. I am about to commit it momentarily. Thank

[PATCH] More restrict testcases

Just figured while "optimizing" Michas ADD_RESTRICT patch ... (well, make it "work"). Tested on x86_64-unknown-linux-gnu, committed. Richard. 2013-10-29 Richard Biener * gcc.dg/torture/restrict-2.c: New testcase. * gcc.dg/torture/restrict-3.c: Likewise. * gcc.dg/tort

Re: [PATCH] Handle __builtin_unreachable () using assertions in VRP

On Tue, 29 Oct 2013, Jakub Jelinek wrote: > On Tue, Oct 29, 2013 at 12:28:49PM +0100, Richard Biener wrote: > > Otherwise ok. > > So like this? Yes, Thanks. Richard. > 2013-10-29 Jakub Jelinek > > * tree-cfg.c (assert_unreachable_fallthru_edge_p): New function. > * tree-cfg.h (a

Re: libsanitizer merge from upstream r191666

On Tue, Oct 29, 2013 at 6:52 AM, Jakub Jelinek wrote: > On Tue, Oct 29, 2013 at 06:49:30AM -0700, Konstantin Serebryany wrote: >> Thanks! >> (At this time I will be slow with response due to travel) > > BTW, don't have compiled clang/llvm pre-3.4 around to look at, for the use > after return, do y

Re: [PATCH] Handle __builtin_unreachable () using assertions in VRP

On Tue, Oct 29, 2013 at 12:28:49PM +0100, Richard Biener wrote: > Otherwise ok. So like this? 2013-10-29 Jakub Jelinek * tree-cfg.c (assert_unreachable_fallthru_edge_p): New function. * tree-cfg.h (assert_unreachable_fallthru_edge_p): New prototype. * tree-vrp.c (all_i

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

On 29 Oct 06:59, Jeff Law wrote: > On 10/29/13 04:17, Richard Biener wrote: > >On Mon, Oct 28, 2013 at 10:21 PM, Jeff Law wrote: > >>On 10/25/13 11:57, Ilya Enkovich wrote: > >> > >>> > >>>There are currently two known issues with LTO. The first one is ICE in > >>>LTO streamer when it reads instru

Re: libsanitizer merge from upstream r191666

On Tue, Oct 29, 2013 at 06:49:30AM -0700, Konstantin Serebryany wrote: > Thanks! > (At this time I will be slow with response due to travel) BTW, don't have compiled clang/llvm pre-3.4 around to look at, for the use after return, do you emit always the the __asan_*malloc/free calls for the stack v

Re: [PATCH] Invalid unpoisoning of stack redzones on ARM

On Tue, Oct 29, 2013 at 01:06:21PM +, Richard Sandiford wrote: > > If it is a pseudo, it is certainly a pseudo that isn't used for > > anything else, as it is the result of (base >> 3) + constant, if it isn't a > > pseudo, then supposedly it is better not to just keep adding the offsets to > >

Re: [PATCH] Invalid unpoisoning of stack redzones on ARM

Jakub Jelinek writes: > On Tue, Oct 29, 2013 at 12:25:33PM +, Richard Sandiford wrote: >> >> Any updates on this one? Note that this bug is a huge blocker for >> >> using AddressSanitizer on ARM platforms. >> > >> > Sorry for the delay, I finally found time to look at it. >> > While your patch

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

On 10/29/13 04:17, Richard Biener wrote: On Mon, Oct 28, 2013 at 10:21 PM, Jeff Law wrote: On 10/25/13 11:57, Ilya Enkovich wrote: There are currently two known issues with LTO. The first one is ICE in LTO streamer when it reads instrumented code. The second one is unitialized flag_check_poi

Re: [wide-int] More optimisations

Richard Biener writes: > On Sun, 27 Oct 2013, Richard Sandiford wrote: >> This patch adds some more optimisations to the wi:: comparison functions. >> It uses the: >> >> #define CONSTANT(X) (__builtin_constant_p (X) && (X)) >> >> idiom that was mentioned before, except that I thought CONSTANT

Re: [PATCH] Invalid unpoisoning of stack redzones on ARM

On Tue, Oct 29, 2013 at 12:25:33PM +, Richard Sandiford wrote: > >> Any updates on this one? Note that this bug is a huge blocker for > >> using AddressSanitizer on ARM platforms. > > > > Sorry for the delay, I finally found time to look at it. > > While your patch fixes the issue, I wonder if

RE: [PING] [AArch64] Peepholes to generate ldp and stp instructions

Hi, >> You are better off CCing the maintainers for such reviews. Let me do >> that for you. I cannot approve or reject this patch but I have a few >> comments as below. Thanks for the quick review and comments. Please find attached the modified patch as per review comments. Please review the sa

Re: [PATCH] Invalid unpoisoning of stack redzones on ARM

Jakub Jelinek writes: > On Wed, Oct 16, 2013 at 09:35:21AM +0400, Yury Gribov wrote: >> >>> I've recently submitted a bug report regarding invalid >> unpoisoning of stack frame redzones >> (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58543). Could someone >> take a look at proposed patch (a simple

Re: [wide-int] More optimisations

On Sun, 27 Oct 2013, Richard Sandiford wrote: > This patch adds some more optimisations to the wi:: comparison functions. > It uses the: > > #define CONSTANT(X) (__builtin_constant_p (X) && (X)) > > idiom that was mentioned before, except that I thought CONSTANT would be > too easily confused

Re: [wide-int] Treat order comparisons like other binary ops

On Sun, 27 Oct 2013, Richard Sandiford wrote: > Until now, eq_p and ne_p have enforced the same argument rules as things > like addition, while order comparisons like lts_p have treated the two > arguments as independent and signed. Richard, I think you said on IRC > that you thought lts_p should

Re: [PATCH][ARM] New rtx cost table for Cortex-A7

On 10/29/13 12:15, Kyrill Tkachov wrote: Hi all, This patch adds the new rtx costs for the Cortex-A7 core as well as a new tuning structure to contain it. Tested arm-none-eabi on qemu and no benchmark regressions. Ok for trunk? Ok. Ramana

[PATCH][ARM] New rtx cost table for Cortex-A7

Hi all, This patch adds the new rtx costs for the Cortex-A7 core as well as a new tuning structure to contain it. Tested arm-none-eabi on qemu and no benchmark regressions. Ok for trunk? Thanks, Kyrill [gcc/] 2013-10-29 Kyrylo Tkachov * config/arm/arm.c (cortexa7_extra_costs): New t

Re: libsanitizer merge from upstream r191666

> On Wed, Oct 2, 2013 at 12:51 PM, Konstantin Serebryany > > 2013-10-XX Kostya Serebryany > > > > * g++.dg/asan/asan_test.cc: Update the test > > to match the fresh asan run-time. > > * c-c++-common/asan/stack-overflow-1.c: Ditto. > > > > === gcc/ChangeLog > > > >

  1   2   >