Re: [PATCH] Invalid unpoisoning of stack redzones on ARM

2013-10-06 Thread Yury Gribov
Hi Jakub, >> I've recently submitted a bug report regarding invalid unpoisoning of stack frame redzones (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58543). Could someone take a look at proposed patch (a simple one-liner) and check whether it's ok for commit? > > Can you please be more verbo

Re: [PATCH, rs6000] Correct vector permute for little endian

2013-10-06 Thread David Edelsohn
On Sun, Oct 6, 2013 at 1:32 PM, Bill Schmidt wrote: > This patch corrects the expansion of vec_perm_constv16qi for > powerpc64le. The explanation of the problem with a detailed example > appears in the commentary, as this corrects for what I found to be > surprising behavior in the implementation

Re: [PATCH, PowerPC] Change code generation for VSX loads and stores for little endian

2013-10-06 Thread David Edelsohn
On Mon, Sep 30, 2013 at 10:04 PM, Bill Schmidt wrote: > This patch implements support for VSX vector loads and stores in little > endian mode. VSX loads and stores permute the register image with > respect to storage in a unique manner that is not truly little endian. > This can cause problems (f

Re: [Patch] Optimize _BFSExecutor in regex

2013-10-06 Thread Paolo Carlini
On 10/07/2013 12:43 AM, Tim Shen wrote: Here's a simple piece of code https://gist.github.com/innocentim/6849759 the reveals _BFSExecutor's inefficiency. ... which we want in testsuite/performance/28_regex! Thanks! Paolo.

Re: [SH] PR 51244 - Fix defects introduced in 4.8

2013-10-06 Thread Kaz Kojima
Oleg Endo wrote: > Forgot to handle a case in function can_remove_cstore, thanks for > catching it. Fixed in the attached patch and also added test cases. > Retested as before without new failures. Ok for trunk. > Yeah, right. I've changed 'ifcvt_sh' to 'sh_ifcvt'. >+ register_pass (make_pas

[Patch] Optimize _BFSExecutor in regex

2013-10-06 Thread Tim Shen
Here's a simple piece of code https://gist.github.com/innocentim/6849759 the reveals _BFSExecutor's inefficiency. Some optimizations are here to reduce the unecessary time complexity from O(n^2) to O(n). I'll do a bootstrap and full testing before committing. Thanks! -- Tim Shen a.patch Desc

Optimize callers using nonnull attribute

2013-10-06 Thread Marc Glisse
Hello, this patch asserts that when we call a function with the nonnull attribute, the corresponding argument is not zero, just like when we dereference a pointer. Everything is under a check for flag_delete_null_pointer_checks. Note that this function currently gives up if the statement may

Re: [C++ Patch] PR 58126

2013-10-06 Thread Jason Merrill
On 10/06/2013 03:35 PM, Paolo Carlini wrote: PS: I struggled a bit with "%qT" vs "%q#T": I would slightly prefer simply talking about, eg, "base class 'A'", we do that in other cases, but here we are already using # which automatically picks class vs struct. Thus I think we should use # for the b

[C++ Patch] PR 58126

2013-10-06 Thread Paolo Carlini
Hi, it seems to me that in order to fix this accepts-invalid (for the testcase we don't reject the declaration 'B b;') we have simply to propagate from bases to derived the CLASSTYPE_READONLY_FIELDS_NEED_INIT and CLASSTYPE_REF_FIELDS_NEED_INIT flags. Thus, the few class.c lines in the patch b

Re: [GOOGLE] Iterative AutoFDO

2013-10-06 Thread Xinliang David Li
Adding additional early inline + value transform (calling them as utility functions) is 'unconventional' way of invoking passes. It would be helpful to do more heavy documentation by providing more examples and explaining why simply augmenting the indirect target info for promoted icall site with i

Re: [Patch] Internal functions for testsuite in regex

2013-10-06 Thread Tim Shen
On Sat, Oct 5, 2013 at 7:45 AM, Paolo Carlini wrote: > Patch looks great to me. If you don't get more comments over the next day or > so, please go ahead. Committed :) -- Tim Shen

Re: [Patch] Fix COMPILE error in regex and remove default parameter in function definition

2013-10-06 Thread Tim Shen
On Sun, Oct 6, 2013 at 5:38 AM, Paolo Carlini wrote: > Ok, thanks. Committed :) -- Tim Shen

[PATCH, rs6000] Correct vector permute for little endian

2013-10-06 Thread Bill Schmidt
This patch corrects the expansion of vec_perm_constv16qi for powerpc64le. The explanation of the problem with a detailed example appears in the commentary, as this corrects for what I found to be surprising behavior in the implementation of the vperm instruction, and I don't want any of us to spen

Re: [Patch] Handle profile counts truncated to 0 in coldness test

2013-10-06 Thread Jan Hubicka
> The second part ensures that frequencies are correctly updated after > inlining. The problem is that after inlining the frequencies were > being recomputed directly from the corresponding bb counts in > rebuild_frequencies. If the counts had been truncated to 0, then the > recomputed frequencies

[v3] libstdc++/58625

2013-10-06 Thread Paolo Carlini
Hi, tested x86_64-linux, committed to mainline. Paolo. /// 2013-10-06 Oleg Endo Paolo Carlini PR libstdc++/58625 * include/c_global/cmath (signbit): Use __builtin_signbitf and __builtin_signbitl. Index: include/c_global/cmath ===

Re: [Patch] Handle profile counts truncated to 0 in coldness test

2013-10-06 Thread Jan Hubicka
> 2013-10-03 Teresa Johnson > > * params.def (PARAM_MIN_HOT_RUN_RATIO): New parameter. I would not mention HOT in the parameter name. Blocks are hot/normal/unlikely and we HOT_BB_FREQUENCY_FRACTION. So perhaps UNLIKELY_BB_COUNT_FRACTION with an explanation that it is relative to numb

Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (2).

2013-10-06 Thread Chung-Ju Wu
2013/10/6 Chung-Lin Tang : > On 2013/10/6 下午 06:33, Richard Sandiford wrote: >> Chung-Lin Tang writes: >>> On 2013/10/6 05:57 PM, Richard Sandiford wrote: Another way to handle this would be to have the movsi expander split large constant moves. When can_create_pseudo_p (), the intermed

Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (2).

2013-10-06 Thread Chung-Ju Wu
2013/10/6 Richard Sandiford : > Chung-Ju Wu writes: >> On 10/2/13 1:31 AM, Richard Sandiford wrote: >>> Chung-Ju Wu writes: + /* Use $r15, if the value is NOT in the range of Is20, + we must output "sethi + ori" directly since + we may already passed the split

Re: [C++ Patch] PR 56060

2013-10-06 Thread Paolo Carlini
Hi, Jason Merrill ha scritto: >For EXPR_PACK_EXPANSION we can just return true; a pack expansion is >always dependent, on the number of arguments if nothing else. Thanks. I suspected that ;) Then I'm going to test the corresponding very simple patch and commit it. Thanks again! Paolo

RE: [PING] [PATCH] PR58143/58227 wrong code at -O3

2013-10-06 Thread Bernd Edlinger
Ping! How I should proceed with this patch, is it OK? The latest version was posted at: http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00234.html Thanks, Bernd. > > ping... > > On Wed, 4 Sep 2013 18:45:39, Bernd Edlinger wrote: >> >> On Tue, 3 Sep 2013 12:31:50, Richard Biener wrote: >>> On Fri

Re: [C++ Patch] PR 56060

2013-10-06 Thread Jason Merrill
For EXPR_PACK_EXPANSION we can just return true; a pack expansion is always dependent, on the number of arguments if nothing else. Jason

Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (2).

2013-10-06 Thread Chung-Lin Tang
On 2013/10/6 下午 06:33, Richard Sandiford wrote: > Chung-Lin Tang writes: >> On 2013/10/6 05:57 PM, Richard Sandiford wrote: > But case 16 is different. > This case is only produced at prologue/epilogue phase, using a temporary > register $r15 to hold a large constant for adjusting stac

Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (2).

2013-10-06 Thread Richard Sandiford
Chung-Lin Tang writes: > On 2013/10/6 05:57 PM, Richard Sandiford wrote: >>> > But case 16 is different. >>> > This case is only produced at prologue/epilogue phase, using a temporary >>> > register $r15 to hold a large constant for adjusting stack pointer. >>> > Since prologue/epilogue is after

Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (2).

2013-10-06 Thread Chung-Lin Tang
On 2013/10/6 05:57 PM, Richard Sandiford wrote: >> > But case 16 is different. >> > This case is only produced at prologue/epilogue phase, using a temporary >> > register $r15 to hold a large constant for adjusting stack pointer. >> > Since prologue/epilogue is after split1/split2 phase, we can on

Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (2).

2013-10-06 Thread Richard Sandiford
Chung-Ju Wu writes: > On 10/2/13 1:31 AM, Richard Sandiford wrote: >> Chung-Ju Wu writes: >>> + /* Use $r15, if the value is NOT in the range of Is20, >>> + we must output "sethi + ori" directly since >>> + we may already passed the split stage. */ >>> + return "sethi\t

Re: [Patch] Fix COMPILE error in regex and remove default parameter in function definition

2013-10-06 Thread Paolo Carlini
On 10/06/2013 07:46 AM, Tim Shen wrote: Stupid errors hidden in some large commit. Ok, thanks. Paolo.

Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (1).

2013-10-06 Thread Richard Sandiford
Thanks for the updates. Chung-Ju Wu writes: > On 9/29/13 7:25 PM, Richard Sandiford wrote: >> Chung-Ju Wu writes: >> >>> + /* We need to provide a customized rtx which contains >>> + necessary information for data analysis, >>> + so we create a parallel rtx like this: >>> + (parall

Re: patch to canonize unsigned tree-csts

2013-10-06 Thread Richard Sandiford
Kenneth Zadeck writes: > On 10/04/2013 01:00 PM, Richard Sandiford wrote: >> I was hoping Richard would weigh in here. In case not... >> >> Kenneth Zadeck writes: >> I was thinking that we should always be able to use the constant as-is >> for max_wide_int-based and addr_wide_int-based o