Re: [PATCH] Fix array sizes created by Java FE (PR libgcj/57074)

2013-05-03 Thread Alan Modra
I believe the real problem here is in place_block_symbol() and output_object_block(). If DECL_INITIAL is given for an array, then shouldn't we be taking the size from the initializer? This patch fixes that problem, and ensures that we get an assembler error if placement in the block changes. I'v

Re: [patch, mips] Fix for PR target/56942

2013-05-03 Thread Steven Bosscher
Hello, I'm on holiday, but I'm back home tomorrow. Imho the active-insn "idiom" is the best solution for the moment. I will fix this mess properly asap, probably next week. Ciao! Steven On 5/3/13, Steve Ellcey wrote: > On Tue, 2013-04-30 at 15:05 +0100, Richard Sandiford wrote: >> Richard Sa

[PATCH, committed] Avoid bootstrap failure for i686-pc-linux-gnu due to SLSR

2013-05-03 Thread Bill Schmidt
This patch disables processing of conditional candidates in SLSR for the time being, until I can sort out the cause of a related bootstrap failure. Bootstrapped on powerpc64-unknown-linux-gnu with no regressions; bootstrapped on i686-pc-linux-gnu to verify bootstrap now works. Committed. Thanks,

Re: [PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-03 Thread Carrot Wei
commited as 198591. On Fri, May 3, 2013 at 11:51 AM, Xinliang David Li wrote: > Please do what Richard suggested. gcov_info_type can be obtained from > gcov_info_var decl. > > David > > > On Fri, May 3, 2013 at 11:31 AM, Carrot Wei wrote: >> On Fri, May 3, 2013 at 1:03 AM, Richard Biener >> wro

Re: [PATCH] SLSR for conditional candidates

2013-05-03 Thread Bill Schmidt
On Fri, 2013-05-03 at 13:58 -0700, H.J. Lu wrote: > On Fri, Mar 29, 2013 at 2:15 PM, Bill Schmidt > wrote: > > This is a resubmission of a patch I sent to the list last August, > > re-based for the C++ changes since then. It implements the last big > > chunk of straight-line strength reduction

[PATCH] Use indentation in gtype.state to show nested structure

2013-05-03 Thread David Malcolm
Whilst learning the internals of the GTY code I noticed that gtype.state's s-expressions are all aligned to the left-hand margin. The following patch to gengtype-state.c rewrites how they are written out to introduce indentation, showing the nesting structure of the s-expressions, which makes the

Re: [PATCH] Fix array sizes created by Java FE (PR libgcj/57074)

2013-05-03 Thread Alan Modra
Here's a smaller case that shows the same problem /home/amodra/build/gcc-current/./gcc/jc1 /home/amodra/src/gcc-current/libjava/classpath/lib/gnu/java/awt/dnd/peer/gtk/GtkDragSourceContextPeer.class -fhash-synchronization -fuse-divide-subroutine -fuse-boehm-gc -fnon-call-exceptions -fPIC -fkeep

Re: [PATCH] Fix array sizes created by Java FE (PR libgcj/57074)

2013-05-03 Thread Alan Modra
On Fri, May 03, 2013 at 07:10:15PM +0200, Jakub Jelinek wrote: > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, but > not tested on powerpc32 where it actually caused runtime issues, can > somebody please try it there? Ok for trunk/4.8? /home/amodra/build/gcc-current/./gcc/g

Re: [PATCH, rs6000] PR target/57150, do not use VSX instructions for long double caller saves

2013-05-03 Thread David Edelsohn
On Fri, May 3, 2013 at 7:05 PM, Michael Meissner wrote: > In debugging the glibc function __ieee754_scalbl when compiling for a power7 > target, we discovered that the compiler was using VSX load and store > instructions to save long double types that are passed in floating point > registes. Howe

[PATCH, rs6000] PR target/57150, do not use VSX instructions for long double caller saves

2013-05-03 Thread Michael Meissner
In debugging the glibc function __ieee754_scalbl when compiling for a power7 target, we discovered that the compiler was using VSX load and store instructions to save long double types that are passed in floating point registes. However, since long double types are passed as two scalar floating po

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Teresa Johnson
Resending since it bounced as my mailer wasn't set to plain text. Teresa On Fri, May 3, 2013 at 12:48 PM, Teresa Johnson wrote: > Yes it will ICE on failure. What is the guideline on c.torture vs gcc.dg? > Thanks, > Teresa > > On May 3, 2013 11:47 AM, "Jeff Law" wrote: >> >> On 05/03/2013 12:35

Re: [PATCH] SLSR for conditional candidates

2013-05-03 Thread H.J. Lu
On Fri, Mar 29, 2013 at 2:15 PM, Bill Schmidt wrote: > This is a resubmission of a patch I sent to the list last August, > re-based for the C++ changes since then. It implements the last big > chunk of straight-line strength reduction (conditional candidates, for > cases like comment 2 in PR35308

Re: [patch, mips] Fix for PR target/56942

2013-05-03 Thread Steve Ellcey
On Tue, 2013-04-30 at 15:05 +0100, Richard Sandiford wrote: > Richard Sandiford writes: > > Steven Bosscher writes: > >> I dont like this at all. At the very least, if we go this way, > >> then all places where next_active_insn is used should be updated. > >> Otherwise this is just confusion

Re: [RFA][PATCH] Fix tree-optimization/57124

2013-05-03 Thread Jeff Law
On 05/02/2013 01:55 AM, Richard Biener wrote: On Wed, May 1, 2013 at 10:26 PM, Jeff Law wrote: range_fits_type_p erroneously returns true in cases where the range has overflowed. So for example, we might have a range [0, +INF(OVF)] and conclude the range fits in an unsigned type. This in tur

Re: [Patch,Testsuite] Fix failure in gcc.dg/tree-ssa/forwprop-26.c

2013-05-03 Thread Jeff Law
On 05/03/2013 01:13 PM, Greta Yorsh wrote: This is a new test that fails on arm and probably other targets that have short enums by default: FAIL: gcc.dg/tree-ssa/forwprop-26.c (test for excess errors) Excess errors: /src/gcc/gcc/testsuite/gcc.dg/tree-ssa/forwprop-26.c:13:22: error: width of 'co

C++/v3 PATCH to add/throw std::bad_array_new_length

2013-05-03 Thread Jason Merrill
Last year Florian fixed the compiler to detect overflow in array new size calculations and pass (size_t)-1 in that case. But C++11 specifies that in case of overflow the program throws std::bad_array_new_length (http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#624), so I've adjuste

Re: [PATCH, i386]: Merge *vec_concatv2si_sse2 with vec_concatv2si_sse and vec_concatv2di with *vec_concatv2di_rex64.

2013-05-03 Thread H.J. Lu
On Fri, May 3, 2013 at 12:21 PM, Dominique Dhumieres wrote: >> Can you please commit the fixup patch, I am away from my keyboard today. > > Sorry, I don't have write access. > > Dominique I checked it in for you. Thanks. -- H.J.

Re: [build, driver] RFC: Support compressed debug sections

2013-05-03 Thread Joseph S. Myers
On Tue, 30 Apr 2013, Rainer Orth wrote: > * gcc.c (LINK_COMPRESS_DEBUG_SPEC, ASM_COMPRESS_DEBUG_SPEC): > Define. > (LINK_COMMAND_SPEC): Invoke LINK_COMPRESS_DEBUG_SPEC. > (asm_options): Invoke ASM_COMPRESS_DEBUG_SPEC. Note that there are separate copies of LINK_COMMAND_SPE

Re: [PATCH, i386]: Merge *vec_concatv2si_sse2 with vec_concatv2si_sse and vec_concatv2di with *vec_concatv2di_rex64.

2013-05-03 Thread Dominique Dhumieres
> Can you please commit the fixup patch, I am away from my keyboard today. Sorry, I don't have write access. Dominique

Re: [PATCH, i386]: Merge *vec_concatv2si_sse2 with vec_concatv2si_sse and vec_concatv2di with *vec_concatv2di_rex64.

2013-05-03 Thread Uros Bizjak
On Fri, May 3, 2013 at 7:44 PM, Dominique Dhumieres wrote: > I think the '\\' should be removed from > > /* { dg-final { scan-assembler-times "\\vec_concatv2di/3" 1 } } */ Oh, indeed. They were used to escape "*" and are useless now. For some reason, the regtest didn't failed for me... Can you

[Patch,Testsuite] Fix failure in gcc.dg/tree-ssa/forwprop-26.c

2013-05-03 Thread Greta Yorsh
This is a new test that fails on arm and probably other targets that have short enums by default: FAIL: gcc.dg/tree-ssa/forwprop-26.c (test for excess errors) Excess errors: /src/gcc/gcc/testsuite/gcc.dg/tree-ssa/forwprop-26.c:13:22: error: width of 'code' exceeds its type gcc.dg/tree-ssa/forwprop

Re: [PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-03 Thread Xinliang David Li
Please do what Richard suggested. gcov_info_type can be obtained from gcov_info_var decl. David On Fri, May 3, 2013 at 11:31 AM, Carrot Wei wrote: > On Fri, May 3, 2013 at 1:03 AM, Richard Biener > wrote: >> On Thu, May 2, 2013 at 10:41 PM, Carrot Wei wrote: >>> This patch outline the constru

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Jeff Law
On 05/03/2013 12:35 PM, Teresa Johnson wrote: Here is the patch with the new test case. Tested using dejagnu with and without my fix for PR57154 to confirm that it exposes the failure and works with the patch. Ok for trunk? Thanks, Teresa 2013-05-03 Teresa Johnson PR bootstrap/57154 * gcc.

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Teresa Johnson
Here is the patch with the new test case. Tested using dejagnu with and without my fix for PR57154 to confirm that it exposes the failure and works with the patch. Ok for trunk? Thanks, Teresa 2013-05-03 Teresa Johnson PR bootstrap/57154 * gcc.dg/pr57154.c: New test. Index: gcc.dg/pr57154.c

Re: [PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-03 Thread Carrot Wei
On Fri, May 3, 2013 at 1:03 AM, Richard Biener wrote: > On Thu, May 2, 2013 at 10:41 PM, Carrot Wei wrote: >> This patch outline the construction of gcov constructor from >> coverage_obj_init >> as a separate function build_init_ctor. >> >> It passed bootstrap and regression test on x86-64. >> >

Re: [PATCH, i386]: Merge *vec_concatv2si_sse2 with vec_concatv2si_sse and vec_concatv2di with *vec_concatv2di_rex64.

2013-05-03 Thread Dominique Dhumieres
Uros, I think the '\\' should be removed from /* { dg-final { scan-assembler-times "\\vec_concatv2di/3" 1 } } */ TIA Dominique

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Teresa Johnson
On Fri, May 3, 2013 at 10:28 AM, David Edelsohn wrote: > On Fri, May 3, 2013 at 1:26 PM, Jeff Law wrote: >> On 05/03/2013 11:15 AM, Teresa Johnson wrote: >>> >>> On Fri, May 3, 2013 at 9:37 AM, David Edelsohn wrote: Thanks for the patch. Bootstrap works on x86 and Anton's tes

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread David Edelsohn
On Fri, May 3, 2013 at 1:26 PM, Jeff Law wrote: > On 05/03/2013 11:15 AM, Teresa Johnson wrote: >> >> On Fri, May 3, 2013 at 9:37 AM, David Edelsohn wrote: >>> >>> Thanks for the patch. >>> >>> Bootstrap works on x86 and Anton's testcase works on x86. >>> >>> Is there any testcase for x86 that wo

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Jeff Law
On 05/03/2013 11:15 AM, Teresa Johnson wrote: On Fri, May 3, 2013 at 9:37 AM, David Edelsohn wrote: Thanks for the patch. Bootstrap works on x86 and Anton's testcase works on x86. Is there any testcase for x86 that would demonstrate the failure or that could check the probabilities in a dump

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Teresa Johnson
On Fri, May 3, 2013 at 9:37 AM, David Edelsohn wrote: > Thanks for the patch. > > Bootstrap works on x86 and Anton's testcase works on x86. > > Is there any testcase for x86 that would demonstrate the failure or > that could check the probabilities in a dump file and see the > inconsistency? Patc

Re: [PATCH] Improve simplify_subreg

2013-05-03 Thread Jakub Jelinek
On Thu, May 02, 2013 at 06:53:31PM +0100, Richard Sandiford wrote: > Jakub Jelinek writes: > > When working on PR57130, I've wondered why we don't simplify it much earlier > > and end up with creating such weirdness. > > > > The following patch fixes that, by using nonzero_bits to see if all the l

[PATCH] Fix array sizes created by Java FE (PR libgcj/57074)

2013-05-03 Thread Jakub Jelinek
Hi! As discovered by Alan Modra, the GCJ FE sometimes emits VAR_DECLs that have smaller DECL_SIZE (and TYPE_SIZE (TREE_TYPE ())) than the size of their initializers. I went through all build_constructor calls in the java FE and it seems only these two spots are problematic, they keep using arrays

Re: [PATCH] Fix tree-optimization/57144

2013-05-03 Thread Jeff Law
On 05/03/2013 10:44 AM, H.J. Lu wrote: On Fri, May 3, 2013 at 9:36 AM, Jeff Law wrote: Only change is in the new test which incorporates Jakub's comments. Installed onto the trunk. commit e30e5a25cb9b1888b48531d87573a833515a1e4b Author: Jeff Law Date: Thu May 2 22:19:37 2013 -0600

Re: [PATCH] Fix tree-optimization/57144

2013-05-03 Thread H.J. Lu
On Fri, May 3, 2013 at 9:36 AM, Jeff Law wrote: > > Only change is in the new test which incorporates Jakub's comments. > Installed onto the trunk. > > > commit e30e5a25cb9b1888b48531d87573a833515a1e4b > Author: Jeff Law > Date: Thu May 2 22:19:37 2013 -0600 > > PR tree-optimization/574

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Jeff Law
On 05/03/2013 10:23 AM, Teresa Johnson wrote: This patch fixes PR bootstrap/57154. Bootstrapped on powerpc64-linux to ensure it fixes the bootstrap problem reported for that architecture, and also the test case attached to the bug report. Also bootstrapped and regtested on x86_64-unknown-linux-

Re: [PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread David Edelsohn
Thanks for the patch. Bootstrap works on x86 and Anton's testcase works on x86. Is there any testcase for x86 that would demonstrate the failure or that could check the probabilities in a dump file and see the inconsistency? Thanks, David

[PATCH] Fix tree-optimization/57144

2013-05-03 Thread Jeff Law
Only change is in the new test which incorporates Jakub's comments. Installed onto the trunk. commit e30e5a25cb9b1888b48531d87573a833515a1e4b Author: Jeff Law Date: Thu May 2 22:19:37 2013 -0600 PR tree-optimization/57411 * tree-vrp.c (simplify_cond_using_ranges): Verify th

[PATCH] Fix PR bootstrap/57154 (issue9179043)

2013-05-03 Thread Teresa Johnson
This patch fixes PR bootstrap/57154. Bootstrapped on powerpc64-linux to ensure it fixes the bootstrap problem reported for that architecture, and also the test case attached to the bug report. Also bootstrapped and regtested on x86_64-unknown-linux-gnu. Ok for trunk? Thanks, Teresa 2013-05-03

Re: [patch, mips] Allow users to avoid promoting prototypes.

2013-05-03 Thread Steve Ellcey
On Thu, 2013-05-02 at 23:26 +0100, Richard Sandiford wrote: > > > > 2013-05-02 Steve Ellcey > > > > * config/mips/mips.c (mips_promote_prototypes) :New. > > (TARGET_PROMOTE_PROTOTYPES): Change to use mips_promote_prototypes. > > * config/mips/mips.opt (mpromote-prototypes): New. >

Re: RFA: Allow simplification of SUBREGs involving the frame pointer during LRA

2013-05-03 Thread Jeff Law
On 05/03/2013 09:01 AM, Nick Clifton wrote: Hi Guys, I would like to apply the patch below to allow simplify_subreg_regno() to treat the frame pointer register in the same way as the stack pointer register when the LRA pass is running. I found that I needed this whilst trying to ena

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
Richi, I also think that it is a digression to have this discussion about rtl.The root problem is really that Mike, Richard, and myself do not believe that infinite precision math is the proper way to do math for the majority of the compiler. Most of the compiler, at both the rtl and tr

Re: [RFA][PATCH] Fix tree-optimization/57144

2013-05-03 Thread Jeff Law
On 05/02/2013 11:56 PM, Jakub Jelinek wrote: On Thu, May 02, 2013 at 10:30:57PM -0600, Jeff Law wrote: --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/pr57144.c @@ -0,0 +1,15 @@ +__attribute__ ((noinline)) +foo(int a) +{ + int z = a > 0 ? a : -a; + long x = z; + if (x > 0x1) +

RFA: Allow simplification of SUBREGs involving the frame pointer during LRA

2013-05-03 Thread Nick Clifton
Hi Guys, I would like to apply the patch below to allow simplify_subreg_regno() to treat the frame pointer register in the same way as the stack pointer register when the LRA pass is running. I found that I needed this whilst trying to enable LRA for the RX and RL78 targets. (LRA is st

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
On 05/03/2013 09:02 AM, Richard Biener wrote: On Fri, May 3, 2013 at 2:45 PM, Kenneth Zadeck wrote: On 05/03/2013 07:19 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 5:29 PM, Richard Sandiford wrote: Richard Biener writes: On Wed, Apr 24, 2013 at 4:35 PM, Kenneth Zadeck wrote: On 04/

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
On 05/03/2013 08:53 AM, Richard Biener wrote: On Fri, May 3, 2013 at 2:37 PM, Richard Sandiford wrote: Richard Biener writes: See e.g. the hoops that cselib has to jump through: /* We need to pass down the mode of constants through the hash table functions. For that purpose, wrap them i

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
On 05/03/2013 08:40 AM, Richard Biener wrote: On Fri, May 3, 2013 at 2:31 PM, Kenneth Zadeck wrote: On 05/03/2013 08:12 AM, Richard Biener wrote: On Fri, May 3, 2013 at 1:49 PM, Kenneth Zadeck wrote: On 05/03/2013 07:34 AM, Richard Biener wrote: On Thu, Apr 25, 2013 at 1:18 AM, Kenneth Zade

[PATCH, i386]: Fix PR 57106, -fcompare-debug failure with -O2 -fschedule-insns -funroll-all-loops

2013-05-03 Thread Uros Bizjak
Hello! Apparently, the wrong insn is used when adding insn dependencies. The "last" index gets updated to the found !NONDEBUG_INSN. Use "first_arg" that points to the right insn instead. 2013-05-03 Uros Bizjak PR target/57106 * config/i386/i386.c (add_parameter_dependencies): Add depe

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Sandiford
Richard Biener writes: >> But storing the mode in the rtx is orthogonal to what Kenny is doing. >> The mode of each rtx constant is already available in the places >> that Kenny is changing, because we already do the work to keep track >> of the mode separately. Being able to get the mode directl

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Sandiford
Richard Biener writes: >> 5) All const_ints in the .md files would need to be given a mode >>(except for those places where const_int actually represents >>a C++ constant, such as in attributes). >> >> I realise your list wasn't supposed to be exhaustive, and neither's mine :-) > > Now, do

Re: [PATCH] Fold VEC_[LR]SHIFT_EXPR (PR tree-optimization/57051)

2013-05-03 Thread Jakub Jelinek
On Thu, Apr 25, 2013 at 11:47:02PM +0200, Jakub Jelinek wrote: > This patch adds folding of constant arguments v>> and v<<, which helps to > optimize the testcase from the PR back into constant store after vectorized > loop is unrolled. As this fixes a regression on the 4.8 branch, I've backported

[PATCH] Fix latent bug in RTL GCSE/PRE (PR57159)

2013-05-03 Thread Julian Brown
Hi, This is a patch which fixes a latent bug in RTL GCSE/PRE, described more fully in: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57159 I haven't been able to reproduce the problem on mainline (nor on a supported target). Maybe someone more familiar with the code in question than I am can tell

Re: [PATCH] Fix PR57147, fix edge removal code

2013-05-03 Thread Richard Biener
On Fri, 3 May 2013, Richard Biener wrote: > > The following fixes a bug in gimple_purge_dead_abnormal_call_edges > which happily removes a EDGE_FALLTHRU|EDGE_ABNORMAL edge. > The CFG builder via make_edge generally seems to merge edge flags > and edges for edges between the same basic-blocks, so

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 2:48 PM, Richard Sandiford wrote: > Kenneth Zadeck writes: >> There are several problems with just dropping a mode into the already >> existing mode field of an rtx constant. >> 1) There may be places where the a back end is testing equality to see >> if constants of differ

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 2:45 PM, Kenneth Zadeck wrote: > On 05/03/2013 07:19 AM, Richard Biener wrote: >> >> On Wed, Apr 24, 2013 at 5:29 PM, Richard Sandiford >> wrote: >>> >>> Richard Biener writes: On Wed, Apr 24, 2013 at 4:35 PM, Kenneth Zadeck wrote: > > On 04/24/2013

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 2:37 PM, Richard Sandiford wrote: > Richard Biener writes: >>> See e.g. the hoops that cselib has to jump through: >>> >>> /* We need to pass down the mode of constants through the hash table >>>functions. For that purpose, wrap them in a CONST of the appropriate >>>

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Sandiford
Kenneth Zadeck writes: > There are several problems with just dropping a mode into the already > existing mode field of an rtx constant. > 1) There may be places where the a back end is testing equality to see > if constants of different modes are in fact the same value. > 2) Most of the places

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
On 05/03/2013 07:19 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 5:29 PM, Richard Sandiford wrote: Richard Biener writes: On Wed, Apr 24, 2013 at 4:35 PM, Kenneth Zadeck wrote: On 04/24/2013 09:36 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 2:44 PM, Richard Sandiford wrote: Ri

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 2:31 PM, Kenneth Zadeck wrote: > On 05/03/2013 08:12 AM, Richard Biener wrote: >> >> On Fri, May 3, 2013 at 1:49 PM, Kenneth Zadeck >> wrote: >>> >>> On 05/03/2013 07:34 AM, Richard Biener wrote: On Thu, Apr 25, 2013 at 1:18 AM, Kenneth Zadeck wrote: > >

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Sandiford
Richard Biener writes: >> See e.g. the hoops that cselib has to jump through: >> >> /* We need to pass down the mode of constants through the hash table >>functions. For that purpose, wrap them in a CONST of the appropriate >>mode. */ >> static rtx >> wrap_constant (enum machine_mode mod

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
On 05/03/2013 08:12 AM, Richard Biener wrote: On Fri, May 3, 2013 at 1:49 PM, Kenneth Zadeck wrote: On 05/03/2013 07:34 AM, Richard Biener wrote: On Thu, Apr 25, 2013 at 1:18 AM, Kenneth Zadeck wrote: On 04/24/2013 11:13 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 5:00 PM, Richard San

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 1:49 PM, Kenneth Zadeck wrote: > On 05/03/2013 07:34 AM, Richard Biener wrote: >> >> On Thu, Apr 25, 2013 at 1:18 AM, Kenneth Zadeck >> wrote: >>> >>> On 04/24/2013 11:13 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 5:00 PM, Richard Sandiford wrote: >>

[PATCH, i386]: Merge *vec_concatv2si_sse2 with vec_concatv2si_sse and vec_concatv2di with *vec_concatv2di_rex64.

2013-05-03 Thread Uros Bizjak
Hello! 2013-05-03 Uros Bizjak * config/i386/i386.md (isa): Add x64_sse4_noavx and x64_avx members. (enabled): Handle new members. * config/i386/sse.md (*vec_concatv2si): Merge from *vec_concatv2si_sse2 and vec_concatv2si_sse. (vec_concatv2di): Merge with *vec_concatv2di_rex

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Kenneth Zadeck
On 05/03/2013 07:34 AM, Richard Biener wrote: On Thu, Apr 25, 2013 at 1:18 AM, Kenneth Zadeck wrote: On 04/24/2013 11:13 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 5:00 PM, Richard Sandiford wrote: Richard Biener writes: On Wed, Apr 24, 2013 at 4:29 PM, Richard Sandiford wrote:

Ping: RFA: replace MD_REDIRECT_BRANCH with TARGET_CAN_FOLLOW_JUMP

2013-05-03 Thread Joern Rennecke
This patch hasn't been reviewed yet: http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01332.html

RFA: fix find_valid_class to accept classes w/out last hard reg

2013-05-03 Thread Joern Rennecke
In revision 91802, the tests in find_valid_class got garbled so that with n > 0, it won't accept a class that does not include FIRST_PSEUDO_REGISTER - 1. The attached patch restores the status quo ante of allowing register classes that stop earlier. This fixes the compile/pr55921.c failures f

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Thu, Apr 25, 2013 at 1:18 AM, Kenneth Zadeck wrote: > On 04/24/2013 11:13 AM, Richard Biener wrote: >> >> On Wed, Apr 24, 2013 at 5:00 PM, Richard Sandiford >> wrote: >>> >>> Richard Biener writes: On Wed, Apr 24, 2013 at 4:29 PM, Richard Sandiford wrote: > > In othe

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Wed, Apr 24, 2013 at 5:55 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Wed, Apr 24, 2013 at 5:00 PM, Richard Sandiford >> wrote: >>> Richard Biener writes: On Wed, Apr 24, 2013 at 4:29 PM, Richard Sandiford wrote: > In other words, one of the reasons wide_int ca

Committed: fix PR tree-optimization/57027

2013-05-03 Thread Joern Rennecke
Bootstrapped & regtested on i686-pc-linux-gnu. Committed, as reviewed by Richard Biener: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57027 and also arguably obvious. 2013-05-03 Joern Rennecke PR tree-optimization/57027 * tree-ssa-math-opts.c (convert_mult_to_fma): When checking

Re: patch to fix constant math -5th patch, rtl

2013-05-03 Thread Richard Biener
On Wed, Apr 24, 2013 at 5:29 PM, Richard Sandiford wrote: > Richard Biener writes: >> On Wed, Apr 24, 2013 at 4:35 PM, Kenneth Zadeck >> wrote: >>> On 04/24/2013 09:36 AM, Richard Biener wrote: On Wed, Apr 24, 2013 at 2:44 PM, Richard Sandiford wrote: > > Richard Biener

[PATCH] Speedup get_ref_base_and_extent (double-int)

2013-05-03 Thread Richard Biener
This speeds up get_ref_base_and_extent by not using the expensive alshift routine to convert from bytes to bits but a new lshift overload that works on the whole double-int and only handles positive shift counts (no extension necessary). The issue with shifts of course is that we allow negative s

[Patch, Fortran] PR57141 - fix using use-associated NULL() intrinsic

2013-05-03 Thread Tobias Burnus
The problem is that the procedure attributed is tried to be set to NULL() - but that's rejected because null() is use associated. I am not sure whether this is the cleanest patch, but I think it should be fine. Build and regtested on x86-64-gnu-linux. OK for the turnk? PENDING PATCHES: - http:

Re: [AArch64] Fix the description of simd_fabd

2013-05-03 Thread Marcus Shawcroft
OK and committed. Thankyou. /Marcus On 2 May 2013 19:21, Vidya Praveen wrote: > Hello, > > This attached patch corrects the description for simd_fabd. > > OK? > > Regards > VP > > > gcc/ChangeLog > > 2013-05-02 Vidya Praveen > > * config/aarch64/aarch64-simd.md (simd_fabd): Correct t

Re: [AArch64] Support scalar form of FABD

2013-05-03 Thread Marcus Shawcroft
OK and committed. Thankyou. /Marcus On 2 May 2013 19:04, Vidya Praveen wrote: > Hello, > > This attached patch adds support to the scalar form of FABD > instruction along with the compile & execute tests for the same. > > Regression tested on aarch64-none-elf with no issues. > > OK? > > Regards

[PATCH] Fix PR57147, fix edge removal code

2013-05-03 Thread Richard Biener
The following fixes a bug in gimple_purge_dead_abnormal_call_edges which happily removes a EDGE_FALLTHRU|EDGE_ABNORMAL edge. The CFG builder via make_edge generally seems to merge edge flags and edges for edges between the same basic-blocks, so any abnormal call edges we insert may shadow the edge

Re: [PATCH] Fix up make_compound_operation (PR rtl-optimization/57130)

2013-05-03 Thread Eric Botcazou
> Does it hurt to punt on nested SUBREG (it isn't really punting, just passing > SET instead of COMPARE, which means avoiding the and with power of two and > some make_extraction details), when usually the nested subregs should be > already simplified and thus the reason I want it there is just to

[C++ testcase, committed] PR 54318

2013-05-03 Thread Paolo Carlini
Hi, committed to mainline. Thanks, Paolo. /// 2013-05-03 Paolo Carlini PR c++/54318 * g++.dg/cpp0x/pr54318.C: New. Index: g++.dg/cpp0x/pr54318.C === --- g++.dg/cpp0x/pr54318.C (revision 0) +

Re: [PATCH] Fix up make_compound_operation (PR rtl-optimization/57130)

2013-05-03 Thread Jakub Jelinek
On Fri, May 03, 2013 at 10:13:17AM +0200, Eric Botcazou wrote: > > My understanding is that in_code == COMPARE (as opposed to > > in_code == SET) is mostly harmless, just tells make_extraction > > to no longer special case zero extraction at position 0, but there is one > > exception - AND with con

Re: [PATCH] Fix up make_compound_operation (PR rtl-optimization/57130)

2013-05-03 Thread Eric Botcazou
> My understanding is that in_code == COMPARE (as opposed to > in_code == SET) is mostly harmless, just tells make_extraction > to no longer special case zero extraction at position 0, but there is one > exception - AND with constant power of two CONST_INT. > If we have > make_compound_operation (

Re: [RFA][PATCH] Fix tree-optimization/57144

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 6:30 AM, Jeff Law wrote: > > When we have > > x = (T) y; > if (x > CONST) > true arm > else > false arm > > Assume CONST is larger than what can be represented in T. If we use > fold_convert, any bits not not in T will be dropped. So if CONST is say > 0x1 and T

Re: [patch, mips] Allow users to avoid promoting prototypes.

2013-05-03 Thread Richard Biener
On Fri, May 3, 2013 at 12:26 AM, Richard Sandiford wrote: > "Steve Ellcey " writes: >> MIPS architectures set TARGET_PROMOTE_PROTOTYPES to true. I would like >> to have an option to set this to false in order to avoid extra masking >> when passing char or short types. I don't think we can chang

Re: [PATCH] Refactor coverage.c, outline the construction of gcov constructor

2013-05-03 Thread Richard Biener
On Thu, May 2, 2013 at 10:41 PM, Carrot Wei wrote: > This patch outline the construction of gcov constructor from coverage_obj_init > as a separate function build_init_ctor. > > It passed bootstrap and regression test on x86-64. > > OK for trunk and google 4.7 branch? Please pass gcov_info_type a

Re: [PATCH, AArch64] Testcases for TST instruction

2013-05-03 Thread Marcus Shawcroft
OK /Marcus On 2 May 2013 15:56, Ian Bolton wrote: > I previously fixed a bug with the patterns that generate TST. > > I added these testcases to make our regression testing more solid. > > They've been running on our internal branch for about a month. > > OK to commit to trunk? > > Cheers, > Ian

Re: [PING] SLSR for conditional candidates

2013-05-03 Thread Richard Biener
On Thu, 2 May 2013, Bill Schmidt wrote: > On Thu, 2013-05-02 at 13:29 +0200, Richard Biener wrote: > > On Mon, 29 Apr 2013, Bill Schmidt wrote: > > > > > Half-hearted ping for > > > http://gcc.gnu.org/ml/gcc-patches/2013-03/msg01291.html ... > > > > > > I promise this is the last major code dump