[PATCH] Fix loop pattern distribution ICE (PR tree-optimization/54321)

2012-08-19 Thread Jakub Jelinek
Hi! The middle-end argument of memset is signed (int), so simplify_builtin_call correctly checks host_integerp (val2, 0), but later on used tree_low_cst (val2, 1), so for negative values it would ICE. Fixed thusly, the memset is supposed to cast the int to unsigned char internally anyway. Bootst

Re: [Patch, Fortran] PR54301 - add warning for pointer might outlive its target

2012-08-19 Thread Tobias Burnus
Am 19.08.2012 23:59, schrieb Thomas Koenig: OK for trunk then. You'll find your patch no longer applies cleanly, because I have changed the same spot(s) in invoke.texi and gfortran.h with my recent commit, but I think you'll manage :-) Thanks for the review. I committed the re-diffed patch as

Re: [PATCH] Add working-set size and hotness information to fdo summary (issue6465057)

2012-08-19 Thread Xinliang David Li
On Sun, Aug 19, 2012 at 9:59 PM, Teresa Johnson wrote: > On Sat, Aug 18, 2012 at 1:19 AM, Jan Hubicka wrote: >> >> > +{ >> > + cs_prg->num = cs_tprg->num; >> > + /* Allocate the working set array for the merged >> > summary. */ >> > +

Re: [PATCH] Add working-set size and hotness information to fdo summary (issue6465057)

2012-08-19 Thread Teresa Johnson
On Sat, Aug 18, 2012 at 1:19 AM, Jan Hubicka wrote: > > > +{ > > + cs_prg->num = cs_tprg->num; > > + /* Allocate the working set array for the merged > > summary. */ > > + if (ws_cnt) > > +{ > > +

Re: [PATCH] Fix PR 52631 (VN does not use simplified expression for lookup)

2012-08-19 Thread Andrew Pinski
On Wed, Jul 25, 2012 at 4:39 AM, Richard Guenther wrote: > On Tue, Jul 24, 2012 at 5:50 PM, Andrew Pinski > wrote: >> Hi, >> Before tuples was introduced, VN used to lookup the simplified >> expression to see if it was available already and use that instead of >> the non simplified one. This p

Re: enlarge hot allocation pools

2012-08-19 Thread Dimitrios Apostolou
Hi Steven, On Sun, 19 Aug 2012, Steven Bosscher wrote: On Sun, Aug 19, 2012 at 8:31 PM, Dimitrios Apostolou wrote: Hello, 2012-08-19 Dimitrios Apostolou * gcc/cselib.c (cselib_init): Make allocation pools larger since they are too hot and show to expand often on the profil

Re: [PATCH] Combine location with block using block_locations

2012-08-19 Thread Dehao Chen
ping Thanks, Dehao On Tue, Aug 14, 2012 at 10:13 AM, Dehao Chen wrote: > Hi, Dodji, > > Thanks for the review. I've fixed all the addressed issues. I'm > attaching the related changes: > > Thanks, > Dehao > > libcpp/ChangeLog: > 2012-08-01 Dehao Chen > > * include/line-map.h (MAX_

Re: [wwwdocs] SH 4.8 changes update

2012-08-19 Thread Oleg Endo
On Sun, 2012-08-19 at 21:43 +0200, Gerald Pfeifer wrote: > On Sun, 19 Aug 2012, Oleg Endo wrote: > > Thanks. Let's hope that I can squeeze in some more stuff while > > stage 1 lasts. :T > > You know that for backend-specific changes (especially for "smaller" > ports) you actually have some more l

Re: [PATCH][3/n] into-SSA TLC

2012-08-19 Thread H.J. Lu
On Fri, Jul 27, 2012 at 5:16 AM, Richard Guenther wrote: > > This tries to more clearly separate per-SSA name held information > from per-DECL held information during update-ssa. We already have > a global array of SSA name informations so it is pointless to > have a hashtable mapping SSA names t

[SH] PR 54089 - Add support for rotcr insn

2012-08-19 Thread Oleg Endo
Hello, This adds support for SH's rotcr insn. Tested on rev 190459 with make -k check RUNTESTFLAGS="--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}" and no new failures. OK? Cheers, Oleg ChangeLog: PR target/50489 * config/sh/sh.md (rotcr, *r

[SH] PR 51244 - Use more zero displacement branches

2012-08-19 Thread Oleg Endo
Hello, This adds two new patterns to undo an optimization that is done by ifcvt and is not beneficial if zero displacement branches are available on SH. Tested on rev 190459 with make -k check RUNTESTFLAGS="--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}" and n

Re: [Patch, Fortran] PR54301 - add warning for pointer might outlive its target

2012-08-19 Thread Thomas Koenig
Hi Tobias, Am 19.08.2012 21:19, schrieb Thomas Koenig: Build and regtested on x86-64-gnu-linux. OK for the trunk? I would exclude pointers on the lhs of the pointer assignment, I assume you mean RHS – excluding LHS pointers in pointer assignments is kind of difficult ;-) Sometimes I have

Re: enlarge hot allocation pools

2012-08-19 Thread Steven Bosscher
On Sun, Aug 19, 2012 at 8:31 PM, Dimitrios Apostolou wrote: > Hello, > > 2012-08-19 Dimitrios Apostolou > > * gcc/cselib.c (cselib_init): Make allocation pools larger since > they are too hot and show to expand often on the profiler. > * gcc/df-problems.c (df_chain_alloc

Re: [wwwdocs] SH 4.8 changes update

2012-08-19 Thread Gerald Pfeifer
On Sun, 19 Aug 2012, Oleg Endo wrote: > Thanks. Let's hope that I can squeeze in some more stuff while > stage 1 lasts. :T You know that for backend-specific changes (especially for "smaller" ports) you actually have some more leeway? > But now that you mention it, maybe it would be better to re

Re: [Patch, Fortran] PR54301 - add warning for pointer might outlive its target

2012-08-19 Thread Tobias Burnus
Am 19.08.2012 21:19, schrieb Thomas Koenig: Build and regtested on x86-64-gnu-linux. OK for the trunk? I would exclude pointers on the lhs of the pointer assignment, I assume you mean RHS – excluding LHS pointers in pointer assignments is kind of difficult ;-) RHS pointers are excluded via

Re: [Patch, Fortran] PR54301 - add warning for pointer might outlive its target

2012-08-19 Thread Thomas Koenig
Hi Tobias, Build and regtested on x86-64-gnu-linux. OK for the trunk? I would exclude pointers on the lhs of the pointer assignment, to make sure that warnings for code such as program main integer :: i integer, pointer :: ip block integer, pointer :: jp allocate (jp) jp = 3

Re: [PATCH, Committed] Fix ChangeLog (was: [PATCH] Fix AVR fallout)

2012-08-19 Thread Jan-Benedict Glaw
On Sun, 2012-08-19 11:58:49 -0700, Ian Lance Taylor wrote: > On Sun, Aug 19, 2012 at 1:34 AM, Jan-Benedict Glaw wrote: > > I fixed ChangeLog's whitespace (probably cut'n'paste error), committed > > as obvious. > > > > 2012-08-19 Jan-Benedict Glaw > > > > * ChangeLog: Fix whitespace. >

Re: [PATCH, Committed] Fix ChangeLog (was: [PATCH] Fix AVR fallout)

2012-08-19 Thread Ian Lance Taylor
On Sun, Aug 19, 2012 at 1:34 AM, Jan-Benedict Glaw wrote: > I fixed ChangeLog's whitespace (probably cut'n'paste error), committed > as obvious. > > 2012-08-19 Jan-Benedict Glaw > > * ChangeLog: Fix whitespace. Note that fixes to the ChangeLog files do not themselves get ChangeLog ent

Re: [PATCH][RFC] Extend memset recognition

2012-08-19 Thread H.J. Lu
On Tue, Jun 5, 2012 at 2:21 AM, Richard Guenther wrote: > On Thu, 31 May 2012, Richard Guenther wrote: > >> On Wed, 30 May 2012, Richard Guenther wrote: >> >> > >> > The patch below extents memset recognition to cover a few more >> > non-byte-size store loops and all byte-size store loops. This e

Re: CXX conversion: min g++ version pre-requisite?

2012-08-19 Thread Gary Funck
I filed two bug reports: "GCC install document does not list minimum required g++ version" http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54324 "GCC does not build with G++ version 3.4.0" http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54326 Re: the latter bug report (54326), it might be further divide

enlarge hot allocation pools

2012-08-19 Thread Dimitrios Apostolou
Hello, 2012-08-19 Dimitrios Apostolou * gcc/cselib.c (cselib_init): Make allocation pools larger since they are too hot and show to expand often on the profiler. * gcc/df-problems.c (df_chain_alloc): Same. * gcc/et-forest.c (et_new_occ, et_new_tree): Same.

alloc_pool for tree-ssa-pre.c:phi_translate_table

2012-08-19 Thread Dimitrios Apostolou
2012-08-19 Dimitrios Apostolou * gcc/tree-ssa-pre.c (phi_translate_pool): New static global alloc_pool, used for allocating struct expr_pred_trans_d for phi_translate_table. (phi_trans_add, init_pre, fini_pre): Use it, avoids thousand of malloc() and f

obstack for equiv_class_label, more vectors on stack

2012-08-19 Thread Dimitrios Apostolou
2012-08-19 Dimitrios Apostolou * gcc/tree-ssa-structalias.c: Change declaration of ce_s type vector from heap to stack. Update all relevant functions to VEC_alloc() such vector upfront with enough (32) slots so that malloc() calls are mostly avoided.

Re: Inheritance of gfc_symbol / gfc_component

2012-08-19 Thread Tobias Schlüter
Hi Mikael, On 2012-08-19 19:57, Mikael Morin wrote: My main concern is this: the increased type safety by changing the (void*) -> (gfc_bbt*) change is balanced by the reduced type safety for all the types inherited from gfc_bbt as the left and right pointer have now gfc_bbt type instead of the

Re: [wwwdocs] SH 4.8 changes update

2012-08-19 Thread Oleg Endo
On Sun, 2012-08-19 at 19:20 +0200, Gerald Pfeifer wrote: > On Sun, 19 Aug 2012, Oleg Endo wrote: > > This is what has been done so far on the SH side for 4.8. > > I hope it's OK. > > Wow, that is quite impressive (and a nice write-up also)! Thanks. Let's hope that I can squeeze in some more stuf

Re: Inheritance of gfc_symbol / gfc_component

2012-08-19 Thread Mikael Morin
On 18/08/2012 19:25, Tobias Schlüter wrote: >>> I thought I could work around this problem without introducing a >>> constructor by: >>> 1) using 0 instead of -1 as value for this fake label (which is also >>> not a valid value for a label, so it can't collide >>> 2) setting ST_LABEL_FORMAT = 0

Re: [Fortran] PR37336 - FIINAL patch [1/n]: Implement the finalization wrapper subroutine

2012-08-19 Thread Tobias Burnus
Dear all, attached is a slightly updated patch: * Call finalizers of nonallocatable, nonpointer components * Generate FINAL wrapper for abstract types which have a finalizer. (The allocatable components are deallocated in the first type (abstract or not) which has a finalizer, i.e. abstract +

Re: [PING][PATCH,dejagnu] Allow dg-skip-if to use compiler flags specified through set_board_info cflags

2012-08-19 Thread Senthil Kumar Selvaraj
Hello On Sat, Aug 11, 2012 at 11:09:03PM +0530, Senthil Kumar Selvaraj wrote: > This patch allows cflags set in board config files using > "set_board_info cflags" to be used in the selectors of > dg-skip-if and other dejagnu commands that use the check-flags > proc. > > The code merely adds cfla

Re: Commit: BFIN: Fix use of VEC_last macro in bfin.c

2012-08-19 Thread Gerald Pfeifer
On Fri, 17 Aug 2012, Diego Novillo wrote: > Thanks. We need a much better mechanism for documenting and advertising > the stuff in contrib/. I see that contrib/ does not even have a README file. How about starting one with your contributions at least (and of course what- ever else you'd like to

Re: [PATCH, MIPS] add new peephole for 74k dspr2

2012-08-19 Thread Richard Sandiford
Sandra Loosemore writes: > This patch adds a peephole optimization to use a clever trick to > zero-initialize the two halves of an accumulator register with one > instruction instead of a mtlo/mthi pair. OK to check in? > > -Sandra > > 2012-08-16 Sandra Loosemore > Julian Brown >

Re: [wwwdocs] SH 4.8 changes update

2012-08-19 Thread Gerald Pfeifer
On Sun, 19 Aug 2012, Oleg Endo wrote: > This is what has been done so far on the SH side for 4.8. > I hope it's OK. Wow, that is quite impressive (and a nice write-up also)! I see this was already approved, but allow me to suggest some minor editorial comments... Index: htdocs/gcc-4.8/changes.ht

Re: [PATCH/MIPS] Use ins/dins instruction when written manually

2012-08-19 Thread Richard Sandiford
Andrew Pinski writes: > Right now we only produce ins when a zero_extract is used on the > right hand side. We can do better by adding some patterns which > combine for the ins instruction. This patch adds those patterns and a > testcase which shows a simple example where the code is improved.

Re: [graphds.h] Allocate graph from obstack

2012-08-19 Thread Richard Guenther
On Sat, Aug 18, 2012 at 8:10 PM, Dimitrios Apostolou wrote: > Initially I had one obstack per struct graph, which was better than using > XNEW for every edge, but still obstack_init() called from new_graph() was > too frequent. > > So in this iteration of the patch the obstack is static global, in

[Patch, Fortran] PR54301 - add warning for pointer might outlive its target

2012-08-19 Thread Tobias Burnus
As suggested in the draft Fortran appendix to ISO/IEC Technical Report 24772 "Guidance for Avoiding Vulnerabilities through Language Selection and Use"* "Future standardization efforts should consider:" ... "* Requiring that processors have the ability to detect and report the occurrence within

[Ada] Avoid unnecessarily overaligned access types

2012-08-19 Thread Eric Botcazou
This changes the default alignment of all access types to that of access types with standard size (Standard'Address_Size) on non-strict-alignment platforms. This in particular means that access-to-unconstrained-array types, whose size is twice as large as that of regular access types, are not overa

[Ada] Fix temporary incorrectly-typed COMPONENT_REF

2012-08-19 Thread Eric Botcazou
We generate a temporary incorrectly-typed COMPONENT_REF in gigi when building a derived tagged type with discriminant. That's essentially harmless, but breaks the invariant that the type of the first operand of COMPONENT_REF is aggregate. Tested on x86_64-suse-linux, applied on the mainline.

Re: [patch, fortran] Warning for feal / complex equality / inequality comparisons

2012-08-19 Thread Tobias Burnus
Thomas Koenig wrote: the attached patch warns about comparisions for equality and inequality of real and complex values if -Wcompare-reals is given. The new compiler option is included in -Wall. Regression-tested, tested with "make info" and "make dvi". OK for trunk? Thanks for the patch. It's

Re: [bootstrap] Tentative fix for PR 54281

2012-08-19 Thread Arnaud Charlet
> The conditionals cannot be removed for the time being because the foreign > language interface of the Ada part of the compiler is hardcoded for C. > > Barring a massive switch to the Ada language for the GNU project, we would > need > to switch the foreign language interface to C++, which mi

[patch, fortran] Warning for feal / complex equality / inequality comparisons

2012-08-19 Thread Thomas Koenig
Hello world, the attached patch warns about comparisions for equality and inequality of real and complex values if -Wcompare-reals is given. The new compiler option is included in -Wall. Regression-tested, tested with "make info" and "make dvi". OK for trunk? Thomas 2012-08-19 Thomas

[committed] cp/Make-lang.in typo fix

2012-08-19 Thread Mikael Morin
Hello, this is outside my area of maintainership, but I thought it was obvious enough. Mikael Index: Make-lang.in === --- Make-lang.in (révision 190512) +++ Make-lang.in (révision 190513) @@ -337,7 +337,7 @@ cp/mangle.o: cp/mangl

Re: [bootstrap] Tentative fix for PR 54281

2012-08-19 Thread Eric Botcazou
[Sorry for the delay] > So, I had failed to include Ada in my testing and my patch breaks it. > In several ada/*.c files, we forcefully include system.h as a C header: > > #ifdef __cplusplus > extern "C" { > #endif > ... > #include "system.h" > ... > #ifdef __cplusplus > } > #endif > > > Eric,

[PATCH, Committed] Fix ChangeLog (was: [PATCH] Fix AVR fallout)

2012-08-19 Thread Jan-Benedict Glaw
On Sun, 2012-08-19 10:19:37 +0400, Denis Chertykov wrote: > 2012/8/18 Jan-Benedict Glaw : [...] > > gcc/Changelog: > > * config/avr/avr-log.c (avr_log_vadump): Properly use > > int-promoted enum values. > > * config/avr/avr.h (struct mcu_type_s): Change `arch' from > >