[PATCH] Fix ICE with asm goto and shrink wrapping (PR rtl-optimization/53589)

2012-06-06 Thread Jakub Jelinek
Hi! On the following testcase we ICE, because shrink-wrapping ends up calling force_nonfallthru_and_redirect on a BB that ends with asm goto that has some labels point to the fallthru block as well (i.e. asm goto ("..." : : : : lab); lab:;). The problem was that in that case the labels weren't ad

[committed] Fix OpenMP ICE with invalidly nested worksharing constructs (PR middle-end/53580)

2012-06-06 Thread Jakub Jelinek
Hi! omp-low.c isn't prepared to see invalidly nested worksharing etc., but diagnosed them just with a warning and let them go further. Fixed by making it an error (and nopping out the problematic constructs), bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. Backport sche

[google/4_6] New fdo summary-based icache sensitive unrolling (issue6298056)

2012-06-06 Thread Teresa Johnson
This is the google/4_6 version of the patch to add new program summary information to the gcov profile files to use as a estimate of code size for guiding unrolling. Bootstrapped and tested on x86_64-unknown-linux-gnu. Ok for google/4_6? Thanks, Teresa Index: doc/invoke.texi

[google/main] New fdo summary-based icache sensitive unrolling (issue6282045)

2012-06-06 Thread Teresa Johnson
Updated patch based on feedback. Original description: This patch adds new program summary information to the gcov profile files that indicate how many profiled counts compose the majority of the program's execution time. This is used to provide an indication of the overall code size of the progra

libgo patch RFA: Fix printing of names in stack dumps

2012-06-06 Thread Ian Lance Taylor
Go strings are not necessarily NUL terminated. The stack dump code was erroneously using %s to print the contents of a Go string. The runtime_printf function that it uses supports %S to print a Go string. This patch fixes the code to use %S. Without this a stack dump sometimes prints random junk

Re: Go patch committed: Fix unsafe.Sizeof for named structs

2012-06-06 Thread Ian Lance Taylor
Jakub Jelinek writes: > On Wed, Jun 06, 2012 at 10:49:56PM -0700, Ian Lance Taylor wrote: >> This patch to the Go frontend fixes an embarrassing and serious bug in >> which unsafe.Sizeof returns the wrong value for a named struct that >> has fields that are themselves named structs. Bootstrapped

[google/gcc-4_6] Fix to use correct form for DW_AT_low_pc in compile_unit DIE. (issue6298055)

2012-06-06 Thread Cary Coutant
This patch is for the google/gcc-4_6 branch. In porting the earlier patch to use constant forms for DW_AT_high_pc, the code in dwarf2out_finish was inadvertently changed to use an indirect form for DW_AT_low_pc in the main compile_unit DIE. This patch adds the force_direct parameter used in other

Re: Go patch committed: Fix unsafe.Sizeof for named structs

2012-06-06 Thread Jakub Jelinek
On Wed, Jun 06, 2012 at 10:49:56PM -0700, Ian Lance Taylor wrote: > This patch to the Go frontend fixes an embarrassing and serious bug in > which unsafe.Sizeof returns the wrong value for a named struct that > has fields that are themselves named structs. Bootstrapped and ran Go > testsuite on x8

Re: [patch] Deal with #ident without

2012-06-06 Thread Andreas Schwab
Steven Bosscher writes: > Index: doc/tm.texi > === > --- doc/tm.texi (revision 188182) > +++ doc/tm.texi (working copy) > @@ -5847,6 +5847,10 @@ value is 0. > @end deftypevr > > @deftypefn {Target Hook} void TARGET_AS

Go patch committed: Fix unsafe.Sizeof for named structs

2012-06-06 Thread Ian Lance Taylor
This patch to the Go frontend fixes an embarrassing and serious bug in which unsafe.Sizeof returns the wrong value for a named struct that has fields that are themselves named structs. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.7 branch. Ian diff

Re: [PATCH][C++] Fix PR52841

2012-06-06 Thread Fabien Chêne
2012/6/6 Jason Merrill : [...] > Often if we continue parsing something on the assumption that the previous > bits are correct it leads to problems; that's all there is to this bug. >  When we see > >  using sat::Solvable::bool_type; > > cp_parser_alias_declaration eats "sat" and then tries to pars

Re: [C++ Patch] for c++/51214

2012-06-06 Thread Fabien Chêne
2012/6/3 Fabien Chêne : > 2012/6/3 Jason Merrill : >> On 05/24/2012 09:18 AM, Jason Merrill wrote: >>> >>> OK, thanks. >> >> >> I notice you haven't checked the patch in yet, is there a problem? > > Not at all, just lack of time, so many problems/holidays to tackle at > the moment... That is May mo

ping*4: Fix gcc.dg/lower-subreg-1.c failure (was: [C Patch]: pr52543)

2012-06-06 Thread Hans-Peter Nilsson
> From: Hans-Peter Nilsson > Date: Wed, 30 May 2012 04:49:27 +0200 > > From: Hans-Peter Nilsson > > Date: Wed, 23 May 2012 06:41:58 +0200 > > > From: Hans-Peter Nilsson > > > Date: Wed, 16 May 2012 08:24:41 +0200 > > > > From: Hans-Peter Nilsson > > > > Date: Wed, 9 May 2012 08:02:25 +0200 > >

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-06 Thread Teresa Johnson
On Wed, Jun 6, 2012 at 3:09 PM, Xinliang David Li wrote: > On Wed, Jun 6, 2012 at 2:02 PM, Teresa Johnson wrote: >> On Tue, Jun 5, 2012 at 11:46 AM,   wrote: >>> >>> http://codereview.appspot.com/6282045/diff/1/gcc/gcov-io.h >>> File gcc/gcov-io.h (right): >>> >>> http://codereview.appspot.com/62

libgo patch committed: Fix TLS stack size problem again

2012-06-06 Thread Ian Lance Taylor
This patch to libgo fixes the TLS stack size problem again, this time using a documented interface. The problem, to repeat, is that glibc subtracts the TLS size out of the stack size when creating a thread with a specified stack size. That causes libgo to fail in a rather obscure manner when used

Re: [C++ Patch] Produce canonical names for debug info without changing normal pretty-printing (issue6215052)

2012-06-06 Thread Gabriel Dos Reis
On Wed, Jun 6, 2012 at 6:07 PM, Sterling Augustine wrote: > On Wed, Jun 6, 2012 at 3:49 PM, Steven Bosscher wrote: >> On Mon, Jun 4, 2012 at 7:53 PM, Sterling Augustine >> wrote: >>> On Fri, Jun 1, 2012 at 4:38 PM, Gabriel Dos Reis >>> wrote: On Fri, Jun 1, 2012 at 6:07 PM, Sterling August

ping: Reorganized documentation for warnings

2012-06-06 Thread David Stone
Ping for patch that reorganized warning documentation http://gcc.gnu.org/ml/gcc-patches/2012-05/msg02024.html

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-06 Thread Teresa Johnson
On Wed, Jun 6, 2012 at 3:12 PM, Jan Hubicka wrote: >> The patch looks like 4_7 based which can be different from 4_6 based >> one. Do you have the latter one for review? > > Hi, > the code determining where program spend most of time in more sane way than > current hot/cold decision logic is long

[google-4_6] fix issues of streaming lipo (issue6297057)

2012-06-06 Thread Rong Xu
Hi, This is for google-4_6 branch only. It fixed a few issues: (1) not passing pedantic flag from primary module to aux; (2) not using pipe to generate iro file even -pipe specified; (3) fix the case like -D"foo bar" option in auxiliary module. Tested google internal benchmarks. 2012-06-06 Ron

Re: [patch] Deal with #ident without

2012-06-06 Thread Michael Eager
On 06/06/2012 03:31 PM, Steven Bosscher wrote: On Thu, Jun 7, 2012 at 12:00 AM, Michael Eager wrote: This is the patch to deal with #ident. It removes the ASM_OUTPUT_IDENT and IDENT_ASM_OP target macros, and replaces them with a single target hook. For targets that treat front-end #idents differ

Re: [C++ Patch] Produce canonical names for debug info without changing normal pretty-printing (issue6215052)

2012-06-06 Thread Sterling Augustine
On Wed, Jun 6, 2012 at 3:49 PM, Steven Bosscher wrote: > On Mon, Jun 4, 2012 at 7:53 PM, Sterling Augustine > wrote: >> On Fri, Jun 1, 2012 at 4:38 PM, Gabriel Dos Reis >> wrote: >>> On Fri, Jun 1, 2012 at 6:07 PM, Sterling Augustine >>> wrote: After finding yet another bug in the previous

Re: [C++ Patch] Produce canonical names for debug info without changing normal pretty-printing (issue6215052)

2012-06-06 Thread Steven Bosscher
On Mon, Jun 4, 2012 at 7:53 PM, Sterling Augustine wrote: > On Fri, Jun 1, 2012 at 4:38 PM, Gabriel Dos Reis > wrote: >> On Fri, Jun 1, 2012 at 6:07 PM, Sterling Augustine >> wrote: >>> After finding yet another bug in the previous patch dealing with >>> pretty-printing >>> decls for dwarf in c

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Steven Bosscher
On Thu, Jun 7, 2012 at 12:00 AM, Michael Eager wrote: > Please eliminate the comment before microblaze_asm_output_ident(). Better yet, attach the right patch. I somehow managed to attach the wrong one. Re-submitted with proper $SUBJECT and all that. Sorry for the confusion! Ciao! Steven

[patch] Deal with #ident without

2012-06-06 Thread Steven Bosscher
On Thu, Jun 7, 2012 at 12:00 AM, Michael Eager wrote: This is the patch to deal with #ident. It removes the ASM_OUTPUT_IDENT and IDENT_ASM_OP target macros, and replaces them with a single target hook. For targets that treat front-end #idents different from the GCC version string .ident, the hooks

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-06 Thread Xinliang David Li
On Wed, Jun 6, 2012 at 2:02 PM, Teresa Johnson wrote: > On Tue, Jun 5, 2012 at 11:46 AM,   wrote: >> >> http://codereview.appspot.com/6282045/diff/1/gcc/gcov-io.h >> File gcc/gcov-io.h (right): >> >> http://codereview.appspot.com/6282045/diff/1/gcc/gcov-io.h#newcode544 >> gcc/gcov-io.h:544: gcov_u

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-06 Thread Jan Hubicka
> The patch looks like 4_7 based which can be different from 4_6 based > one. Do you have the latter one for review? Hi, the code determining where program spend most of time in more sane way than current hot/cold decision logic is long time on my TODO. My plan was to count number of gimple statme

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-06 Thread Xinliang David Li
On Wed, Jun 6, 2012 at 2:02 PM, Teresa Johnson wrote: > On Tue, Jun 5, 2012 at 11:46 AM,   wrote: >> >> http://codereview.appspot.com/6282045/diff/1/gcc/gcov-io.h >> File gcc/gcov-io.h (right): >> >> http://codereview.appspot.com/6282045/diff/1/gcc/gcov-io.h#newcode544 >> gcc/gcov-io.h:544: gcov_u

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Michael Eager
On 06/06/2012 02:22 PM, Steven Bosscher wrote: On Wed, Jun 6, 2012 at 10:45 AM, Richard Guenther wrote: Please split up the patch into one dealing with #ident exclusively and a followup with the other pieces. Hello, This is the patch to deal with #ident. It removes the ASM_OUTPUT_IDENT and

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-06 Thread Xinliang David Li
The patch looks like 4_7 based which can be different from 4_6 based one. Do you have the latter one for review? David On Wed, Jun 6, 2012 at 2:02 PM, Teresa Johnson wrote: > On Tue, Jun 5, 2012 at 11:46 AM,   wrote: >> >> http://codereview.appspot.com/6282045/diff/1/gcc/gcov-io.h >> File gcc/gc

[patch, fortran] Optimize assignment of empty strings

2012-06-06 Thread Thomas Koenig
Hello world, this rather simple patch makes sure that only memset is used for assigning empty strings when front-end optimization is used. Regression-tested. OK for trunk? Thomas 2012-06-06 Thomas König PR fortran/52861 * frontend-passes (empty_string): Add protot

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Steven Bosscher
On Wed, Jun 6, 2012 at 10:45 AM, Richard Guenther wrote: > Please split up the patch into one dealing with #ident exclusively and > a followup with the other pieces. Hello, This is the patch to deal with #ident. It removes the ASM_OUTPUT_IDENT and IDENT_ASM_OP target macros, and replaces them wi

[PATCH] don't presume undelegitimized UNSPEC_TLS SYMBOL_REF is a decl

2012-06-06 Thread Roland McGrath
cf this change: 2010-11-19 Jakub Jelinek PR target/45870 * dwarf2out.c (const_ok_for_output_1): Don't complain about non-delegitimized TLS UNSPECs. This case hit me where the rtx was: (unspec:SI [ (symbol_ref:SI

Re: [google] New fdo summary-based icache sensitive unrolling (issue 6282045)

2012-06-06 Thread Teresa Johnson
On Tue, Jun 5, 2012 at 11:46 AM, wrote: > > http://codereview.appspot.com/6282045/diff/1/gcc/gcov-io.h > File gcc/gcov-io.h (right): > > http://codereview.appspot.com/6282045/diff/1/gcc/gcov-io.h#newcode544 > gcc/gcov-io.h:544: gcov_unsigned_t sum_cutoff_percent;/* sum_all cutoff > percentage com

Re: [PATCH, WWWDOCS] Document AArch64 branch.

2012-06-06 Thread Gerald Pfeifer
On Tue, 29 May 2012, Marcus Shawcroft wrote: This patch documents the AArch64 branch in wwwdocs/htdocs/svn.html. Looks good to me. (Note, that as someone with write access to the GCC repository you don't need approval for changes like this, though I am always happy to look at changes.) Gerald

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Steven Bosscher
On Wed, Jun 6, 2012 at 7:15 PM, Paolo Bonzini wrote: > Il 06/06/2012 09:15, Steven Bosscher ha scritto: >> +    add_asm_printf ("%s\n\t.ascii \"%s\"\n", >> +                 READONLY_DATA_SECTION_ASM_OP, string); >> +  else > > Need to escape the string as in mips_output_ascii, of course. :( Well

Re: [PATCH] Hoist adjacent pointer loads

2012-06-06 Thread William J. Schmidt
On Mon, 2012-06-04 at 08:45 -0500, William J. Schmidt wrote: > Hi Richard, > > Here's a revision of the hoist-adjacent-loads patch. I'm sorry for the > delay since the last revision, but my performance testing has been > blocked waiting for a fix to PR53487. I ended up applying a test > version

Re: [patch] Remove -fconserve-space

2012-06-06 Thread Jason Merrill
On 06/06/2012 02:06 PM, Steven Bosscher wrote: -// { dg-options "-fconserve-space -fcommon" } +// { dg-options "-fcommon" } I think we can just remove the dg-options; -fcommon has no effect for C++. OK with that change. Jason

Re: [C++ Patch] PR 53567

2012-06-06 Thread Jason Merrill
OK, thanks. Jason

[committed] Fix up memset call in libgomp (PR libgomp/52993)

2012-06-06 Thread Jakub Jelinek
Hi! This is a Linux only file, on which GNU symbol versioning should be supported, therefore this code isn't compiled in, so not severe enough to backport. Fixed on the trunk. 2012-06-06 Jakub Jelinek PR libgomp/52993 * config/linux/lock.c (gomp_init_nest_lock_25): Fix up las

[PATCH, testsuite]: Avoid magic constants in gcc.target/i386/avx-os-support.h

2012-06-06 Thread Uros Bizjak
Hello! 2012-06-06 Uros Bizjak * gcc.target/i386/avx-os-support.h (XCR_XFEATURE_ENABLED_MASK): New. (XSTATE_FP): Ditto. (XSTATE_SSE): Ditto. (XSTATE_YMM): Ditto. (avx_os_support): Use new defines. Tested on x86_64-pc-linux-gnu AVX target, committed to ma

Re: [PATCH] Fixincludes/VxWorks

2012-06-06 Thread rbmj
On 06/06/2012 01:11 PM, Bruce Korb wrote: On 06/06/12 09:33, rbmj wrote: Hi everyone, OK, I'm slow. I just woke up from a late night. "test -r vxWorks.h" is the mechanism to ensure that tests only fire on a vxworks platform. Seems a bit obscure, but if it is easier than other mechanisms, the

[patch] Remove -fconserve-space

2012-06-06 Thread Steven Bosscher
Hello, The attached patch removes the -fconserve-space flag, as discussed last week. Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for trunk? Ciao! Steven gcc/ * doc/invoke.texi (fconserve-space): Remove documentation. c-family/ * c.opt (fconserve-space): Turn into a no-

Re: Why is fixincludes not doing anything?

2012-06-06 Thread Bruce Korb
RE: http://gcc.gnu.org/ml/gcc-help/2012-05/msg00245.html perhaps it would be useful to echo a warning into the stderr stream when platforms get bypassed?

Re: [RFC] [PowerPC] Patch to create new attribute type: popcnt

2012-06-06 Thread Edmar
On 06/06/2012 08:57 AM, David Edelsohn wrote: On Tue, Jun 5, 2012 at 4:21 PM, Edmar wrote: David, Michael, Here is the new type "popcnt" patch that I had separated from previous E5500/E6500 submission, also added the changes suggested by Michael Meissner (detailed bellow). I am missing some de

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Paolo Bonzini
Il 06/06/2012 09:15, Steven Bosscher ha scritto: > +add_asm_printf ("%s\n\t.ascii \"%s\"\n", > + READONLY_DATA_SECTION_ASM_OP, string); > + else Need to escape the string as in mips_output_ascii, of course. :( Paolo

Re: [PATCH] Fixincludes/VxWorks

2012-06-06 Thread Bruce Korb
On 06/06/12 09:33, rbmj wrote: Hi everyone, OK, I'm slow. I just woke up from a late night. "test -r vxWorks.h" is the mechanism to ensure that tests only fire on a vxworks platform. Seems a bit obscure, but if it is easier than other mechanisms, then fine. I do think a "mach" test would be

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Michael Eager
On 06/06/2012 12:15 AM, Steven Bosscher wrote: On Tue, Jun 5, 2012 at 10:59 AM, Richard Guenther wrote: On Mon, Jun 4, 2012 at 8:23 PM, Steven Bosscher wrote: Hello, The attached patch removes one more #include output.h, this time from c-family/c-pch.c. Anything written out to asm_out_file

Re: [PATCH] Fixincludes/VxWorks

2012-06-06 Thread Bruce Korb
Please read README and look to inclhack.def for examples approximating the kind of testing you are interested in doing. "test -r vxWorks.h" is a pointless test if you configure the fix to apply only to a file named vxWorks.h. On Wed, Jun 6, 2012 at 9:33 AM, rbmj wrote: > Hi everyone, > > This pat

[PATCH 7/7] Add fix to make write() const correct on VxWorks

2012-06-06 Thread rbmj
VxWorks' write() takes its second argument as non-const, but the compiler complains if one tries to pass a const pointer to it. This simply changes the prototype to say it is const so everything works. Changes: * fixincludes/inclhack.def: Added vxworks_write_const fix * fixincludes/fixi

[PATCH 6/7] Add hack for ioctl() on VxWorks.

2012-06-06 Thread rbmj
ioctl() is supposed to be variadic, but VxWorks only has a three argument version with the third argument of type int. This messes up when the third argument is not implicitly convertible to int. This adds a macro which wraps around ioctl() and explicitly casts the third argument to an int. Chan

[PATCH 5/7] Add fix to prevent accidental inclusion of regs.h on, VxWorks.

2012-06-06 Thread rbmj
VxWorks has it's own regs.h that conflicts with GCC's regs.h, so just make any replace any references to regs.h in VxWorks with references to arch/../regs.h, which includes the VxWorks header, not GCC's header. Changes: * fixincludes/inclhack.def: Added vxworks_regs fix --- fixincludes/incl

[PATCH 4/7] Add unistd.h wrapper for VxWorks.

2012-06-06 Thread rbmj
On VxWorks, unistd.h doesn't define everything it should, like read/write, etc. This wrapper adds the things it should define so everything can be compliant and compile correctly without manual modification. Changes: * fixincludes/inclhack.def: Added AAB_vxworks_unistd fix --- fixincludes/

[PATCH 3/7] Add stdint.h wrapper for VxWorks.

2012-06-06 Thread rbmj
The stdint.h doesn't have all the typedefs needed for standards compliance, so add a hack that adds all of the needed typedefs to be fully compliant to the standard. Fixes broken libstdc++. Changes: * fixincludes/inclhack.def: Added AAB_vxworks_stdint fix --- fixincludes/inclhack.def | 4

[PATCH 2/7] Added assert fixinclude hack for VxWorks.

2012-06-06 Thread rbmj
VxWorks's assert.h relies on adjacent string tokens being joined, and uses macros for some of the strings (e.g. __FILE__). However, it does not put a space after the end quote and before the macro, so instead of replacing the macro, gcc >= 4.7.x thinks it's a user-defined literal token, and since

Re: [RFC] [PowerPC] Patch to create new attribute type: popcnt

2012-06-06 Thread Michael Meissner
On Tue, Jun 05, 2012 at 04:21:00PM -0400, Edmar wrote: > David, Michael, > > Here is the new type "popcnt" patch that I had separated from previous > E5500/E6500 submission, also added the changes suggested by Michael > Meissner (detailed bellow). > I am missing some details for power6. (Could not

[PATCH 1/7] Add ability to skip the machine_name fixincludes fix.

2012-06-06 Thread rbmj
On some platforms, machine_name is overzealous, or even breaks things. This patch adds the functionality to skip the machine_name 'fix' by giving it an empty macro list. gcc/configure: Regenerate --- fixincludes/mkfixinc.sh |1 - gcc/Makefile.in | 15 +++ gcc/configure.

[PATCH] Fixincludes/VxWorks

2012-06-06 Thread rbmj
Hi everyone, This patch series is the result of this [1] thread about fixincludes on VxWorks. It resolves bugs 53457 and 53378, and a few other issues that previously required manual intervention to fix for VxWorks header files. The fixes are tested and work correctly both with make stmp-fix

[Patch,AVR] Tidy up builtins expansion

2012-06-06 Thread Georg-Johann Lay
This patch merges the tree functions that handled builtins with one, two, three arguments to one function. Code is clearer and smaller if the arguments are handled in a loop instead of hand-unrolled loops as with the old functions. Ok for trunk? Johann * config/avr/avr.c (avr_default_ex

Re: [PATCH][C++] Fix PR52841

2012-06-06 Thread Jason Merrill
On 06/06/2012 04:09 AM, Fabien Chêne wrote: Out of curiosity, do you happen to know what kind of problem was triggered here ? Shouldn't we fix the underlying issue as well ? Unless that the canonical way to solve it be to simply return earlier... Often if we continue parsing something on the as

Re: [C++ Patch] PR 53567

2012-06-06 Thread Jason Merrill
On 06/06/2012 05:45 AM, Paolo Carlini wrote: The warning belongs to joust, called by tourney, called by build_user_type_conversion_1, called by implicit_conversion. Hmm. We really ought not to issue that warning until we know that we've committed to that conversion. But I guess that doesn't

[patch] Do not include rtl.h in cfgloop.h

2012-06-06 Thread Steven Bosscher
Hello, cfgloop.h only depends on rtl.h for rtx_code. The patch introduces a new enum and a simple function to convert from one enum to another in a few non-performance critical places. The upside is that this makes most of the tree-* files independent of rtl.h. Bootstrapped on x86_64-unknown-lin

[patch] Do not include rtl.h in tree-phinodes.c

2012-06-06 Thread Steven Bosscher
Hello, tree-phinodes.c includes rtl.h for ... ceil_log2 (?!). Moving ceil_log2 to hwint.c/hwint.h to join its sibling floor_log2 breaks this dependency. Bootstrapped on x86_64-unknown-linux-gnu. OK for trunk? Ciao! Steven tree_phinodes_no_rtl_h.diff Description: Binary data

Re: RF[CA]: Don't restrict stack slot sharing

2012-06-06 Thread Richard Guenther
On Wed, Jun 6, 2012 at 2:43 PM, Michael Matz wrote: > Hi, > > On Tue, 29 May 2012, Richard Guenther wrote: > >> > [... patch about making conflict handling for stack slot sharing >> > faster...] >> >> The volatile handling is very odd - the objects_must_conflict_p code >> basically says that two v

[PATCH][RFC] alias.c TLC

2012-06-06 Thread Richard Guenther
This removes some odd code from true_dependence_1 and may_alias_p that is not in write_dependence - namely special-casing of AND as alias-everything (and the function doing the same named aliases_everything_p). It also makes BLKmode SCRATCH handling consistent between both and removes special ca

Re: [patch] support for multiarch systems

2012-06-06 Thread Thomas Schwinge
Hi! On Sat, 19 May 2012 18:05:30 +0200, I wrote: > On Wed, 09 May 2012 02:38:11 +0200, Matthias Klose wrote: > > ok, the attached patch includes just the support for the x86 targets, > > including > > the kfreebsd and the hurd systems. The x32 multiarch tuple isn't yet > > defined, so > > I'd l

Re: Support for Runtime CPU type detection via builtins (issue5754058)

2012-06-06 Thread H.J. Lu
On Tue, Jun 5, 2012 at 3:00 PM, Sriraman Tallam wrote: > Hi H.J., > > I am attaching a patch to add __cpu_indicator_init to the list of > symbols to be versioned and exported in libgcc_s.so. Also, updating > builtin_target.c test to explicitly do a CPUID and check if the > features are identified

Re: [RFA] PowerPC e5500 and e6500 cores support

2012-06-06 Thread David Edelsohn
On Tue, Jun 5, 2012 at 3:13 PM, Edmar wrote: > The patch I submitted had an omission. I failed to regenerate > rs6000-tables.opt > (Sorry, I misunderstood gcc_update --touch instructions) > OK to commit the update ? > > 2012-06-05  Edmar Wienskoski > >    * config/rs6000/rs6000-tables.opt: Regene

Re: [RFC] [PowerPC] Patch to create new attribute type: popcnt

2012-06-06 Thread David Edelsohn
On Tue, Jun 5, 2012 at 4:21 PM, Edmar wrote: > David, Michael, > > Here is the new type "popcnt" patch that I had separated from previous > E5500/E6500 submission, also added the changes suggested by Michael > Meissner (detailed bellow). > I am missing some details for power6. (Could not find any

[PATCH] Fix PR53588

2012-06-06 Thread Richard Guenther
Tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-06-06 Richard Guenther PR testsuite/32380 * gfortran.dg/vect/pr32380.f: Adjust number of expected vectorized loops. Index: gcc/testsuite/gfortran.dg/vect/pr32380.f

Re: [PATCH] Fix output in mklog

2012-06-06 Thread Diego Novillo
On Wed, Jun 6, 2012 at 8:44 AM, Marek Polacek wrote: > Sorry, I don't have commit rights, so I'm not able to apply this > one myself.  Thanks, Committed rev 188265. Thanks for the fix. Diego.

Re: [PATCH] Fix output in mklog

2012-06-06 Thread Marek Polacek
On Wed, Jun 06, 2012 at 07:09:08AM -0400, Diego Novillo wrote: > On Thu, May 31, 2012 at 4:12 PM, Marek Polacek wrote: > > > 2012-05-31  Marek Polacek   > > > >        * mklog: Prevent printing three spaces after the date. > > OK. Sorry, I don't have commit rights, so I'm not able to apply this

RF[CA]: Don't restrict stack slot sharing

2012-06-06 Thread Michael Matz
Hi, On Tue, 29 May 2012, Richard Guenther wrote: > > [... patch about making conflict handling for stack slot sharing > > faster...] > > The volatile handling is very odd - the objects_must_conflict_p code > basically says that two volatile vars may always share stack slots?! > What's the re

Re: _FORTIFY_SOURCE for std::vector

2012-06-06 Thread Florian Weimer
On 06/05/2012 11:05 AM, Richard Guenther wrote: And that would only be at -O1. Note that such range-checks will defeat most, if not all, loop optimizations, too. So C++ code using std::vector in compute-intensive parts would be severely pessimized. Array bounds check elimination could deal wi

Re: [PATCH ARM iWMMXt 2/5] intrinsic head file change

2012-06-06 Thread Ramana Radhakrishnan
I've only had a brief look at this and point out certain stylistic issues that I noticed and would like another set of eyes on this and the next patch. On 29 May 2012 05:13, Matt Turner wrote: > From: Xinyu Qi > >        gcc/ >        * config/arm/mmintrin.h: Use __IWMMXT__ to enable iWMMXt int

Re: [patch] Fix PR ada/52362

2012-06-06 Thread Diego Novillo
On 12-06-06 07:23 , Eric Botcazou wrote: So, why do we have the --with-gnu-as flag then? Because, on some platforms like Solaris, you can use the system assembler or the GNU assembler, so nothing is hardcoded in config.gcc and --with-gnu-as makes it possible to pick one. On Linux, it's always

Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support

2012-06-06 Thread Ramana Radhakrishnan
On 29 May 2012 05:13, Matt Turner wrote: > > This series was written by Marvell and sent by Xinyu Qi > a number of times in the last year. > > We (One Laptop per Child) need these patches for reasonable iWMMXt support > and performance. Without them, logical and shift intrinsics cause ICEs, > see

Re: [PATCH ARM iWMMXt 3/5] built in define and expand

2012-06-06 Thread Ramana Radhakrishnan
On 29 May 2012 05:13, Matt Turner wrote: > From: Xinyu Qi > >        gcc/ >        * config/arm/arm.c (enum arm_builtins): Revise built-in fcode. >        (IWMMXT2_BUILTIN): New define. >        (IWMMXT2_BUILTIN2): Likewise. >        (iwmmx2_mbuiltin): Likewise. >        (builtin_description bdes

Re: [PATCH ARM iWMMXt 1/5] ARM code generic change

2012-06-06 Thread Ramana Radhakrishnan
On 29 May 2012 05:13, Matt Turner wrote: > From: Xinyu Qi > >        gcc/ >        * config/arm/arm.c (FL_IWMMXT2): New define. >        (arm_arch_iwmmxt2): New variable. >        (arm_option_override): Enable use of iWMMXt with VFP. >        Disable use of iWMMXt with NEON. Disable use of iWMMXt

Re: [RFC, ivopts] fix bugs in ivopts address cost computation

2012-06-06 Thread Zdenek Dvorak
Hi, > > (7) If the computed address cost turns out to be 0, the current code > > (for some unknown reason) is turning that into 1, which can screw up > > the relative costs of address computations vs other operations like > > addition. > > > > I've come up with the attached patch to try to fix the

Re: [patch] Fix PR ada/52362

2012-06-06 Thread Eric Botcazou
> So, why do we have the --with-gnu-as flag then? Because, on some platforms like Solaris, you can use the system assembler or the GNU assembler, so nothing is hardcoded in config.gcc and --with-gnu-as makes it possible to pick one. On Linux, it's always the GNU assembler so this is hardcoded.

Re: [ARM Patch 1/n] PR53447: optimizations of 64bit ALU operation with constant

2012-06-06 Thread Carrot Wei
In the original patch, if "add r0, c" is not possible, but "sub r0, -c" is possible, it will use the sub instruction. Although they generate same result, but they may generate different CF flag, and cause subsequent adc to compute out wrong result. So I updated the patch to avoid using sub instruct

Re: [patch] Fix PR ada/52362

2012-06-06 Thread Diego Novillo
On 12-06-06 03:32 , Eric Botcazou wrote: When doing native bootstraps, we need to set --with-gnu-as=no because binutils 'as' does not handle a flag that we pass to our own version of 'as'. That looks like a kludge to me. You can probably achieve the same effect with a script filtering out the

Re: [PATCH] Fix output in mklog

2012-06-06 Thread Diego Novillo
On Thu, May 31, 2012 at 4:12 PM, Marek Polacek wrote: > 2012-05-31  Marek Polacek   > >        * mklog: Prevent printing three spaces after the date. OK. Diego.

Re: [PATCH] arm: Fix iwmmxt shift and logical intrinsics (PR 35294).

2012-06-06 Thread Ramana Radhakrishnan
On 28 May 2012 22:57, Matt Turner wrote: > On Fri, Feb 24, 2012 at 10:53 PM, Matt Turner wrote: >> PR 36798 and 36966 are duplicates. >> >> 2012-02-24  Matt Turner   >> >>        PR target/35294 >>        * config/arm/arm.c (arm_expand_builtin): Wire up missing >>        intrinsics. >> --- >>  gc

Re: [C++ Patch] PR 53567

2012-06-06 Thread Paolo Carlini
Hi again, some additional details: On 06/06/2012 11:20 AM, Paolo Carlini wrote: Hi, On 06/06/2012 03:57 AM, Jason Merrill wrote: On 06/05/2012 08:23 PM, Paolo Carlini wrote: @@ -1695,6 +1695,8 @@ implicit_conversion (tree to, tree from, tree expr |LOOKUP_NO_TEMP_BIND|LOOKUP_NO_RVA

Re: [PATCH][RFC] Recognize memcpy/memmove - fix PR53081

2012-06-06 Thread Richard Guenther
On Tue, 5 Jun 2012, Richard Guenther wrote: > > This adds memcpy/memmove recognition to loop distribution (and > cleans it up some more). Issues are similar to memset and > not handled (and I just noticed we generate memset/memcpy even > with -fno-builtin ...). > > Bootstrapped on x86_64-unknow

Re: [PATCH] arm: add _mm_empty to mmintrin.h for source compatibility

2012-06-06 Thread Ramana Radhakrishnan
On 28 May 2012 22:56, Matt Turner wrote: > On Tue, Feb 28, 2012 at 7:13 PM, Ramana Radhakrishnan > wrote: >> On Fri, Feb 24, 2012 at 10:53:35PM -0500, Matt Turner wrote: >>> The x86/amd64 mmintrin.h provides the _mm_empty intrinsic for the 'emms' >>> MMX instruction. Although ARM does not need su

Re: [C++ Patch] PR 53567

2012-06-06 Thread Paolo Carlini
Hi, On 06/06/2012 03:57 AM, Jason Merrill wrote: On 06/05/2012 08:23 PM, Paolo Carlini wrote: @@ -1695,6 +1695,8 @@ implicit_conversion (tree to, tree from, tree expr |LOOKUP_NO_TEMP_BIND|LOOKUP_NO_RVAL_BIND|LOOKUP_PREFER_RVALUE |LOOKUP_NO_NARROWING|LOOKUP_PROTECT); + comp

Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin

2012-06-06 Thread Ramana Radhakrishnan
Hi Christophe, Sorry it's taken me a while to get back on this patch - I've been traveling. > diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md > index 4568dea..0a4d00b 100644 > --- a/gcc/config/arm/neon.md > +++ b/gcc/config/arm/neon.md > @@ -4397,20 +4397,32 @@ > ) > (define_insn

Re: [PATCH] Fix output in mklog

2012-06-06 Thread Marek Polacek
Ping. On Thu, May 31, 2012 at 10:12:09PM +0200, Marek Polacek wrote: > The new mklog script prints three spaces after the date part, which > is wrong. Thus fixed by adjusting the split pattern. Tested manually. > > 2012-05-31 Marek Polacek > > * mklog: Prevent printing three spaces af

Re: [PATCH 2/2] arm: add iwMMXt mmx-2.c test

2012-06-06 Thread Ramana Radhakrishnan
On 28 May 2012 22:55, Matt Turner wrote: > On Thu, Apr 5, 2012 at 4:53 AM, Ramana Radhakrishnan > wrote: >> On 4 April 2012 19:35, Matt Turner wrote: >>>  gcc/testsuite/gcc.target/arm/mmx-2.c |  158 >>> ++ >>>  1 files changed, 158 insertions(+), 0 deletions(-) >

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Richard Guenther
On Wed, Jun 6, 2012 at 9:15 AM, Steven Bosscher wrote: > On Tue, Jun 5, 2012 at 10:59 AM, Richard Guenther > wrote: >> On Mon, Jun 4, 2012 at 8:23 PM, Steven Bosscher >> wrote: >>> Hello, >>> >>> The attached patch removes one more #include output.h, this time from >>> c-family/c-pch.c. >>> >>>

Re: [RFC, ivopts] fix bugs in ivopts address cost computation

2012-06-06 Thread Richard Guenther
On Tue, Jun 5, 2012 at 6:34 PM, Sandra Loosemore wrote: > My colleagues and I have been working on the GCC port for the Qualcomm > Hexagon.  Along the way I noticed that we were getting poor results > from the ivopts pass no matter how we adjusted the target-specific RTX > costs.  In many cases iv

Re: [PATCH][C++] Fix PR52841

2012-06-06 Thread Fabien Chêne
2012/6/5 Jason Merrill : > OK. Out of curiosity, do you happen to know what kind of problem was triggered here ? Shouldn't we fix the underlying issue as well ? Unless that the canonical way to solve it be to simply return earlier... Thanks, -- Fabien

Re: [patch] Fix PR ada/52362

2012-06-06 Thread Eric Botcazou
> When doing native bootstraps, we need to set --with-gnu-as=no because > binutils 'as' does not handle a flag that we pass to our own version > of 'as'. That looks like a kludge to me. You can probably achieve the same effect with a script filtering out the unsupported flag. > 2- Eric, your pa

Re: [patch][PCH] Do not write/read asm_out_file

2012-06-06 Thread Steven Bosscher
On Tue, Jun 5, 2012 at 10:59 AM, Richard Guenther wrote: > On Mon, Jun 4, 2012 at 8:23 PM, Steven Bosscher wrote: >> Hello, >> >> The attached patch removes one more #include output.h, this time from >> c-family/c-pch.c. >> >> Anything written out to asm_out_file between pch_init and >> c_common_