Re: [RFC] PR 53063 encode group options in .opt files

2012-05-17 Thread Chung-Lin Tang
On 2012/5/18 03:20 AM, Joseph S. Myers wrote: > On Fri, 18 May 2012, Chung-Lin Tang wrote: > >> Joseph, how does this look? It makes the default post-stage1 C++ >> bootstrap fail similarly without the other options.c Makefile change, so >> I guess it works as intended. > > For build system patche

Re: [RFC] PR 53063 encode group options in .opt files

2012-05-17 Thread Chung-Lin Tang
On 2012/5/18 01:51 AM, Gabriel Dos Reis wrote: > On Thu, May 17, 2012 at 12:41 PM, Gabriel Dos Reis > wrote: >> On Thu, May 17, 2012 at 12:28 PM, Manuel López-Ibáñez >> wrote: >>> On 17 May 2012 19:25, Gabriel Dos Reis >>> wrote: On Thu, May 17, 2012 at 12:19 PM, Chung-Lin Tang wrote

Re: Turn check macros into functions. (issue6188088)

2012-05-17 Thread Mike Stump
On May 17, 2012, at 2:41 PM, Lawrence Crowl wrote: >> Reusing the compiler for this seems like the only way to go. >> But, we did look at using g++ to parse C++ expressions from gdb, >> and it was too slow :-(. We're going to look again, at least to >> generate some bug reports if we can. > > It'

Re: [RFA] PowerPC e5500 and e6500 cores support

2012-05-17 Thread Michael Meissner
On Tue, Mar 06, 2012 at 11:44:08AM -0500, Edmar wrote: > Freescale would like to contribute these patches to gcc. > > It enables gcc for the new Freescale 64 bit cores. It creates a pipeline > description, and set proper default flags for the e5500 and e6500 cores. > > Both are 64 bit cores capa

[PATCH] Simplify attempt_builtin_powi logic

2012-05-17 Thread William J. Schmidt
This patch gives up on using the reassociation rank algorithm to correctly place __builtin_powi calls and their feeding multiplies. In the end this proved to introduce more complexity than it saved, due in part to the poor fit of introducing DAG expressions into the reassociated operand tree. Thi

Re: Turn check macros into functions. (issue6188088)

2012-05-17 Thread Lawrence Crowl
On 5/17/12, Tom Tromey wrote: > > "Lawrence" == Lawrence Crowl writes: > > Tom> Doesn't this mean that if you have checking enabled, and you use > Tom> the wrong macro on some tree, cc1 will crash? That seems like > Tom> a distinct minus to me. > > Lawrence> Yes, it does mean that, but it is a n

Re: Turn check macros into functions. (issue6188088)

2012-05-17 Thread Andrew Pinski
On Thu, May 17, 2012 at 1:53 PM, Tom Tromey wrote: >> "Lawrence" == Lawrence Crowl writes: > > Tom> Doesn't this mean that if you have checking enabled, and you use the > Tom> wrong macro on some tree, cc1 will crash?  That seems like a distinct > Tom> minus to me. > > Lawrence> Yes, it does

Re: rfa: vectorize strided loads [2/2] [PR 18437]

2012-05-17 Thread H.J. Lu
On Sat, Apr 21, 2012 at 11:19 AM, H.J. Lu wrote: > On Sat, Apr 21, 2012 at 11:11 AM, H.J. Lu wrote: >> On Tue, Apr 10, 2012 at 6:46 AM, Michael Matz wrote: >>> Hi, >>> >> >>> Michael. >>> >>>        PR tree-optimization/18437 >>> >>>        * tree-vectorizer.h (_stmt_vec_info.stride_load_p): New

Re: Turn check macros into functions. (issue6188088)

2012-05-17 Thread Tom Tromey
> "Lawrence" == Lawrence Crowl writes: Tom> Doesn't this mean that if you have checking enabled, and you use the Tom> wrong macro on some tree, cc1 will crash? That seems like a distinct Tom> minus to me. Lawrence> Yes, it does mean that, but it is a net overall improvement. It is a net de

Re: [PATCH] PR rtl-optimization/53352

2012-05-17 Thread Meador Inge
On 05/17/2012 03:02 PM, Richard Sandiford wrote: > After agonising over this for a couple of days, I think it's probably > the correct fix. What we're doing now would be valid if the only use of > equiv_constant(x) were to substitute for x. The name and current use > of the function obviously re

Re: [C++ Patch] PR 44516

2012-05-17 Thread Iain Sandoe
On 17 May 2012, at 21:16, Mike Stump wrote: On May 17, 2012, at 12:53 PM, Paolo Carlini wrote: On 05/17/2012 09:47 PM, Jason Merrill wrote: On 05/17/2012 05:06 AM, Paolo Carlini wrote: On 05/17/2012 10:33 AM, Gabriel Dos Reis wrote: I am still puzzled by why we need to assert, as opposed to

Re: [C++ Patch] PR 44516

2012-05-17 Thread Mike Stump
On May 17, 2012, at 12:53 PM, Paolo Carlini wrote: > On 05/17/2012 09:47 PM, Jason Merrill wrote: >> On 05/17/2012 05:06 AM, Paolo Carlini wrote: >>> On 05/17/2012 10:33 AM, Gabriel Dos Reis wrote: I am still puzzled by why we need to assert, as opposed to just ignore, unless we have a pl

Re: [PATCH] PR rtl-optimization/53352

2012-05-17 Thread Richard Sandiford
Steven Bosscher writes: > On Thu, May 17, 2012, Meador Inge wrote: >>> ;; This is *not* equal to zero because the upper >>> ;; two bytes are undefined. >>> (insn 14 13 15 2 (set (reg:SI 142) >>>         (subreg:SI (reg:QI 141) 0)) >>>      (expr_list:REG_EQUAL (const_int 0 [0]) >>>         (nil))

Re: [C++ Patch] PR 44516

2012-05-17 Thread Paolo Carlini
On 05/17/2012 09:47 PM, Jason Merrill wrote: On 05/17/2012 05:06 AM, Paolo Carlini wrote: On 05/17/2012 10:33 AM, Gabriel Dos Reis wrote: I am still puzzled by why we need to assert, as opposed to just ignore, unless we have a plan to make a wholesale move -- but even there I am bit nervous.

Re: [C++ Patch] PR 44516

2012-05-17 Thread Jason Merrill
On 05/17/2012 05:06 AM, Paolo Carlini wrote: On 05/17/2012 10:33 AM, Gabriel Dos Reis wrote: I am still puzzled by why we need to assert, as opposed to just ignore, unless we have a plan to make a wholesale move -- but even there I am bit nervous. Eh, don't ask me ;) Anyway, in terms of testin

Re: [RFC] PR 53063 encode group options in .opt files

2012-05-17 Thread Joseph S. Myers
On Fri, 18 May 2012, Chung-Lin Tang wrote: > Joseph, how does this look? It makes the default post-stage1 C++ > bootstrap fail similarly without the other options.c Makefile change, so > I guess it works as intended. For build system patches you ought to be asking the build system maintainers fo

Re: Turn check macros into functions. (issue6188088)

2012-05-17 Thread Diego Novillo
On 12-05-17 10:52 , Michael Matz wrote: Cross the bridge when you reach it, not before. Not everybody agrees that the splitting of tree would be a good idea. Right now templates aren't necessary, so you shouldn't use them. (well, and an investigation why they come up with smaller .text would

Re: [PATCH] Fix bessel_7.f90 failures on sparc-*-linux-gnu

2012-05-17 Thread Steven Bosscher
On Thu, May 17, 2012 at 1:56 AM, David Miller wrote: > > I've noticed this failure for some time but never got around to > inspecting things.  The X=34.53 case seem to need a precision > allowance bump. > > Ok for mainline and 4.7 branch? OK. Ciao! Steven

Re: [RFA] leb128.h: New file.

2012-05-17 Thread Doug Evans
Hi. This is a slightly modified version of my previous patch. ref: http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00962.html The only change is to make the result of the functions an int instead of a const pointer. This lets them be used in places where the code is using non-const pointers without

Re: [RFC, 4.8] Magic matching for flags clobbering and setting

2012-05-17 Thread Richard Henderson
On 05/17/12 10:59, Steven Bosscher wrote: > Are you still working on this for GCC 4.8? Not actively. r~

Re: [RFC, 4.8] Magic matching for flags clobbering and setting

2012-05-17 Thread Steven Bosscher
On Sat, Feb 11, 2012 at 1:12 AM, Richard Henderson wrote: > Seeing as how Uros is starting to go down the path of cleaning up the > flags handling for x86, I thought I'd go ahead and knock up the idea > that I've been tossing around to help automate the process of building > patterns that match bo

Re: [RFC] PR 53063 encode group options in .opt files

2012-05-17 Thread Gabriel Dos Reis
On Thu, May 17, 2012 at 12:41 PM, Gabriel Dos Reis wrote: > On Thu, May 17, 2012 at 12:28 PM, Manuel López-Ibáñez > wrote: >> On 17 May 2012 19:25, Gabriel Dos Reis wrote: >>> On Thu, May 17, 2012 at 12:19 PM, Chung-Lin Tang >>> wrote: On 2012/5/17 01:55 AM, Manuel López-Ibáñez wrote:

Re: [RFC] PR 53063 encode group options in .opt files

2012-05-17 Thread Gabriel Dos Reis
On Thu, May 17, 2012 at 12:28 PM, Manuel López-Ibáñez wrote: > On 17 May 2012 19:25, Gabriel Dos Reis wrote: >> On Thu, May 17, 2012 at 12:19 PM, Chung-Lin Tang >> wrote: >>> On 2012/5/17 01:55 AM, Manuel López-Ibáñez wrote: > I'm guessing these changes are the cause of a full C bootstrap >>

Re: [RFC] PR 53063 encode group options in .opt files

2012-05-17 Thread Manuel López-Ibáñez
On 17 May 2012 19:25, Gabriel Dos Reis wrote: > On Thu, May 17, 2012 at 12:19 PM, Chung-Lin Tang > wrote: >> On 2012/5/17 01:55 AM, Manuel López-Ibáñez wrote: I'm guessing these changes are the cause of a full C bootstrap > (--disable-build-poststage1-with-cxx) failure I'm seeing on tru

Re: [RFC] PR 53063 encode group options in .opt files

2012-05-17 Thread Gabriel Dos Reis
On Thu, May 17, 2012 at 12:19 PM, Chung-Lin Tang wrote: > On 2012/5/17 01:55 AM, Manuel López-Ibáñez wrote: >>> I'm guessing these changes are the cause of a full C bootstrap >>> > (--disable-build-poststage1-with-cxx) failure I'm seeing on trunk. The >>> > *_handle_option_auto function prototypes

Re: [RFC] PR 53063 encode group options in .opt files

2012-05-17 Thread Chung-Lin Tang
On 2012/5/17 01:55 AM, Manuel López-Ibáñez wrote: >> I'm guessing these changes are the cause of a full C bootstrap >> > (--disable-build-poststage1-with-cxx) failure I'm seeing on trunk. The >> > *_handle_option_auto function prototypes are not seen in options.c, and >> > -Werror -Wmissing-prototy

Re: [google][4.7]Port function reordering via linker plugin from google/gcc-4_6 branch (issue6195099)

2012-05-17 Thread Sriraman Tallam
Patch committed. I am preparing to send to trunk by splitting this into multiple patches. Thanks, -Sri. On Wed, May 16, 2012 at 9:23 PM, Xinliang David Li wrote: > ok for google-4_7 branch. This should also be pushed to trunk. > > Thanks, > > David > > On Wed, May 16, 2012 at 6:56 PM, Sriraman T

Symbol table 21/many: analyze initializers of external vars

2012-05-17 Thread Jan Hubicka
Hi, C++ virtual tables keyed to other compilation units are represented as DECL_EXTERNAL variables with constructor known. Knowhing the constructor helps constant folding to do devirtualization. At the moment these costructors are not seen by varpool and thus they are not represented by ipa-ref

Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)

2012-05-17 Thread Diego Novillo
On 12-05-17 12:27 , Han Shen(沈涵) wrote: Hi, ok for approval? OK. Diego.

Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)

2012-05-17 Thread 沈涵
Hi, ok for approval? Thanks, -Han On Wed, May 16, 2012 at 4:49 PM, wrote: > On 2012/05/16 23:30:28, Diego Novillo wrote: > >> On 12-05-16 19:22 , mailto:jin...@google.com wrote: >> > In my opinion, gcc/ChangeLog is for upstream commits only. >> > It is fine that you want to port upstream gcc/Ch

Re: [Dwarf Patch] Improve pubnames and pubtypes generation. (issue6197069)

2012-05-17 Thread Sterling Augustine
On Thu, May 10, 2012 at 9:08 AM, Sterling Augustine wrote: > The enclosed patch fixes many issues with pubnames and pubtypes. It generates > them for many more variables and with mostly correct and canonical dwarf > names. > > This patch should not affect any target that does not use pubnames. >

Re: PING PATCH: break lines in announce_function

2012-05-17 Thread Mike Stump
On May 16, 2012, at 11:44 AM, Tom Tromey wrote: >> "Manuel" == Manuel López-Ibáñez writes: > > Manuel> It seems it will never work for statement expressions: > Manuel> http://article.gmane.org/gmane.comp.gcc.devel/107339 > > It could be done, but it is non-trivial for sure. > > Manuel

Re: PING PATCH: break lines in announce_function

2012-05-17 Thread Mike Stump
On May 16, 2012, at 8:57 AM, Manuel López-Ibáñez wrote: > I see now that any change in the underlying implementation becomes a > serious annoyance for you. No, it is easy, we just need a low cost solution by which people can use the normal accessors. Once that is provided, then I think it is ea

Re: PING PATCH: break lines in announce_function

2012-05-17 Thread Gabriel Dos Reis
On Thu, May 17, 2012 at 10:24 AM, Mike Stump wrote: >> * announce_function dumps slow down Emacs (and the shell when working >> via SSH) when debugging anything related to libstdc++ (or any large >> testcase). > > Let's make -quiet the default. Agreed. (I had always reflexively used -quiet so t

Re: PING PATCH: break lines in announce_function

2012-05-17 Thread Mike Stump
On May 16, 2012, at 6:56 AM, Manuel López-Ibáñez wrote: > On 16 May 2012 15:40, Richard Guenther wrote: >>> >>> Without that patch displaying happen too late (and eats a lot of Emacs >>> CPU)!! >> >> 1) Fix emacs (do not buffer stderr) >> 2) do not omit -quiet when running from inside emacs >

[Patch, committed as obvious] obj++/53388

2012-05-17 Thread Paolo Carlini
Hi, sorry about that, will commit momentarily at the end of a bootstrap. Thanks, Paolo. /// 2012-05-17 Paolo Carlini PR objc++/53388 * objc-act.c (objc_get_class_reference, objc_build_message_expr): Use build_min_nt_loc. Index: objc-act.c ===

Re: [C++ Patch] PR 53371

2012-05-17 Thread Jason Merrill
OK. Jason

Re: Turn check macros into functions. (issue6188088)

2012-05-17 Thread Michael Matz
Hi, On Wed, 16 May 2012, Lawrence Crowl wrote: > > Because it accepts any type as tree argument? It's of course not less > > type safety than using macros, but less type safety compared to not > > using templates. > > The overload works if the only types are tree and const_tree. In the > fut

Ping (Was: Speed up insn-attrtab.c compilation)

2012-05-17 Thread Michael Matz
Ping. On Tue, 8 May 2012, Michael Matz wrote: > Hi, > > On Mon, 7 May 2012, Mike Stump wrote: > > > On May 7, 2012, at 6:11 AM, Michael Matz wrote: > > > I'd like to retain the #if 0 code therein, > > > > Can you structure this code as > > > > #define DEBUG 0 > > > > if (DEBUG) ... > > >

Re: [patch] More thorough checking in reg_fits_class_p

2012-05-17 Thread Jim MacArthur
On 02/05/12 14:55, Richard Sandiford wrote: Richard Earnshaw writes: On 02/05/12 14:00, Richard Sandiford wrote: Jim MacArthur writes: New Changelog text: 2012-05-02 Jim MacArthur * recog.c (reg_fits_class_p): Check both regno and regno + offset are hard registers. Thanks. I still think t

[C++ Patch] PR 53371

2012-05-17 Thread Paolo Carlini
Hi, this is a rather simple PR about us not rejecting rvalue reference catch parameters. When I looked into it I noticed that we also aren't explicitly handling abstract types (which now in C++11 are explicitly mentioned in [except.handle]): eventually we rejected those but with a quite poor

Re: PING PATCH: break lines in announce_function

2012-05-17 Thread Manuel López-Ibáñez
On 16 May 2012 20:41, Tom Tromey wrote: > > Manuel> * Hitting auto-completion in GDB means staring at the window for 5-10 > Manuel> minutes until it decides to stop listing stuff. > > Report completion bugs to gdb.  There's only so much gdb can do here. > But maybe we could have some mode to be mo

Make ipa-reference to work on non-static at LTO time

2012-05-17 Thread Jan Hubicka
Hi, when I was upding ipa-reference.c to LTO I took the easiest possible approach keeping it to work only on statics without address taken at compile time and propagate at linktime. The idea was that soonish we will replace it by something more sane. Well, this did not happen yet and this hack nee

Coldfire Cores

2012-05-17 Thread Nathan Sidwell
I've committed this patch of Kwok's, which adds some additional Coldfire 51-series cores. I committed the binutils part yesterday. nathan 2012-05-17 Kwok Cheung Yeung * config/m68k/m68k-devices.def: Add 51ag, 51je, 51jf, 51jg, 51mm, 51qm. * config/m68k/m68k-tables.opt: Regenerated. * do

Re: [C++ Patch] PR 44516

2012-05-17 Thread Paolo Carlini
On 05/17/2012 10:33 AM, Gabriel Dos Reis wrote: On Thu, May 17, 2012 at 2:52 AM, Paolo Carlini wrote: On 05/17/2012 09:48 AM, Paolo Carlini wrote: Can we concisely characterize those messages and exclude them from the gcc_assert? Well, if don't quickly figure out something better, I guess we

Re: [libjava] --enable-symvers tweak for 52700

2012-05-17 Thread Andrew Haley
On 05/17/2012 12:14 AM, Benjamin De Kosnik wrote: > Allows use of --enable-symvers=gnu-versioned-namespace while > configuring in libjava. The rest of the target libs that use > --enable-symvers already handle this. As per libstdc++/52700. > > Pretty simple, but will wait for OK for trunk/branch >

Re: [C++ Patch] PR 44516

2012-05-17 Thread Gabriel Dos Reis
On Thu, May 17, 2012 at 2:52 AM, Paolo Carlini wrote: > On 05/17/2012 09:48 AM, Paolo Carlini wrote: >> >> Can we concisely characterize those messages and exclude them from the >> gcc_assert? > > Well, if don't quickly figure out something better, I guess we can always > add the assert at the beg

Re: [C++ Patch] PR 44516

2012-05-17 Thread Paolo Carlini
On 05/17/2012 09:48 AM, Paolo Carlini wrote: Can we concisely characterize those messages and exclude them from the gcc_assert? Well, if don't quickly figure out something better, I guess we can always add the assert at the beginning of warning_at, error_at, etc. Paolo.

Re: [C++ Patch] PR 44516

2012-05-17 Thread Paolo Carlini
On 05/17/2012 05:32 AM, Jason Merrill wrote: On 05/16/2012 08:34 PM, Paolo Carlini wrote: Ok. Something like p2 below? Yes. Since the earlier patch without LOC_OR_HERE passed testing, let's apply that plus this p2. Ok, great. Does Manuel's suggestion of aborting if we get UNKNOWN_LOCATION

PR middle-end/52584

2012-05-17 Thread David Miller
Richard, I was looking into a testsuite failure on the 4.7 branch on sparc and I think your fix for 52584 would fix it too. The problem eminates in gcc.c-torture/execute/vector-shift2.c with -O0 The 4 integer vector shifts get lowered to 2 integer vector shifts, since that is what the VIS3 shift