Re: [google/gcc-4_6_2-mobile] PATCH: PR other/46770: Replace .ctors/.dtors with .init_array/.fini_array on targets supporting them

2012-02-17 Thread Jing Yu
OK. Thanks for porting the patch. I will commit the patch into google/gcc-4_6_2-mobile for you. I would also like to commit it into google/gcc-4_6 branch if all tests pass. This patch is almost the same as Google Ref 47894. Thanks, Jing On Fri, Feb 17, 2012 at 5:20 PM, H.J. Lu wrote: > Hi, > >

[patch, committed] invoke.texi: GCC coding conventions issues

2012-02-17 Thread Sandra Loosemore
I've checked in this patch to address several nits mentioned on the GCC coding conventions web page http://gcc.gnu.org/codingconventions.html Specific tweaks made in this patch include: * American spelling * "back end"/"front end" * "bit-field" * "enumerated type" * "epilogue/prologue" * "lower

Re: [patch, committed] invoke.texi: "big-endian", "little-endian"

2012-02-17 Thread Robert Dewar
On 2/17/2012 8:00 PM, Sandra Loosemore wrote: I've checked in this patch to consistently hyphenate "big-endian" and "little-endian" when used as adjectives. I observe that Jonathan Swift also hyphenated "Big-endians" when used as a noun in Gulliver's Travels, but I did not see any uses of either

libgo patch committed: Add mount flags, fallocate, statfs.

2012-02-17 Thread Ian Lance Taylor
This patch to libgo adds the mount flags, the GNU/Linux specific fallocate function, and the GNU/Linux version of the statfs function. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 2b6e531380f6 libgo/configure.ac --- a/libgo/configure.ac Fri Feb

[google/gcc-4_6_2-mobile] PATCH: PR other/46770: Replace .ctors/.dtors with .init_array/.fini_array on targets supporting them

2012-02-17 Thread H.J. Lu
Hi, This patch backports the fix from trunk: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46770 for google/gcc-4_6_2-mobile branch. This is needed to support C++ global constructors/destructiors on Android/x86. OK for google/gcc-4_6_2-mobile branch? Thanks. H.J. --- 2011-08-20 H.J. Lu

[patch, committed] invoke.texi: "big-endian", "little-endian"

2012-02-17 Thread Sandra Loosemore
I've checked in this patch to consistently hyphenate "big-endian" and "little-endian" when used as adjectives. I observe that Jonathan Swift also hyphenated "Big-endians" when used as a noun in Gulliver's Travels, but I did not see any uses of either term as a noun in invoke.texi, so thankfull

Go patch committed: Permit empty interface to be embedded twice

2012-02-17 Thread Ian Lance Taylor
Interface embedding just means copying the interface methods, so there is nothing wrong with embedding the empty interface more than once. This patch fixes the gccgo frontend to permit that. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 34a3fa

Go patch committed: Permit (_) on left hand side of =

2012-02-17 Thread Ian Lance Taylor
In an oversight, the gccgo frontend rejected valid Go code (_) = 1 This patch fixes the problem. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r bcfd45b0bd55 go/parse.cc --- a/go/parse.cc Fri Feb 17 15:19:05 2012 -0800 +++ b/go/parse.cc

Re: [Patch, libfortran] RFC: Shared vtables, constification

2012-02-17 Thread Steven Bosscher
On Fri, Feb 17, 2012 at 12:44 PM, Janne Blomqvist wrote: > On Mon, Feb 13, 2012 at 23:04, Steven Bosscher wrote: >> On Mon, Feb 13, 2012 at 7:20 PM, Janne Blomqvist >> wrote: >>> Hi, >>> >>> the attached patch changes the low-level libgfortran IO dispatching >>> mechanism to use shared vtables f

Re: [google/main] Check for cross-compilers in validate_failures.py (issue5674087)

2012-02-17 Thread Diego Novillo
On Fri, Feb 17, 2012 at 18:17, Doug Kwan (關振德) wrote: > Should I submit toe trunk also, now that it is closed? Yes, that's fine. contrib/ is not release-critical. Diego.

Go patch committed: List imported packages in export information

2012-02-17 Thread Ian Lance Taylor
This patch to the Go frontend changes it to list all imported packages in the export information. This is useful for tools which want to trace package dependencies. This is another incompatible change to the export information--might as well do them together. Bootstrapped and ran Go testsuite on

Re: [google/main] Check for cross-compilers in validate_failures.py (issue5674087)

2012-02-17 Thread 關振德
Should I submit toe trunk also, now that it is closed? On Fri, Feb 17, 2012 at 4:52 AM, Diego Novillo wrote: > On 17/02/12 05:49 , Doug Kwan wrote: > >> 2012-02-17   Doug Kwan >> >>        * contrib/testsuite-management/validate_failures.py >>        (def GetMakefileValue): Check for cross compil

Go patch committed: Add parameter names to export information

2012-02-17 Thread Ian Lance Taylor
I got a request to add function parameter names to the Go export information, so that tools that do context-sensitive help, such as some IDEs, have more information to present to the user. This patch implements that request. This is an incompatible change to the export format--all existing packag

Go patch committed: Don't lower binary exprs with mismatched types

2012-02-17 Thread Ian Lance Taylor
The Go frontend was accidentally lowering binary expressions with mismatched types. It would reject two integer constant expressions with mismatched types, but would then go on to try to see if the expressions had floating point constant values. Since all integer constants can be viewed as floati

Go patch committed: Add -o option when linking

2012-02-17 Thread Ian Lance Taylor
The Go compiler needs to see all input files at once, rather than be invoked separately on each one. The gcc driver will only do that if the static combine_inputs variable is set. And combine_inputs is only set if the -o option is used (or LTO-specific -fwpa option is used). The gccgo driver cur

Re: [patch, testsuite] PR 52229, testsuite failure

2012-02-17 Thread Thomas Koenig
Am 13.02.2012 21:39, schrieb Thomas Koenig: Ping? Hello world, the attached patch xfails the offencing test case on architectures which do not allow unaligned access for vecorization. OK for trunk? Any other architectures which should be XFAILed? Regression-tested on powerpc64-unknown-linux-g

Re: [v3] libstdc++/51798

2012-02-17 Thread Benjamin Kosnik
Noticed that the config for the new atomic builtins was not correct for targets that did not do link tests. (ie x86-x-cris-elf). Fixed as follows. tested x86/linux tested x86/linux x cris-elf -benjamin2012-02-17 Benjamin Kosnik PR libstdc++/51798 continued. * acinclude.m4 (GL

Re: Continue strict-volatile-bitfields fixes

2012-02-17 Thread Thomas Schwinge
Hi! How do we move this issue forward? On Mon, 23 Jan 2012 15:46:34 +0100, Bernd Schmidt wrote: > On 11/29/2011 05:35 PM, Mitchell, Mark wrote: > >>> So, I still think this patch is the best way to go forward, and it > >> does > >>> fix incorrect code generation. Would appreciate an OK. > >> >

[v3] libstdc++/47058

2012-02-17 Thread Benjamin Kosnik
Adds support for disabling -Werror with --disable-werror configure flag. tested x86/linux --enable-maintainer-mode tested x86/linux --enable-maintainer-mode --disable-werror -benjamin2012-02-17 Benjamin Kosnik PR libstdc++/47058 * acinclude.m4 (GLIBCXX_ENABLE_WERROR): New. (GL

Go patch committed: Fix interface method representation

2012-02-17 Thread Ian Lance Taylor
In Go an interface method always takes a receiver parameter. The gccgo frontend was not correctly representing that in the backend type information generated for an interface value. This didn't make any difference for code generation, but it would mess up debug info and perhaps other things as we

Go patch committed: Check for initialization loop in constant init

2012-02-17 Thread Ian Lance Taylor
In Go it is possible to have an initialization loop in a constant initializer, if the initializer is a function pointer. This patch adds that check to the gccgo frontend. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r e19e56d17d8c go/gogo-tree

Re: [wwwdocs] add information on TILE-Gx/TILEPro ports

2012-02-17 Thread Walter Lee
On 2/17/2012 1:30 PM, Gerald Pfeifer wrote: On Tue, 14 Feb 2012, Walter Lee wrote: This patch adds information on the Tile-Gx/TILEPro ports to wwwdocs. Ok to commit? (assuming I have commit rights which I have not tried.) Yes (and yes). :-) If you'd like to mention your name in the news item,

Re: [wwwdocs] add information on TILE-Gx/TILEPro ports

2012-02-17 Thread Gerald Pfeifer
On Tue, 14 Feb 2012, Walter Lee wrote: > This patch adds information on the Tile-Gx/TILEPro ports to wwwdocs. > Ok to commit? (assuming I have commit rights which I have not tried.) Yes (and yes). :-) If you'd like to mention your name in the news item, like we have in other cases, that would b

Re: [libitm] Link with -litm and -pthread

2012-02-17 Thread Andreas Krebbel
On 02/14/2012 11:58 PM, Eric Botcazou wrote: >> I see several new fails on s390x with that patch (r184174): > > People should realize that -fgnu-tm doesn't really work if libitm hasn't been > ported to the architecture, for example s390/s390x. My understanding is that > Hans-Peter's patch shoul

[Patch,AVR] Fix/hack around spill fail ICE PR52148

2012-02-17 Thread Georg-Johann Lay
Spill failure PR52148 occurs for movmem insn that allocates 2 of AVR's 3 pointer registers. Register allocator is at it's limits and the patch tries to cure the situation by replacing (match_operand:HI 0 "register_operand" "x") with explicit (reg:HI REG_X) and similar for Z Register classes "x"

Re: [RFC 4.8] use ip+cfa to identify unwind frames, if possible

2012-02-17 Thread Richard Henderson
On 02/17/12 09:31, David Daney wrote: > Just off the top of my head (with out actually looking at the code). Is > there anything that could be done with the register zero save slot (if it > even exists)? No. We're talking about saving information in the exception structure between unwindings.

Re: [RFC 4.8] use ip+cfa to identify unwind frames, if possible

2012-02-17 Thread David Daney
On 02/16/2012 03:32 PM, Richard Sandiford wrote: David Daney writes: On 02/16/2012 02:12 PM, Richard Henderson wrote: [...] Thanks for the patch. index 1c19f8b..59d4560 100644 --- a/gcc/config/mips/mips.h +++ b/gcc/config/mips/mips.h @@ -2920,3 +2920,15 @@ extern GTY(()) struct target_globa

Re: [PATCH][ARM] Improve 64-bit shifts (non-NEON)

2012-02-17 Thread Andrew Stubbs
On 16/02/12 15:33, Andrew Stubbs wrote: OK for 4.8? I forgot to address Ramana's comment about optimize_size. This update fixes that and leaves everything else untouched. OK? Andrew 2012-02-17 Andrew Stubbs gcc/ * config/arm/arm-protos.h (arm_emit_coreregs_64bit_shift): New prototype.

libgo patch committed: Remove accidental AC_INCLUDES_DEFAULT

2012-02-17 Thread Ian Lance Taylor
For some reason I added AC_INCLUDES_DEFAULT to the libgo configure.ac script a while back. AC_INCLUDES_DEFAULT is only meant to be used as part of AC_COMPILE_IFELSE and friends, it's not meant to be used by itself. Problem fixed by removing it. Bootstrapped on x86_64-unknown-linux-gnu. Committe

Re: [PATCH][ARM] Improve use of conditional execution in thumb mode.

2012-02-17 Thread Andrew Stubbs
On 14/02/12 18:00, Andrew Stubbs wrote: On Tue 14 Feb 2012 17:35:36 GMT, Richard Earnshaw wrote: Bernds checked in a patch last year (or maybe even before that) to make the selection of flags clobbered insns run very late (certainly after condexec had run), so I'm not sure why you're not seeing

Re: [PATCH] Fix cgraph verification (PR middle-end/51929)

2012-02-17 Thread Jan Hubicka
> On Tue, Feb 14, 2012 at 11:12:31AM -0800, Jason Merrill wrote: > > On 02/10/2012 06:25 AM, Jakub Jelinek wrote: > > > PR middle-end/51929 > > > * cgraphunit.c (verify_edge_corresponds_to_fndecl): If node is > > > a same_body_alias, also test whether e->callee isn't a former > > > or curre

[wwwdocs,committed]: Update backends.html to match avr backend

2012-02-17 Thread Georg-Johann Lay
Committed the following to backends.html: -m : The port *does* use define_constants +b : Port does not use "* ..." notation for output template code +g : Port does not define TARGET_ASM_FUNCTION_(PRO|EPI)LOGUE Johann Index: backends.html =

Re: Patch ping

2012-02-17 Thread Jan Hubicka
> Hi! > > I'd like to ping two patches: > > - http://gcc.gnu.org/ml/gcc-patches/2012-01/msg01335.html > PR debug/51950 P2 > -gdwarf-4 -fdebug-types-section cloning bug > > - http://gcc.gnu.org/ml/gcc-patches/2012-02/msg00496.html > PR middle-end/51929 P1 > cgraph verification failur

[Ada] Package instantiation as remote call interface

2012-02-17 Thread Arnaud Charlet
For a remote call interface library unit that is a package instantiation, no instance body should be emitted in DSA calling stubs mode; instead, a stub body will be produced by the expander. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-02-17 Thomas Quinot * sem_ch12.adb (Ana

MAINTAINERS: delete self from "Write After Approval"

2012-02-17 Thread Walter Lee
Gerald Pfeifer tells me I am already a port maintainer, so I don't need to be listed in the "write after approval" section. This patch fixes that and has been committed. Walter Index: ChangeLog === --- ChangeLog (revision 184338)

[Ada] Allocation of controlled private type with unknown discriminants

2012-02-17 Thread Arnaud Charlet
This patch ensures that the finalization machinery properly locates primitive Finalize_Address when the designated type is private, has unknown discriminants and is controlled. -- Source -- -- types.ads with Ada.Finalization; use Ada.Finalization; package Types is t

[Ada] Don't flag No_Obsolescent_Features violations in instances

2012-02-17 Thread Arnaud Charlet
This patch avoids flagging violations of the No_Obsolescent_Features restriction in generic instances. Such diagnostics are redundant since the violation will be flagged in the template anyway. The following is a test of this patch gnat.adc contains pragma Restrictions (No_Obsolescent_Features);

[Ada] Check that an aggregate is not Externally_Built

2012-02-17 Thread Arnaud Charlet
Add missing check for aggregate libraries consistency. Tested on x86_64-pc-linux-gnu, committed on trunk 2012-02-17 Pascal Obry * prj-nmsc.adb: prj-nmsc.adb (Check_Aggregated): Check that an aggregate is not Externally_Built. Index: prj-nmsc.adb ==

[Ada] Better warning for failure to override an abstract operation in an instance

2012-02-17 Thread Arnaud Charlet
An operation declared in the private part of a generic package is overriding in an instane only if it was overriding in the generic. If an instantiation fails because a non-abstract type has a remaining abstract inherited operation it may be because of a failure to override. This patch produces a w

Re: [PATCH] Fix up --enable-initfini-array autodetection in configure (PR bootstrap/50237)

2012-02-17 Thread Rainer Orth
Rainer Orth writes: > Richard Guenther writes: > >> I'm not sure about the varasm.c change - it's definitely not a no-op >> (callback will be not set, and the flags will be different). Certainly > > As I've demonstrated in my response to H.J., the effect with gas is none. > >> the current code

[PATCH] Fix (X & C1) | C2 folding (PR tree-optimization/52286)

2012-02-17 Thread Jakub Jelinek
Hi! The following testcase is miscompiled (by CCP, or, if -fno-tree-ccp, by VRP), because the (X & C1) | C2 folding changes the C1 constant into an integer constant with most significant bit set, but not sign-extended into the double_int. Fixed by using double_int_to_tree which extends it properl

Re: [v3] Disable gthreads on Solaris 8/9 (PR libstdc++/52189)

2012-02-17 Thread Rainer Orth
Jonathan Wakely writes: > For the HTML docs, just check in without that bit in the ChangeLog. > Regenerating the HTML changes almost every page because links between > sections get randomly-generated anchor names, so I'll just do an > update for doc/html/* once your change is checked in. Ok, I s

Re: [Patch, Fortran, committed] Fix various misspellings

2012-02-17 Thread Tobias Burnus
I missed one issue because it was in the bug summary while the bug description ("also in the same line") mentioned a different bug. The attached patch now fixes also the bug of the summary. (Rev. 184334.) Note to self: Read bug descriptions more carefully and also read the summary line. Tobi

Re: [google/integration] Add support for powerpc64-grtev2-linux-gnu (issue5659050)

2012-02-17 Thread Diego Novillo
On 16/02/12 20:00 , Doug Kwan (關振德) wrote: Hi Diego& Ollie, Could you guys take a look? -Doug On Mon, Feb 13, 2012 at 6:41 PM, Doug Kwan wrote: Hi, This patch adds support for powerpc*-grtev2-linux-gnu. The changes include: 1. Relocating the dynamic linker using a run-time root pref

Re: [google/main] Check for cross-compilers in validate_failures.py (issue5674087)

2012-02-17 Thread Diego Novillo
On 17/02/12 05:49 , Doug Kwan wrote: 2012-02-17 Doug Kwan * contrib/testsuite-management/validate_failures.py (def GetMakefileValue): Check for cross compilers. OK. Thanks. Diego.

[patch stor-layout]: Fix PR 52238 - -mms-bitfields: __attribute__ ((aligned (n))) ignored for struct members

2012-02-17 Thread Kai Tietz
Hi, this patch fixes old regression about ms-bitfields structure layout. This patch was verified by VLC community and libAV people (as to see in bug-report). The result of the structure-layout was also compared to VC's 32-bit and 64-bit result by VLC people. ChangeLog 2012-02-17 Kai Tietz

Re: [Patch, libfortran] RFC: Shared vtables, constification

2012-02-17 Thread Janne Blomqvist
On Mon, Feb 13, 2012 at 23:04, Steven Bosscher wrote: > On Mon, Feb 13, 2012 at 7:20 PM, Janne Blomqvist > wrote: >> Hi, >> >> the attached patch changes the low-level libgfortran IO dispatching >> mechanism to use shared vtables for each stream type, instead of all >> the function pointers being

Re: [Patch, Fortran, committed] Fix some typos in .texi

2012-02-17 Thread Tobias Burnus
On 02/17/2012 12:15 PM, Tobias Burnus wrote: Committed as Rev. 184332. I just saw that one line didn't only have a typo but also a grammar bug. Fix that one now as attached. (Rev. 184333.) Tobias Index: gfortran.texi === --- gfo

[Patch, Fortran, committed] Fix some typos in .texi

2012-02-17 Thread Tobias Burnus
Committed as Rev. 184332. Tobias Index: gfortran.texi === --- gfortran.texi (revision 184330) +++ gfortran.texi (working copy) @@ -795,7 +795,7 @@ override type-bound procedures or to have deferred @item Polymorphic entities (``@c

[Patch, Fortran, committed] Fix various misspellings

2012-02-17 Thread Tobias Burnus
I committed (Rev. 184331) the attached patch as obvious. Thanks to all translators at translationproject.org for their work - and in particular to Roland, who reported all the issues below. See also PR 52274 for remaining translation-related issues. * * * General GCC status: 0 P1, 64 P2, 12

[google/main] Check for cross-compilers in validate_failures.py (issue5674087)

2012-02-17 Thread Doug Kwan
Hi Diego, This patch fixes a problem of the validate_failures.py script that it rejects cross compilers. I have tested it by running the script in the build directory of gcc configure for arm-unknown-linux-gnueabi. I also tested it on a native compiler for x86. This should go to both google/

Re: obvious(?) typo in libstdc++-v3/src/c++98/locale.cc

2012-02-17 Thread Jonathan Wakely
On 15 February 2012 20:09, DJ Delorie wrote: > > The typo is obvious, but whether or not the wrapped code still works > isn't (to me). > >        * src/c++98/locale.cc (locale::facet::_S_get_c_locale): Fix typo. I must have looked at that code dozens of times and never seen it! :-\ I wonder if t

Re: [PATCH 2/9] [doloop] Correct extracting loop exit condition

2012-02-17 Thread Richard Sandiford
Andrey Belevantsev writes: > On 30.09.2011 19:21, Roman Zhuykov wrote: >> 2011/7/22 Richard Sandiford: >>> That's pre-approved (independently of the other patches) if it works. > ... >> Changed like the following. Will commit if no objections after a couple of >> days. > > We forgot to commit thi

C++ PATCH for c++/52248 (ICE with -ftime-report and undefined label)

2012-02-17 Thread Jason Merrill
Here we can get to define_label from within poplevel, which results in recursive starting of TV_NAME_LOOKUP. The obvious solution is to just use cond_start/stop in define_label. Tested x86_64-pc-linux-gnu, applying to trunk. commit 4e0a90cdec5d3e1b29335eb8c63c6a6885e0f674 Author: Jason Merrill