Re: PATCH: Replace tmp with __tmp

2011-09-16 Thread Andreas Schwab
"H.J. Lu" writes: > diff --git a/gcc/config/i386/bmiintrin.h b/gcc/config/i386/bmiintrin.h > index af5d9dc..72ab114 100644 > --- a/gcc/config/i386/bmiintrin.h > +++ b/gcc/config/i386/bmiintrin.h > @@ -42,8 +42,8 @@ __tzcnt_u16 (unsigned short __X) > extern __inline unsigned int __attribute__((__

PATCH: Replace tmp with __tmp

2011-09-16 Thread H.J. Lu
Hi, We should use __tmp instead of tmp in intrinsics. OK for trunk? Thanks. H.J. --- 2011-09-16 H.J. Lu * config/i386/bmiintrin.h: Replace tmp with __tmp. * config/i386/tbmintrin.h: Likewise. diff --git a/gcc/config/i386/bmiintrin.h b/gcc/config/i386/bmiintrin.h index af5d9

Go patch committed: Better errors for invalid [...]type

2011-09-16 Thread Ian Lance Taylor
This patch to the Go frontend improves the error handling for invalid use of [...]type, which may be only used with a composite literal. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/parse.cc

Go patch committed: send/recieve on nil channel blocks forever

2011-09-16 Thread Ian Lance Taylor
The Go language was clarified so that a send/receive on a nil channel blocks forever, which makes nil channels not very useful but consistent with select. This patch implements that. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian Index: libgo/runtime/

C++ PATCH for c++/50424 (wrong code with throwing default argument)

2011-09-16 Thread Jason Merrill
We collect information about whether a function can throw as we compile the function: if we build up a call that can throw, then the current function can throw, too. But we weren't doing the same for default arguments used in a call, which might themselves contain calls that can throw. Teste

Re: [PATCH] Add VIS intrinsics header for sparc.

2011-09-16 Thread David Miller
From: Eric Botcazou Date: Fri, 16 Sep 2011 23:01:56 +0200 >> Eric, any objections? > > None, this looks OK to me. Thanks Eric, I'll check this in.

Re: [RFC] Add FMA support to sparc backend

2011-09-16 Thread David Miller
From: Eric Botcazou Date: Fri, 16 Sep 2011 22:53:09 +0200 >> There have never been TFmode float operations implemented in hardware >> ever for sparc, and I doubt we'll see it in the future. >> >> And this applies also to the FMA instructions. > > Do the specs totally disregard quad floats for FM

Re: [PATCH] Add VIS intrinsics header for sparc.

2011-09-16 Thread Eric Botcazou
> I considered trying to make a set of VIS headers compatible with the > vis_*.h headers Sun provides in medialib and Sun Studio, but that's > not possible since we use fundamentally different types in the > builtins provided by GCC. > > Sun uses "double" and "float" in the declarations whereas we

Re: [RFC] Add FMA support to sparc backend

2011-09-16 Thread Eric Botcazou
> There have never been TFmode float operations implemented in hardware > ever for sparc, and I doubt we'll see it in the future. > > And this applies also to the FMA instructions. Do the specs totally disregard quad floats for FMA or...? > And especially since the presence of the FMA patterns is

Re: [libgomp] Pass CC to the libgomp testsuite to capture -sysroot

2011-09-16 Thread Diego Novillo
On Fri, Sep 16, 2011 at 16:49, Diego Novillo wrote: > On 11-09-16 16:40 , Mike Stump wrote: >> >> On Sep 16, 2011, at 1:13 PM, Diego Novillo wrote: >>> >>> I would like to push this libgomp patch upstream.  We need it to pass >>> sysroot to GCC when testing libgomp. >> >> I'd be curious if Ian lik

Re: [libgomp] Pass CC to the libgomp testsuite to capture -sysroot

2011-09-16 Thread Diego Novillo
On 11-09-16 16:40 , Mike Stump wrote: On Sep 16, 2011, at 1:13 PM, Diego Novillo wrote: I would like to push this libgomp patch upstream. We need it to pass sysroot to GCC when testing libgomp. I'd be curious if Ian likes this... Can one still set GCC_UNDER_TEST in the site.exp file or do o

Re: [Ada] fix potential memory corruption in annotated value cache

2011-09-16 Thread Eric Botcazou
> Some possible fixes I considered were: > > 1. inserting on entry (as is), allocating the cache entry right away, > and *always* filling it before returning > > 2. inserting on entry (as is), allocating the cache entry right away, > and releasing it before returning unless we're filling it in > >

Re: [libgomp] Pass CC to the libgomp testsuite to capture -sysroot

2011-09-16 Thread Mike Stump
On Sep 16, 2011, at 1:13 PM, Diego Novillo wrote: > I would like to push this libgomp patch upstream. We need it to pass > sysroot to GCC when testing libgomp. I'd be curious if Ian likes this... Can one still set GCC_UNDER_TEST in the site.exp file or do other unholy things with it after your

Re: [RFC] Add FMA support to sparc backend

2011-09-16 Thread David Miller
From: Eric Botcazou Date: Fri, 16 Sep 2011 22:25:41 +0200 > What's the story with TFmode for FMA? There have never been TFmode float operations implemented in hardware ever for sparc, and I doubt we'll see it in the future. And this applies also to the FMA instructions. And especially since th

Re: [RFC] Add FMA support to sparc backend

2011-09-16 Thread Eric Botcazou
> Second, like rs6000 the sparc negate fused multiply instructions > negate the full result, not the multiply result. So we cannot use > those instructions for the fnmadf4/fnmsdf4/fnmasf4/fnmssf4 patterns. > Since rs6000 provides patterns for such negate operations (presumably > just in case the c

[libgomp] Pass CC to the libgomp testsuite to capture -sysroot

2011-09-16 Thread Diego Novillo
I would like to push this libgomp patch upstream. We need it to pass sysroot to GCC when testing libgomp. Tested on x86_64. OK for trunk? Thanks. Diego. -- Forwarded message -- From: Simon Baldwin Date: Fri, Jan 28, 2011 at 11:30 Subject: [google] Pass CC to the libgomp tes

Re: [PATCH] Add VIS intrinsics header for sparc.

2011-09-16 Thread David Miller
From: Jakub Jelinek Date: Fri, 16 Sep 2011 21:07:09 +0200 > On Fri, Sep 16, 2011 at 03:02:07PM -0400, David Miller wrote: >> +extern __inline void * >> +__attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) >> +__vis_alignaddr (void *__A, long __B) >> +{ >> +return __builtin_vis

Re: [PATCH] Add VIS intrinsics header for sparc.

2011-09-16 Thread Jakub Jelinek
On Fri, Sep 16, 2011 at 03:02:07PM -0400, David Miller wrote: > +extern __inline void * > +__attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > +__vis_alignaddr (void *__A, long __B) > +{ > + return __builtin_vis_alignaddr(__A, __B); Just formatting nits, two spaces instead of

[PATCH] Add VIS intrinsics header for sparc.

2011-09-16 Thread David Miller
I've been meaning to toss something like this together for a while. If we were going to do this, I wanted to get it out of the way before adding VIS2 and VIS3 support. I considered trying to make a set of VIS headers compatible with the vis_*.h headers Sun provides in medialib and Sun Studio, bu

[RFC PATCH] AVX2 32-byte integer min/max reductions

2011-09-16 Thread Jakub Jelinek
On Fri, Sep 16, 2011 at 06:20:52PM +0200, Jakub Jelinek wrote: > So, either we can fix this by adding > reduc_{smin,smax,umin,umax}_v{32q,16h,8s,4d}i > patterns (at that point I guess I should just macroize them together with > the reduc_{smin,smax,umin,umax}_v{4sf,8sf,4df}) and handle the 4 32-by

Re: [Patch,AVR]: Fix PR 50358

2011-09-16 Thread Denis Chertykov
2011/9/16 Georg-Johann Lay : > Georg-Johann Lay schrieb: >> Denis Chertykov schrieb: >>> 2011/9/12 Georg-Johann Lay : This patch introduces patterns for multiply-add and multiply-sub. On the enhanced core, these operations can be performed with the product in R0; there is

Re: [Trunk/GCC 4.6] Re: [google] Omit date from Fortran .mod files for reproducible builds

2011-09-16 Thread Diego Novillo
On Fri, Jan 28, 2011 at 13:00, Diego Novillo wrote: > On Fri, Jan 28, 2011 at 06:19, Tobias Burnus wrote: >> We (Janne and I) think this patch can also be applied to the GCC 4.6 trunk; >> as the date is never read there is also no .mod ABI issue. >> >> I assume that there are no copyright issues.

Re: [PATCH] fix PR ada/42978

2011-09-16 Thread Simon Wright
On 8 Feb 2010, at 14:18, Arnaud Charlet wrote: >> OK, second try. >> >> Tested on gcc version 4.5.0 20100207 (experimental) [trunk revision 156574] >> (GCC). >> >> 2010-02-07 Simon Wright >> >> PR ada/42978 >> * mlib-utl.adb (Ar): Output ranlib options if verbose. > > This is OK,

Re: [Patch,AVR]: Fix PR 50358

2011-09-16 Thread Georg-Johann Lay
Georg-Johann Lay schrieb: > Denis Chertykov schrieb: >> 2011/9/12 Georg-Johann Lay : >>> This patch introduces patterns for multiply-add and multiply-sub. >>> >>> On the enhanced core, these operations can be performed with the product in >>> R0; >>> there is no need to MOVW it out of that registe

Re: Vector Comparison patch

2011-09-16 Thread Richard Henderson
On 08/29/2011 04:41 AM, Paolo Bonzini wrote: > The definition in OpenCL makes zero sense to me. For byte operands > it is custom-tailored after the SSE PMOVMSKB instruction, but there > is no PMOVMSKW/PMOVMSKD instruction so you would need very slow bit > shift operations before PMOVMSK. On the o

Re: [Patch,AVR]: Fix PR 50358

2011-09-16 Thread Georg-Johann Lay
Denis Chertykov schrieb: > 2011/9/12 Georg-Johann Lay : >> This patch introduces patterns for multiply-add and multiply-sub. >> >> On the enhanced core, these operations can be performed with the product in >> R0; >> there is no need to MOVW it out of that register. The code is smaller and >> fas

Re: [PATCH, libiberty] correct md5_process_bytes with unaligned pointers

2011-09-16 Thread Basile Starynkevitch
On Fri, 16 Sep 2011 14:46:57 +0200 Pierre Vittet wrote: > Hello, [...] > The patch also remove a preprocessor #if testing if > _STRING_ARCH_unaligned is defined. This symbol is never defined in gcc > and could be only used in CFLAGS. Looking at the code, it does not looks > usefull to define it

[v3] Add std::array testcase + other minor housekeeping

2011-09-16 Thread Paolo Carlini
Hi, tested x86_64-linux, -Wall too, committed to mainline. Paolo. // 2011-09-16 Paolo Carlini * testsuite/23_containers/array/comparison_operators/ less_or_equal.cc: New. * testsuite/23_containers/array/comparison_operators/ greater_or

[RFC PATCH] AVX2 32-byte integer {s,u}m{in,ax} and vcond{,u} patterns

2011-09-16 Thread Jakub Jelinek
Hi! On Fri, Sep 16, 2011 at 01:24:53PM +0200, Jakub Jelinek wrote: > Surprisingly with -mavx2 the integer loops aren't vectorized with > 32-byte vectors, wonder why. But looking at the integer umin/umax/smin/smax > 16-byte reductions they generate good code even without reduc_* patterns, > appare

Re: [RFC PATCH] Improve -mavx{,2} vector extraction

2011-09-16 Thread Richard Henderson
On 09/16/2011 08:22 AM, Jakub Jelinek wrote: > * config/i386/sse.md (vec_extract_hi_, > vec_extract_hi_v16hi, vec_extract_hi_v32qi): Use > vextracti128 instead of vextractf128 for -mavx2 and > integer vectors. For V4DFmode fix up mode attribute. > (VEC_EXTRACT_MODE):

Re: [RFC PATCH] Improve V8SFmode and V4DFmode smin/smax reductions

2011-09-16 Thread Richard Henderson
On 09/16/2011 04:24 AM, Jakub Jelinek wrote: > * config/i386/i386.c (ix86_expand_reduc_v4sf): Rename to ... > (ix86_expand_reduc): ... this. Handle also V8SFmode and V4DFmode. > * config/i386/sse.md (reduc_splus_v4sf, reduc_smax_v4sf, > reduc_smin_v4sf): Adjust callers. >

Re: [RFC PATCH] Improve -mavx{,2} vector extraction

2011-09-16 Thread Jakub Jelinek
On Fri, Sep 16, 2011 at 11:16:44AM +0200, Jakub Jelinek wrote: > The avx2_extracti128 pattern looked like wrong RTL, as to extract > a 2 element vector from 4 element vector it used just one constant > in the parallel instead of two. I've changed it into a define_expand. Actually there were two f

Ping^3: PR 50113/50061: Fix ABI breakage from emit_library_call_value_1 patch

2011-09-16 Thread Richard Sandiford
Ping for this patch to emit_library_call_value_1: http://gcc.gnu.org/ml/gcc-patches/2011-08/msg00735.html which fixes a bootstrap failure on MIPS since: http://gcc.gnu.org/ml/gcc-patches/2011-06/msg02341.html Tested on mips64-linux-gnu, mips-sgi-irix6.5 (by Rainer) and on both big and l

Re: inline-analysis improvement

2011-09-16 Thread Eric Botcazou
> * ipa-inline-analysis.c (add_condition): Add conditions parameter; > simplify obviously true clauses. > (and_predicates, or_predicates): Add conditions parameter. > (inline_duplication_hoook): Update. > (mark_modified): New function. > (unmodified_parm): New fu

partial fix for PR lto/50430

2011-09-16 Thread Jan Hubicka
Hi, this patch fixes ICE seen when compiling libreoffice. Sadly I didn't get any testcase since libreoffice one desn't reproduce with -r. The problem is external vtable whose constructor is not streamed, because we stream only constructors needed and we do not take external vars into account. Thi

Re: [PATCH] Do not store/stream binfos in jump functions

2011-09-16 Thread Jan Hubicka
> > * ipa-prop.h (jump_func_type): Updated comments. > (ipa_known_type_data): New type. > (ipa_jump_func): Use it to describe known type jump functions. > * ipa-prop.c (ipa_print_node_jump_functions_for_edge): Updated to > reflect the new known type jump function cont

[PATCH, libiberty] correct md5_process_bytes with unaligned pointers

2011-09-16 Thread Pierre Vittet
Hello, The patch is the result of the following threads: Here is a patch correcting md5_process_bytes when we are in the case of unaligned pointers.A pair of brace was missing, leading the buffer to be shift 2 times losing a part of its content. The patch also remove a preprocessor #if testing

[PATCH] Do not store/stream binfos in jump functions

2011-09-16 Thread Martin Jambor
Hi, this patch is basically a followup to http://gcc.gnu.org/ml/gcc-patches/2011-09/msg00398.html The problem is that BINFOs coming from different compilation units and which are streamed into jump-functions do not undergo any unification in LTO and we have the same value represented by different

[RFC PATCH] Improve V8SFmode and V4DFmode smin/smax reductions

2011-09-16 Thread Jakub Jelinek
Hi! I've noticed that the code generated for -mavx min/max reductions is terrible, the following patch is an attempt to improve it. In fad function (i.e. V4DFmode reduction) the difference with the patch (plus the patch I've posted today) is: - vmovapd %ymm0, -56(%rsp) - vmovapd %ymm0

[PATCH, 4.4] Backport of the fix for PR 49886 (again)

2011-09-16 Thread Martin Jambor
Hi, the patch below is a backport of the fix for PR 49886 as it is now in trunk except that we check for type attributes in ipa-split instead of in ipa-inline-analysis which does not exist in the 4.6 branch. The fix is almost the same as the one I have previously reverted but the !is_gimple_reg p

[RFC PATCH] Improve -mavx{,2} vector extraction

2011-09-16 Thread Jakub Jelinek
Hi! I've noticed vector extraction generates terrible code with -mavx{,2} when extracting something from 32-byte vectors. Everything is forced into memory, then loaded back. For extraction of first lane I believe we can just use standard 128-bit extraction from the %xmmN register corresponding to

[ARM] pass "--be8" to linker when linking for M profile

2011-09-16 Thread Bin Cheng
his so that the list is ordered alphabetically by > architecture/cpu (with architectures first). > > It might save some patch churn in the future if each element was put on > a line on its own. > > OK with that change. > > R. gcc-be8-for-m-profile-20110916.patch Description: Binary data

Re: [PATCH 6/7] Kill pedantic warnings on system headers macros

2011-09-16 Thread Dodji Seketeli
Jason Merrill writes: > On 07/16/2011 10:37 AM, Dodji Seketeli wrote: > > + location_t here = c_parser_peek_token (parser)->location; > > Perhaps "first_token_loc"? OK, changed. > > > + SYNTAX_ERROR2_AT (prev_virtual_location, > > + "missing binary opera

Re: [Patch, gcc, testsuite] Use long enums for case foldconst-3.c for target ARM EABI.

2011-09-16 Thread Richard Earnshaw
On 16/09/11 09:28, Terry Guo wrote: >> This is a compile-only test, and -fno-short-enums is a global option >> that all targets support, so I'd suggest just adding -fno-short-enums >> to >> the standard list of options. It won't hurt those platforms where that >> is already the default and it will

RE: [Patch, gcc, testsuite] Use long enums for case foldconst-3.c for target ARM EABI.

2011-09-16 Thread Terry Guo
> This is a compile-only test, and -fno-short-enums is a global option > that all targets support, so I'd suggest just adding -fno-short-enums > to > the standard list of options. It won't hurt those platforms where that > is already the default and it will fix the testcase problem for all > those

Re: [Ada] fix potential memory corruption in annotated value cache

2011-09-16 Thread Jakub Jelinek
On Fri, Sep 16, 2011 at 04:02:32AM -0300, Alexandre Oliva wrote: > - struct tree_int_map in; > + struct tree_int_map **h; > + >if (!annotate_value_cache) > annotate_value_cache = htab_create_ggc (512, tree_int_map_hash, > tree

Re: do not copy DEBUG_EXPRs in copy_insn

2011-09-16 Thread Jakub Jelinek
On Fri, Sep 16, 2011 at 04:04:54AM -0300, Alexandre Oliva wrote: > from Alexandre Oliva > > * emit-rtl.c (copy_insn_1): Do not copy DEBUG_EXPRs. This is ok. Jakub

Re: [Patch, gcc, testsuite] Use long enums for case foldconst-3.c for target ARM EABI.

2011-09-16 Thread Richard Earnshaw
On 11/09/11 02:39, Terry Guo wrote: > Hello, > > This patch aims to disable short enums for arm eabi otherwise the case will > fail to be compiled due to "width of 'code' exceeds its type". Is it OK to > trunk? > > BR, > Terry > > 2011-09-09 Terry Guo > > * gcc.dg/tree-ssa/foldconst-

Re: [PATCH 5/7] Add line map statistics to -fmem-report output

2011-09-16 Thread Dodji Seketeli
> On 07/16/2011 10:37 AM, Dodji Seketeli wrote: > > +#define ONE_M ONE_K * ONE_K > > Parenthesize this so that users don't need to. OK. > > > + macro_maps_used_size = > > +LINEMAPS_MACRO_USED (set) * sizeof (struct line_map) > > ++ macro_maps_locations_size; > > It seems odd to add in

Re: [PATCH 4/7] Support -fdebug-cpp option

2011-09-16 Thread Dodji Seketeli
Jason Merrill writes: > On 08/24/2011 10:06 AM, Tom Tromey wrote: >> Dodji> Would it be acceptable to just change the output of -fdirective to >> fit? >> Dodji> Or are we bound to not breaking existing consumers? >> >> I think changing it would be fine. > > I agree. I have added that to my TODO

do not copy DEBUG_EXPRs in copy_insn

2011-09-16 Thread Alexandre Oliva
copy_rtx avoids duplicating DEBUG_EXPRs, so that they map one-to-one to DEBUG_EXPR_DECLs, but copy_insn lacks these smarts. This was exposed by a patch I'm working on, that uses RTL flags in DEBUG_EXPRs to speed up expansion of var location notes within var-tracking. Regstrapped on i686-pc-linux-

Re: [PATCH 3/7] Emit macro expansion related diagnostics

2011-09-16 Thread Dodji Seketeli
> On 08/04/2011 11:32 AM, Dodji Seketeli wrote: > > +++ b/gcc/diagnostic.c > > @@ -30,6 +30,7 @@ along with GCC; see the file COPYING3. If not see > > #include "input.h" > > #include "intl.h" > > #include "diagnostic.h" > > +#include "vec.h" > > Do you still need this? Oops, no. Removed and

RE: [Patch, gcc, testsuite] Use long enums for case foldconst-3.c for target ARM EABI.

2011-09-16 Thread Terry Guo
Ping. BR, Terry > -Original Message- > From: Terry Guo [mailto:terry@arm.com] > Sent: Sunday, September 11, 2011 9:39 AM > To: gcc-patches@gcc.gnu.org > Cc: r...@cebitec.uni-bielefeld.de > Subject: [Patch, gcc, testsuite] Use long enums for case foldconst-3.c > for target ARM EABI. >

[Ada] fix potential memory corruption in annotated value cache

2011-09-16 Thread Alexandre Oliva
A -fcompare-debug regression in s-regexp.adb on x86_64-linux-gnu turned out to be caused by a hashtable management error in annotate_value(). We ask for an insertion and leave the allocated slot empty while proceeding to other computations that might (a) return without filling it in, or (b) recurse

Re: Fortran Patches

2011-09-16 Thread Janus Weil
Hi Tobias, > could you also patches, which you commit as obvious to the mailing lists? yes, I usually do this, but this time I just forgot. Sorry. > Regarding the last patch, the GNU style puts a line break after the ")" in: > > +  if (!sym) return NULL; > + In principle I'm aware of the GNU c