[Bug tree-optimization/64269] [4.8/4.9/5 Regression] ICE with -O3 enabled on Ubuntu 14.04

2014-12-13 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64269 --- Comment #7 from Jakub Jelinek --- Author: jakub Date: Sat Dec 13 08:43:09 2014 New Revision: 218703 URL: https://gcc.gnu.org/viewcvs?rev=218703&root=gcc&view=rev Log: Backported from mainline 2014-12-12 Jakub Jelinek PR tree-

[Bug tree-optimization/64269] [4.8/4.9/5 Regression] ICE with -O3 enabled on Ubuntu 14.04

2014-12-13 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64269 --- Comment #8 from Jakub Jelinek --- Author: jakub Date: Sat Dec 13 08:57:05 2014 New Revision: 218704 URL: https://gcc.gnu.org/viewcvs?rev=218704&root=gcc&view=rev Log: Backported from mainline 2014-12-12 Jakub Jelinek PR tree-

[Bug tree-optimization/64269] [4.8/4.9/5 Regression] ICE with -O3 enabled on Ubuntu 14.04

2014-12-13 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64269 Jakub Jelinek changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug tree-optimization/64295] New: [5 Regression] ICE: SIGSEGV (infinite recursion) with -frounding-math -funsafe-math-optimizations

2014-12-13 Thread zsojka at seznam dot cz
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64295 Bug ID: 64295 Summary: [5 Regression] ICE: SIGSEGV (infinite recursion) with -frounding-math -funsafe-math-optimizations Product: gcc Version: 5.0 Status: UNCONFIRMED

[Bug tree-optimization/63551] [4.9/5 Regression] wrong code (segfaults) at -Os on x86_64-linux-gnu

2014-12-13 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63551 --- Comment #11 from Jakub Jelinek --- The gcc.dg/ipa/pr63551.c test fails on the 4.9 branch on 32-bit targets (i386, arm, s390): gcc.dg/ipa/pr63551.c:24:9: warning: this decimal constant is unsigned only in ISO C90 Seems the test is equally misc

[Bug middle-end/64028] [5 Regression] r211599 caused many vectorizer test failures with -fPIC

2014-12-13 Thread ubizjak at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64028 Uroš Bizjak changed: What|Removed |Added Target||i686 Status|UNCONFIRMED

[Bug middle-end/64028] [5 Regression] r211599 caused many vectorizer test failures with -fPIC

2014-12-13 Thread ubizjak at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64028 --- Comment #3 from Uroš Bizjak --- (In reply to Uroš Bizjak from comment #2) > Confirmed. Still happens on trunk [1]. [1] https://gcc.gnu.org/ml/gcc-testresults/2014-12/msg01629.html

[Bug middle-end/58624] gcc internal compiler error: Segmentaion fault in insert_to_assembler_name_hash

2014-12-13 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58624 Jakub Jelinek changed: What|Removed |Added CC||jakub at gcc dot gnu.org --- Comment #13

[Bug jit/64296] New: link failure of libgccjit.so for "in tree" gmp/mpc/mpfr/isl

2014-12-13 Thread alfred.minarik.1 at aon dot at
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64296 Bug ID: 64296 Summary: link failure of libgccjit.so for "in tree" gmp/mpc/mpfr/isl Product: gcc Version: 5.0 Status: UNCONFIRMED Severity: normal Prio

[Bug bootstrap/64023] [5 Regression] r216964 breaks bootstrap on darwin when using gcc as the bootstrap compiler.

2014-12-13 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64023 --- Comment #6 from Jakub Jelinek --- Author: jakub Date: Sat Dec 13 11:24:37 2014 New Revision: 218705 URL: https://gcc.gnu.org/viewcvs?rev=218705&root=gcc&view=rev Log: PR bootstrap/64023 * Makefile.tpl (EXTRA_TARGET_FLAGS): Set STAGE1

[Bug target/53513] [SH] Add support for fschg and fpchg insns and improve fenv support

2014-12-13 Thread olegendo at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53513 --- Comment #44 from Oleg Endo --- Author: olegendo Date: Sat Dec 13 13:17:55 2014 New Revision: 218707 URL: https://gcc.gnu.org/viewcvs?rev=218707&root=gcc&view=rev Log: gcc/testsuite/ PR target/53513 * gcc.target/sh/attr-isr-nosave_low

[Bug c++/64297] New: [5 Regression] ICE: canonical types differ for identical types

2014-12-13 Thread reichelt at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64297 Bug ID: 64297 Summary: [5 Regression] ICE: canonical types differ for identical types Product: gcc Version: 5.0 Status: UNCONFIRMED Severity: normal P

[Bug c++/64297] [5 Regression] ICE: canonical types differ for identical types

2014-12-13 Thread reichelt at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64297 Volker Reichelt changed: What|Removed |Added Keywords||ice-on-valid-code Known to work|

[Bug c++/57846] CRTP, templates, metaprogramming, forwarding and static member

2014-12-13 Thread harald at gigawatt dot nl
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57846 Harald van Dijk changed: What|Removed |Added CC||harald at gigawatt dot nl --- Comment

[Bug ipa/64298] New: [5 Regression] ICE: Segmentation fault in get_binfo_at_offset at tree.c:11914

2014-12-13 Thread danglin at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64298 Bug ID: 64298 Summary: [5 Regression] ICE: Segmentation fault in get_binfo_at_offset at tree.c:11914 Product: gcc Version: 5.0 Status: UNCONFIRMED Severity: nor

[Bug tree-optimization/64295] [5 Regression] ICE: SIGSEGV (infinite recursion) with -frounding-math -funsafe-math-optimizations

2014-12-13 Thread jakub at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64295 Jakub Jelinek changed: What|Removed |Added Priority|P3 |P1 Status|UNCONFIRMED

[Bug target/64299] New: [SH] improve FPSCR.PR mode switching by reordering insns

2014-12-13 Thread olegendo at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64299 Bug ID: 64299 Summary: [SH] improve FPSCR.PR mode switching by reordering insns Product: gcc Version: 5.0 Status: UNCONFIRMED Severity: normal Priorit

[Bug c++/64293] [C++14] explicit instantiation declaration suppresses instantiation of constexpr constructor

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64293 Ville Voutilainen changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c++/63604] [C++11] A direct-initialization of a reference should use explicit conversion functions

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63604 Ville Voutilainen changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c++/63296] g++ reports incomplete type for static template member of template class

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63296 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/63378] decltype and access control issues

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63378 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/63263] friend declaration of function template specialization gets confused when specialization was forward declared.

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63263 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/63217] template conversion operator returning const reference not used for conversion in some cases

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63217 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug target/64300] New: s390x, ICE, unable to generate reloads, in curr_insn_transform, at lra-constraints.c

2014-12-13 Thread jan.kratochvil at redhat dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64300 Bug ID: 64300 Summary: s390x, ICE, unable to generate reloads, in curr_insn_transform, at lra-constraints.c Product: gcc Version: 5.0 Status: UNCONFIRMED Severi

[Bug c++/61648] g++ accepts literal operator friends for non-template classes but not for *template* classes

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61648 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/61936] template template friends fail to compile.

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61936 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/63149] wrong auto deduction from braced-init-list

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63149 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug middle-end/64292] [5.0 regression] FAIL: g++.dg/torture/pr60474.C -O1 (internal compiler error)

2014-12-13 Thread mpolacek at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64292 Marek Polacek changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed|

[Bug c++/64301] New: TrinityCore error

2014-12-13 Thread jean...@redstone-city.de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64301 Bug ID: 64301 Summary: TrinityCore error Product: gcc Version: 4.7.2 Status: UNCONFIRMED Severity: normal Priority: P3 Component: c++ Assignee: unassig

[Bug c++/64301] TrinityCore error

2014-12-13 Thread jean...@redstone-city.de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64301 jean...@redstone-city.de changed: What|Removed |Added Component|middle-end |c++ --- Comment #1 from jean..

[Bug middle-end/64301] TrinityCore error

2014-12-13 Thread pinskia at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64301 Andrew Pinski changed: What|Removed |Added Component|c++ |middle-end --- Comment #2 from Andrew Pi

[Bug middle-end/64301] TrinityCore error

2014-12-13 Thread jean...@redstone-city.de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64301 jean...@redstone-city.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--

[Bug other/59242] Ensure correct FLAGS are used at various stages of the build

2014-12-13 Thread benedikt.morbach at googlemail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59242 Benedikt Morbach changed: What|Removed |Added CC||benedikt.morbach@googlemail

[Bug middle-end/64301] TrinityCore error

2014-12-13 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64301 Jonathan Wakely changed: What|Removed |Added Resolution|FIXED |WORKSFORME

[Bug rtl-optimization/64294] invalid code, zero check gets optimized away

2014-12-13 Thread gcc at breakpoint dot cc
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64294 Sebastian Andrzej Siewior changed: What|Removed |Added Attachment #34272|0 |1 is obsolete|

[Bug rtl-optimization/64294] invalid code, zero check gets optimized away

2014-12-13 Thread gcc at breakpoint dot cc
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64294 --- Comment #4 from Sebastian Andrzej Siewior --- Created attachment 34276 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34276&action=edit tc-static function

[Bug rtl-optimization/64294] invalid code, zero check gets optimized away

2014-12-13 Thread gcc at breakpoint dot cc
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64294 Sebastian Andrzej Siewior changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resoluti

[Bug libstdc++/64239] regex_iterator::operator= should copy match_results::position

2014-12-13 Thread timshen at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64239 --- Comment #5 from Tim Shen --- Author: timshen Date: Sat Dec 13 22:19:18 2014 New Revision: 218710 URL: https://gcc.gnu.org/viewcvs?rev=218710&root=gcc&view=rev Log: PR libstdc++/64239 * include/bits/regex.h (match_results<>::match_res

[Bug libstdc++/64239] regex_iterator::operator= should copy match_results::position

2014-12-13 Thread timshen at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64239 --- Comment #6 from Tim Shen --- Author: timshen Date: Sat Dec 13 23:10:39 2014 New Revision: 218711 URL: https://gcc.gnu.org/viewcvs?rev=218711&root=gcc&view=rev Log: PR libstdc++/64239 * include/bits/regex.h (match_results<>::match_res

[Bug c++/63192] non-mutable lambda capture by value on reference does not apply const

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63192 Ville Voutilainen changed: What|Removed |Added Keywords||wrong-code Status|UNCONF

[Bug c++/63192] non-mutable lambda capture by value on reference does not apply const

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63192 --- Comment #2 from Ville Voutilainen --- Reduced: template struct same {static constexpr bool value = false;}; template struct same {static constexpr bool value = true;}; int main() { float x, &r = x; [=] { // x and r are not capture

[Bug c++/63151] Accessibility error when brace-constructing base class with protected defaulted constructor and member variable

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63151 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/62310] fails to consider default initializers (NSDMIs) when checking inheriting constructors

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62310 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/62276] ICE when non-variadic template template parameter is default argument of variadic template template parameter

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62276 Ville Voutilainen changed: What|Removed |Added Keywords||ice-on-valid-code Status

[Bug c++/62274] [C++11] Variadic templates expansion into non-variadic class template

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62274 Ville Voutilainen changed: What|Removed |Added CC||ville.voutilainen at gmail dot com

[Bug c++/62241] C++14 generalized lambda capture doesn't work with uniform initialization syntax.

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62241 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/60262] explicit destructor call via Derived to destructor of Base accepted without using a qualified-id

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60262 Ville Voutilainen changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c++/62207] ICE: tree check: expected tree that contains 'decl minimal' structure, have 'overload' in tsubst_copy, at cp/pt.c

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62207 Ville Voutilainen changed: What|Removed |Added CC||ville.voutilainen at gmail dot com

[Bug c++/62163] Dependent function call in constant expression produces error in template definition context

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62163 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/62110] Attempting to use template conversion operator in a contextual conversion

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62110 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/62134] [C++11] ICE with template alias

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62134 Ville Voutilainen changed: What|Removed |Added Keywords||ice-on-valid-code Status

[Bug c++/62134] [C++11] ICE with template alias

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62134 --- Comment #2 from Ville Voutilainen --- A reduced testcase would be nice.

[Bug c++/60511] [C++1y][N3652] Missing extended constexpr function support

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60511 Ville Voutilainen changed: What|Removed |Added CC||jason at redhat dot com,

[Bug c++/61953] [C++11] The template parameter pack of a function template should be the last template parameter

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61953 Ville Voutilainen changed: What|Removed |Added Keywords||accepts-invalid CC|

[Bug c++/61953] [C++11] The template parameter pack of a function template should be the last template parameter

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61953 Ville Voutilainen changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c++/61941] Mis-parsing of warn_unused_result function with ref-qualifiers

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61941 Ville Voutilainen changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c++/61937] Misleading errors due to constructor template deducing argument as void

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61937 Ville Voutilainen changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c++/61806] [C++11] Expression sfinae w/o access gives hard error in partial template specializations

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61806 Ville Voutilainen changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c++/59790] Inner template class specialization has no direct access to outer template class typedefs

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59790 Ville Voutilainen changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c++/57743] Code accepted by other recent compilers, but not by g++ - possibly failure to activate ADL

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57743 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/60105] [C++11] ICE on enable_if explicit cast operator

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60105 Ville Voutilainen changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug go/61244] gccgo: ICE in write_specific_type_functions [GoSmith]

2014-12-13 Thread ian at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61244 --- Comment #4 from ian at gcc dot gnu.org --- Author: ian Date: Sun Dec 14 00:55:01 2014 New Revision: 218715 URL: https://gcc.gnu.org/viewcvs?rev=218715&root=gcc&view=rev Log: PR go/61244 compiler: Traverse type descriptor expressions. Mo

[Bug c++/61726] Ambiguous overload resolution with inherited op()s

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61726 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/61683] decltype-specifier not accepted as mem-initializer-id

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61683 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/61663] [DR 976] Deduction for const T& conversion functions

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61663 Ville Voutilainen changed: What|Removed |Added Keywords||rejects-valid Status|UNC

[Bug c++/59480] Missing error diagnostic: friend declaration specifying a default argument must be a definition

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59480 Ville Voutilainen changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c++/61670] ICE on invalid in tree_nop_conversion

2014-12-13 Thread ville.voutilainen at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61670 Ville Voutilainen changed: What|Removed |Added CC||jason at redhat dot com,

[Bug middle-end/58624] gcc internal compiler error: Segmentaion fault in insert_to_assembler_name_hash

2014-12-13 Thread jason at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58624 --- Comment #14 from Jason Merrill --- (In reply to Jakub Jelinek from comment #13) > Jason, do you think that change (just the plugin.exp one) is ok for 4.8.4, Yes, that should be fine.