https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #34 from Matt Godbolt ---
Confirmed this fixes all the issues we were seeing. Thanks!
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
Martin Liška changed:
What|Removed |Added
Known to work|7.1.0 |7.0
--- Comment #33 from Martin Liška --
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #32 from Matt Godbolt ---
Thanks! One thing, I probably misunderstand this, but you've put 7.1 in "known
to work" above: is this on purpose? 7.1 is the version the issue comes up in, I
assume it'll be fixed in an upcoming 7.2 release?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
Martin Liška changed:
What|Removed |Added
Status|NEW |RESOLVED
Known to work|
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #30 from Martin Liška ---
Author: marxin
Date: Thu Jul 27 07:32:15 2017
New Revision: 250604
URL: https://gcc.gnu.org/viewcvs?rev=250604&root=gcc&view=rev
Log:
Backport r249833
2017-07-27 Martin Liska
Backport from mainl
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #29 from Ed Catmur ---
Created attachment 41750
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=41750&action=edit
stack-use-after-scope-read.cpp
Another testcase, no library required. Slight difference here is that the
offending
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #28 from Avi Kivity ---
It's a combination of several things:
1. We use antlr to generate a parser. The generated code allocates many local
variables in the same function
2. use-after-scope disabled -fstack-reuse=all
3. ASAN is quite
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #27 from Martin Liška ---
(In reply to Avi Kivity from comment #26)
> Thanks a lot for handling this issue.
You're welcome, I'm happy that it's a known issue and I don't have to dig in
the source base. It's quite large.
Anyhow, do y
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #26 from Avi Kivity ---
Thanks a lot for handling this issue.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #25 from Martin Liška ---
(In reply to Martin Liška from comment #24)
> Just run with current trunk and it works (it fails after a minute in
> ==13736==ERROR: AddressSanitizer: stack-overflow on address 0x2adb9b406e48
> (pc 0x067d
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #24 from Martin Liška ---
Just run with current trunk and it works (it fails after a minute in
==13736==ERROR: AddressSanitizer: stack-overflow on address 0x2adb9b406e48 (pc
0x067d8638 bp 0x2adb9b408020 sp 0x2adb9b406e30 T1)
So I'
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #23 from Martin Liška ---
(In reply to Martin Liška from comment #22)
> One more question, would it be possible to somehow attach gdb to the server
> which is tested? It will help me to debug where precisely is the stack
> poisoned?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #22 from Martin Liška ---
One more question, would it be possible to somehow attach gdb to the server
which is tested? It will help me to debug where precisely is the stack
poisoned?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #21 from Martin Liška ---
> The code uses user-level threads (makecontext/setcontext etc). It annotates
> the new stack during the switch, see for example
> https://github.com/scylladb/seastar/blob/master/core/thread.cc#L66.
> Suppose
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #20 from Avi Kivity ---
btw, you can try pulling from https://github.com/avikivity/scylla/tree/2546; it
has some fixes (specifically
https://github.com/avikivity/scylla/commit/408d540eda30b557ecc0ab07ac3d39b617b37c4c)
that fixed failu
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #19 from Avi Kivity ---
(In reply to Martin Liška from comment #18)
> I can confirm I can reproduce it. Now with just AddressSanitizer I see:
>
> ==5488==ERROR: AddressSanitizer: unknown-crash on address 0x7fa04c0092e0 at
> pc 0x
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #18 from Martin Liška ---
I can confirm I can reproduce it. Now with just AddressSanitizer I see:
==5488==ERROR: AddressSanitizer: unknown-crash on address 0x7fa04c0092e0 at pc
0x05ee3108 bp 0x7fa04c0091b0 sp 0x7fa04c0091a0
WRITE
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #17 from Avi Kivity ---
(In reply to Martin Liška from comment #16)
>
> Unfortunately I don't have any Fedora system to test it. Do you have any
> experience using Docker? This can be good candidate to reproduce that?
If you run the
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #16 from Martin Liška ---
(In reply to Avi Kivity from comment #15)
> Unfortunately, backporting your patch is not enough; it depends on another,
> and backporting the dependency generates many conflicts.
>
> There is now a ./install
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #15 from Avi Kivity ---
Unfortunately, backporting your patch is not enough; it depends on another, and
backporting the dependency generates many conflicts.
There is now a ./install-dependencies.sh in the scylla repositories, so to g
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #14 from Martin Liška ---
Ok, so as the project has quite some dependencies I'm not able to build. Please
try to use patched compiler.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #13 from Avi Kivity ---
Output:
$ build/debug/tests/view_schema_test_g -- --smp 1 -m 1G
WARNING: debug mode. Not for benchmarking or production
Running 60 test cases...
WARN 2017-07-10 11:41:14,955 seastar - Seastar compiled with de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #12 from Duarte ---
(In reply to Avi Kivity from comment #10)
> Oh, and a binary that triggers it is build/release/tests/view_schema_test.
Should be build/debug/tests/view_schema_test. For reference, other binaries
affected by this i
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #11 from Martin Liška ---
(In reply to Avi Kivity from comment #10)
> Oh, and a binary that triggers it is build/release/tests/view_schema_test.
Can you please provide the error from sanitizer, I can investigate the code
whether it's
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #9 from Avi Kivity ---
(In reply to Martin Liška from comment #8)
> (In reply to Avi Kivity from comment #7)
> > Hitting something similar-looking on Fedora 26's gcc 7.1.1.
>
> Can you please provide a test-case so that I can verify
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #10 from Avi Kivity ---
Oh, and a binary that triggers it is build/release/tests/view_schema_test.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #8 from Martin Liška ---
(In reply to Avi Kivity from comment #7)
> Hitting something similar-looking on Fedora 26's gcc 7.1.1.
Can you please provide a test-case so that I can verify it's the same issue?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #7 from Avi Kivity ---
Hitting something similar-looking on Fedora 26's gcc 7.1.1.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
Martin Liška changed:
What|Removed |Added
Known to work||8.0
Known to fail|
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #5 from Martin Liška ---
Author: marxin
Date: Fri Jun 30 08:51:00 2017
New Revision: 249833
URL: https://gcc.gnu.org/viewcvs?rev=249833&root=gcc&view=rev
Log:
Call BUILT_IN_ASAN_HANDLE_NO_RETURN before BUILT_IN_UNWIND_RESUME (PR
sani
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #4 from Martin Liška ---
Created attachment 41537
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=41537&action=edit
Untested patch
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
Martin Liška changed:
What|Removed |Added
CC||d.frey at gmx dot de
--- Comment #3 from
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
--- Comment #2 from Matt Godbolt ---
Thanks Martin!
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81021
Martin Liška changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Last reconfirmed|
34 matches
Mail list logo
