[Bug preprocessor/65852] Incorrect escaping in depfiles

2015-04-24 Thread ccoutant at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65852 Cary Coutant changed: What|Removed |Added CC||ccoutant at gmail dot com --- Comment #11

[Bug preprocessor/65852] Incorrect escaping in depfiles

2015-04-22 Thread paul_robinson at playstation dot sony.com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65852 --- Comment #10 from Paul Robinson --- I thought I had heard your name before! Howdy... Granted this is an obscure corner case, but they are legal filenames, using a leading # is less horrifying than a leading space, and the depfile that gcc p

[Bug preprocessor/65852] Incorrect escaping in depfiles

2015-04-22 Thread pinskia at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65852 --- Comment #9 from Andrew Pinski --- (In reply to Paul Robinson from comment #8) > Admittedly the gcc I have on Windows is *very* old, but it does not > normalize \ to / before writing the depfile. I know it is very old, I worked on it before l

[Bug preprocessor/65852] Incorrect escaping in depfiles

2015-04-22 Thread paul_robinson at playstation dot sony.com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65852 --- Comment #8 from Paul Robinson --- (In reply to Andrew Pinski from comment #7) > Hmm, I thought \ would be converted into / by the time we reach here for > windows. I wonder if that is the better fix. Admittedly the gcc I have on Windows is

[Bug preprocessor/65852] Incorrect escaping in depfiles

2015-04-22 Thread pinskia at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65852 --- Comment #7 from Andrew Pinski --- Hmm, I thought \ would be converted into / by the time we reach here for windows. I wonder if that is the better fix.

[Bug preprocessor/65852] Incorrect escaping in depfiles

2015-04-22 Thread paul_robinson at playstation dot sony.com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65852 --- Comment #6 from Paul Robinson --- (In reply to Andrew Pinski from comment #4) > Really for portability using \ and/or # should be avoided. I accept that, however we do have Windows clients trying to use Make, so \ is a fact of life. These a

[Bug preprocessor/65852] Incorrect escaping in depfiles

2015-04-22 Thread paul_robinson at playstation dot sony.com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65852 --- Comment #5 from Paul Robinson --- Compare how space and # are handled, to see the problem. They need to be handled the same way.

[Bug preprocessor/65852] Incorrect escaping in depfiles

2015-04-22 Thread pinskia at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65852 --- Comment #4 from Andrew Pinski --- Really for portability using \ and/or # should be avoided.

[Bug preprocessor/65852] Incorrect escaping in depfiles

2015-04-22 Thread pinskia at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65852 --- Comment #3 from Andrew Pinski --- Here is what the comment says in the source: /* Given a filename, quote characters in that filename which are significant to Make. Note that it's not possible to quote all such characters - e.g. \n, %,

[Bug preprocessor/65852] Incorrect escaping in depfiles

2015-04-22 Thread pinskia at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65852 --- Comment #2 from Andrew Pinski --- This was bug 35458 which says it was fixed in 4.4.0.

[Bug preprocessor/65852] Incorrect escaping in depfiles

2015-04-22 Thread paul_robinson at playstation dot sony.com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65852 Paul Robinson changed: What|Removed |Added Version|unknown |4.8.2 --- Comment #1 from Paul Robinson