[Bug preprocessor/49973] Column numbers count multibyte characters as multiple columns

2020-07-14 Thread manu at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973 Manuel López-Ibáñez changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug preprocessor/49973] Column numbers count multibyte characters as multiple columns

2020-07-14 Thread lhyatt at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973 --- Comment #23 from Lewis Hyatt --- Fixed for GCC 11, may I ask someone please to close the PR?

[Bug preprocessor/49973] Column numbers count multibyte characters as multiple columns

2020-07-14 Thread cvs-commit at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973 --- Comment #22 from CVS Commits --- The master branch has been updated by Lewis Hyatt : https://gcc.gnu.org/g:004bb936d6d5f177af26ad4905595e843d5665a5 commit r11-2092-g004bb936d6d5f177af26ad4905595e843d5665a5 Author: Lewis Hyatt Date: Tue J

[Bug preprocessor/49973] Column numbers count multibyte characters as multiple columns

2019-12-09 Thread dmalcolm at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973 --- Comment #21 from David Malcolm --- (In reply to David Malcolm from comment #20) > I've committed r279137 on Lewis's behalf, which fixes the issues identified > in patch #13. comment #13, I meant to say

[Bug preprocessor/49973] Column numbers count multibyte characters as multiple columns

2019-12-09 Thread dmalcolm at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973 --- Comment #20 from David Malcolm --- I've committed r279137 on Lewis's behalf, which fixes the issues identified in patch #13. As noted in review of the patch, we didn't attempt to change the behavior of diagnostic_get_location_text with this

[Bug preprocessor/49973] Column numbers count multibyte characters as multiple columns

2019-12-09 Thread dmalcolm at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973 --- Comment #19 from David Malcolm --- Author: dmalcolm Date: Mon Dec 9 20:03:47 2019 New Revision: 279137 URL: https://gcc.gnu.org/viewcvs?rev=279137&root=gcc&view=rev Log: Byte vs column awareness for diagnostic-show-locus.c (PR 49973) contr

[Bug preprocessor/49973] Column numbers count multibyte characters as multiple columns

2019-09-26 Thread lhyatt at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973 --- Comment #18 from Lewis Hyatt --- (In reply to jos...@codesourcery.com from comment #17) > On Tue, 17 Sep 2019, lhyatt at gmail dot com wrote: > > > In any case, the underlying source of wcwidth() could easily be changed as a > > drop-in repl

[Bug preprocessor/49973] Column numbers count multibyte characters as multiple columns

2019-09-17 Thread joseph at codesourcery dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973 --- Comment #17 from joseph at codesourcery dot com --- On Tue, 17 Sep 2019, lhyatt at gmail dot com wrote: > In any case, the underlying source of wcwidth() could easily be changed as a > drop-in replacement so I guess it can also be decided la

[Bug preprocessor/49973] Column numbers count multibyte characters as multiple columns

2019-09-17 Thread lhyatt at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973 --- Comment #16 from Lewis Hyatt --- Thank you both for the feedback so far. Regarding the use of wcwidth(), one thing I noticed is that glibc has a much different result than gnulib does, say for instance emojis return width 2 in the former rath

[Bug preprocessor/49973] Column numbers count multibyte characters as multiple columns

2019-09-17 Thread manu at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973 --- Comment #15 from Manuel López-Ibáñez --- (In reply to Lewis Hyatt from comment #13) > I have one other question though. This quick attempt uses wchar.h, namely > the mbrtowc() and wcwidth() functions. Firstly, it seems unfortunate to > introd

[Bug preprocessor/49973] Column numbers count multibyte characters as multiple columns

2019-09-16 Thread joseph at codesourcery dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973 --- Comment #14 from joseph at codesourcery dot com --- On Sun, 15 Sep 2019, lhyatt at gmail dot com wrote: > I feel like the most portable solution is just to use directly the necessary > code (from glibc or gnulib or from scratch or wherever)

[Bug preprocessor/49973] Column numbers count multibyte characters as multiple columns

2019-09-14 Thread lhyatt at gmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973 Lewis Hyatt changed: What|Removed |Added CC||lhyatt at gmail dot com --- Comment #13 fr