https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194
--- Comment #12 from Eric Gallager ---
(In reply to Jan Hubicka from comment #11)
> Well, I am working on gradual improvements in the inlining decisions,
> but since the PR is not very specific, we never will be perfect :)
So should we leave it
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194
--- Comment #11 from Jan Hubicka ---
Well, I am working on gradual improvements in the inlining decisions,
but since the PR is not very specific, we never will be perfect :)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194
Eric Gallager changed:
What|Removed |Added
Assignee|hubicka at gcc dot gnu.org |unassigned at gcc dot
gnu.org
--
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194
Eric Gallager changed:
What|Removed |Added
CC||egallager at gcc dot gnu.org
--- Comment
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194
--- Comment #8 from Jan Hubicka 2012-03-25
09:43:46 UTC ---
GCC 4.7 has now shrink wrapping that should reduce effect of inlining large
cold functions called once. Realistic testcases where we still kill code
quality would be welcome.
I tested
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194
--- Comment #7 from Jan Hubicka 2011-05-27 18:47:56 UTC
---
>
> We used to play with inlining limits (gcc had some really bad decisions), but
> the meaning of the numbers kept changing from one gcc version to another, and
> the heuristics gcc us
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194
--- Comment #6 from Linus Torvalds 2011-05-27
16:38:22 UTC ---
(In reply to comment #3)
>
> -finline-functions-called-once is trottled down by the large-function-growth
> and large-stack-frame-growth limits. The Kernel case coupld proably be
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194
--- Comment #5 from Jakub Jelinek 2011-05-27
16:24:45 UTC ---
Oops, s/65536/128/, I've changed the testcase too late without retesting.
Anyway, the point is that the limits should be adjusted somewhat if the call is
PROB_VERY_UNLIKELY.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194
--- Comment #4 from Jan Hubicka 2011-05-27
16:19:04 UTC ---
BTW mainline won't inline foo in that testcase:
Deciding on functions called once:
not inlinable: bar/1 -> foo/0, --param large-stack-frame-growth limit reached
I fixed some stack-gr
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194
--- Comment #3 from Jan Hubicka 2011-05-27 16:15:02 UTC
---
> I agree if the called function is big and it is very unlikely (most probably
> just in PROB_VERY_UNLIKELY cases) -finline-functions-called-once shouldn't
> inline.
-finline-functions-
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194
Michael Matz changed:
What|Removed |Added
CC||matz at gcc dot gnu.org
--- Comment #2 fro
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194
Jakub Jelinek changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Last reconfirmed|
12 matches
Mail list logo
