https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
--- Comment #20 from Martin Liška ---
Author: marxin
Date: Mon Sep 3 07:51:56 2018
New Revision: 264050
URL: https://gcc.gnu.org/viewcvs?rev=264050&root=gcc&view=rev
Log:
Make __builtin_expect effective in switch statements (PR middle-end/PR595
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
Martin Liška changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution|---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
--- Comment #19 from Martin Liška ---
(In reply to Eric Gallager from comment #18)
> (In reply to Martin Liška from comment #17)
> > Unfortunately I decided to postpone it to GCC 9.x.
>
> GCC 9.x development is ongoing now.
Yes, I've just insta
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
--- Comment #18 from Eric Gallager ---
(In reply to Martin Liška from comment #17)
> Unfortunately I decided to postpone it to GCC 9.x.
GCC 9.x development is ongoing now.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
Martin Liška changed:
What|Removed |Added
Target Milestone|--- |9.0
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
--- Comment #17 from Martin Liška ---
Unfortunately I decided to postpone it to GCC 9.x.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
Yury Gribov changed:
What|Removed |Added
CC||ygribov at gcc dot gnu.org
--- Comment #16
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
Daniel Fruzynski changed:
What|Removed |Added
CC||bugzilla@poradnik-webmaster
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
--- Comment #14 from Yuri Gribov ---
Patch posted in https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01016.html
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
Yuri Gribov changed:
What|Removed |Added
Attachment #41737|0 |1
is obsolete|
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
--- Comment #12 from Ulrich Drepper ---
On Fri, Jul 14, 2017 at 2:17 PM, marxin at gcc dot gnu.org
wrote:
> Maybe I miss something, but I would expect to sort all branches in
> emit_case_decision_tree as either predictors can sort branches, or o
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
--- Comment #11 from Martin Liška ---
(In reply to Yuri Gribov from comment #10)
> (In reply to Martin Liška from comment #9)
> > The patch works for me for the described case, but does not for PGO, which
> > should do the same based on real numb
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
--- Comment #10 from Yuri Gribov ---
(In reply to Martin Liška from comment #9)
> The patch works for me for the described case, but does not for PGO, which
> should do the same based on real numbers:
Problem here is that we optimize only very_l
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
--- Comment #9 from Martin Liška ---
(In reply to Yuri Gribov from comment #8)
> Created attachment 41737 [details]
> New draft patch
>
> How about this? I added edge attribute for builtin_expect and later used it
> in emit_case_decision_tree to
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
Yuri Gribov changed:
What|Removed |Added
Attachment #41698|0 |1
is obsolete|
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
--- Comment #7 from Yuri Gribov ---
(In reply to Martin Liška from comment #5)
> Apart from that I added code that preserves
> that probability in combine_predictions_for_bb.
Yes, I did pretty much the same locally)
> But still there's a missin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
--- Comment #6 from Martin Liška ---
Created attachment 41713
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=41713&action=edit
Semi-working patch
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
--- Comment #5 from Martin Liška ---
Ok, your patch is definitely needed to properly propagate the builtin
probability to a proper edge. Apart from that I added code that preserves that
probability incombine_predictions_for_bb. Having that we're
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
Martin Liška changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|unassigned at
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
Yuri Gribov changed:
What|Removed |Added
CC||marxin at gcc dot gnu.org
--- Comment #3 f
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
Yuri Gribov changed:
What|Removed |Added
CC||tetra2005 at gmail dot com
--- Comment #2
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
Richard Biener changed:
What|Removed |Added
Severity|normal |enhancement
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59521
Marek Polacek changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Last reconfirmed|
23 matches
Mail list logo
