--- Comment #18 from rguenth at gcc dot gnu dot org 2009-12-02 17:16
---
Fixed.
--
rguenth at gcc dot gnu dot org changed:
What|Removed |Added
Status|ASSIGNE
--- Comment #17 from rguenth at gcc dot gnu dot org 2009-12-02 17:14
---
Subject: Bug 42088
Author: rguenth
Date: Wed Dec 2 17:13:51 2009
New Revision: 154918
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=154918
Log:
2009-12-02 Richard Guenther
PR middle-end/42088
--- Comment #16 from ebotcazou at gcc dot gnu dot org 2009-11-30 22:08
---
> The issue with the boolean_type_node is that the middle-end does not have
> a type for a comparison result but implicitly assumes boolean_type_node.
>
> So for
>
> D._16 = (boolean) D._6;
> if (D.
--- Comment #15 from rguenth at gcc dot gnu dot org 2009-11-30 15:05
---
The issue with the boolean_type_node is that the middle-end does not have
a type for a comparison result but implicitly assumes boolean_type_node.
So for
D._16 = (boolean) D._6;
if (D._16 != 0)
w
--- Comment #14 from rguenth at gcc dot gnu dot org 2009-11-24 14:16
---
Created an attachment (id=19110)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=19110&action=view)
candidate patch
Patch I was testing. Unfortunately I get
Comparing stages 2 and 3
warning: gcc/cc1plus-chec
--- Comment #13 from aoliva at gcc dot gnu dot org 2009-11-19 18:54 ---
> one could randomize the delta we add to next_decl_uid
Yeah, that would be an interesting test. In fact, we had something along these
lines before, when we used (randomized) pointers rather than uids, and we
faile
--- Comment #12 from rguenther at suse dot de 2009-11-19 15:36 ---
Subject: Re: flag_gtoggle in free_lang_data hides -fcompare-debug
errors
On Thu, 19 Nov 2009, ebotcazou at gcc dot gnu dot org wrote:
> --- Comment #11 from ebotcazou at gcc dot gnu dot org 2009-11-19 15:11
> --
--- Comment #11 from ebotcazou at gcc dot gnu dot org 2009-11-19 15:11
---
> For not doing the boolean_type_node fixing we'd need to not pre-load the
> streamer chache with (selected) builtin type nodes but instead stream them
> with every unit and function and pass them through the mer
--- Comment #10 from rguenth at gcc dot gnu dot org 2009-11-19 14:40
---
Btw I can reproduce the bootstrap comparison fail with Ada when removing the
bogus flag_gtoggle check. Fixing the problem with canonicalize_cond_expr_cond
isn't the whole story appearantly - fixing it doesn't fix
--- Comment #9 from rguenther at suse dot de 2009-11-18 20:52 ---
Subject: Re: flag_gtoggle in free_lang_data hides -fcompare-debug
errors
On Wed, 18 Nov 2009, aoliva at gcc dot gnu dot org wrote:
> --- Comment #8 from aoliva at gcc dot gnu dot org 2009-11-18 20:05
> ---
>
--- Comment #8 from aoliva at gcc dot gnu dot org 2009-11-18 20:05 ---
We used to do such things, using pointers rather than UIDs even, and I fixed a
number of such issues to avoid codegen differences. But hey, if you could
prove that a DECL uid would never affect decisions taken by the
--- Comment #7 from rguenther at suse dot de 2009-11-18 19:50 ---
Subject: Re: flag_gtoggle in free_lang_data hides -fcompare-debug
errors
On Wed, 18 Nov 2009, aoliva at gcc dot gnu dot org wrote:
> --- Comment #6 from aoliva at gcc dot gnu dot org 2009-11-18 17:58
> ---
>
--- Comment #6 from aoliva at gcc dot gnu dot org 2009-11-18 17:58 ---
decl UIDs are used in various expression hashes. Enforcing strict ordering
among them without relying on UIDs would be an interesting problem, but if you
have a solution for that, go for it. Disabling the printing o
--- Comment #5 from rguenth at gcc dot gnu dot org 2009-11-18 16:53 ---
Btw, when I remove the flag_gtoggle check from free-lang-data we should get
bootstrap-debug comparison fails, no?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42088
--- Comment #4 from rguenther at suse dot de 2009-11-18 16:51 ---
Subject: Re: flag_gtoggle in free_lang_data hides -fcompare-debug
errors
On Wed, 18 Nov 2009, aoliva at gcc dot gnu dot org wrote:
> --- Comment #3 from aoliva at gcc dot gnu dot org 2009-11-18 16:30
> ---
>
--- Comment #3 from aoliva at gcc dot gnu dot org 2009-11-18 16:30 ---
Different UIDs affect hash table walks, which in turn may affect codegen.
We've had several -g/-g0 codegen differences ultimately caused by decl UID
differences, and they were detected and fixed long before -fcompare
--- Comment #2 from rguenth at gcc dot gnu dot org 2009-11-18 10:32 ---
Oh, the UIDs appear in the dumps you compare. That's a bug in your comparer,
we never said different UIDs are not ok, only codegen differences are not
(and yes, UID _ordering_ differences have a great chance of caus
--- Comment #1 from rguenth at gcc dot gnu dot org 2009-11-18 10:28 ---
Hmpf, no testcases ...
./xgcc -B. -c tree.i -O -g -fcompare-debug=-g0
has a compare-debug failure (-O0 does not). Fixed by
Index: gcc/tree.c
===
---
18 matches
Mail list logo
