[Bug libstdc++/90920] [9 Regression] ABI incompatibility in std::rotate

2019-06-21 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90920 Jonathan Wakely changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug libstdc++/90920] [9 Regression] ABI incompatibility in std::rotate

2019-06-21 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90920 --- Comment #7 from Jonathan Wakely --- Fixed for 9.2

[Bug libstdc++/90920] [9 Regression] ABI incompatibility in std::rotate

2019-06-21 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90920 --- Comment #6 from Jonathan Wakely --- Author: redi Date: Fri Jun 21 17:37:07 2019 New Revision: 272558 URL: https://gcc.gnu.org/viewcvs?rev=272558&root=gcc&view=rev Log: PR libstdc++/90920 restore previous checks for empty ranges The change i

[Bug libstdc++/90920] [9 Regression] ABI incompatibility in std::rotate

2019-06-20 Thread rguenther at suse dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90920 --- Comment #5 from rguenther at suse dot de --- On June 20, 2019 6:42:10 PM GMT+02:00, "redi at gcc dot gnu.org" wrote: >https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90920 > >--- Comment #4 from Jonathan Wakely --- >I did experiment with putti

[Bug libstdc++/90920] [9 Regression] ABI incompatibility in std::rotate

2019-06-20 Thread redi at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90920 --- Comment #4 from Jonathan Wakely --- I did experiment with putting the range checks in *both* places, the std::rotate function and the std::__rotate helpers it calls. But there's still no guarantee you won't get a "bad" combination of definit

[Bug libstdc++/90920] [9 Regression] ABI incompatibility in std::rotate

2019-06-20 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90920 Richard Biener changed: What|Removed |Added Priority|P3 |P2 CC|