[Bug libstdc++/58403] __normal_iterator triggers odr-use

2013-09-12 Thread redi at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58403 --- Comment #10 from Jonathan Wakely --- Yes, I agree it's QoI.

[Bug libstdc++/58403] __normal_iterator triggers odr-use

2013-09-12 Thread lichray at gmail dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58403 --- Comment #9 from Zhihao Yuan --- (In reply to Jonathan Wakely from comment #7) > [...] It is unspecified whether > "it += A::a" is an odr-use or not. Well, it's true, but I guess the primary purpose of making containers' iterator implementatio

[Bug libstdc++/58403] __normal_iterator triggers odr-use

2013-09-12 Thread paolo at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58403 --- Comment #11 from paolo at gcc dot gnu.org --- Author: paolo Date: Thu Sep 12 15:15:34 2013 New Revision: 202531 URL: http://gcc.gnu.org/viewcvs?rev=202531&root=gcc&view=rev Log: 2013-09-12 Paolo Carlini PR libstdc++/58403 * includ

[Bug libstdc++/58403] __normal_iterator triggers odr-use

2013-09-12 Thread paolo.carlini at oracle dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58403 Paolo Carlini changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug libstdc++/58403] __normal_iterator triggers odr-use

2013-09-12 Thread paolo.carlini at oracle dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58403 --- Comment #8 from Paolo Carlini --- Hi, (In reply to Jonathan Wakely from comment #7) > http://gcc.gnu.org/wiki/VerboseDiagnostics#missing_static_const_definition > > You odr-use a static member variable, so it must have a definition. I may b

[Bug libstdc++/58403] __normal_iterator triggers odr-use

2013-09-12 Thread redi at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58403 --- Comment #7 from Jonathan Wakely --- http://gcc.gnu.org/wiki/VerboseDiagnostics#missing_static_const_definition You odr-use a static member variable, so it must have a definition. The linker error is your fault for not defining the static mem

[Bug libstdc++/58403] __normal_iterator triggers odr-use

2013-09-12 Thread paolo.carlini at oracle dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58403 Paolo Carlini changed: What|Removed |Added CC||jwakely.gcc at gmail dot com --- Comment

[Bug libstdc++/58403] __normal_iterator triggers odr-use

2013-09-12 Thread lichray at gmail dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58403 --- Comment #5 from Zhihao Yuan --- (In reply to Jonathan Wakely from comment #4) > Although I see no harm in changing the library to take those arguments by > value, the testcase is of course invalid. Can you elaborate?

[Bug libstdc++/58403] __normal_iterator triggers odr-use

2013-09-12 Thread redi at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58403 --- Comment #4 from Jonathan Wakely --- Although I see no harm in changing the library to take those arguments by value, the testcase is of course invalid.

[Bug libstdc++/58403] __normal_iterator triggers odr-use

2013-09-12 Thread paolo.carlini at oracle dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58403 Paolo Carlini changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed|

[Bug libstdc++/58403] __normal_iterator triggers odr-use

2013-09-12 Thread lichray at gmail dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58403 --- Comment #2 from Zhihao Yuan --- Created attachment 30807 --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30807&action=edit test case

[Bug libstdc++/58403] __normal_iterator triggers odr-use

2013-09-12 Thread paolo.carlini at oracle dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58403 --- Comment #1 from Paolo Carlini --- Changing this would be of course trivial. I'd like to see one of those linker-errors though.