http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #15 from singler at gcc dot gnu.org
2011-02-25 14:04:48 UTC ---
Author: singler
Date: Fri Feb 25 14:04:40 2011
New Revision: 170494
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170494
Log:
2011-02-25 Johannes Singler
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #14 from singler at gcc dot gnu.org
2011-02-11 10:11:46 UTC ---
Author: singler
Date: Fri Feb 11 10:11:41 2011
New Revision: 170047
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170047
Log:
2011-02-11 Johannes Singler
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
Johannes Singler changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #12 from singler at gcc dot gnu.org
2011-01-24 17:07:40 UTC ---
Author: singler
Date: Mon Jan 24 17:07:35 2011
New Revision: 169171
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169171
Log:
2011-01-24 Johannes Singler
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #11 from Paolo Carlini 2011-01-24
14:11:05 UTC ---
Thanks Johannes. Jon is right (and indeed we are already using the pattern
elsewhere): when we are removing the std:: qualification from std::swap inside
a namespace != std, let's als
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #10 from Johannes Singler 2011-01-24
13:57:16 UTC ---
Created attachment 23098
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23098
Minimal patch avoid std::swap on template types.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #9 from Johannes Singler 2011-01-24
13:55:33 UTC ---
I have made the attached minimal patch.
Use std::iter_swap where possible, use swap for _Tp, and leave std::swap for
built-in types. I will test and then submit the patch.
Johan
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #8 from Jonathan Wakely 2011-01-24
13:53:27 UTC ---
(In reply to comment #3)
> Is anything specified in the standard in this direction?
20.2.2 Swappable requirements [swappable.requirements]
3 The context in which swa
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #7 from Paolo Carlini 2011-01-24
13:28:28 UTC ---
For sure if we are swapping _Tps we have to omit the std::. In general, when we
are not swapping built-ins or pointers we have to omit the qualification or use
something else, like std
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #6 from Johannes Singler 2011-01-24
13:23:26 UTC ---
Taking __key as value type in (some variants of __delete_min_insert) makes
sense, since it is also used as a buffer for storing the current loser. Having
a local variable that is i
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #5 from Johannes Singler 2011-01-24
13:19:22 UTC ---
What are you proposing for a fix? Omitting std::? Using std::iter_swap where
appropriate, like stl_algo.h mostly does? The latter would be more consistent.
Johannes
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #4 from Paolo Carlini 2011-01-24
13:10:43 UTC ---
I don't think it is. I can double check later.
Also, in losertree.h most uses involve built-in types (like bool or int) or
pointers, and those are also fine.
Beyond the issue discuss
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #3 from Manuel Holtgrewe 2011-01-24
12:56:16 UTC ---
I agree, that there are no obvious problems with std::swap_ranges.
Is anything specified in the standard in this direction?
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
--- Comment #2 from Paolo Carlini 2011-01-24
12:52:30 UTC ---
Note: std::swap_ranges is fine, AFAICS.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47433
Paolo Carlini changed:
What|Removed |Added
Status|UNCONFIRMED |NEW
Last reconfirmed|
15 matches
Mail list logo
