[Bug libstdc++/28765] __gnu_cxx::__vstring::clear() is slow

2006-08-18 Thread ian at airs dot com
--- Comment #7 from ian at airs dot com 2006-08-18 15:58 --- Thanks! -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28765

[Bug libstdc++/28765] __gnu_cxx::__vstring::clear() is slow

2006-08-18 Thread pcarlini at suse dot de
--- Comment #6 from pcarlini at suse dot de 2006-08-18 15:44 --- Fixed for 4.1.2. -- pcarlini at suse dot de changed: What|Removed |Added Status|ASSIGNED

[Bug libstdc++/28765] __gnu_cxx::__vstring::clear() is slow

2006-08-18 Thread paolo at gcc dot gnu dot org
--- Comment #5 from paolo at gcc dot gnu dot org 2006-08-18 15:42 --- Subject: Bug 28765 Author: paolo Date: Fri Aug 18 15:42:27 2006 New Revision: 116241 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=116241 Log: 2006-08-18 Paolo Carlini <[EMAIL PROTECTED]> PR libstd

[Bug libstdc++/28765] __gnu_cxx::__vstring::clear() is slow

2006-08-18 Thread paolo at gcc dot gnu dot org
--- Comment #4 from paolo at gcc dot gnu dot org 2006-08-18 15:42 --- Subject: Bug 28765 Author: paolo Date: Fri Aug 18 15:42:05 2006 New Revision: 116240 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=116240 Log: 2006-08-18 Paolo Carlini <[EMAIL PROTECTED]> PR libstd

[Bug libstdc++/28765] __gnu_cxx::__vstring::clear() is slow

2006-08-18 Thread pcarlini at suse dot de
--- Comment #3 from pcarlini at suse dot de 2006-08-18 08:31 --- Ok, I see... Then I will do the change, a little embarassing ;) By the way, if it's not obvious, the reason we don't simply call _M_set_length is the other base class, where clear cannot be trivial (due to refcounting) and

[Bug libstdc++/28765] __gnu_cxx::__vstring::clear() is slow

2006-08-17 Thread ian at airs dot com
--- Comment #2 from ian at airs dot com 2006-08-18 06:32 --- Unfortunately I do not currently have a valid copyright assignment with the FSF. I think my one word change is fine, but I don't feel comfortable moving a function around (although I agree that is the right approach). --

[Bug libstdc++/28765] __gnu_cxx::__vstring::clear() is slow

2006-08-17 Thread pcarlini at suse dot de
--- Comment #1 from pcarlini at suse dot de 2006-08-18 02:13 --- Hi Ian. Please go ahead with the inlining: only, from a stylistical point of view, please move the entire body inline, do not mark inline the out of line code. Patch preapproved, thanks a lot! -- pcarlini at suse dot de