[Bug fortran/14569] should not warn about truncated comment lines

2005-04-15 Thread cvs-commit at gcc dot gnu dot org
--- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-04-15 20:35 --- Subject: Bug 14569 CVSROOT:/cvs/gcc Module name:gcc Changes by: [EMAIL PROTECTED] 2005-04-15 20:35:26 Modified files: gcc/fortran: ChangeLog gfortran.h parse.c scanner.

[Bug fortran/14569] should not warn about truncated comment lines

2005-04-15 Thread rguenth at gcc dot gnu dot org
--- Additional Comments From rguenth at gcc dot gnu dot org 2005-04-15 20:01 --- It works by not advancing to the next line in gfc_error_recovery. Final patch at http://gcc.gnu.org/ml/gcc-patches/2005-04/msg01768.html -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14569

[Bug fortran/14569] should not warn about truncated comment lines

2005-04-15 Thread rguenth at gcc dot gnu dot org
--- Additional Comments From rguenth at gcc dot gnu dot org 2005-04-15 18:23 --- Ok, I'm looking into implementing your suggestion. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14569

[Bug fortran/14569] should not warn about truncated comment lines

2005-04-15 Thread tobi at gcc dot gnu dot org
--- Additional Comments From tobi at gcc dot gnu dot org 2005-04-15 15:46 --- I just caught that you only sent the patch to gcc-patches@ Fortran patches should be sent to both gcc-patches@ and [EMAIL PROTECTED], few of the Fortran people are subscribed to gcc-patches. -- http://gcc

[Bug fortran/14569] should not warn about truncated comment lines

2005-04-15 Thread tobi at gcc dot gnu dot org
--- Additional Comments From tobi at gcc dot gnu dot org 2005-04-15 15:27 --- Yes, this seems to be the case: when the statement matchers don't succeed, they skip to the next line via gfc_error_recovery, see the bottom of decode_statement. therefore the if (gfc_at_eol ()) you changed do

[Bug fortran/14569] should not warn about truncated comment lines

2005-04-15 Thread tobi at gcc dot gnu dot org
--- Additional Comments From tobi at gcc dot gnu dot org 2005-04-15 15:17 --- (In reply to comment #9) > I'm surprised that the line truncation warning is omitted in the error case. > Somewhere in the dark of the parser or error reporter someone advances to the > next line without my no

[Bug fortran/14569] should not warn about truncated comment lines

2005-04-15 Thread tobi at gcc dot gnu dot org
--- Additional Comments From tobi at gcc dot gnu dot org 2005-04-15 15:15 --- The patch is ok. IIRC I actually tried the exact same thing, except that I used gfc_warning instead of gfc_warning_now (and indeed the latter makes a lot more sense). -- http://gcc.gnu.org/bugzilla/show_bu

[Bug fortran/14569] should not warn about truncated comment lines

2005-04-15 Thread rguenth at gcc dot gnu dot org
--- Additional Comments From rguenth at gcc dot gnu dot org 2005-04-15 15:12 --- I'm surprised that the line truncation warning is omitted in the error case. Somewhere in the dark of the parser or error reporter someone advances to the next line without my notice. -- http://gcc.gnu.

[Bug fortran/14569] should not warn about truncated comment lines

2005-04-15 Thread tobi at gcc dot gnu dot org
--- Additional Comments From tobi at gcc dot gnu dot org 2005-04-15 15:10 --- I didn't count columns, but why would you be surprised that x = 4.3 + is not a valid statement? At least this seems to be the compiler's complaint in your second example. -- http://gcc.gnu.org/bugzilla/

[Bug fortran/14569] should not warn about truncated comment lines

2005-04-15 Thread rguenth at gcc dot gnu dot org
--- Additional Comments From rguenth at gcc dot gnu dot org 2005-04-15 14:50 --- Created an attachment (id=8649) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=8649&action=view) proposed patch Proposed patch attached; it seems, error reporting interferes with warnings, though. Or

[Bug fortran/14569] should not warn about truncated comment lines

2005-04-15 Thread rguenth at gcc dot gnu dot org
--- Additional Comments From rguenth at gcc dot gnu dot org 2005-04-15 11:30 --- Oh btw, looking into fixing all this. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14569

[Bug fortran/14569] should not warn about truncated comment lines

2005-04-15 Thread rguenth at gcc dot gnu dot org
--- Additional Comments From rguenth at gcc dot gnu dot org 2005-04-15 11:25 --- Another thing is, that the warning shows up as alwazn:default> gfortran -Wall -Dlinux -ffixed-form -I. -I../../include -o bounds.o -c bounds.F Warning: /tmp/cciShzeh.f:1: Line is being truncated Warning: /t