[Bug c++/10591] use ODR rules to make C++ objects not be TREE_PUBLIC

2006-03-27 Thread pinskia at gcc dot gnu dot org
--- Comment #21 from pinskia at gcc dot gnu dot org 2006-03-28 03:06 --- *** Bug 26895 has been marked as a duplicate of this bug. *** -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10591

[Bug c++/10591] use ODR rules to make C++ objects not be TREE_PUBLIC

2006-03-21 Thread jason at redhat dot com
--- Comment #20 from jason at redhat dot com 2006-03-21 19:19 --- Subject: Re: use ODR rules to make C++ objects not be TREE_PUBLIC Sorry I wasn't clear; I agree that this is an important bug. I meant that fixing the unique anonymous namespace name in the presence of PCH is the righ

[Bug c++/10591] use ODR rules to make C++ objects not be TREE_PUBLIC

2006-03-21 Thread cpence at gmail dot com
--- Comment #19 from cpence at gmail dot com 2006-03-21 19:12 --- @#18: I disagree. This bug is the only thing preventing anonymous namespaces from working together with PCH. As such, it's a bug, insofar as it keeps a _very_ worthwhile feature (namely, precompiling massive C++ headers

[Bug c++/10591] use ODR rules to make C++ objects not be TREE_PUBLIC

2006-03-21 Thread jason at gcc dot gnu dot org
--- Comment #18 from jason at gcc dot gnu dot org 2006-03-21 18:22 --- I think the summary is misleading; the change requested is an optimization. The testcase breaks because PCH breaks anonymous namespace naming so that it gets the same name in all translation units. I assume that the

[Bug c++/10591] use ODR rules to make C++ objects not be TREE_PUBLIC

2006-03-08 Thread geoffk at gcc dot gnu dot org
--- Comment #17 from geoffk at gcc dot gnu dot org 2006-03-09 00:53 --- I made 26612 to track the similar situation with visibility. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10591

[Bug c++/10591] use ODR rules to make C++ objects not be TREE_PUBLIC

2006-03-08 Thread geoffk at gcc dot gnu dot org
--- Comment #16 from geoffk at gcc dot gnu dot org 2006-03-09 00:48 --- Oops! I got confused about visibility vs. TREE_PUBLIC. I think it would be better to track the visibility stuff under a different bug. The previous comment does apply when something is in an anonymous namespace, b

[Bug c++/10591] use ODR rules to make C++ objects not be TREE_PUBLIC

2006-03-08 Thread geoffk at gcc dot gnu dot org
--- Comment #15 from geoffk at gcc dot gnu dot org 2006-03-09 00:44 --- Another case is when someone writes struct a_struct __attribute__((visibility(hidden))); void foo(a_struct &) { } Even though "foo" is not marked hidden it should still be hidden, because it could be overloaded in

[Bug c++/10591] use ODR rules to make C++ objects not be TREE_PUBLIC

2006-03-08 Thread geoffk at gcc dot gnu dot org
--- Comment #14 from geoffk at gcc dot gnu dot org 2006-03-09 00:37 --- This is the same original report as bug 25915, which then was generalised as follows: Any entity which could be defined more than once (like a class or an inline function) but whose token stream refers to a function