[PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2014-08-24 Thread Josh Triplett
2014-08-24 Josh Triplett + + * c-family/c-common.c (handle_section_attribute): Refactor to reduce + nesting and distinguish between error cases. + 2014-08-24 Oleg Endo PR target/61996 diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c index 58b9763..a63eedf 10

Re: [PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2014-08-24 Thread Josh Triplett
On Sun, Aug 24, 2014 at 01:58:52PM -0700, Andrew Pinski wrote: > On Sun, Aug 24, 2014 at 1:42 PM, Josh Triplett wrote: > > handle_section_attribute contains many levels of nested conditionals and > > branching code flow paths, with the error cases sometimes in the else > >

Re: [PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2014-08-24 Thread Josh Triplett
On Sun, Aug 24, 2014 at 05:47:23PM -0400, Trevor Saunders wrote: > On Sun, Aug 24, 2014 at 01:58:52PM -0700, Andrew Pinski wrote: > > On Sun, Aug 24, 2014 at 1:42 PM, Josh Triplett > > wrote: > > > handle_section_attribute contains many levels of nested conditionals and &

[PATCH] Refactor handle_section_attribute to reduce nesting and distinguish error cases

2015-04-26 Thread Josh Triplett
else clauses. --- I do not have commit access; if you approve, please commit. This cleanup will help enable a larger patch enhancing the section attribute. gcc/Changelog entry: 2014-08-24 Josh Triplett * c-family/c-common.c (handle_section_attribute): Refactor to reduce

Re: Feature request - a macro defined for GCC

2008-07-03 Thread Josh Triplett
onical list of extension names. We could use the ugly approach of names like "org.gnu.gcc.extension.sentinel" and "org.kernel.sparse.address_space", but that seems entirely too ugly. The other alternative seems like a central registry of extension names; I'd happily help maintain such a registry. Thoughts? - Josh Triplett