Re: Dealing with warnings on __attribute__((user)) when dehydra is not loaded

2009-10-16 Thread Benjamin Smedberg
On 10/16/09 12:11 PM, Tom Tromey wrote: >> "Diego" == Diego Novillo writes: > > Diego> void foo(void) __attribute__((user("bleh"))); > > Diego> foo.cc:1: warning: 'user' attribute directive ignored > > Diego> We could change the compiler to never complain about the 'user' > Diego> attribute

Re: C++ Plugins

2009-10-19 Thread Benjamin Smedberg
On 10/11/09 12:13 PM, Terrence Miller wrote: > (Version 4.5.0) > > There are plugin callbacks which trigger at the end of processing types > and C++ functions, > but I can not find a clean way for plugin code to notice a top-level > variable declaration. > > I'm hoping that the answer does not re

Re: Plugin API Comments (was Re: GCC Plug-in Framework ready to port)

2009-02-02 Thread Benjamin Smedberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 1/31/09 10:06 PM, Sean Callanan wrote: > (1) register_callback is an unnecessary API. It's already possible to > use dlsym() to get a pointer to a symbol in a plug-in. A plug-in could > export a function symbol corresponding to each hook it is in

Re: Massive performance regression from switching to gcc 4.5

2010-06-24 Thread Benjamin Smedberg
On 6/24/10 3:06 PM, Andrew Pinski wrote: Most of the code is compiled with -fPIC -fno-rtti -fno-exceptions -Os Stop right there. You are compiling at -Os, that is tuned for size and not speed. So the question is did the size go down? Not the speed decreased. Try at -O2 and report back. I doubt

Re: Backporting the 4.5 plugin framework to 3.4.5

2011-01-21 Thread Benjamin Smedberg
On 1/21/2011 4:12 PM, Kyle Girard wrote: Hello, I currently have a plugin for gcc 4.5 that works great. However, the need has arisen to have the same plugin run on gcc 3.4.5. Knowing that the plugin api wasn't added until 4.5 I was wondering if anyone could tell me how much pain i would be in f

Re: gcc visibility used by moz

2006-07-12 Thread Benjamin Smedberg
Jason Merrill wrote: OK, you've convinced me that the compiler shouldn't override or complain about explicit visibility attributes. Do you have a problem with implicit propagation of visibility in the absence of an attribute? Specifically: Do you agree with implicitly giving template instan

Re: gcc visibility used by moz

2006-07-17 Thread Benjamin Smedberg
Jason Merrill wrote: OK, you've convinced me that the compiler shouldn't override or complain about explicit visibility attributes. Do you have a problem with implicit propagation of visibility in the absence of an attribute? Specifically: Do you agree with implicitly giving template instan

dynamic_cast broken on GCC trunk

2006-08-03 Thread Benjamin Smedberg
The patch for GCC bug 10891 changed the behavior of dynamic_cast when RTTI is disabled. The new behavior is too restrictive for certain types of dynamic_cast that can be reliably performed without any RTTI information: If you have a class with virtual functions: class A { virtual DoSomething

4.3 regression: -frtti and #pragma visibility

2008-02-25 Thread Benjamin Smedberg
tree node somewhere that represents __class_type_info and needs default-visibility to be explicitly set on it. - --BDS - -- Benjamin Smedberg Platform Guru Mozilla Corporation [EMAIL PROTECTED] http://benjamin.smedbergs.us/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) Comment: U

Re: How to determine if a decl is a class member in GCC

2008-07-22 Thread Benjamin Smedberg
Le-Chun Wu wrote: Hi, I haven't heard anything back on my questions. Can any of C++ frontend maintainers please shed some light (or comment on my proposed patch)? Thanks a lot. Le-chun On Fri, Jul 18, 2008 at 10:22 AM, Le-Chun Wu <[EMAIL PROTECTED]> wrote: Hi, In my attribute handlers that h

Re: How to determine if a decl is a class member in GCC

2008-07-22 Thread Benjamin Smedberg
Le-Chun Wu wrote: Benjamin, Thanks for looking into this issue. I see what's going on here. It's basically a phase ordering problem. I am trying to determine whether a declaration is a class member when attributes are parsed and handled (in c-common.c), which happens earlier than where the conte

Re: gcc emit wrong symbols in multiple inheritance case

2008-07-30 Thread Benjamin Smedberg
Ian Lance Taylor wrote: "Bo Yang" <[EMAIL PROTECTED]> writes: Could anybody give some advice on this? Thanks! The mailing list gcc@gcc.gnu.org is for gcc developers, who mostly do not use cygwin. Try asking on [EMAIL PROTECTED] and/or [EMAIL PROTECTED] For what it's worth, Bo is my intern

Re: gcc emit wrong symbols in multiple inheritance case

2008-07-30 Thread Benjamin Smedberg
Brian Dessent wrote: Benjamin Smedberg wrote: For what it's worth, Bo is my intern in the Google SoC and has traced this back to being a code-generation error (missed stdcall mangling) in the mingw backend. I will work with him to narrow the problem and reformulate the question.. Isn&#

Re: RFH: GPLv3

2007-07-12 Thread Benjamin Smedberg
> Doug> could then either cut off the GCC 4.2 branch entirely or leave it > Doug> GPLv2. Then there are no surprises for anyone. > > Leaving released branches as GPLv2 is not an option. That > definitely would be the path of least surprise. Why is it not an option? - --

Re: RFH: GPLv3

2007-07-12 Thread Benjamin Smedberg
s copyright to FSF, do they still have the right to license their changes separately? - --BDS - -- Benjamin Smedberg Platform Guru Mozilla Corporation [EMAIL PROTECTED] http://benjamin.smedbergs.us/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (Darwin) Com

Re: RFH: GPLv3

2007-07-12 Thread Benjamin Smedberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 David Edelsohn wrote: >>>>>> Benjamin Smedberg writes: > > Doug> It seems obvious to me that it would be easiest to just move today's > Doug> mainline over to GPLv3, and have every GCC release >= 4.3 be GPLv3.

Re: Progress on GCC plugins ?

2007-11-15 Thread Benjamin Smedberg
n extra flag such as g++ - -static-analyze=/custom/libmozstaticanalysis.so... in many cases we could even pre-compile this file for common versions of GCC. - --BDS - -- Benjamin Smedberg Platform Guru Mozilla Corporation [EMAIL PROTECTED] http://benjamin.smedbergs.us/ -BEGIN PGP SIGNATURE--

Re: Progress on GCC plugins ?

2007-11-16 Thread Benjamin Smedberg
orce that pointers to subclasses of MMgc::GCObject allocated on the heap are only written through this particular writebarrier pattern"... so arguments about whether we want the code to be integrated into GCC itself are irrelevant. - --BDS - -- Benjamin Smedberg Platform Guru Mozilla Corporation [