GCC arc port defaults to -fcommon

2021-07-07 Thread Florian Weimer via Gcc
It seems to me that the arc port still defaults to -fcommon, presumably due to this in gcc/common/config/arc/arc-common.c: static void arc_option_init_struct (struct gcc_options *opts) { opts->x_flag_no_common = 255; /* Mark as not user-initialized. */ /* Which cpu we're compiling for (ARC60

tree decl stored during LGEN does not map to a symtab_node during WPA

2021-07-07 Thread Erick Ochoa via Gcc
Hi, I am saving some tree declarations during LGEN that I will be later analyzing at WPA time. I am able to read the decl from my summaries and print it at WPA time. It corresponds to a global variable. However, whenever I use symtab_node::get (decl) during WPA time I keep getting NULL. Does anyo

Re: GCC arc port defaults to -fcommon

2021-07-07 Thread Richard Biener via Gcc
On Wed, Jul 7, 2021 at 11:00 AM Florian Weimer via Gcc wrote: > > It seems to me that the arc port still defaults to -fcommon, presumably > due to this in gcc/common/config/arc/arc-common.c: > > static void > arc_option_init_struct (struct gcc_options *opts) > { > opts->x_flag_no_common = 255; /

Re: GCC arc port defaults to -fcommon

2021-07-07 Thread Richard Biener via Gcc
On Wed, Jul 7, 2021 at 11:56 AM Richard Biener wrote: > > On Wed, Jul 7, 2021 at 11:00 AM Florian Weimer via Gcc > wrote: > > > > It seems to me that the arc port still defaults to -fcommon, presumably > > due to this in gcc/common/config/arc/arc-common.c: > > > > static void > > arc_option_init

Re: GCC arc port defaults to -fcommon

2021-07-07 Thread Florian Weimer via Gcc
* Richard Biener: > On Wed, Jul 7, 2021 at 11:56 AM Richard Biener > wrote: >> >> On Wed, Jul 7, 2021 at 11:00 AM Florian Weimer via Gcc >> wrote: >> > >> > It seems to me that the arc port still defaults to -fcommon, presumably >> > due to this in gcc/common/config/arc/arc-common.c: >> > >> >

Re: GCC arc port defaults to -fcommon

2021-07-07 Thread Claudiu Zissulescu via Gcc
The fno-common option is indeed related to the use of small-data. However, the small data is only used for baremetal applications, and it shouldn't be used for linux toolchain. To me Richard's patch looks alright. Thanks, Claudiu From: Richard Biener Sent: Wed

Re: GCC arc port defaults to -fcommon

2021-07-07 Thread Claudiu Zissulescu via Gcc
Hi, I have quickly tested the next patch, and it looks like everything is alright. In the end we don't really need to temper with fcommon. diff --git a/gcc/common/config/arc/arc-common.c b/gcc/common/config/arc/arc-common.c index 6a1190296167..3b36d09997c7 100644 --- a/gcc/common/config/arc/ar

Re: daily report on extending static analyzer project [GSoC]

2021-07-07 Thread Ankur Saini via Gcc
> On 07-Jul-2021, at 4:16 AM, David Malcolm wrote: > > On Sat, 2021-07-03 at 20:07 +0530, Ankur Saini wrote: >> AIM for today : >> >> - update the call_stack to track something else other than supergraph >> edges >> >> — >> >> PROGRESS : >> >> - After some brainstorming about tracking the

Re: daily report on extending static analyzer project [GSoC]

2021-07-07 Thread David Malcolm via Gcc
On Wed, 2021-07-07 at 19:22 +0530, Ankur Saini wrote: > > > > On 07-Jul-2021, at 4:16 AM, David Malcolm > > wrote: > > > > On Sat, 2021-07-03 at 20:07 +0530, Ankur Saini wrote: > > > AIM for today : > > > > > > - update the call_stack to track something else other than > > > supergraph > > >

Re: where is PRnnnn required again?

2021-07-07 Thread Martin Sebor via Gcc
On 7/6/21 4:09 PM, Jonathan Wakely wrote: On Tue, 6 Jul 2021, 22:45 Martin Sebor via Gcc, > wrote: On 7/6/21 3:36 PM, Marek Polacek wrote: > On Tue, Jul 06, 2021 at 03:20:26PM -0600, Martin Sebor via Gcc wrote: >> I came away from the recent discussion of

Re: where is PRnnnn required again?

2021-07-07 Thread Jakub Jelinek via Gcc
On Tue, Jul 06, 2021 at 03:20:26PM -0600, Martin Sebor via Gcc wrote: > I came away from the recent discussion of ChangeLogs requirements > with the impression that the PR bit should be in the subject > (first) line and also above the ChangeLog part but doesn't need > to be repeated again in th

Re: where is PRnnnn required again?

2021-07-07 Thread Martin Sebor via Gcc
On 7/7/21 11:51 AM, Jakub Jelinek wrote: On Tue, Jul 06, 2021 at 03:20:26PM -0600, Martin Sebor via Gcc wrote: I came away from the recent discussion of ChangeLogs requirements with the impression that the PR bit should be in the subject (first) line and also above the ChangeLog part but doe

Re: where is PRnnnn required again?

2021-07-07 Thread Jonathan Wakely via Gcc
On Wed, 7 Jul 2021, 17:39 Martin Sebor, wrote: > On 7/6/21 4:09 PM, Jonathan Wakely wrote: > > > > > > On Tue, 6 Jul 2021, 22:45 Martin Sebor via Gcc, > > wrote: > > > > On 7/6/21 3:36 PM, Marek Polacek wrote: > > > On Tue, Jul 06, 2021 at 03:20:26PM -0600, Marti

Re: where is PRnnnn required again?

2021-07-07 Thread Jason Merrill via Gcc
On Wed, Jul 7, 2021 at 1:54 PM Jakub Jelinek via Gcc wrote: > On Tue, Jul 06, 2021 at 03:20:26PM -0600, Martin Sebor via Gcc wrote: > > I came away from the recent discussion of ChangeLogs requirements > > with the impression that the PR bit should be in the subject > > (first) line and also

Re: where is PRnnnn required again?

2021-07-07 Thread Martin Sebor via Gcc
On 7/7/21 2:42 PM, Jonathan Wakely wrote: On Wed, 7 Jul 2021, 17:39 Martin Sebor, > wrote: On 7/6/21 4:09 PM, Jonathan Wakely wrote: > > > On Tue, 6 Jul 2021, 22:45 Martin Sebor via Gcc, mailto:gcc@gcc.gnu.org> >

Re: where is PRnnnn required again?

2021-07-07 Thread Marek Polacek via Gcc
On Wed, Jul 07, 2021 at 03:35:35PM -0600, Martin Sebor wrote: > On 7/7/21 2:42 PM, Jonathan Wakely wrote: > > > > > > On Wed, 7 Jul 2021, 17:39 Martin Sebor, > > wrote: > > > > On 7/6/21 4:09 PM, Jonathan Wakely wrote: > > > > > > > > > On Tue, 6 Jul

Re: where is PRnnnn required again?

2021-07-07 Thread Jonathan Wakely via Gcc
On Wed, 7 Jul 2021, 22:35 Martin Sebor, wrote: > On 7/7/21 2:42 PM, Jonathan Wakely wrote: > > > > > > On Wed, 7 Jul 2021, 17:39 Martin Sebor, > > wrote: > > > > On 7/6/21 4:09 PM, Jonathan Wakely wrote: > > > > > > > > > On Tue, 6 Jul 2021, 22:45 Mart

Re: where is PRnnnn required again?

2021-07-07 Thread Martin Sebor via Gcc
On 7/7/21 3:53 PM, Marek Polacek wrote: On Wed, Jul 07, 2021 at 03:35:35PM -0600, Martin Sebor wrote: On 7/7/21 2:42 PM, Jonathan Wakely wrote: On Wed, 7 Jul 2021, 17:39 Martin Sebor, mailto:mse...@gmail.com>> wrote: On 7/6/21 4:09 PM, Jonathan Wakely wrote: > > > On T

Re: where is PRnnnn required again?

2021-07-07 Thread Jonathan Wakely via Gcc
On Wed, 7 Jul 2021, 23:18 Martin Sebor, wrote: > On 7/7/21 3:53 PM, Marek Polacek wrote: > > I'm not sure why you keep hitting so many issues; git addlog takes care > of > > this stuff for me and I've had no trouble pushing my patches. Is there > > a reason you don't use it also? > > I probably

Re: where is PRnnnn required again?

2021-07-07 Thread Martin Sebor via Gcc
On 7/7/21 4:24 PM, Jonathan Wakely wrote: On Wed, 7 Jul 2021, 23:18 Martin Sebor, > wrote: On 7/7/21 3:53 PM, Marek Polacek wrote: > I'm not sure why you keep hitting so many issues; git addlog takes care of > this stuff for me and I've had no troubl

Re: where is PRnnnn required again?

2021-07-07 Thread David Malcolm via Gcc
On Wed, 2021-07-07 at 16:58 -0600, Martin Sebor via Gcc wrote: > On 7/7/21 4:24 PM, Jonathan Wakely wrote: > > > > > > On Wed, 7 Jul 2021, 23:18 Martin Sebor, > > wrote: > > > >     On 7/7/21 3:53 PM, Marek Polacek wrote: > > > I'm not sure why you keep hitting so

Re: where is PRnnnn required again?

2021-07-07 Thread Martin Sebor via Gcc
On 7/7/21 4:15 PM, Jonathan Wakely wrote: On Wed, 7 Jul 2021, 22:35 Martin Sebor, > wrote: On 7/7/21 2:42 PM, Jonathan Wakely wrote: > > > On Wed, 7 Jul 2021, 17:39 Martin Sebor, mailto:mse...@gmail.com> >