Re: unwind-dw2-fde-darwin.c corrections

2006-10-02 Thread Mike Stump
On Oct 2, 2006, at 4:33 PM, Jack Howarth wrote: diff -uNr gcc-4.2-20061002/gcc/unwind-dw2-fde-darwin.c gcc-4.2-20061002.allocatable_unwind-dw2-fde-darwin/gcc/unwind-dw2- fde-darwin.c --- gcc-4.2-20061002/gcc/unwind-dw2-fde-darwin.c2006-10-01 23:03:13.0 0400 +++ gcc-4.2-2006100

Re: unwind-dw2-fde-darwin.c corrections

2006-10-02 Thread Geoffrey Keating
On 02/10/2006, at 4:33 PM, Jack Howarth wrote: Geoff, Well removing the portions of my previous patch which weren't being used, the effective change that I had (which eliminated the failures under MacOS X 10.4.8 with the -m64 objc testsuite) was... diff -uNr gcc-4.2-20061002/gcc/unwind-dw2-

Re: unwind-dw2-fde-darwin.c corrections

2006-10-02 Thread Jack Howarth
Geoff, Well removing the portions of my previous patch which weren't being used, the effective change that I had (which eliminated the failures under MacOS X 10.4.8 with the -m64 objc testsuite) was... diff -uNr gcc-4.2-20061002/gcc/unwind-dw2-fde-darwin.c gcc-4.2-20061002.allocatable_unwind-d

Re: unwind-dw2-fde-darwin.c corrections

2006-10-02 Thread Geoffrey Keating
On 02/10/2006, at 4:17 PM, Jack Howarth wrote: Geoff, So should we have... #ifdef __ppc__ fde = getsectdatafromheader (image->mh, "__DATA", "__eh_frame", &sz); #endif #ifdef __ppc64__ fde = getsectdatafromheader_64 ((struct mach_header_64 *)image- >mh, "__DATA", "__eh_frame", &sz

Re: unwind-dw2-fde-darwin.c corrections

2006-10-02 Thread Jack Howarth
Geoff, So should we have... #ifdef __ppc__ fde = getsectdatafromheader (image->mh, "__DATA", "__eh_frame", &sz); #endif #ifdef __ppc64__ fde = getsectdatafromheader_64 ((struct mach_header_64 *)image->mh, "__DATA", "__eh_frame", &sz); #endif or does the check for __DATA eh frames have

Re: unwind-dw2-fde-darwin.c corrections

2006-10-02 Thread Geoffrey Keating
On 02/10/2006, at 3:37 PM, Jack Howarth wrote: Geoff, I made one typo in my original proposed patch for unwind-dw2-fde-darwin.c. It should be... Index: unwind-dw2-fde-darwin.c === --- unwind-dw2-fde-darwin.c (revision 117

unwind-dw2-fde-darwin.c corrections

2006-10-02 Thread Jack Howarth
Geoff, I made one typo in my original proposed patch for unwind-dw2-fde-darwin.c. It should be... Index: unwind-dw2-fde-darwin.c === --- unwind-dw2-fde-darwin.c (revision 117350) +++ unwind-dw2-fde-darwin.c (working copy)