Re: trivial trailing whitespace issue

2009-11-27 Thread Sebastian Huber
Hi! If whitespace is an issue for some of you, why don't you fix this in a generic way? 1. Identify all modules in which whitespace at the end of a line is a problem. 2. Identify all branches of these modules. 3. Identify all lines with the whitespace problem in all modules and branches. 4. Iden

Re: trivial trailing whitespace issue

2009-11-26 Thread Mark Mielke
On 11/26/2009 08:18 AM, Michael Matz wrote: How, for goodness sake, can pure trailing whitespace changes, which by necessity you can't even _see_ in an editor (except if you activate modes that explicitely show them e.g. in different color) clean up code? Have you looked at the patch or fallout

Re: trivial trailing whitespace issue

2009-11-26 Thread Basile STARYNKEVITCH
Michael Matz wrote: Hi, On Wed, 25 Nov 2009, Basile STARYNKEVITCH wrote: 1. What to do in the immediate term with the repo. I've got no strong opinions here. I do understand most of the opinions, but I would rather prefer that we don't revert the trailing whitespace patch. I definitely can

Re: trivial trailing whitespace issue

2009-11-26 Thread Michael Matz
Hi, On Wed, 25 Nov 2009, Basile STARYNKEVITCH wrote: > > 1. What to do in the immediate term with the repo. I've got no strong > > opinions here. > > I do understand most of the opinions, but I would rather prefer that we > don't revert the trailing whitespace patch. I definitely can live wi

Re: trivial trailing whitespace issue

2009-11-25 Thread Basile STARYNKEVITCH
Joern Rennecke wrote: Quoting Basile STARYNKEVITCH : I would imagine that patching GNU indent (in its source code form) requires a copyright assignment specific to it (and uncovered by a, or at least "mine", GCC copyright assigment to FSF). If this is the case, I [Basile] won't do it (because ge

Re: trivial trailing whitespace issue

2009-11-25 Thread Joern Rennecke
Quoting Basile STARYNKEVITCH : I would imagine that patching GNU indent (in its source code form) requires a copyright assignment specific to it (and uncovered by a, or at least "mine", GCC copyright assigment to FSF). If this is the case, I [Basile] won't do it (because getting a copyright assig

Re: trivial trailing whitespace issue

2009-11-25 Thread Basile STARYNKEVITCH
Joseph S. Myers wrote: On Wed, 25 Nov 2009, Basile STARYNKEVITCH wrote: My wish would be that every C source file in GCC would be indent-ed by GNU indent with --gnu option. But since this has not been done, I suppose it is (sadly) not realistic. I don't understand all the issues involved (but I

Re: trivial trailing whitespace issue

2009-11-25 Thread Andrew Haley
Jeff Law wrote: > Ultimately I think there are X issues here. > >1. What to do in the immediate term with the repo. I've got no > strong opinions here. > >2. What to do longer term. I'd like to see us fix the whitespace > stuff then use hooks or a cron job to make sure they don't com

Re: trivial trailing whitespace issue

2009-11-25 Thread Joseph S. Myers
On Wed, 25 Nov 2009, Basile STARYNKEVITCH wrote: > My wish would be that every C source file in GCC would be indent-ed by GNU > indent with --gnu option. But since this has not been done, I suppose it is > (sadly) not realistic. I don't understand all the issues involved (but I do There are vario

Re: trivial trailing whitespace issue

2009-11-25 Thread Basile STARYNKEVITCH
Jeff Law wrote: Ultimately I think there are X issues here. 1. What to do in the immediate term with the repo. I've got no strong opinions here. I do understand most of the opinions, but I would rather prefer that we don't revert the trailing whitespace patch. I definitely can live with t

Re: trivial trailing whitespace issue

2009-11-25 Thread Jeff Law
On 11/25/09 12:33, Richard Guenther wrote: On Wed, 25 Nov 2009, Dave Korn wrote: Joseph S. Myers wrote: Doing it right at the end of branch-to-trunk merges for a release (which is where we are right now, just after merges from Graphite) is probably the optimal timing in terms of min

trivial trailing whitespace issue

2009-11-25 Thread Dennis Clarke
May I make a subject line change please ? This issue is trivial trailing whitespace changes I think and procedures, process and notice of such changes. -- Dennis Clarke dcla...@opensolaris.ca <- Email related to the open source Solaris dcla...@blastwave.org <- Email related to open source fo