Re: testsuite exp programming issue

2006-10-04 Thread Mike Stump
On Oct 3, 2006, at 7:57 PM, Jack Howarth wrote: I'll double check but I don't think the testcases which use -fnext-runtime were failing when I had these changes hardwired in for -m64. The reason is that the -fgnu-runtime appears on the cflags skip each test when -fgnu-runtime and darwin9.

Re: testsuite exp programming issue

2006-10-04 Thread Mike Stump
On Oct 3, 2006, at 9:30 PM, Jack Howarth wrote: I think I have this puzzled out now. The correct patch is... Index: lib/obj-c++.exp === --- lib/obj-c++.exp (revision 117423) +++ lib/obj-c++.exp (working copy) @@ -282,8 +282,

Re: testsuite exp programming issue

2006-10-04 Thread Janis Johnson
On Tue, Oct 03, 2006 at 10:40:47PM -0400, Jack Howarth wrote: > however this doesn't manage to detect when '-m64' > is being used in the compile flags. Does anyone have > any hints on how to change... > > +[regexp ".*-m64.*" "$(options)"] } { > > to properly catch the instances when -m64

Re: testsuite exp programming issue

2006-10-04 Thread Jack Howarth
> Most of the testcases that are failing (except for the > objc.dg-struct-layout-encoding-1/* ones) are failing because they depend > on the fact the default on darwin is -fnext-runtime. Which means you > have to modify most of those to include "-fnext-runtime" in the compiler > flags (via dg-optio

Re: testsuite exp programming issue

2006-10-04 Thread Jack Howarth
Andrew, Okay. I do plan on submitting the patch I came up with for gcc 4.2. Mike had suggested I see if I could get objc to test against the gnu-runtime rather than just not test it at all for -m64 on Darwin8. The only thing remaining that is broken in the -m64 testsuite on Darwin8 is the java t

Re: testsuite exp programming issue

2006-10-04 Thread Andrew Pinski
On Wed, 2006-10-04 at 00:30 -0400, Jack Howarth wrote: > Andrew, > I think I have this puzzled out now. The correct patch is... Most of the testcases that are failing (except for the objc.dg-struct-layout-encoding-1/* ones) are failing because they depend on the fact the default on darwin is -

Re: testsuite exp programming issue

2006-10-03 Thread Andrew Pinski
On Wed, 2006-10-04 at 00:30 -0400, Jack Howarth wrote: > FAIL: objc.dg-struct-layout-encoding-1/t001_main.m execution test If these (being objc.dg-struct-layout-encoding-1/*) are all failing, then something is wrong. I bet natural alignment is not set correctly for 64bit. But these were added so

Re: testsuite exp programming issue

2006-10-03 Thread Jack Howarth
Andrew, I think I have this puzzled out now. The correct patch is... Index: lib/obj-c++.exp === --- lib/obj-c++.exp (revision 117423) +++ lib/obj-c++.exp (working copy) @@ -282,8 +282,16 @@ proc obj-c++_target_compile { so

Re: testsuite exp programming issue

2006-10-03 Thread Jack Howarth
Andrew, I'll double check but I don't think the testcases which use -fnext-runtime were failing when I had these changes hardwired in for -m64. The reason is that the -fgnu-runtime appears on the cflags and gets overridden when a specific testcase appends -fnext-runtime because that appears last

Re: testsuite exp programming issue

2006-10-03 Thread Andrew Pinski
> > I am trying to adjust the current gcc/gcc/testsuite/lib/objc.exp > to allow it to build against the gnu-objc runtime library in the > case of -m64 compiles on Darwin8. Unfortunately, I've hit a brick > wall in terms of catching the instance of '-m64' being passed to > the compiler flags.

testsuite exp programming issue

2006-10-03 Thread Jack Howarth
I am trying to adjust the current gcc/gcc/testsuite/lib/objc.exp to allow it to build against the gnu-objc runtime library in the case of -m64 compiles on Darwin8. Unfortunately, I've hit a brick wall in terms of catching the instance of '-m64' being passed to the compiler flags. Normally I do